]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView_pimpl.C
John's Layout Tabular UI improvements and Martins fixes to clearing the
[lyx.git] / src / BufferView_pimpl.C
index fdbd79098c30d277606116fd14eae7d9b435c2e9..da45676c33d8a96f95710361ae71e5a865b643c1 100644 (file)
@@ -1,10 +1,5 @@
 #include <config.h>
 
-#include <ctime>
-#include <unistd.h>
-#include <sys/wait.h>
-#include <locale.h>
-
 #ifdef __GNUG__
 #pragma implementation
 #endif
@@ -14,6 +9,7 @@
 #include "lyxscreen.h"
 #include "lyxtext.h"
 #include "lyxrow.h"
+#include "paragraph.h"
 #include "LyXView.h"
 #include "commandtags.h"
 #include "lyxfunc.h"
 #include "lyx_gui_misc.h"
 #include "lyxrc.h"
 #include "intl.h"
-#include "support/LAssert.h"
-#include "support/lstrings.h"
+// added for Dispatch functions
+#include "lyx_cb.h"
+#include "lyx_main.h"
+#include "FloatList.h"
+#include "gettext.h"
+#include "ParagraphParameters.h"
+#include "undo_funcs.h"
+#include "lyxtextclasslist.h"
+
 #include "frontends/Dialogs.h"
 #include "frontends/Alert.h"
+#include "frontends/FileDialog.h"
+
 #include "insets/insetbib.h"
 #include "insets/insettext.h"
-/// added for Dispatch functions
-#include "lyx_cb.h"
-#include "frontends/FileDialog.h"
-#include "lyx_main.h"
-#include "FloatList.h"
-#include "support/filetools.h"
-#include "support/lyxfunctional.h"
 #include "insets/inseturl.h"
 #include "insets/insetlatexaccent.h"
 #include "insets/insettoc.h"
 #include "insets/insetcaption.h"
 #include "insets/insetfloatlist.h"
 #include "insets/insetspecialchar.h"
-#include "gettext.h"
-#include "ParagraphParameters.h"
-#include "undo_funcs.h"
+
 #include "mathed/formulabase.h"
 
-extern LyXTextClass::size_type current_layout;
+#include "support/LAssert.h"
+#include "support/lstrings.h"
+#include "support/filetools.h"
+#include "support/lyxfunctional.h"
+
+#include <ctime>
+#include <unistd.h>
+#include <sys/wait.h>
+#include <clocale>
+
+
+extern lyx::layout_type current_layout;
 
 using std::vector;
 using std::find_if;
@@ -78,6 +85,10 @@ using std::make_pair;
 using std::min;
 using SigC::slot;
 
+using lyx::pos_type;
+using lyx::layout_type;
+using lyx::textclass_type;
+
 /* the selection possible is needed, that only motion events are 
  * used, where the bottom press event was on the drawing area too */
 bool selection_possible = false;
@@ -294,9 +305,9 @@ int BufferView::Pimpl::resizeCurrentBuffer()
        Paragraph * selendpar = 0;
        UpdatableInset * the_locking_inset = 0;
        
-       Paragraph::size_type pos = 0;
-       Paragraph::size_type selstartpos = 0;
-       Paragraph::size_type selendpos = 0;
+       pos_type pos = 0;
+       pos_type selstartpos = 0;
+       pos_type selendpos = 0;
        bool selection = false;
        bool mark_set  = false;
 
@@ -357,7 +368,9 @@ int BufferView::Pimpl::resizeCurrentBuffer()
                bv_->theLockingInset(the_locking_inset);
        }
        bv_->text->first = screen_->topCursorVisible(bv_->text);
+#if 0
        buffer_->resizeInsets(bv_);
+#endif
        // this will scroll the screen such that the cursor becomes visible
        updateScrollbar();
        redraw();
@@ -569,7 +582,7 @@ void BufferView::Pimpl::workAreaButtonPress(int xpos, int ypos,
 {
        if (!buffer_ || !screen_.get()) return;
 
-       Inset * inset_hit = checkInsetHit(bv_->text, xpos, ypos, button);
+       Inset * inset_hit = checkInsetHit(bv_->text, xpos, ypos);
 
        // ok ok, this is a hack.
        if (button == 4 || button == 5) {
@@ -670,25 +683,25 @@ void BufferView::Pimpl::doubleClick(int /*x*/, int /*y*/, unsigned int button)
 {
        // select a word
        if (!buffer_)
-           return;
+               return;
 
        LyXText * text = bv_->getLyXText();
 
        if (text->bv_owner && bv_->theLockingInset())
-           return;
+               return;
 
        if (screen_.get() && button == 1) {
-           if (text->bv_owner) {
-               screen_->hideCursor();
-               screen_->toggleSelection(text, bv_);
-               text->selectWord(bv_, LyXText::WHOLE_WORD_STRICT);
-               screen_->toggleSelection(text, bv_, false);
-           } else {
-               text->selectWord(bv_, LyXText::WHOLE_WORD_STRICT);
-           }
-           /* This will fit the cursor on the screen
-            * if necessary */
-           update(text, BufferView::SELECT|BufferView::FITCUR);
+               if (text->bv_owner) {
+                       screen_->hideCursor();
+                       screen_->toggleSelection(text, bv_);
+                       text->selectWord(bv_, LyXText::WHOLE_WORD_STRICT);
+                       screen_->toggleSelection(text, bv_, false);
+               } else {
+                       text->selectWord(bv_, LyXText::WHOLE_WORD_STRICT);
+               }
+               /* This will fit the cursor on the screen
+                * if necessary */
+               update(text, BufferView::SELECT|BufferView::FITCUR);
        }
 }
 
@@ -705,13 +718,17 @@ void BufferView::Pimpl::tripleClick(int /*x*/, int /*y*/, unsigned int button)
            return;
 
        if (screen_.get() && (button == 1)) {
-               screen_->hideCursor();
-               screen_->toggleSelection(text, bv_);
+               if (text->bv_owner) {
+                       screen_->hideCursor();
+                       screen_->toggleSelection(text, bv_);
+               }
                text->cursorHome(bv_);
                text->selection.cursor = text->cursor;
                text->cursorEnd(bv_);
                text->setSelection(bv_);
-               screen_->toggleSelection(text, bv_, false);
+               if (text->bv_owner) {
+                       screen_->toggleSelection(text, bv_, false);
+               }
                /* This will fit the cursor on the screen
                 * if necessary */
                update(text, BufferView::SELECT|BufferView::FITCUR);
@@ -745,7 +762,7 @@ void BufferView::Pimpl::workAreaButtonRelease(int x, int y,
        // If we hit an inset, we have the inset coordinates in these
        // and inset_hit points to the inset.  If we do not hit an
        // inset, inset_hit is 0, and inset_x == x, inset_y == y.
-       Inset * inset_hit = checkInsetHit(bv_->text, x, y, button);
+       Inset * inset_hit = checkInsetHit(bv_->text, x, y);
 
        if (bv_->theLockingInset()) {
                // We are in inset locking mode.
@@ -771,7 +788,21 @@ void BufferView::Pimpl::workAreaButtonRelease(int x, int y,
                // Inset like error, notes and figures
                selection_possible = false;
 
+               // if we reach this point with a selection, it
+               // must mean we are currently selecting.
+               // But we don't want to open the inset
+               // because that is annoying for the user. 
+               // So just pretend we didn't hit it.
+               // this is OK because a "kosher" ButtonRelease
+               // will follow a ButtonPress that clears
+               // the selection.
+               // Note this also fixes selection drawing
+               // problems if we end up opening an inset
+               if (bv_->getLyXText()->selection.set())
+                       return;
                // CHECK fix this proper in 0.13
+               // well, maybe 13.0 !!!!!!!!!
 
                // Following a ref shouldn't issue
                // a push on the undo-stack
@@ -805,6 +836,7 @@ void BufferView::Pimpl::workAreaButtonRelease(int x, int y,
 
 #ifdef WITH_WARNINGS
 #warning variable c is set but never used. What is it good for?? (JMarc)
+#warning isnt this code dead ?? "open a float" ??? (jbl)
 #endif
        // check whether we want to open a float
        if (bv_->text) {
@@ -837,76 +869,91 @@ void BufferView::Pimpl::workAreaButtonRelease(int x, int y,
 }
 
 
-/* 
- * Returns an inset if inset was hit. 0 otherwise.
- * If hit, the coordinates are changed relative to the inset. 
- * Otherwise coordinates are not changed, and false is returned.
- */
-Inset * BufferView::Pimpl::checkInsetHit(LyXText * text, int & x, int & y,
-                                        unsigned int /* button */)
+Box BufferView::Pimpl::insetDimensions(LyXText const & text, LyXCursor const & cursor) const
+{
+       Paragraph /*const*/ & par = *cursor.par();
+       pos_type const pos = cursor.pos();
+
+       lyx::Assert(par.getInset(pos));
+       Inset const & inset(*par.getInset(pos));
+
+       LyXFont const & font = text.getFont(buffer_, &par, pos);
+       int const width = inset.width(bv_, font);
+       int const inset_x = font.isVisibleRightToLeft()
+               ? (cursor.x() - width) : cursor.x();
+       return Box(
+               inset_x + inset.scroll(),
+               inset_x + width,
+               cursor.y() - inset.ascent(bv_, font),
+               cursor.y() + inset.descent(bv_, font));
+}
+Inset * BufferView::Pimpl::checkInset(LyXText const & text, LyXCursor const & cursor, int & x, int & y) const
+{
+       pos_type const pos(cursor.pos());
+       Paragraph /*const*/ & par(*cursor.par());
+
+       if (pos >= par.size() || !par.isInset(pos)) {
+               return 0;
+       }
+
+       Inset /*const*/ * inset = par.getInset(pos);
+       if (!isEditableInset(inset)) {
+               return 0;
+       }
+
+       Box b(insetDimensions(text, cursor));
+
+       if (!b.contained(x, y)) {
+               return 0;
+       }
+       text.setCursor(bv_, &par, pos, true);
+       x -= b.x1;
+       // The origin of an inset is on the baseline
+       y -= (text.cursor.y());
+  
+       return inset;
+}
+
+Inset * BufferView::Pimpl::checkInsetHit(LyXText * text, int & x, int & y)
 {
        if (!screen_.get())
                return 0;
   
        int y_tmp = y + text->first;
-  
        LyXCursor cursor;
        text->setCursorFromCoordinates(bv_, cursor, x, y_tmp);
-       text->setCursor(bv_, cursor, cursor.par(),cursor.pos(),true);
-
-
-       if (cursor.pos() < cursor.par()->size()
-           && cursor.par()->isInset(cursor.pos())
-           && isEditableInset(cursor.par()->getInset(cursor.pos()))) {
+       Inset * inset(checkInset(*text, cursor, x, y_tmp));
 
-               // Check whether the inset really was hit
-               Inset * tmpinset = cursor.par()->getInset(cursor.pos());
-               LyXFont font = text->getFont(buffer_,
-                                                 cursor.par(), cursor.pos());
-               int const width = tmpinset->width(bv_, font);
-               int const inset_x = font.isVisibleRightToLeft()
-                       ? cursor.x() - width : cursor.x();
-               int const start_x = inset_x + tmpinset->scroll();
-               int const end_x = inset_x + width;
-
-               if (x > start_x && x < end_x
-                   && y_tmp > cursor.y() - tmpinset->ascent(bv_, font)
-                   && y_tmp < cursor.y() + tmpinset->descent(bv_, font)) {
-                       text->setCursor(bv_, cursor.par(),cursor.pos(), true);
-                       x = x - start_x;
-                       // The origin of an inset is on the baseline
-                       y = y_tmp - (text->cursor.y()); 
-                       return tmpinset;
-               }
+       if (inset) {
+               y = y_tmp;
+               return inset;
+       }
+       // look at previous position
+       if (cursor.pos() == 0) {
+               return 0;
        }
 
-       if ((cursor.pos() - 1 >= 0) &&
-           cursor.par()->isInset(cursor.pos() - 1) &&
-           isEditableInset(cursor.par()->getInset(cursor.pos() - 1))) {
-               Inset * tmpinset = cursor.par()->getInset(cursor.pos()-1);
-               LyXFont font = text->getFont(buffer_, cursor.par(),
-                                                 cursor.pos() - 1);
-               int const width = tmpinset->width(bv_, font);
-               int const inset_x = font.isVisibleRightToLeft()
-                       ? cursor.x() : cursor.x() - width;
-               int const start_x = inset_x + tmpinset->scroll();
-               int const end_x = inset_x + width;
-
-               if (x > start_x && x < end_x
-                   && y_tmp > cursor.y() - tmpinset->ascent(bv_, font)
-                   && y_tmp < cursor.y() + tmpinset->descent(bv_, font)) {
-#if 0
-                       if (move_cursor && (tmpinset != bv_->theLockingInset()))
-#endif
-                               text->setCursor(bv_, cursor.par(),
-                                               cursor.pos() - 1, true);
-                       x = x - start_x;
-                       // The origin of an inset is on the baseline
-                       y = y_tmp - (text->cursor.y()); 
-                       return tmpinset;
-               }
+       // move back one
+       text->setCursor(bv_, cursor, cursor.par(), cursor.pos() - 1, true);
+
+       inset = checkInset(*text, cursor, x, y_tmp);
+       if (inset) {
+               y = y_tmp;
        }
-       return 0;
+       return inset;
 }
 
 
@@ -967,7 +1014,7 @@ void BufferView::Pimpl::update()
                LyXText::text_status st = bv_->text->status();
                screen_->update(bv_->text, bv_);
                bool fitc = false;
-               while(bv_->text->status() == LyXText::CHANGED_IN_DRAW) {
+               while (bv_->text->status() == LyXText::CHANGED_IN_DRAW) {
                        if (bv_->text->fullRebreak(bv_)) {
                                st = LyXText::NEED_MORE_REFRESH;
                                bv_->text->setCursor(bv_, bv_->text->cursor.par(),
@@ -1340,9 +1387,9 @@ void BufferView::Pimpl::pasteClipboard(bool asPara)
        if (clip.empty()) return;
 
        if (asPara) {
-               bv_->text->insertStringAsParagraphs(bv_, clip);
+               bv_->getLyXText()->insertStringAsParagraphs(bv_, clip);
        } else {
-               bv_->text->insertStringAsLines(bv_, clip);
+               bv_->getLyXText()->insertStringAsLines(bv_, clip);
        }
        update(bv_->text, BufferView::SELECT|BufferView::FITCUR|BufferView::CHANGE);
 }
@@ -1514,7 +1561,8 @@ bool BufferView::Pimpl::Dispatch(kb_action action, string const & argument)
        case LFUN_PASTESELECTION:
        {
                bool asPara = false;
-               if (argument == "paragraph") asPara = true;
+               if (argument == "paragraph")
+                       asPara = true;
                pasteClipboard(asPara);
        }
        break;
@@ -1594,10 +1642,8 @@ bool BufferView::Pimpl::Dispatch(kb_action action, string const & argument)
                break;
 
        case LFUN_FILE_INSERT:
-       {
                MenuInsertLyXFile(argument);
-       }
-       break;
+               break;
        
        case LFUN_FILE_INSERT_ASCII_PARA:
                InsertAsciiFile(bv_, argument, true);
@@ -1614,18 +1660,16 @@ bool BufferView::Pimpl::Dispatch(kb_action action, string const & argument)
                
                // Derive layout number from given argument (string)
                // and current buffer's textclass (number). */    
-               LyXTextClassList::ClassList::size_type tclass =
-                       buffer_->params.textclass;
-               pair <bool, LyXTextClass::size_type> layout = 
+               textclass_type tclass = buffer_->params.textclass;
+               pair <bool, layout_type> layout = 
                        textclasslist.NumberOfLayout(tclass, argument);
 
                // If the entry is obsolete, use the new one instead.
                if (layout.first) {
-                       string obs = textclasslist.Style(tclass,layout.second)
+                       string obs = textclasslist.Style(tclass, layout.second)
                                .obsoleted_by();
                        if (!obs.empty()) 
-                               layout = 
-                                       textclasslist.NumberOfLayout(tclass, obs);
+                               layout = textclasslist.NumberOfLayout(tclass, obs);
                }
 
                // see if we found the layout number:
@@ -2799,7 +2843,7 @@ bool BufferView::Pimpl::Dispatch(kb_action action, string const & argument)
 
        case LFUN_CHARATCURSOR:
        {
-               Paragraph::size_type pos = bv_->getLyXText()->cursor.pos();
+               pos_type pos = bv_->getLyXText()->cursor.pos();
                if (pos < bv_->getLyXText()->cursor.par()->size())
                        owner_->getLyXFunc()->setMessage(
                                tostr(bv_->getLyXText()->cursor.par()->getChar(pos)));
@@ -3244,7 +3288,7 @@ void BufferView::Pimpl::smartQuote()
 {
        LyXText const * lt = bv_->getLyXText();
        Paragraph const * par = lt->cursor.par();
-       Paragraph::size_type pos = lt->cursor.pos();
+       pos_type pos = lt->cursor.pos();
        char c;
 
        if (!pos
@@ -3318,10 +3362,9 @@ bool BufferView::Pimpl::insertInset(Inset * inset, string const & lout)
                        update(bv_->text, BufferView::SELECT|BufferView::FITCUR|BufferView::CHANGE);
                }
 
-               pair<bool, LyXTextClass::size_type> lres =
-                       textclasslist.NumberOfLayout(buffer_->params
-                                                    .textclass, lout);
-               LyXTextClass::size_type lay;
+               pair<bool, layout_type> lres =
+                       textclasslist.NumberOfLayout(buffer_->params .textclass, lout);
+               layout_type lay = 0;
                if (lres.first != false) {
                        // layout found
                        lay = lres.second;