]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView_pimpl.C
Alfredo's second patch
[lyx.git] / src / BufferView_pimpl.C
index 4574489f56f3dce52505a5d674ed3675e60a34c2..a2f74e21a1a8148baacdd20a54010cc0e0d176cd 100644 (file)
@@ -9,48 +9,43 @@
 #include <config.h>
 
 #include "BufferView_pimpl.h"
-#include "frontends/WorkArea.h"
-#include "frontends/screen.h"
-#include "frontends/LyXScreenFactory.h"
-#include "frontends/WorkAreaFactory.h"
-#include "frontends/Dialogs.h"
-#include "frontends/Alert.h"
-#include "frontends/FileDialog.h"
-#include "frontends/mouse_state.h"
-#include "lyxtext.h"
-#include "lyxrow.h"
-#include "paragraph.h"
-#include "frontends/LyXView.h"
-#include "commandtags.h"
-#include "lyxfunc.h"
-#include "debug.h"
-#include "bufferview_funcs.h"
-#include "TextCache.h"
 #include "bufferlist.h"
-#include "lyxrc.h"
-#include "intl.h"
-// added for Dispatch functions
-#include "lyx_cb.h"
-#include "lyx_main.h"
+#include "bufferview_funcs.h"
+#include "lfuns.h"
+#include "debug.h"
+#include "factory.h"
 #include "FloatList.h"
-#include "gettext.h"
-#include "ParagraphParameters.h"
-#include "undo_funcs.h"
 #include "funcrequest.h"
+#include "gettext.h"
+#include "intl.h"
 #include "iterators.h"
+#include "lyx_cb.h" // added for Dispatch functions
+#include "lyx_main.h"
 #include "lyxfind.h"
+#include "lyxfunc.h"
+#include "lyxtext.h"
+#include "lyxrc.h"
+#include "lyxrow.h"
+#include "paragraph.h"
+#include "ParagraphParameters.h"
+#include "TextCache.h"
+#include "undo_funcs.h"
 
-#include "insets/insetbib.h"
-#include "insets/insettext.h"
-#include "insets/insetlatexaccent.h"
-#include "insets/insettoc.h"
-#include "insets/insetindex.h"
-#include "insets/insetref.h"
-#include "insets/insetinclude.h"
-#include "insets/insetcite.h"
-#include "insets/insetgraphics.h"
-#include "insets/insetmarginal.h"
 #include "insets/insetfloatlist.h"
+#include "insets/insetgraphics.h"
+#include "insets/insetinclude.h"
+#include "insets/insetref.h"
+#include "insets/insettext.h"
+
+#include "frontends/Alert.h"
+#include "frontends/Dialogs.h"
+#include "frontends/FileDialog.h"
+#include "frontends/LyXView.h"
+#include "frontends/LyXScreenFactory.h"
+#include "frontends/mouse_state.h"
+#include "frontends/screen.h"
+#include "frontends/WorkArea.h"
+#include "frontends/WorkAreaFactory.h"
 
 #include "mathed/formulabase.h"
 
@@ -62,7 +57,7 @@
 
 #include <boost/bind.hpp>
 #include <boost/signals/connection.hpp>
-#include "BoostFormat.h"
+#include "support/BoostFormat.h"
 
 #include <unistd.h>
 #include <sys/wait.h>
@@ -77,6 +72,7 @@ using std::make_pair;
 using std::min;
 
 using lyx::pos_type;
+using namespace bv_funcs;
 
 extern BufferList bufferlist;
 
@@ -116,7 +112,7 @@ BufferView::Pimpl::Pimpl(BufferView * bv, LyXView * owner,
        resizecon = workarea().workAreaResize
                .connect(boost::bind(&BufferView::Pimpl::workAreaResize, this));
        dispatchcon = workarea().dispatch
-               .connect(boost::bind(&BufferView::Pimpl::dispatch, this, _1));
+               .connect(boost::bind(&BufferView::Pimpl::workAreaDispatch, this, _1));
        kpresscon = workarea().workAreaKeyPress
                .connect(boost::bind(&BufferView::Pimpl::workAreaKeyPress, this, _1, _2));
        selectioncon = workarea().selectionRequested
@@ -170,7 +166,9 @@ void BufferView::Pimpl::buffer(Buffer * b)
        // set current buffer
        buffer_ = b;
 
-       if (bufferlist.getState() == BufferList::CLOSING) return;
+       // if we're quitting lyx, don't bother updating stuff
+       if (quitting)
+               return;
 
        // if we are closing the buffer, use the first buffer as current
        if (!buffer_) {
@@ -187,10 +185,9 @@ void BufferView::Pimpl::buffer(Buffer * b)
                }
 
                // FIXME: needed when ?
-               bv_->text->first_y =
-                       screen().topCursorVisible(bv_->text->cursor, bv_->text->first_y);
+               bv_->text->top_y(screen().topCursorVisible(bv_->text->cursor, bv_->text->top_y()));
 
-               // Similarly, buffer-dependent dialogs should be updated or
+               // Buffer-dependent dialogs should be updated or
                // hidden. This should go here because some dialogs (eg ToC)
                // require bv_->text.
                owner_->getDialogs().updateBufferDependent(true);
@@ -213,6 +210,13 @@ void BufferView::Pimpl::buffer(Buffer * b)
        owner_->updateLayoutChoice();
        owner_->updateWindowTitle();
 
+       if (buffer_) {
+               // Don't forget to update the Layout
+               string const layoutname =
+                       bv_->text->cursor.par()->layout()->name();
+               owner_->setLayout(layoutname);
+       }
+
        if (grfx::Previews::activated() && buffer_)
                grfx::Previews::get().generateBufferPreviews(*buffer_);
 }
@@ -229,9 +233,12 @@ bool BufferView::Pimpl::fitCursor()
                ret = screen().fitCursor(bv_->text, bv_);
        }
 
-       bv_->owner()->getDialogs().updateParagraph();
-       if (ret)
-               updateScrollbar();
+       dispatch(FuncRequest(LFUN_PARAGRAPH_UPDATE));
+
+       // We need to always update, in case we did a
+       // paste and we stayed anchored to a row, but
+       // the actual height of the doc changed ...
+       updateScrollbar();
        return ret;
 }
 
@@ -264,15 +271,15 @@ int BufferView::Pimpl::resizeCurrentBuffer()
        bool mark_set  = false;
 
        owner_->busy(true);
+
        owner_->message(_("Formatting document..."));
 
        if (bv_->text) {
-               par = bv_->text->cursor.par();
+               par = &*bv_->text->cursor.par();
                pos = bv_->text->cursor.pos();
-               selstartpar = bv_->text->selection.start.par();
+               selstartpar = &*bv_->text->selection.start.par();
                selstartpos = bv_->text->selection.start.pos();
-               selendpar = bv_->text->selection.end.par();
+               selendpar = &*bv_->text->selection.end.par();
                selendpos = bv_->text->selection.end.pos();
                selection = bv_->text->selection.set();
                mark_set = bv_->text->selection.mark();
@@ -311,13 +318,13 @@ int BufferView::Pimpl::resizeCurrentBuffer()
                // Mechanism when setting the cursor.
                bv_->text->selection.mark(mark_set);
                if (selection) {
-                       bv_->text->setCursor(bv_, selstartpar, selstartpos);
+                       bv_->text->setCursor(selstartpar, selstartpos);
                        bv_->text->selection.cursor = bv_->text->cursor;
-                       bv_->text->setCursor(bv_, selendpar, selendpos);
-                       bv_->text->setSelection(bv_);
-                       bv_->text->setCursor(bv_, par, pos);
+                       bv_->text->setCursor(selendpar, selendpos);
+                       bv_->text->setSelection();
+                       bv_->text->setCursor(par, pos);
                } else {
-                       bv_->text->setCursor(bv_, par, pos);
+                       bv_->text->setCursor(par, pos);
                        bv_->text->selection.cursor = bv_->text->cursor;
                        bv_->text->selection.set(false);
                }
@@ -325,11 +332,14 @@ int BufferView::Pimpl::resizeCurrentBuffer()
                bv_->theLockingInset(the_locking_inset);
        }
 
-       bv_->text->first_y = screen().topCursorVisible(bv_->text->cursor, bv_->text->first_y);
+       bv_->text->top_y(screen().topCursorVisible(bv_->text->cursor, bv_->text->top_y()));
 
        switchKeyMap();
        owner_->busy(false);
 
+       // reset the "Formatting..." message
+       owner_->clearMessage();
+
        updateScrollbar();
 
        return 0;
@@ -353,10 +363,10 @@ void BufferView::Pimpl::updateScrollbar()
 
        LyXText const & t = *bv_->text;
 
-       lyxerr[Debug::GUI] << "Updating scrollbar: h " << t.height << ", first_y "
-               << t.first_y << ", default height " << defaultRowHeight() << endl;
+       lyxerr[Debug::GUI] << "Updating scrollbar: h " << t.height << ", top_y() "
+               << t.top_y() << ", default height " << defaultRowHeight() << endl;
 
-       workarea().setScrollbarParams(t.height, t.first_y, defaultRowHeight());
+       workarea().setScrollbarParams(t.height, t.top_y(), defaultRowHeight());
 }
 
 
@@ -375,13 +385,15 @@ void BufferView::Pimpl::scrollDocView(int value)
        LyXText * vbt = bv_->text;
 
        int const height = defaultRowHeight();
-       int const first = static_cast<int>((bv_->text->first_y + height));
-       int const last = static_cast<int>((bv_->text->first_y + workarea().workHeight() - height));
+       int const first = static_cast<int>((bv_->text->top_y() + height));
+       int const last = static_cast<int>((bv_->text->top_y() + workarea().workHeight() - height));
 
        if (vbt->cursor.y() < first)
-               vbt->setCursorFromCoordinates(bv_, 0, first);
+               vbt->setCursorFromCoordinates(0, first);
        else if (vbt->cursor.y() > last)
-               vbt->setCursorFromCoordinates(bv_, 0, last);
+               vbt->setCursorFromCoordinates(0, last);
+
+       owner_->updateLayoutChoice();
 }
 
 
@@ -395,16 +407,16 @@ void BufferView::Pimpl::scroll(int lines)
        int const line_height = defaultRowHeight();
 
        // The new absolute coordinate
-       int new_first_y = t->first_y + lines * line_height;
+       int new_top_y = t->top_y() + lines * line_height;
 
        // Restrict to a valid value
-       new_first_y = std::min(t->height - 4 * line_height, new_first_y);
-       new_first_y = std::max(0, new_first_y);
+       new_top_y = std::min(t->height - 4 * line_height, new_top_y);
+       new_top_y = std::max(0, new_top_y);
 
-       scrollDocView(new_first_y);
+       scrollDocView(new_top_y);
 
        // Update the scrollbar.
-       workarea().setScrollbarParams(t->height, t->first_y, defaultRowHeight());
+       workarea().setScrollbarParams(t->height, t->top_y(), defaultRowHeight());
 }
 
 
@@ -503,95 +515,44 @@ void BufferView::Pimpl::workAreaResize()
 void BufferView::Pimpl::update()
 {
        if (!bv_->theLockingInset() || !bv_->theLockingInset()->nodraw()) {
-               LyXText::text_status st = bv_->text->status();
-               screen().update(bv_->text, bv_);
-               bool fitc = false;
-               while (bv_->text->status() == LyXText::CHANGED_IN_DRAW) {
-                       bv_->text->fullRebreak(bv_);
-                       st = LyXText::NEED_MORE_REFRESH;
-                       bv_->text->setCursor(bv_, bv_->text->cursor.par(),
-                                            bv_->text->cursor.pos());
-                       if (bv_->text->selection.set()) {
-                               bv_->text->setCursor(bv_, bv_->text->selection.start,
-                                                    bv_->text->selection.start.par(),
-                                                    bv_->text->selection.start.pos());
-                               bv_->text->setCursor(bv_, bv_->text->selection.end,
-                                                    bv_->text->selection.end.par(),
-                                                    bv_->text->selection.end.pos());
-                       }
-                       fitc = true;
-                       bv_->text->status(bv_, st);
-                       screen().update(bv_->text, bv_);
-               }
-               // do this here instead of in the screen::update because of
-               // the above loop!
-               bv_->text->status(bv_, LyXText::UNCHANGED);
-               if (fitc)
-                       fitCursor();
+               screen().update(*bv_);
+               bv_->text->clearPaint();
        }
 }
 
-// Values used when calling update:
-// -3 - update
-// -2 - update, move sel_cursor if selection, fitcursor
-// -1 - update, move sel_cursor if selection, fitcursor, mark dirty
-//  0 - update, move sel_cursor if selection, fitcursor
-//  1 - update, move sel_cursor if selection, fitcursor, mark dirty
-//  3 - update, move sel_cursor if selection
-//
-// update -
-// a simple redraw of the parts that need refresh
-//
-// move sel_cursor if selection -
-// the text's sel_cursor is moved if there is selection is progress
-//
-// fitcursor -
-// fitCursor() is called and the scrollbar updated
-//
-// mark dirty -
-// the buffer is marked dirty.
-//
-// enum {
-//       UPDATE = 0,
-//       SELECT = 1,
-//       FITCUR = 2,
-//       CHANGE = 4
-// };
-//
-// UPDATE_ONLY = UPDATE;
-// UPDATE_SELECT = UPDATE | SELECT;
-// UPDATE_SELECT_MOVE = UPDATE | SELECT | FITCUR;
-// UPDATE_SELECT_MOVE_AFTER_CHANGE = UPDATE | SELECT | FITCUR | CHANGE;
-//
-// update(-3) -> update(0)         -> update(0) -> update(UPDATE)
-// update(-2) -> update(1 + 2)     -> update(3) -> update(SELECT|FITCUR)
-// update(-1) -> update(1 + 2 + 4) -> update(7) -> update(SELECT|FITCUR|CHANGE)
-// update(1)  -> update(1 + 2 + 4) -> update(7) -> update(SELECT|FITCUR|CHANGE)
-// update(3)  -> update(1)         -> update(1) -> update(SELECT)
 
 void BufferView::Pimpl::update(LyXText * text, BufferView::UpdateCodes f)
 {
-       owner_->updateLayoutChoice();
-
        if (!text->selection.set() && (f & SELECT)) {
                text->selection.cursor = text->cursor;
        }
 
-       text->fullRebreak(bv_);
+       text->fullRebreak();
 
        if (text->inset_owner) {
                text->inset_owner->setUpdateStatus(bv_, InsetText::NONE);
-               updateInset(text->inset_owner, false);
+               updateInset(text->inset_owner);
        } else {
                update();
        }
+}
+
 
-       if ((f & FITCUR)) {
-               fitCursor();
+void BufferView::Pimpl::update(BufferView::UpdateCodes f)
+{
+       LyXText * text = bv_->text;
+
+       if (!text->selection.set() && (f & SELECT)) {
+               text->selection.cursor = text->cursor;
        }
 
-       if ((f & CHANGE)) {
-               buffer_->markDirty();
+       text->fullRebreak();
+
+       if (text->inset_owner) {
+               text->inset_owner->setUpdateStatus(bv_, InsetText::NONE);
+               updateInset(text->inset_owner);
+       } else {
+               update();
        }
 }
 
@@ -624,14 +585,14 @@ bool BufferView::Pimpl::available() const
 
 Change const BufferView::Pimpl::getCurrentChange()
 {
-       if (!bv_->buffer()->params.tracking_changes) 
+       if (!bv_->buffer()->params.tracking_changes)
                return Change(Change::UNCHANGED);
 
        LyXText * t(bv_->getLyXText());
+
        if (!t->selection.set())
                return Change(Change::UNCHANGED);
+
        LyXCursor const & cur(t->selection.start);
        return cur.par()->lookupChangeFull(cur.pos());
 }
@@ -679,14 +640,14 @@ void BufferView::Pimpl::restorePosition(unsigned int i)
                if (b != 0) buffer(b);
        }
 
-       Paragraph * par = buffer_->getParFromID(saved_positions[i].par_id);
+       Paragraph * par = &*buffer_->getParFromID(saved_positions[i].par_id);
        if (!par)
                return;
 
-       bv_->text->setCursor(bv_, par,
+       bv_->text->setCursor(par,
                             min(par->size(), saved_positions[i].par_pos));
 
-       update(bv_->text, BufferView::SELECT | BufferView::FITCUR);
+       update(BufferView::SELECT);
        if (i > 0) {
                ostringstream str;
 #if USE_BOOST_FORMAT
@@ -779,18 +740,20 @@ void BufferView::Pimpl::center()
                new_y = t->cursor.y() - half_height;
        }
 
+       // FIXME: look at this comment again ...
+
        // FIXME: can we do this w/o calling screen directly ?
-       // This updates first_y but means the fitCursor() call
+       // This updates top_y() but means the fitCursor() call
        // from the update(FITCUR) doesn't realise that we might
        // have moved (e.g. from GOTOPARAGRAPH), so doesn't cause
        // the scrollbar to be updated as it should, so we have
        // to do it manually. Any operation that does a center()
-       // and also might have moved first_y must make sure to call
+       // and also might have moved top_y() must make sure to call
        // updateScrollbar() currently. Never mind that this is a
-       // pretty obfuscated way of updating t->first_y
+       // pretty obfuscated way of updating t->top_y()
        screen().draw(t, bv_, new_y);
 
-       update(t, BufferView::SELECT | BufferView::FITCUR);
+       update(BufferView::SELECT);
 }
 
 
@@ -870,8 +833,7 @@ void BufferView::Pimpl::MenuInsertLyXFile(string const & filen)
                                initpath = trypath;
                }
 
-               FileDialog fileDlg(bv_->owner(),
-                                  _("Select LyX document to insert"),
+               FileDialog fileDlg(_("Select LyX document to insert"),
                        LFUN_FILE_INSERT,
                        make_pair(string(_("Documents|#o#O")),
                                  string(lyxrc.document_path)),
@@ -943,14 +905,14 @@ void BufferView::Pimpl::trackChanges()
                // we cannot allow undos beyond the freeze point
                buf->undostack.clear();
        } else {
-               bv_->update(bv_->text, BufferView::SELECT | BufferView::FITCUR);
-               bv_->text->setCursor(bv_, &(*buf->paragraphs.begin()), 0);
-#warning changes FIXME 
+               update(BufferView::SELECT);
+               bv_->text->setCursor(&(*buf->paragraphs.begin()), 0);
+#warning changes FIXME
                //moveCursorUpdate(false);
 
                bool found = lyxfind::findNextChange(bv_);
                if (found) {
-                       owner_->getDialogs().showMergeChanges();
+                       owner_->getDialogs().show("changes");
                        return;
                }
 
@@ -960,13 +922,41 @@ void BufferView::Pimpl::trackChanges()
                }
                buf->params.tracking_changes = false;
        }
+
        buf->redostack.clear();
 }
 
 
-bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
+// Doesn't go through lyxfunc, so we need to update the
+// layout choice etc. ourselves
+bool BufferView::Pimpl::workAreaDispatch(FuncRequest const & ev_in)
+{
+       // e.g. Qt mouse press when no buffer
+       if (!available())
+               return false;
+
+       bool const res = dispatch(ev_in);
+
+       // FIXME: we should skip these when selecting
+       bv_->owner()->updateLayoutChoice();
+       bv_->owner()->updateToolbar();
+       bv_->fitCursor();
+
+       // slight hack: this is only called currently when
+       // we clicked somewhere, so we force through the display
+       // of the new status here.
+       bv_->owner()->clearMessage();
+
+       return res;
+}
+
+
+bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
 {
+       // Make sure that the cached BufferView is correct.
+       FuncRequest ev = ev_in;
+       ev.setView(bv_);
+
        lyxerr[Debug::ACTION] << "BufferView::Pimpl::Dispatch:"
                << " action[" << ev.action << ']'
                << " arg[" << ev.argument << ']'
@@ -975,10 +965,6 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
                << " button[" << ev.button() << ']'
                << endl;
 
-       // e.g. Qt mouse press when no buffer
-       if (!buffer_)
-               return false;
-
        LyXTextClass const & tclass = buffer_->params.getLyXTextClass();
 
        switch (ev.action) {
@@ -989,40 +975,6 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
                // a tabular-inset
                break;
 
-       case LFUN_INSET_GRAPHICS:
-       {
-               Inset * new_inset = new InsetGraphics;
-               if (!insertInset(new_inset)) {
-                       delete new_inset;
-               } else {
-                       // this is need because you don't use a inset->Edit()
-                       updateInset(new_inset, true);
-                       new_inset->edit(bv_);
-               }
-               break;
-       }
-
-       case LFUN_LAYOUT_COPY:
-               bv_->copyEnvironment();
-               break;
-
-       case LFUN_LAYOUT_PASTE:
-               bv_->pasteEnvironment();
-               switchKeyMap();
-               break;
-
-       case LFUN_DEPTH_MIN:
-               changeDepth(bv_, bv_->getLyXText(), -1);
-               break;
-
-       case LFUN_DEPTH_PLUS:
-               changeDepth(bv_, bv_->getLyXText(), 1);
-               break;
-
-       case LFUN_FREE:
-               owner_->getDialogs().setUserFreeFont();
-               break;
-
        case LFUN_FILE_INSERT:
                MenuInsertLyXFile(ev.argument);
                break;
@@ -1090,25 +1042,15 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
                owner_->getLyXFunc().setMessage(currentState(bv_));
                break;
 
-       case LFUN_INSERT_LABEL:
-               MenuInsertLabel(bv_, ev.argument);
-               break;
-
-       case LFUN_REF_INSERT:
-               if (ev.argument.empty()) {
-                       InsetCommandParams p("ref");
-                       owner_->getDialogs().createRef(p.getAsString());
-               } else {
-                       InsetCommandParams p;
-                       p.setFromString(ev.argument);
-
-                       InsetRef * inset = new InsetRef(p, *buffer_);
-                       if (!insertInset(inset))
-                               delete inset;
-                       else
-                               updateInset(inset, true);
-               }
-               break;
+       case LFUN_INSERT_LABEL: {
+               // Try and generate a valid label
+               string const contents = ev.argument.empty() ?
+                       getPossibleLabel(*bv_) : ev.argument;
+               InsetCommandParams icp("label", contents);
+               string data = InsetCommandMailer::params2string("label", icp);
+               owner_->getDialogs().show("label", data, 0);
+       }
+       break;
 
        case LFUN_BOOKMARK_SAVE:
                savePosition(strToUnsignedInt(ev.argument));
@@ -1118,8 +1060,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
                restorePosition(strToUnsignedInt(ev.argument));
                break;
 
-       case LFUN_REF_GOTO:
-       {
+       case LFUN_REF_GOTO: {
                string label = ev.argument;
                if (label.empty()) {
                        InsetRef * inset =
@@ -1130,13 +1071,8 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
                        }
                }
 
-               if (!label.empty()) {
-                       //bv_->savePosition(0);
-                       if (!bv_->gotoLabel(label))
-                               Alert::alert(_("Error"),
-                                          _("Couldn't find this label"),
-                                          _("in current document."));
-               }
+               if (!label.empty())
+                       bv_->gotoLabel(label);
        }
        break;
 
@@ -1166,10 +1102,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
                        owner_->getLyXFunc().handleKeyFunc(ev.action);
                        owner_->getIntl().getTransManager()
                                .TranslateAndInsert(ev.argument[0], bv_->getLyXText());
-                       update(bv_->getLyXText(),
-                              BufferView::SELECT
-                              | BufferView::FITCUR
-                              | BufferView::CHANGE);
+                       update(bv_->getLyXText(), BufferView::SELECT);
                }
                break;
 
@@ -1180,89 +1113,42 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
        case LFUN_MATH_IMPORT_SELECTION: // Imports LaTeX from the X selection
        case LFUN_MATH_DISPLAY:          // Open or create a displayed math inset
        case LFUN_MATH_MODE:             // Open or create an inlined math inset
-       case LFUN_GREEK:                 // Insert a single greek letter
-               mathDispatch(FuncRequest(bv_, ev.action, ev.argument));
+               mathDispatch(ev);
                break;
 
-       case LFUN_CITATION_INSERT:
-       {
-               InsetCommandParams p;
-               p.setFromString(ev.argument);
+       case LFUN_INSET_APPLY: {
+               string const name = ev.getArg(0);
 
-               InsetCitation * inset = new InsetCitation(p);
-               if (!insertInset(inset))
-                       delete inset;
-               else {
-                       inset->setLoadingBuffer(bv_->buffer(), false);
-                       updateInset(inset, true);
-               }
-
-       }
-       break;
-
-       case LFUN_INSERT_BIBTEX:
-       {
-               // ale970405+lasgoutt970425
-               // The argument can be up to two tokens separated
-               // by a space. The first one is the bibstyle.
-               string const db = token(ev.argument, ' ', 0);
-               string bibstyle = token(ev.argument, ' ', 1);
-               if (bibstyle.empty())
-                       bibstyle = "plain";
-
-               InsetCommandParams p("BibTeX", db, bibstyle);
-               InsetBibtex * inset = new InsetBibtex(p);
-
-               if (insertInset(inset)) {
-                       if (ev.argument.empty())
-                               inset->edit(bv_);
-               } else
-                       delete inset;
-       }
-       break;
-
-       // BibTeX data bases
-       case LFUN_BIBDB_ADD:
-       {
-               InsetBibtex * inset =
-                       static_cast<InsetBibtex*>(getInsetByCode(Inset::BIBTEX_CODE));
+               InsetBase * inset = owner_->getDialogs().getOpenInset(name);
                if (inset) {
-                       inset->addDatabase(ev.argument);
+                       // This works both for 'original' and 'mathed' insets.
+                       // Note that the localDispatch performs updateInset
+                       // also.
+                       FuncRequest fr(bv_, LFUN_INSET_MODIFY, ev.argument);
+                       inset->localDispatch(fr);
+               } else {
+                       FuncRequest fr(bv_, LFUN_INSET_INSERT, ev.argument);
+                       dispatch(fr);
                }
        }
        break;
 
-       case LFUN_BIBDB_DEL:
-       {
-               InsetBibtex * inset =
-                       static_cast<InsetBibtex*>(getInsetByCode(Inset::BIBTEX_CODE));
-               if (inset)
-                       inset->delDatabase(ev.argument);
-       }
-       break;
-
-       case LFUN_BIBTEX_STYLE:
-       {
-               InsetBibtex * inset =
-                       static_cast<InsetBibtex*>(getInsetByCode(Inset::BIBTEX_CODE));
-               if (inset)
-                       inset->setOptions(ev.argument);
-       }
-       break;
-
-       case LFUN_CHILD_INSERT:
-       {
-               InsetInclude::Params p;
-               if (!ev.argument.empty())
-                       p.cparams.setFromString(ev.argument);
-               p.masterFilename_ = buffer_->fileName();
-
-               InsetInclude * inset = new InsetInclude(p);
-               if (!insertInset(inset))
+       case LFUN_INSET_INSERT: {
+               Inset * inset = createInset(ev);
+               if (inset && insertInset(inset)) {
+                       updateInset(inset);
+
+                       string const name = ev.getArg(0);
+                       if (name == "bibitem") {
+                               // We need to do a redraw because the maximum
+                               // InsetBibitem width could have changed
+#warning please check you mean repaint() not update(),
+#warning and whether the repaint() is needed at all
+                               bv_->repaint();
+                               bv_->fitCursor();
+                       }
+               } else {
                        delete inset;
-               else {
-                       updateInset(inset, true);
-                       bv_->owner()->getDialogs().showInclude(inset);
                }
        }
        break;
@@ -1278,6 +1164,41 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
                }
                break;
 
+       case LFUN_LAYOUT_PARAGRAPH: {
+               Paragraph const * par = &*bv_->getLyXText()->cursor.par();
+               if (!par)
+                       break;
+
+               string data;
+               params2string(*par, data);
+
+               data = "show\n" + data;
+               bv_->owner()->getDialogs().show("paragraph", data);
+               break;
+       }
+
+       case LFUN_PARAGRAPH_UPDATE: {
+               Paragraph const * par = &*bv_->getLyXText()->cursor.par();
+               if (!par)
+                       break;
+
+               string data;
+               params2string(*par, data);
+
+               // Will the paragraph accept changes from the dialog?
+               Inset * const inset = par->inInset();
+               bool const accept =
+                       !(inset && inset->forceDefaultParagraphs(inset));
+
+               data = "update " + tostr(accept) + '\n' + data;
+               bv_->owner()->getDialogs().update("paragraph", data);
+               break;
+       }
+
+       case LFUN_PARAGRAPH_APPLY:
+               setParagraphParams(*bv_, ev.argument);
+               break;
+
        case LFUN_THESAURUS_ENTRY:
        {
                string arg = ev.argument;
@@ -1289,66 +1210,62 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev)
                        // FIXME
                        if (arg.size() > 100 || arg.empty()) {
                                // Get word or selection
-                               bv_->getLyXText()->selectWordWhenUnderCursor(bv_, LyXText::WHOLE_WORD);
+                               bv_->getLyXText()->selectWordWhenUnderCursor(LyXText::WHOLE_WORD);
                                arg = bv_->getLyXText()->selectionAsString(buffer_, false);
                                // FIXME: where is getLyXText()->unselect(bv_) ?
                        }
                }
 
-               bv_->owner()->getDialogs().showThesaurus(arg);
+               bv_->owner()->getDialogs().show("thesaurus", arg);
        }
                break;
 
        case LFUN_TRACK_CHANGES:
                trackChanges();
                break;
+
        case LFUN_MERGE_CHANGES:
-               owner_->getDialogs().showMergeChanges();
+               owner_->getDialogs().show("changes");
                break;
+
        case LFUN_ACCEPT_ALL_CHANGES: {
-               bv_->update(bv_->text, BufferView::SELECT | BufferView::FITCUR);
-               bv_->text->setCursor(bv_, &(*bv_->buffer()->paragraphs.begin()), 0);
-#warning FIXME changes 
+               update(BufferView::SELECT);
+               bv_->text->setCursor(&(*bv_->buffer()->paragraphs.begin()), 0);
+#warning FIXME changes
                //moveCursorUpdate(false);
 
                while (lyxfind::findNextChange(bv_)) {
-                       bv_->getLyXText()->acceptChange(bv_);
+                       bv_->getLyXText()->acceptChange();
                }
-               update(bv_->text,
-                       BufferView::SELECT | BufferView::FITCUR | BufferView::CHANGE);
+               update(BufferView::SELECT);
                break;
        }
+
        case LFUN_REJECT_ALL_CHANGES: {
-               bv_->update(bv_->text, BufferView::SELECT | BufferView::FITCUR);
-               bv_->text->setCursor(bv_, &(*bv_->buffer()->paragraphs.begin()), 0);
-#warning FIXME changes 
+               update(BufferView::SELECT);
+               bv_->text->setCursor(&(*bv_->buffer()->paragraphs.begin()), 0);
+#warning FIXME changes
                //moveCursorUpdate(false);
 
                while (lyxfind::findNextChange(bv_)) {
-                       bv_->getLyXText()->rejectChange(bv_);
+                       bv_->getLyXText()->rejectChange();
                }
-               update(bv_->text,
-                       BufferView::SELECT | BufferView::FITCUR | BufferView::CHANGE);
+               update(BufferView::SELECT);
                break;
        }
+
        case LFUN_ACCEPT_CHANGE: {
-               bv_->getLyXText()->acceptChange(bv_);
-               update(bv_->text,
-                       BufferView::SELECT | BufferView::FITCUR | BufferView::CHANGE);
+               bv_->getLyXText()->acceptChange();
+               update(BufferView::SELECT);
                break;
        }
 
        case LFUN_REJECT_CHANGE: {
-               bv_->getLyXText()->rejectChange(bv_);
-               update(bv_->text,
-                       BufferView::SELECT | BufferView::FITCUR | BufferView::CHANGE);
+               bv_->getLyXText()->rejectChange();
+               update(BufferView::SELECT);
                break;
        }
+
        case LFUN_UNKNOWN_ACTION:
                ev.errorMessage(N_("Unknown function!"));
                break;
@@ -1377,15 +1294,15 @@ bool BufferView::Pimpl::insertInset(Inset * inset, string const & lout)
 
        beforeChange(bv_->text);
        if (!lout.empty()) {
-               update(bv_->text, BufferView::SELECT|BufferView::FITCUR);
-               bv_->text->breakParagraph(bv_);
-               update(bv_->text, BufferView::SELECT|BufferView::FITCUR|BufferView::CHANGE);
+               update(BufferView::SELECT);
+               bv_->text->breakParagraph(bv_->buffer()->paragraphs);
+               update(BufferView::SELECT);
 
                if (!bv_->text->cursor.par()->empty()) {
                        bv_->text->cursorLeft(bv_);
 
-                       bv_->text->breakParagraph(bv_);
-                       update(bv_->text, BufferView::SELECT|BufferView::FITCUR|BufferView::CHANGE);
+                       bv_->text->breakParagraph(bv_->buffer()->paragraphs);
+                       update(BufferView::SELECT);
                }
 
                string lres = lout;
@@ -1402,27 +1319,27 @@ bool BufferView::Pimpl::insertInset(Inset * inset, string const & lout)
                        lay = tclass.defaultLayoutName();
                }
 
-               bv_->text->setLayout(bv_, lay);
+               bv_->text->setLayout(lay);
 
-               bv_->text->setParagraph(bv_, 0, 0,
+               bv_->text->setParagraph(0, 0,
                                   0, 0,
                                   VSpace(VSpace::NONE), VSpace(VSpace::NONE),
                                   Spacing(),
                                   LYX_ALIGN_LAYOUT,
                                   string(),
                                   0);
-               update(bv_->text, BufferView::SELECT|BufferView::FITCUR|BufferView::CHANGE);
+               update(BufferView::SELECT);
        }
 
-       bv_->text->insertInset(bv_, inset);
-       update(bv_->text, BufferView::SELECT|BufferView::FITCUR|BufferView::CHANGE);
+       bv_->text->insertInset(inset);
+       update(BufferView::SELECT);
 
        unFreezeUndo();
        return true;
 }
 
 
-void BufferView::Pimpl::updateInset(Inset * inset, bool mark_dirty)
+void BufferView::Pimpl::updateInset(Inset * inset)
 {
        if (!inset || !available())
                return;
@@ -1430,20 +1347,14 @@ void BufferView::Pimpl::updateInset(Inset * inset, bool mark_dirty)
        // first check for locking insets
        if (bv_->theLockingInset()) {
                if (bv_->theLockingInset() == inset) {
-                       if (bv_->text->updateInset(bv_, inset)) {
+                       if (bv_->text->updateInset(inset)) {
                                update();
-                               if (mark_dirty) {
-                                       buffer_->markDirty();
-                               }
                                updateScrollbar();
                                return;
                        }
                } else if (bv_->theLockingInset()->updateInsetInInset(bv_, inset)) {
-                       if (bv_->text->updateInset(bv_,  bv_->theLockingInset())) {
+                       if (bv_->text->updateInset(bv_->theLockingInset())) {
                                update();
-                               if (mark_dirty) {
-                                       buffer_->markDirty();
-                               }
                                updateScrollbar();
                                return;
                        }
@@ -1458,22 +1369,15 @@ void BufferView::Pimpl::updateInset(Inset * inset, bool mark_dirty)
                tl_inset = tl_inset->owner();
        hideCursor();
        if (tl_inset == inset) {
-               update(bv_->text, BufferView::UPDATE);
-               if (bv_->text->updateInset(bv_, inset)) {
-                       if (mark_dirty) {
-                               update(bv_->text,
-                                      BufferView::SELECT
-                                      | BufferView::FITCUR
-                                      | BufferView::CHANGE);
-                       } else {
-                               update(bv_->text, SELECT);
-                       }
+               update(BufferView::UPDATE);
+               if (bv_->text->updateInset(inset)) {
+                       update(BufferView::SELECT);
                        return;
                }
        } else if (static_cast<UpdatableInset *>(tl_inset)
                           ->updateInsetInInset(bv_, inset))
        {
-               if (bv_->text->updateInset(bv_, tl_inset)) {
+               if (bv_->text->updateInset(tl_inset)) {
                        update();
                        updateScrollbar();
                }