]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView_pimpl.C
minimal effort implementation of:
[lyx.git] / src / BufferView_pimpl.C
index 716a88bcb83401bd0bfdfab89b11c3c7662cbe0a..a1fc04b408b4608db3e96008a0fb279cb3f44de3 100644 (file)
@@ -12,6 +12,7 @@
  * \author André Pönitz
  * \author Dekel Tsur
  * \author Jürgen Vigna
+ * \author Abdelrazak Younes
  *
  * Full author contact details are available in file CREDITS.
  */
 #include "bufferparams.h"
 #include "coordcache.h"
 #include "cursor.h"
+#include "CutAndPaste.h"
 #include "debug.h"
 #include "dispatchresult.h"
+#include "errorlist.h"
 #include "factory.h"
 #include "FloatList.h"
 #include "funcrequest.h"
 #include "lyxfunc.h"
 #include "lyxtext.h"
 #include "lyxrc.h"
-#include "lastfiles.h"
+#include "session.h"
 #include "metricsinfo.h"
 #include "paragraph.h"
 #include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
 #include "pariterator.h"
-#include "rowpainter.h"
+#include "toc.h"
 #include "undo.h"
 #include "vspace.h"
 
+#include "insets/insetbibtex.h"
 #include "insets/insetref.h"
 #include "insets/insettext.h"
 
 #include "frontends/Dialogs.h"
 #include "frontends/FileDialog.h"
 #include "frontends/font_metrics.h"
+#include "frontends/Gui.h"
 #include "frontends/LyXView.h"
-#include "frontends/LyXScreenFactory.h"
-#include "frontends/screen.h"
-#include "frontends/WorkArea.h"
-#include "frontends/WorkAreaFactory.h"
+#include "frontends/Selection.h"
 
 #include "graphics/Previews.h"
 
 #include "support/convert.h"
 #include "support/filefilterlist.h"
 #include "support/filetools.h"
-#include "support/forkedcontr.h"
 #include "support/package.h"
 #include "support/types.h"
 
 #include <functional>
 #include <vector>
 
+using lyx::frontend::Clipboard;
+using lyx::frontend::Gui;
+
 using lyx::pos_type;
 
-using lyx::support::AddPath;
+using lyx::support::addPath;
 using lyx::support::bformat;
 using lyx::support::FileFilterList;
-using lyx::support::FileSearch;
-using lyx::support::ForkedcallsController;
-using lyx::support::IsDirWriteable;
-using lyx::support::MakeDisplayPath;
-using lyx::support::MakeAbsPath;
+using lyx::support::fileSearch;
+using lyx::support::isDirWriteable;
+using lyx::support::makeDisplayPath;
+using lyx::support::makeAbsPath;
 using lyx::support::package;
 
 using std::endl;
@@ -100,7 +103,6 @@ using std::string;
 using std::mem_fun_ref;
 using std::vector;
 
-
 extern BufferList bufferlist;
 
 
@@ -108,21 +110,8 @@ namespace {
 
 unsigned int const saved_positions_num = 20;
 
-// All the below connection objects are needed because of a bug in some
-// versions of GCC (<=2.96 are on the suspects list.) By having and assigning
-// to these connections we avoid a segfault upon startup, and also at exit.
-// (Lgb)
-
-boost::signals::connection dispatchcon;
-boost::signals::connection timecon;
-boost::signals::connection doccon;
-boost::signals::connection resizecon;
-boost::signals::connection kpresscon;
-boost::signals::connection selectioncon;
-boost::signals::connection lostcon;
 
-
-/// Get next inset of this class from current cursor position
+/// Return an inset of this class if it exists at the current cursor position
 template <class T>
 T * getInsetByCode(LCursor & cur, InsetBase::Code code)
 {
@@ -138,102 +127,22 @@ T * getInsetByCode(LCursor & cur, InsetBase::Code code)
 } // anon namespace
 
 
-BufferView::Pimpl::Pimpl(BufferView & bv, LyXView * owner,
-                        int width, int height)
-       : bv_(&bv), owner_(owner), buffer_(0), cursor_timeout(400),
-         using_xterm_cursor(false), cursor_(bv) ,
-         anchor_ref_(0), offset_ref_(0)
+BufferView::Pimpl::Pimpl(BufferView & bv, LyXView * owner)
+       : bv_(&bv), owner_(owner), buffer_(0), wh_(0),
+         cursor_(bv),
+         multiparsel_cache_(false), anchor_ref_(0), offset_ref_(0)
 {
        xsel_cache_.set = false;
 
-       workarea_.reset(WorkAreaFactory::create(*owner_, width, height));
-       screen_.reset(LyXScreenFactory::create(workarea()));
-
-       // Setup the signals
-       doccon = workarea().scrollDocView
-               .connect(boost::bind(&BufferView::Pimpl::scrollDocView, this, _1));
-       resizecon = workarea().workAreaResize
-               .connect(boost::bind(&BufferView::Pimpl::workAreaResize, this));
-       dispatchcon = workarea().dispatch
-               .connect(boost::bind(&BufferView::Pimpl::workAreaDispatch, this, _1));
-       kpresscon = workarea().workAreaKeyPress
-               .connect(boost::bind(&BufferView::Pimpl::workAreaKeyPress, this, _1, _2));
-       selectioncon = workarea().selectionRequested
-               .connect(boost::bind(&BufferView::Pimpl::selectionRequested, this));
-       lostcon = workarea().selectionLost
-               .connect(boost::bind(&BufferView::Pimpl::selectionLost, this));
-
-       timecon = cursor_timeout.timeout
-               .connect(boost::bind(&BufferView::Pimpl::cursorToggle, this));
-       cursor_timeout.start();
        saved_positions.resize(saved_positions_num);
-}
-
-
-void BufferView::Pimpl::addError(ErrorItem const & ei)
-{
-       errorlist_.push_back(ei);
-}
-
-
-void BufferView::Pimpl::showReadonly(bool)
-{
-       owner_->updateWindowTitle();
-       owner_->getDialogs().updateBufferDependent(false);
-}
-
-
-void BufferView::Pimpl::connectBuffer(Buffer & buf)
-{
-       if (errorConnection_.connected())
-               disconnectBuffer();
-
-       errorConnection_ =
-               buf.error.connect(
-                       boost::bind(&BufferView::Pimpl::addError, this, _1));
-
-       messageConnection_ =
-               buf.message.connect(
-                       boost::bind(&LyXView::message, owner_, _1));
-
-       busyConnection_ =
-               buf.busy.connect(
-                       boost::bind(&LyXView::busy, owner_, _1));
-
-       titleConnection_ =
-               buf.updateTitles.connect(
-                       boost::bind(&LyXView::updateWindowTitle, owner_));
-
-       timerConnection_ =
-               buf.resetAutosaveTimers.connect(
-                       boost::bind(&LyXView::resetAutosaveTimer, owner_));
-
-       readonlyConnection_ =
-               buf.readonly.connect(
-                       boost::bind(&BufferView::Pimpl::showReadonly, this, _1));
-
-       closingConnection_ =
-               buf.closing.connect(
-                       boost::bind(&BufferView::Pimpl::setBuffer, this, (Buffer *)0));
-}
-
-
-void BufferView::Pimpl::disconnectBuffer()
-{
-       errorConnection_.disconnect();
-       messageConnection_.disconnect();
-       busyConnection_.disconnect();
-       titleConnection_.disconnect();
-       timerConnection_.disconnect();
-       readonlyConnection_.disconnect();
-       closingConnection_.disconnect();
-}
-
-
-void BufferView::Pimpl::newFile(string const & filename, string const & tname,
-       bool isNamed)
-{
-       setBuffer(::newFile(filename, tname, isNamed));
+       // load saved bookmarks
+       lyx::Session::BookmarkList & bmList = LyX::ref().session().loadBookmarks();
+       for (lyx::Session::BookmarkList::iterator bm = bmList.begin();
+               bm != bmList.end(); ++bm)
+               if (bm->get<0>() < saved_positions_num)
+                       saved_positions[bm->get<0>()] = Position( bm->get<1>(), bm->get<2>(), bm->get<3>() );
+       // and then clear them
+       bmList.clear();
 }
 
 
@@ -241,7 +150,7 @@ bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
 {
        // Get absolute path of file and add ".lyx"
        // to the filename if necessary
-       string s = FileSearch(string(), filename, "lyx");
+       string s = fileSearch(string(), filename, "lyx");
 
        bool const found = !s.empty();
 
@@ -250,7 +159,7 @@ bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
 
        // File already open?
        if (bufferlist.exists(s)) {
-               string const file = MakeDisplayPath(s, 20);
+               string const file = makeDisplayPath(s, 20);
                string text = bformat(_("The document %1$s is already "
                                        "loaded.\n\nDo you want to revert "
                                        "to the saved version?"), file);
@@ -267,11 +176,10 @@ bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
                // Fall through to new load. (Asger)
        }
 
-       Buffer * b;
+       Buffer * b = 0;
 
        if (found) {
                b = bufferlist.newBuffer(s);
-               connectBuffer(*b);
                if (!::loadLyXFile(b, s)) {
                        bufferlist.release(b);
                        return false;
@@ -283,37 +191,56 @@ bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
                int const ret = Alert::prompt(_("Create new document?"),
                         text, 0, 1, _("&Create"), _("Cancel"));
 
-               if (ret == 0)
-                       b = ::newFile(s, string(), true);
-               else
+               if (ret == 0) {
+                       b = newFile(s, string(), true);
+                       if (!b)
+                               return false;
+               } else
                        return false;
        }
 
        setBuffer(b);
-       bv_->showErrorList(_("Parse"));
+       // Send the "errors" signal in case of parsing errors
+       b->errors("Parse");
+
+       // scroll to the position when the file was last closed
+       if (lyxrc.use_lastfilepos) {
+               lyx::pit_type pit;
+               lyx::pos_type pos;
+               boost::tie(pit, pos) = LyX::ref().session().loadFilePosition(s);
+               // I am not sure how to separate the following part to a function
+               // so I will leave this to Lars.
+               //
+               // check pit since the document may be externally changed.
+               if ( static_cast<size_t>(pit) < b->paragraphs().size() ) {
+                       ParIterator it = b->par_iterator_begin();
+                       ParIterator const end = b->par_iterator_end();
+                       for (; it != end; ++it)
+                               if (it.pit() == pit) {
+                                       // restored pos may be bigger than it->size
+                                       bv_->setCursor(makeDocIterator(it, min(pos, it->size())));
+                                       bv_->update(Update::FitCursor);
+                                       break;
+                               }
+               }
+       }
 
        if (tolastfiles)
-               LyX::ref().lastfiles().newFile(b->fileName());
+               LyX::ref().session().addLastFile(b->fileName());
 
        return true;
 }
 
 
-WorkArea & BufferView::Pimpl::workarea() const
-{
-       return *workarea_.get();
-}
-
-
-LyXScreen & BufferView::Pimpl::screen() const
+int BufferView::Pimpl::width() const
 {
-       return *screen_.get();
+       return width_;
 }
 
 
-Painter & BufferView::Pimpl::painter() const
+int BufferView::Pimpl::height() const
 {
-       return workarea().getPainter();
+       return height_;
 }
 
 
@@ -322,8 +249,22 @@ void BufferView::Pimpl::setBuffer(Buffer * b)
        lyxerr[Debug::INFO] << BOOST_CURRENT_FUNCTION
                            << "[ b = " << b << "]" << endl;
 
-       if (buffer_)
-               disconnectBuffer();
+       if (buffer_) {
+               // Save the actual cursor position and anchor inside the
+               // buffer so that it can be restored in case we rechange
+               // to this buffer later on.
+               buffer_->saveCursor(cursor_.selectionBegin(),
+                                   cursor_.selectionEnd());
+               // current buffer is going to be switched-off, save cursor pos
+               LyX::ref().session().saveFilePosition(buffer_->fileName(),
+                       boost::tie(cursor_.pit(), cursor_.pos()) );
+       }
+
+       // If we're quitting lyx, don't bother updating stuff
+       if (quitting) {
+               buffer_ = 0;
+               return;
+       }
 
        // If we are closing current buffer, switch to the first in
        // buffer list.
@@ -332,7 +273,6 @@ void BufferView::Pimpl::setBuffer(Buffer * b)
                                    << " No Buffer!" << endl;
                // We are closing the buffer, use the first buffer as current
                buffer_ = bufferlist.first();
-               owner_->getDialogs().hideBufferDependent();
        } else {
                // Set current buffer
                buffer_ = b;
@@ -343,37 +283,24 @@ void BufferView::Pimpl::setBuffer(Buffer * b)
        anchor_ref_ = 0;
        offset_ref_ = 0;
 
-
-       // If we're quitting lyx, don't bother updating stuff
-       if (quitting)
-               return;
-
        if (buffer_) {
                lyxerr[Debug::INFO] << BOOST_CURRENT_FUNCTION
                                    << "Buffer addr: " << buffer_ << endl;
-               connectBuffer(*buffer_);
-
                cursor_.push(buffer_->inset());
                cursor_.resetAnchor();
                buffer_->text().init(bv_);
                buffer_->text().setCurrentFont(cursor_);
-
-               // Buffer-dependent dialogs should be updated or
-               // hidden. This should go here because some dialogs (eg ToC)
-               // require bv_->text.
-               owner_->getDialogs().updateBufferDependent(true);
+               if (buffer_->getCursor().size() > 0 &&
+                   buffer_->getAnchor().size() > 0)
+               {
+                       cursor_.setCursor(buffer_->getAnchor().asDocIterator(&(buffer_->inset())));
+                       cursor_.resetAnchor();
+                       cursor_.setCursor(buffer_->getCursor().asDocIterator(&(buffer_->inset())));
+                       cursor_.setSelection();
+               }
        }
 
        update();
-       updateScrollbar();
-       owner_->updateMenubar();
-       owner_->updateToolbars();
-       owner_->updateLayoutChoice();
-       owner_->updateWindowTitle();
-
-       // This is done after the layout combox has been populated
-       if (buffer_)
-               owner_->setLayout(cursor_.paragraph().layout()->name());
 
        if (buffer_ && lyx::graphics::Previews::status() != LyXRC::PREVIEW_OFF)
                lyx::graphics::Previews::get().generateBufferPreviews(*buffer_);
@@ -383,8 +310,6 @@ void BufferView::Pimpl::setBuffer(Buffer * b)
 void BufferView::Pimpl::resizeCurrentBuffer()
 {
        lyxerr[Debug::DEBUG] << BOOST_CURRENT_FUNCTION << endl;
-       owner_->busy(true);
-       owner_->message(_("Formatting document..."));
 
        LyXText * text = bv_->text();
        if (!text)
@@ -392,14 +317,7 @@ void BufferView::Pimpl::resizeCurrentBuffer()
 
        text->init(bv_);
        update();
-
        switchKeyMap();
-       owner_->busy(false);
-
-       // Reset the "Formatting..." message
-       owner_->clearMessage();
-
-       updateScrollbar();
 }
 
 
@@ -408,13 +326,14 @@ void BufferView::Pimpl::updateScrollbar()
        if (!bv_->text()) {
                lyxerr[Debug::DEBUG] << BOOST_CURRENT_FUNCTION
                                     << " no text in updateScrollbar" << endl;
-               workarea().setScrollbarParams(0, 0, 0);
+               scrollbarParameters_.reset();
                return;
        }
 
        LyXText & t = *bv_->text();
-       if (anchor_ref_ >  int(t.paragraphs().size()) - 1) {
-               anchor_ref_ = int(t.paragraphs().size()) - 1;
+       int const parsize = int(t.paragraphs().size() - 1);
+       if (anchor_ref_ >  parsize)  {
+               anchor_ref_ = parsize;
                offset_ref_ = 0;
        }
 
@@ -426,10 +345,42 @@ void BufferView::Pimpl::updateScrollbar()
 
        // It would be better to fix the scrollbar to understand
        // values in [0..1] and divide everything by wh
-       int const wh = workarea().workHeight() / 4;
-       int const h = t.getPar(anchor_ref_).height();
-       workarea().setScrollbarParams(t.paragraphs().size() * wh, anchor_ref_ * wh + int(offset_ref_ * wh / float(h)), int (wh * defaultRowHeight() / float(h)));
-//     workarea().setScrollbarParams(t.paragraphs().size(), anchor_ref_, 1);
+
+       // estimated average paragraph height:
+       if (wh_ == 0)
+               wh_ = height_ / 4;
+       int h = t.getPar(anchor_ref_).height();
+
+       // Normalize anchor/offset (MV):
+       while (offset_ref_ > h && anchor_ref_ < parsize) {
+               anchor_ref_++;
+               offset_ref_ -= h;
+               h = t.getPar(anchor_ref_).height();
+       }
+       // Look at paragraph heights on-screen
+       int sumh = 0;
+       int nh = 0;
+       for (lyx::pit_type pit = anchor_ref_; pit <= parsize; ++pit) {
+               if (sumh > height_)
+                       break;
+               int const h2 = t.getPar(pit).height();
+               sumh += h2;
+               nh++;
+       }
+       int const hav = sumh / nh;
+       // More realistic average paragraph height
+       if (hav > wh_)
+               wh_ = hav;
+
+       scrollbarParameters_.height = (parsize + 1) * wh_;
+       scrollbarParameters_.position = anchor_ref_ * wh_ + int(offset_ref_ * wh_ / float(h));
+       scrollbarParameters_.lineScrollHeight = int(wh_ * defaultRowHeight() / float(h));
+}
+
+
+ScrollbarParameters const & BufferView::Pimpl::scrollbarParameters() const
+{
+       return scrollbarParameters_;
 }
 
 
@@ -441,26 +392,26 @@ void BufferView::Pimpl::scrollDocView(int value)
        if (!buffer_)
                return;
 
-       screen().hideCursor();
-
-       int const wh = workarea().workHeight() / 4;
-
        LyXText & t = *bv_->text();
 
-       float const bar = value / float(wh * t.paragraphs().size());
+       float const bar = value / float(wh_ * t.paragraphs().size());
 
        anchor_ref_ = int(bar * t.paragraphs().size());
+       if (anchor_ref_ >  int(t.paragraphs().size()) - 1)
+               anchor_ref_ = int(t.paragraphs().size()) - 1;
        t.redoParagraph(anchor_ref_);
        int const h = t.getPar(anchor_ref_).height();
        offset_ref_ = int((bar * t.paragraphs().size() - anchor_ref_) * h);
-       update();
+}
 
-       if (!lyxrc.cursor_follows_scrollbar)
-               return;
+
+void BufferView::Pimpl::setCursorFromScrollbar()
+{
+       LyXText & t = *bv_->text();
 
        int const height = 2 * defaultRowHeight();
        int const first = height;
-       int const last = workarea().workHeight() - height;
+       int const last = height_ - height;
        LCursor & cur = cursor_;
 
        bv_funcs::CurStatus st = bv_funcs::status(bv_, cur);
@@ -475,14 +426,13 @@ void BufferView::Pimpl::scrollDocView(int value)
                cur.clearSelection();
                break;
        case bv_funcs::CUR_INSIDE:
-               int const y = bv_funcs::getPos(cur).y_;
+               int const y = bv_funcs::getPos(cur, cur.boundary()).y_;
                int const newy = min(last, max(y, first));
                if (y != newy) {
                        cur.reset(buffer_->inset());
                        t.setCursorFromCoordinates(cur, 0, newy);
                }
        }
-       owner_->updateLayoutChoice();
 }
 
 
@@ -504,26 +454,7 @@ void BufferView::Pimpl::scroll(int /*lines*/)
 //     scrollDocView(new_top_y);
 //
 //     // Update the scrollbar.
-//     workarea().setScrollbarParams(t->height(), top_y(), defaultRowHeight());
-}
-
-
-void BufferView::Pimpl::workAreaKeyPress(LyXKeySymPtr key,
-                                        key_modifier::state state)
-{
-       owner_->getLyXFunc().processKeySym(key, state);
-
-       /* This is perhaps a bit of a hack. When we move
-        * around, or type, it's nice to be able to see
-        * the cursor immediately after the keypress. So
-        * we reset the toggle timeout and force the visibility
-        * of the cursor. Note we cannot do this inside
-        * dispatch() itself, because that's called recursively.
-        */
-       if (available()) {
-               cursor_timeout.restart();
-               screen().showCursor(*bv_);
-       }
+//     workArea_->setScrollbarParams(t->height(), top_y(), defaultRowHeight());}
 }
 
 
@@ -550,7 +481,7 @@ void BufferView::Pimpl::selectionRequested()
                xsel_cache_.set = cur.selection();
                sel = cur.selectionAsString(false);
                if (!sel.empty())
-                       workarea().putClipboard(sel);
+                       owner_->gui().selection().put(sel);
        }
 }
 
@@ -558,36 +489,28 @@ void BufferView::Pimpl::selectionRequested()
 void BufferView::Pimpl::selectionLost()
 {
        if (available()) {
-               screen().hideCursor();
                cursor_.clearSelection();
                xsel_cache_.set = false;
        }
 }
 
 
-void BufferView::Pimpl::workAreaResize()
+void BufferView::Pimpl::workAreaResize(int width, int height)
 {
-       static int work_area_width;
-       static int work_area_height;
-
-       bool const widthChange = workarea().workWidth() != work_area_width;
-       bool const heightChange = workarea().workHeight() != work_area_height;
+       bool const widthChange = width != width_;
+       bool const heightChange = height != height_;
 
        // Update from work area
-       work_area_width = workarea().workWidth();
-       work_area_height = workarea().workHeight();
+       width_ = width;
+       height_ = height;
 
        if (buffer_ && widthChange) {
-               // The visible LyXView need a resize
+               // The WorkArea content needs a resize
                resizeCurrentBuffer();
        }
 
        if (widthChange || heightChange)
                update();
-
-       // Always make sure that the scrollbar is sane.
-       updateScrollbar();
-       owner_->updateLayoutChoice();
 }
 
 
@@ -597,8 +520,8 @@ bool BufferView::Pimpl::fitCursor()
                LyXFont const font = cursor_.getFont();
                int const asc = font_metrics::maxAscent(font);
                int const des = font_metrics::maxDescent(font);
-               Point p = bv_funcs::getPos(cursor_);
-               if (p.y_ - asc >= 0 && p.y_ + des < workarea().workHeight())
+               Point const p = bv_funcs::getPos(cursor_, cursor_.boundary());
+               if (p.y_ - asc >= 0 && p.y_ + des < height_)
                        return false;
        }
        center();
@@ -606,60 +529,51 @@ bool BufferView::Pimpl::fitCursor()
 }
 
 
-void BufferView::Pimpl::update(bool fitcursor, bool forceupdate)
+bool BufferView::Pimpl::multiParSel()
 {
-       lyxerr << BOOST_CURRENT_FUNCTION
-              << "[fitcursor = " << fitcursor << ','
-              << " forceupdate = " << forceupdate
-              << "]  buffer: " << buffer_ << endl;
-
-       // Check needed to survive LyX startup
-       if (buffer_) {
-               // Update macro store
-               buffer_->buildMacros();
-               // First drawing step
-
-               CoordCache backup;
-               std::swap(theCoords, backup);
-               theCoords.startUpdating();
+       if (!cursor_.selection())
+               return false;
+       bool ret = multiparsel_cache_;
+       multiparsel_cache_ = cursor_.selBegin().pit() != cursor_.selEnd().pit();
+       // Either this, or previous selection spans paragraphs
+       return ret || multiparsel_cache_;
+}
 
-               ViewMetricsInfo vi = metrics();
 
-               if (fitcursor && fitCursor()) {
-                       forceupdate = true;
-                       vi = metrics();
-               }
-               if (forceupdate) {
-                       // Second drawing step
-                       screen().redraw(*bv_, vi);
-               } else {
-                       // Abort updating of the coord cache - just restore the old one
-                       std::swap(theCoords, backup);
-               }
-       } else
-               screen().greyOut();
-
-       // And the scrollbar
-       updateScrollbar();
-       owner_->view_state_changed();
+ViewMetricsInfo const & BufferView::Pimpl::viewMetricsInfo()
+{
+       return metrics_info_;
 }
 
 
-// Callback for cursor timer
-void BufferView::Pimpl::cursorToggle()
+bool BufferView::Pimpl::update(Update::flags flags)
 {
-       if (buffer_) {
-               screen().toggleCursor(*bv_);
-
-               // Use this opportunity to deal with any child processes that
-               // have finished but are waiting to communicate this fact
-               // to the rest of LyX.
-               ForkedcallsController & fcc = ForkedcallsController::get();
-               if (fcc.processesCompleted())
-                       fcc.handleCompletedProcesses();
+       // This is close to a hot-path.
+       if (lyxerr.debugging(Debug::DEBUG)) {
+               lyxerr[Debug::DEBUG]
+                       << BOOST_CURRENT_FUNCTION
+                       << "[fitcursor = " << (flags & Update::FitCursor)
+                       << ", forceupdate = " << (flags & Update::Force)
+                       << ", singlepar = " << (flags & Update::SinglePar)
+                       << "]  buffer: " << buffer_ << endl;
        }
 
-       cursor_timeout.restart();
+       // Check needed to survive LyX startup
+       if (!buffer_)
+               return false;
+
+       // Update macro store
+       buffer_->buildMacros();
+
+       // First drawing step
+       updateMetrics(flags & Update::SinglePar);
+
+       // The second drawing step is done in WorkArea::redraw() if needed.
+       bool const need_second_step =
+               (flags & (Update::Force | Update::FitCursor | Update::MultiParSel))
+               && (fitCursor() || multiParSel());
+
+       return need_second_step;
 }
 
 
@@ -681,7 +595,7 @@ Change const BufferView::Pimpl::getCurrentChange()
                return Change(Change::UNCHANGED);
 
        return text->getPar(cur.selBegin().pit()).
-                       lookupChangeFull(cur.selBegin().pos());
+                       lookupChange(cur.selBegin().pos());
 }
 
 
@@ -694,7 +608,8 @@ void BufferView::Pimpl::savePosition(unsigned int i)
                                      cursor_.paragraph().id(),
                                      cursor_.pos());
        if (i > 0)
-               owner_->message(bformat(_("Saved bookmark %1$d"), i));
+               // emit message signal.
+               bv_->message(bformat(_("Saved bookmark %1$d"), i));
 }
 
 
@@ -727,7 +642,8 @@ void BufferView::Pimpl::restorePosition(unsigned int i)
        bv_->setCursor(makeDocIterator(par, min(par->size(), saved_positions[i].par_pos)));
 
        if (i > 0)
-               owner_->message(bformat(_("Moved to bookmark %1$d"), i));
+               // emit message signal.
+               bv_->message(bformat(_("Moved to bookmark %1$d"), i));
 }
 
 
@@ -737,6 +653,22 @@ bool BufferView::Pimpl::isSavedPosition(unsigned int i)
 }
 
 
+void BufferView::Pimpl::saveSavedPositions()
+{
+       // save bookmarks. It is better to use the pit interface
+       // but I do not know how to effectively convert between
+       // par_id and pit.
+       for (unsigned int i=1; i < saved_positions_num; ++i) {
+               if ( isSavedPosition(i) )
+                       LyX::ref().session().saveBookmark( boost::tie(
+                               i,
+                               saved_positions[i].filename,
+                               saved_positions[i].par_id,
+                               saved_positions[i].par_pos) );
+       }
+}
+
+
 void BufferView::Pimpl::switchKeyMap()
 {
        if (!lyxrc.rtl_support)
@@ -745,10 +677,10 @@ void BufferView::Pimpl::switchKeyMap()
        Intl & intl = owner_->getIntl();
        if (bv_->getLyXText()->real_current_font.isRightToLeft()) {
                if (intl.keymap == Intl::PRIMARY)
-                       intl.KeyMapSec();
+                       intl.keyMapSec();
        } else {
                if (intl.keymap == Intl::SECONDARY)
-                       intl.KeyMapPrim();
+                       intl.keyMapPrim();
        }
 }
 
@@ -760,19 +692,14 @@ void BufferView::Pimpl::center()
        bot.text()->redoParagraph(pit);
        Paragraph const & par = bot.text()->paragraphs()[pit];
        anchor_ref_ = pit;
-       offset_ref_ = bv_funcs::coordOffset(cursor_).y_ + par.ascent()
-               - workarea().workHeight() / 2;
+       offset_ref_ = bv_funcs::coordOffset(cursor_, cursor_.boundary()).y_
+               + par.ascent() - height_ / 2;
 }
 
 
-void BufferView::Pimpl::stuffClipboard(string const & content) const
-{
-       workarea().putClipboard(content);
-}
-
-
-void BufferView::Pimpl::MenuInsertLyXFile(string const & filenm)
+void BufferView::Pimpl::menuInsertLyXFile(string const & filenm)
 {
+       BOOST_ASSERT(cursor_.inTexted());
        string filename = filenm;
 
        if (filename.empty()) {
@@ -780,9 +707,9 @@ void BufferView::Pimpl::MenuInsertLyXFile(string const & filenm)
                string initpath = lyxrc.document_path;
 
                if (available()) {
-                       string const trypath = owner_->buffer()->filePath();
+                       string const trypath = buffer_->filePath();
                        // If directory is writeable, use this as default.
-                       if (IsDirWriteable(trypath))
+                       if (isDirWriteable(trypath))
                                initpath = trypath;
                }
 
@@ -791,7 +718,7 @@ void BufferView::Pimpl::MenuInsertLyXFile(string const & filenm)
                        make_pair(string(_("Documents|#o#O")),
                                  string(lyxrc.document_path)),
                        make_pair(string(_("Examples|#E#e")),
-                                 string(AddPath(package().system_support(), "examples"))));
+                                 string(addPath(package().system_support(), "examples"))));
 
                FileDialog::Result result =
                        fileDlg.open(initpath,
@@ -805,30 +732,36 @@ void BufferView::Pimpl::MenuInsertLyXFile(string const & filenm)
 
                // check selected filename
                if (filename.empty()) {
-                       owner_->message(_("Canceled."));
+                       // emit message signal.
+                       bv_->message(_("Canceled."));
                        return;
                }
        }
 
        // Get absolute path of file and add ".lyx"
        // to the filename if necessary
-       filename = FileSearch(string(), filename, "lyx");
-
-       string const disp_fn = MakeDisplayPath(filename);
-       owner_->message(bformat(_("Inserting document %1$s..."), disp_fn));
-
-       cursor_.clearSelection();
-       bv_->getLyXText()->breakParagraph(cursor_);
-
-       BOOST_ASSERT(cursor_.inTexted());
+       filename = fileSearch(string(), filename, "lyx");
+
+       string const disp_fn = makeDisplayPath(filename);
+       // emit message signal.
+       bv_->message(bformat(_("Inserting document %1$s..."), disp_fn));
+
+       string res;
+       Buffer buf("", false);
+       if (::loadLyXFile(&buf, makeAbsPath(filename))) {
+               ErrorList & el = buffer_->errorList("Parse");
+               // Copy the inserted document error list into the current buffer one.
+               el = buf.errorList("Parse");
+               lyx::cap::pasteParagraphList(cursor_, buf.paragraphs(),
+                                            buf.params().textclass, el);
+               res = _("Document %1$s inserted.");
+       } else
+               res = _("Could not insert document %1$s");
 
-       string const fname = MakeAbsPath(filename);
-       bool const res = buffer_->readFile(fname, cursor_.pit());
+       // emit message signal.
+       bv_->message(bformat(res, disp_fn));
+       buffer_->errors("Parse");
        resizeCurrentBuffer();
-
-       string s = res ? _("Document %1$s inserted.")
-                      : _("Could not insert document %1$s");
-       owner_->message(bformat(s, disp_fn));
 }
 
 
@@ -845,13 +778,8 @@ void BufferView::Pimpl::trackChanges()
                // We cannot allow undos beyond the freeze point
                buffer_->undostack().clear();
        } else {
-               update();
-               bv_->text()->setCursor(cursor_, 0, 0);
-#ifdef WITH_WARNINGS
-#warning changes FIXME
-#endif
-               bool const found = lyx::find::findNextChange(bv_);
-               if (found) {
+               cursor_.setCursor(doc_iterator_begin(buffer_->inset()));
+               if (lyx::find::findNextChange(bv_)) {
                        owner_->getDialogs().show("changes");
                        return;
                }
@@ -869,19 +797,12 @@ void BufferView::Pimpl::trackChanges()
 
 bool BufferView::Pimpl::workAreaDispatch(FuncRequest const & cmd0)
 {
-       lyxerr << BOOST_CURRENT_FUNCTION
-              << "[ cmd0 " << cmd0 << "]" << endl;
+       //lyxerr << BOOST_CURRENT_FUNCTION << "[ cmd0 " << cmd0 << "]" << endl;
 
        // This is only called for mouse related events including
        // LFUN_FILE_OPEN generated by drag-and-drop.
        FuncRequest cmd = cmd0;
 
-       // Handle drag&drop
-       if (cmd.action == LFUN_FILE_OPEN) {
-               owner_->dispatch(cmd);
-               return true;
-       }
-
        if (!buffer_)
                return false;
 
@@ -896,18 +817,16 @@ bool BufferView::Pimpl::workAreaDispatch(FuncRequest const & cmd0)
        if (!available())
                return false;
 
-       screen().hideCursor();
-
        // Either the inset under the cursor or the
        // surrounding LyXText will handle this event.
 
        // Build temporary cursor.
-       cmd.y = min(max(cmd.y,-1), workarea().workHeight());
+       cmd.y = min(max(cmd.y, -1), height_);
        InsetBase * inset = bv_->text()->editXY(cur, cmd.x, cmd.y);
-       lyxerr << BOOST_CURRENT_FUNCTION
-              << " * hit inset at tip: " << inset << endl;
-       lyxerr << BOOST_CURRENT_FUNCTION
-              << " * created temp cursor:" << cur << endl;
+       //lyxerr << BOOST_CURRENT_FUNCTION
+       //       << " * hit inset at tip: " << inset << endl;
+       //lyxerr << BOOST_CURRENT_FUNCTION
+       //       << " * created temp cursor:" << cur << endl;
 
        // Put anchor at the same position.
        cur.resetAnchor();
@@ -926,23 +845,12 @@ bool BufferView::Pimpl::workAreaDispatch(FuncRequest const & cmd0)
 
        if (cur.result().dispatched()) {
                // Redraw if requested or necessary.
-               update(cur.result().update(), cur.result().update());
-       }
-
-       // See workAreaKeyPress
-       cursor_timeout.restart();
-       screen().showCursor(*bv_);
-
-       // Skip these when selecting
-       if (cmd.action != LFUN_MOUSE_MOTION) {
-               owner_->updateLayoutChoice();
-               owner_->updateToolbars();
+               if (cur.result().update())
+                       update(Update::FitCursor | Update::Force);
+               else
+                       update(Update::FitCursor | Update::MultiParSel);
        }
 
-       // Slight hack: this is only called currently when we
-       // clicked somewhere, so we force through the display
-       // of the new status here.
-       owner_->clearMessage();
        return true;
 }
 
@@ -962,47 +870,69 @@ FuncStatus BufferView::Pimpl::getStatus(FuncRequest const & cmd)
        case LFUN_FILE_INSERT:
        case LFUN_FILE_INSERT_ASCII_PARA:
        case LFUN_FILE_INSERT_ASCII:
-       case LFUN_FONT_STATE:
-       case LFUN_INSERT_LABEL:
        case LFUN_BOOKMARK_SAVE:
-       case LFUN_REF_GOTO:
-       case LFUN_GOTO_PARAGRAPH:
-       case LFUN_GOTOERROR:
-       case LFUN_GOTONOTE:
-       case LFUN_REFERENCE_GOTO:
+               // FIXME: Actually, these LFUNS should be moved to LyXText
+               flag.enabled(cursor_.inTexted());
+               break;
+       case LFUN_FONT_STATE:
+       case LFUN_LABEL_INSERT:
+       case LFUN_PARAGRAPH_GOTO:
+       // FIXME handle non-trivially
+       case LFUN_OUTLINE_UP:
+       case LFUN_OUTLINE_DOWN:
+       case LFUN_OUTLINE_IN:
+       case LFUN_OUTLINE_OUT:
+       case LFUN_NOTE_NEXT:
+       case LFUN_REFERENCE_NEXT:
        case LFUN_WORD_FIND:
        case LFUN_WORD_REPLACE:
        case LFUN_MARK_OFF:
        case LFUN_MARK_ON:
-       case LFUN_SETMARK:
-       case LFUN_CENTER:
+       case LFUN_MARK_TOGGLE:
+       case LFUN_SCREEN_RECENTER:
+       case LFUN_BIBTEX_DATABASE_ADD:
+       case LFUN_BIBTEX_DATABASE_DEL:
        case LFUN_WORDS_COUNT:
+       case LFUN_NEXT_INSET_TOGGLE:
                flag.enabled(true);
                break;
 
+       case LFUN_LABEL_GOTO: {
+               flag.enabled(!cmd.argument.empty()
+                   || getInsetByCode<InsetRef>(cursor_, InsetBase::REF_CODE));
+               break;
+       }
+
        case LFUN_BOOKMARK_GOTO:
                flag.enabled(isSavedPosition(convert<unsigned int>(cmd.argument)));
                break;
-       case LFUN_TRACK_CHANGES:
+       case LFUN_CHANGES_TRACK:
                flag.enabled(true);
                flag.setOnOff(buffer_->params().tracking_changes);
                break;
 
-       case LFUN_OUTPUT_CHANGES: {
-               LaTeXFeatures features(*buffer_, buffer_->params(), false);
+       case LFUN_CHANGES_OUTPUT: {
+               OutputParams runparams;
+               LaTeXFeatures features(*buffer_, buffer_->params(), runparams);
                flag.enabled(buffer_ && buffer_->params().tracking_changes
                        && features.isAvailable("dvipost"));
                flag.setOnOff(buffer_->params().output_changes);
                break;
        }
 
-       case LFUN_MERGE_CHANGES:
-       case LFUN_ACCEPT_CHANGE: // what about these two
-       case LFUN_REJECT_CHANGE: // what about these two
-       case LFUN_ACCEPT_ALL_CHANGES:
-       case LFUN_REJECT_ALL_CHANGES:
+       case LFUN_CHANGES_MERGE:
+       case LFUN_CHANGE_ACCEPT: // what about these two
+       case LFUN_CHANGE_REJECT: // what about these two
+       case LFUN_ALL_CHANGES_ACCEPT:
+       case LFUN_ALL_CHANGES_REJECT:
                flag.enabled(buffer_ && buffer_->params().tracking_changes);
                break;
+
+       case LFUN_BUFFER_TOGGLE_COMPRESSION: {
+               flag.setOnOff(buffer_->params().compressed);
+               break;
+       }
+
        default:
                flag.enabled(false);
        }
@@ -1053,15 +983,15 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
 
        case LFUN_FILE_INSERT:
-               MenuInsertLyXFile(cmd.argument);
+               menuInsertLyXFile(cmd.argument);
                break;
 
        case LFUN_FILE_INSERT_ASCII_PARA:
-               InsertAsciiFile(bv_, cmd.argument, true);
+               insertAsciiFile(bv_, cmd.argument, true);
                break;
 
        case LFUN_FILE_INSERT_ASCII:
-               InsertAsciiFile(bv_, cmd.argument, false);
+               insertAsciiFile(bv_, cmd.argument, false);
                break;
 
        case LFUN_FONT_STATE:
@@ -1076,7 +1006,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                restorePosition(convert<unsigned int>(cmd.argument));
                break;
 
-       case LFUN_REF_GOTO: {
+       case LFUN_LABEL_GOTO: {
                string label = cmd.argument;
                if (label.empty()) {
                        InsetRef * inset =
@@ -1093,7 +1023,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
        }
 
-       case LFUN_GOTO_PARAGRAPH: {
+       case LFUN_PARAGRAPH_GOTO: {
                int const id = convert<int>(cmd.argument);
                ParIterator par = buffer_->getParFromID(id);
                if (par == buffer_->par_iterator_end()) {
@@ -1113,15 +1043,30 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
        }
 
-       case LFUN_GOTOERROR:
-               bv_funcs::gotoInset(bv_, InsetBase::ERROR_CODE, false);
+       case LFUN_OUTLINE_UP:
+               lyx::toc::outline(lyx::toc::Up, cursor_);
+               cursor_.text()->setCursor(cursor_, cursor_.pit(), 0);
+               updateLabels(*buffer_);
+               break;
+       case LFUN_OUTLINE_DOWN:
+               lyx::toc::outline(lyx::toc::Down, cursor_);
+               cursor_.text()->setCursor(cursor_, cursor_.pit(), 0);
+               updateLabels(*buffer_);
+               break;
+       case LFUN_OUTLINE_IN:
+               lyx::toc::outline(lyx::toc::In, cursor_);
+               updateLabels(*buffer_);
+               break;
+       case LFUN_OUTLINE_OUT:
+               lyx::toc::outline(lyx::toc::Out, cursor_);
+               updateLabels(*buffer_);
                break;
 
-       case LFUN_GOTONOTE:
+       case LFUN_NOTE_NEXT:
                bv_funcs::gotoInset(bv_, InsetBase::NOTE_CODE, false);
                break;
 
-       case LFUN_REFERENCE_GOTO: {
+       case LFUN_REFERENCE_NEXT: {
                vector<InsetBase_code> tmp;
                tmp.push_back(InsetBase::LABEL_CODE);
                tmp.push_back(InsetBase::REF_CODE);
@@ -1129,21 +1074,22 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
        }
 
-       case LFUN_TRACK_CHANGES:
+       case LFUN_CHANGES_TRACK:
                trackChanges();
                break;
 
-       case LFUN_OUTPUT_CHANGES: {
+       case LFUN_CHANGES_OUTPUT: {
                bool const state = buffer_->params().output_changes;
                buffer_->params().output_changes = !state;
                break;
        }
 
-       case LFUN_MERGE_CHANGES:
-               owner_->getDialogs().show("changes");
+       case LFUN_CHANGES_MERGE:
+               if (lyx::find::findNextChange(bv_))
+                       owner_->getDialogs().show("changes");
                break;
 
-       case LFUN_ACCEPT_ALL_CHANGES: {
+       case LFUN_ALL_CHANGES_ACCEPT: {
                cursor_.reset(buffer_->inset());
 #ifdef WITH_WARNINGS
 #warning FIXME changes
@@ -1154,7 +1100,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
        }
 
-       case LFUN_REJECT_ALL_CHANGES: {
+       case LFUN_ALL_CHANGES_REJECT: {
                cursor_.reset(buffer_->inset());
 #ifdef WITH_WARNINGS
 #warning FIXME changes
@@ -1185,7 +1131,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                cur.message(N_("Mark on"));
                break;
 
-       case LFUN_SETMARK:
+       case LFUN_MARK_TOGGLE:
                cur.clearSelection();
                if (cur.mark()) {
                        cur.mark() = false;
@@ -1197,10 +1143,34 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                cur.resetAnchor();
                break;
 
-       case LFUN_CENTER:
+       case LFUN_SCREEN_RECENTER:
                center();
                break;
 
+       case LFUN_BIBTEX_DATABASE_ADD: {
+               LCursor tmpcur = cursor_;
+               bv_funcs::findInset(tmpcur, InsetBase::BIBTEX_CODE, false);
+               InsetBibtex * inset = getInsetByCode<InsetBibtex>(tmpcur,
+                                               InsetBase::BIBTEX_CODE);
+               if (inset) {
+                       if (inset->addDatabase(cmd.argument))
+                               buffer_->updateBibfilesCache();
+               }
+               break;
+       }
+
+       case LFUN_BIBTEX_DATABASE_DEL: {
+               LCursor tmpcur = cursor_;
+               bv_funcs::findInset(tmpcur, InsetBase::BIBTEX_CODE, false);
+               InsetBibtex * inset = getInsetByCode<InsetBibtex>(tmpcur,
+                                               InsetBase::BIBTEX_CODE);
+               if (inset) {
+                       if (inset->delDatabase(cmd.argument))
+                               buffer_->updateBibfilesCache();
+               }
+               break;
+       }
+
        case LFUN_WORDS_COUNT: {
                DocIterator from, to;
                if (cur.selection()) {
@@ -1230,6 +1200,36 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                Alert::information(_("Count words"), message);
        }
                break;
+
+       case LFUN_BUFFER_TOGGLE_COMPRESSION:
+               // turn compression on/off
+               buffer_->params().compressed = !buffer_->params().compressed;
+               break;
+
+       case LFUN_NEXT_INSET_TOGGLE: {
+               // this is the real function we want to invoke
+               FuncRequest tmpcmd = FuncRequest(LFUN_INSET_TOGGLE, cmd.origin);
+               // if there is an inset at cursor, see whether it
+               // wants to toggle.
+               InsetBase * inset = cur.nextInset();
+               if (inset && inset->isActive()) {
+                       LCursor tmpcur = cur;
+                       tmpcur.pushLeft(*inset);
+                       inset->dispatch(tmpcur, tmpcmd);
+                       if (tmpcur.result().dispatched()) {
+                               cur.dispatched();
+                       }
+               }
+               // if it did not work, try the underlying inset.
+               if (!cur.result().dispatched())
+                       cur.dispatch(tmpcmd);
+
+               if (cur.result().dispatched()) 
+                       cur.clearSelection();
+               
+               break;
+       }
+
        default:
                return false;
        }
@@ -1238,12 +1238,14 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
 }
 
 
-ViewMetricsInfo BufferView::Pimpl::metrics()
+void BufferView::Pimpl::updateMetrics(bool singlepar)
 {
        // Remove old position cache
        theCoords.clear();
        BufferView & bv = *bv_;
        LyXText * const text = bv.text();
+       lyx::pit_type size = int(text->paragraphs().size());
+
        if (anchor_ref_ > int(text->paragraphs().size() - 1)) {
                anchor_ref_ = int(text->paragraphs().size() - 1);
                offset_ref_ = 0;
@@ -1254,22 +1256,22 @@ ViewMetricsInfo BufferView::Pimpl::metrics()
        int pit2 = pit;
        size_t const npit = text->paragraphs().size();
 
-       lyxerr << BOOST_CURRENT_FUNCTION
-              << " npit: " << npit
-              << " pit1: " << pit1
-              << " pit2: " << pit2
-              << endl;
-
-       // Rebreak anchor par
-       text->redoParagraph(pit);
-       int y0 = text->getPar(pit1).ascent() - offset_ref_;
+       // Rebreak anchor paragraph. In Single Paragraph mode, rebreak only
+       // the (main text, not inset!) paragraph containing the cursor.
+       // (if this paragraph contains insets etc., rebreaking will
+       // recursively descend)
+       if (!singlepar || pit == cursor_.bottom().pit())
+               text->redoParagraph(pit);
+       int y0 = text->getPar(pit).ascent() - offset_ref_;
 
-       // Redo paragraphs above cursor if necessary
+       // Redo paragraphs above anchor if necessary; again, in Single Par
+       // mode, only if we encounter the (main text) one having the cursor.
        int y1 = y0;
        while (y1 > 0 && pit1 > 0) {
                y1 -= text->getPar(pit1).ascent();
                --pit1;
-               text->redoParagraph(pit1);
+               if (!singlepar || pit1 == cursor_.bottom().pit())
+                       text->redoParagraph(pit1);
                y1 -= text->getPar(pit1).descent();
        }
 
@@ -1288,12 +1290,14 @@ ViewMetricsInfo BufferView::Pimpl::metrics()
                anchor_ref_ = 0;
        }
 
-       // Redo paragraphs below cursor if necessary
+       // Redo paragraphs below the anchor if necessary. Single par mode:
+       // only the one containing the cursor if encountered.
        int y2 = y0;
        while (y2 < bv.workHeight() && pit2 < int(npit) - 1) {
                y2 += text->getPar(pit2).descent();
                ++pit2;
-               text->redoParagraph(pit2);
+               if (!singlepar || pit2 == cursor_.bottom().pit())
+                       text->redoParagraph(pit2);
                y2 += text->getPar(pit2).ascent();
        }
 
@@ -1302,16 +1306,36 @@ ViewMetricsInfo BufferView::Pimpl::metrics()
 
        // The coordinates of all these paragraphs are correct, cache them
        int y = y1;
+       CoordCache::InnerParPosCache & parPos = theCoords.parPos()[text];
        for (lyx::pit_type pit = pit1; pit <= pit2; ++pit) {
-               y += text->getPar(pit).ascent();
-               theCoords.parPos()[text][pit] = Point(0, y);
-               y += text->getPar(pit).descent();
+               Paragraph const & par = text->getPar(pit);
+               y += par.ascent();
+               parPos[pit] = Point(0, y);
+               if (singlepar && pit == cursor_.bottom().pit()) {
+                       // In Single Paragraph mode, collect here the
+                       // y1 and y2 of the (one) paragraph the cursor is in
+                       y1 = y - par.ascent();
+                       y2 = y + par.descent();
+               }
+               y += par.descent();
+       }
+
+       if (singlepar) {
+               // collect cursor paragraph iter bounds
+               pit1 = cursor_.bottom().pit();
+               pit2 = cursor_.bottom().pit();
        }
 
-       lyxerr << BOOST_CURRENT_FUNCTION
-              << " y1: " << y1
-              << " y2: " << y2
-              << endl;
+       lyxerr[Debug::DEBUG]
+               << BOOST_CURRENT_FUNCTION
+               << " y1: " << y1
+               << " y2: " << y2
+               << " pit1: " << pit1
+               << " pit2: " << pit2
+               << " npit: " << npit
+               << " singlepar: " << singlepar
+               << "size: " << size
+               << endl;
 
-       return ViewMetricsInfo(pit1, pit2, y1, y2);
+       metrics_info_ = ViewMetricsInfo(pit1, pit2, y1, y2, singlepar, size);
 }