]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView_pimpl.C
rev 14409 committed the file from a wrong tree, here is the file.
[lyx.git] / src / BufferView_pimpl.C
index 061f9385a971d5c9a4fd6d660eeabb9621c68638..859b2f57938c0b41629c5d5129a26175ecf904b3 100644 (file)
@@ -48,7 +48,6 @@
 #include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
 #include "pariterator.h"
-#include "rowpainter.h"
 #include "toc.h"
 #include "undo.h"
 #include "vspace.h"
 #include "frontends/Dialogs.h"
 #include "frontends/FileDialog.h"
 #include "frontends/font_metrics.h"
+#include "frontends/Gui.h"
 #include "frontends/LyXView.h"
-#include "frontends/LyXScreenFactory.h"
-#include "frontends/screen.h"
-#include "frontends/WorkArea.h"
-#include "frontends/WorkAreaFactory.h"
+#include "frontends/Selection.h"
 
 #include "graphics/Previews.h"
 
 #include "support/convert.h"
 #include "support/filefilterlist.h"
 #include "support/filetools.h"
-#include "support/forkedcontr.h"
 #include "support/package.h"
 #include "support/types.h"
 
 #include <functional>
 #include <vector>
 
+using lyx::frontend::Clipboard;
+using lyx::frontend::Gui;
+
 using lyx::pos_type;
 
-using lyx::support::AddPath;
+using lyx::support::addPath;
 using lyx::support::bformat;
 using lyx::support::FileFilterList;
-using lyx::support::FileSearch;
-using lyx::support::ForkedcallsController;
-using lyx::support::IsDirWriteable;
-using lyx::support::MakeDisplayPath;
-using lyx::support::MakeAbsPath;
+using lyx::support::fileSearch;
+using lyx::support::isDirWriteable;
+using lyx::support::makeDisplayPath;
+using lyx::support::makeAbsPath;
 using lyx::support::package;
 
 using std::endl;
@@ -103,7 +101,6 @@ using std::string;
 using std::mem_fun_ref;
 using std::vector;
 
-
 extern BufferList bufferlist;
 
 
@@ -111,20 +108,6 @@ namespace {
 
 unsigned int const saved_positions_num = 20;
 
-// All the below connection objects are needed because of a bug in some
-// versions of GCC (<=2.96 are on the suspects list.) By having and assigning
-// to these connections we avoid a segfault upon startup, and also at exit.
-// (Lgb)
-
-boost::signals::connection dispatchcon;
-boost::signals::connection timecon;
-boost::signals::connection doccon;
-boost::signals::connection resizecon;
-boost::signals::connection kpresscon;
-boost::signals::connection selectioncon;
-boost::signals::connection lostcon;
-
-
 /// Return an inset of this class if it exists at the current cursor position
 template <class T>
 T * getInsetByCode(LCursor & cur, InsetBase::Code code)
@@ -141,34 +124,13 @@ T * getInsetByCode(LCursor & cur, InsetBase::Code code)
 } // anon namespace
 
 
-BufferView::Pimpl::Pimpl(BufferView & bv, LyXView * owner,
-                        int width, int height)
-       : bv_(&bv), owner_(owner), buffer_(0), wh_(0), cursor_timeout(400),
-         using_xterm_cursor(false), cursor_(bv), 
-         anchor_ref_(0), offset_ref_(0)
+BufferView::Pimpl::Pimpl(BufferView & bv, LyXView * owner)
+       : bv_(&bv), owner_(owner), buffer_(0), wh_(0),
+         cursor_(bv),
+         multiparsel_cache_(false), anchor_ref_(0), offset_ref_(0), needs_redraw_(false)
 {
        xsel_cache_.set = false;
 
-       workarea_.reset(WorkAreaFactory::create(*owner_, width, height));
-       screen_.reset(LyXScreenFactory::create(workarea()));
-
-       // Setup the signals
-       doccon = workarea().scrollDocView
-               .connect(boost::bind(&BufferView::Pimpl::scrollDocView, this, _1));
-       resizecon = workarea().workAreaResize
-               .connect(boost::bind(&BufferView::Pimpl::workAreaResize, this));
-       dispatchcon = workarea().dispatch
-               .connect(boost::bind(&BufferView::Pimpl::workAreaDispatch, this, _1));
-       kpresscon = workarea().workAreaKeyPress
-               .connect(boost::bind(&BufferView::Pimpl::workAreaKeyPress, this, _1, _2));
-       selectioncon = workarea().selectionRequested
-               .connect(boost::bind(&BufferView::Pimpl::selectionRequested, this));
-       lostcon = workarea().selectionLost
-               .connect(boost::bind(&BufferView::Pimpl::selectionLost, this));
-
-       timecon = cursor_timeout.timeout
-               .connect(boost::bind(&BufferView::Pimpl::cursorToggle, this));
-       cursor_timeout.start();
        saved_positions.resize(saved_positions_num);
        // load saved bookmarks
        lyx::Session::BookmarkList & bmList = LyX::ref().session().loadBookmarks();
@@ -176,7 +138,7 @@ BufferView::Pimpl::Pimpl(BufferView & bv, LyXView * owner,
                bm != bmList.end(); ++bm)
                if (bm->get<0>() < saved_positions_num)
                        saved_positions[bm->get<0>()] = Position( bm->get<1>(), bm->get<2>(), bm->get<3>() );
-       // and then clear them          
+       // and then clear them
        bmList.clear();
 }
 
@@ -252,7 +214,7 @@ bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
 {
        // Get absolute path of file and add ".lyx"
        // to the filename if necessary
-       string s = FileSearch(string(), filename, "lyx");
+       string s = fileSearch(string(), filename, "lyx");
 
        bool const found = !s.empty();
 
@@ -261,7 +223,7 @@ bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
 
        // File already open?
        if (bufferlist.exists(s)) {
-               string const file = MakeDisplayPath(s, 20);
+               string const file = makeDisplayPath(s, 20);
                string text = bformat(_("The document %1$s is already "
                                        "loaded.\n\nDo you want to revert "
                                        "to the saved version?"), file);
@@ -302,14 +264,14 @@ bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
 
        setBuffer(b);
        bv_->showErrorList(_("Parse"));
-    
+
        // scroll to the position when the file was last closed
        if (lyxrc.use_lastfilepos) {
                lyx::pit_type pit;
                lyx::pos_type pos;
                boost::tie(pit, pos) = LyX::ref().session().loadFilePosition(s);
                // I am not sure how to separate the following part to a function
-               // so I will leave this to Lars. 
+               // so I will leave this to Lars.
                //
                // check pit since the document may be externally changed.
                if ( static_cast<size_t>(pit) < b->paragraphs().size() ) {
@@ -321,7 +283,7 @@ bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
                                        bv_->setCursor(makeDocIterator(it, min(pos, it->size())));
                                        bv_->update(Update::FitCursor);
                                        break;
-                               }       
+                               }
                }
        }
 
@@ -332,21 +294,21 @@ bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
 }
 
 
-WorkArea & BufferView::Pimpl::workarea() const
+lyx::frontend::Gui & BufferView::Pimpl::gui() const
 {
-       return *workarea_.get();
+       return owner_->gui();
 }
 
 
-LyXScreen & BufferView::Pimpl::screen() const
+int BufferView::Pimpl::width() const
 {
-       return *screen_.get();
+       return width_;
 }
 
 
-Painter & BufferView::Pimpl::painter() const
+int BufferView::Pimpl::height() const
 {
-       return workarea().getPainter();
+       return height_;
 }
 
 
@@ -414,7 +376,6 @@ void BufferView::Pimpl::setBuffer(Buffer * b)
        }
 
        update();
-       updateScrollbar();
        owner_->updateMenubar();
        owner_->updateToolbars();
        owner_->updateLayoutChoice();
@@ -434,7 +395,7 @@ void BufferView::Pimpl::setBuffer(Buffer * b)
                        BOOST_ASSERT(i>0);
                        --i;
                }
-       }       
+       }
 
        if (buffer_ && lyx::graphics::Previews::status() != LyXRC::PREVIEW_OFF)
                lyx::graphics::Previews::get().generateBufferPreviews(*buffer_);
@@ -459,8 +420,6 @@ void BufferView::Pimpl::resizeCurrentBuffer()
 
        // Reset the "Formatting..." message
        owner_->clearMessage();
-
-       updateScrollbar();
 }
 
 
@@ -469,7 +428,7 @@ void BufferView::Pimpl::updateScrollbar()
        if (!bv_->text()) {
                lyxerr[Debug::DEBUG] << BOOST_CURRENT_FUNCTION
                                     << " no text in updateScrollbar" << endl;
-               workarea().setScrollbarParams(0, 0, 0);
+               scrollbarParameters_.reset();
                return;
        }
 
@@ -491,7 +450,7 @@ void BufferView::Pimpl::updateScrollbar()
 
        // estimated average paragraph height:
        if (wh_ == 0)
-               wh_ = workarea().workHeight() / 4; 
+               wh_ = height_ / 4;
        int h = t.getPar(anchor_ref_).height();
 
        // Normalize anchor/offset (MV):
@@ -504,9 +463,9 @@ void BufferView::Pimpl::updateScrollbar()
        int sumh = 0;
        int nh = 0;
        for (lyx::pit_type pit = anchor_ref_; pit <= parsize; ++pit) {
-               if (sumh > workarea().workHeight())
+               if (sumh > height_)
                        break;
-               int const h2 = t.getPar(pit).height(); 
+               int const h2 = t.getPar(pit).height();
                sumh += h2;
                nh++;
        }
@@ -514,10 +473,16 @@ void BufferView::Pimpl::updateScrollbar()
        // More realistic average paragraph height
        if (hav > wh_)
                wh_ = hav;
-       
-       workarea().setScrollbarParams((parsize + 1) * wh_, 
-               anchor_ref_ * wh_ + int(offset_ref_ * wh_ / float(h)), 
-               int(wh_ * defaultRowHeight() / float(h)));
+
+       scrollbarParameters_.height = (parsize + 1) * wh_;
+       scrollbarParameters_.position = anchor_ref_ * wh_ + int(offset_ref_ * wh_ / float(h));
+       scrollbarParameters_.lineScrollHeight = int(wh_ * defaultRowHeight() / float(h));
+}
+
+
+ScrollbarParameters const & BufferView::Pimpl::scrollbarParameters() const
+{
+       return scrollbarParameters_;
 }
 
 
@@ -529,8 +494,6 @@ void BufferView::Pimpl::scrollDocView(int value)
        if (!buffer_)
                return;
 
-       screen().hideCursor();
-
        LyXText & t = *bv_->text();
 
        float const bar = value / float(wh_ * t.paragraphs().size());
@@ -548,7 +511,7 @@ void BufferView::Pimpl::scrollDocView(int value)
 
        int const height = 2 * defaultRowHeight();
        int const first = height;
-       int const last = workarea().workHeight() - height;
+       int const last = height_ - height;
        LCursor & cur = cursor_;
 
        bv_funcs::CurStatus st = bv_funcs::status(bv_, cur);
@@ -592,7 +555,7 @@ void BufferView::Pimpl::scroll(int /*lines*/)
 //     scrollDocView(new_top_y);
 //
 //     // Update the scrollbar.
-//     workarea().setScrollbarParams(t->height(), top_y(), defaultRowHeight());
+//     workArea_->setScrollbarParams(t->height(), top_y(), defaultRowHeight());
 }
 
 
@@ -600,16 +563,6 @@ void BufferView::Pimpl::workAreaKeyPress(LyXKeySymPtr key,
                                         key_modifier::state state)
 {
        owner_->getLyXFunc().processKeySym(key, state);
-
-       /* This is perhaps a bit of a hack. When we move
-        * around, or type, it's nice to be able to see
-        * the cursor immediately after the keypress. So
-        * we reset the toggle timeout and force the visibility
-        * of the cursor. Note we cannot do this inside
-        * dispatch() itself, because that's called recursively.
-        */
-       if (available())
-               screen().showCursor(*bv_);
 }
 
 
@@ -636,7 +589,7 @@ void BufferView::Pimpl::selectionRequested()
                xsel_cache_.set = cur.selection();
                sel = cur.selectionAsString(false);
                if (!sel.empty())
-                       workarea().putClipboard(sel);
+                       owner_->gui().selection().put(sel);
        }
 }
 
@@ -644,24 +597,20 @@ void BufferView::Pimpl::selectionRequested()
 void BufferView::Pimpl::selectionLost()
 {
        if (available()) {
-               screen().hideCursor();
                cursor_.clearSelection();
                xsel_cache_.set = false;
        }
 }
 
 
-void BufferView::Pimpl::workAreaResize()
+void BufferView::Pimpl::workAreaResize(int width, int height)
 {
-       static int work_area_width;
-       static int work_area_height;
-
-       bool const widthChange = workarea().workWidth() != work_area_width;
-       bool const heightChange = workarea().workHeight() != work_area_height;
+       bool const widthChange = width != width_;
+       bool const heightChange = height != height_;
 
        // Update from work area
-       work_area_width = workarea().workWidth();
-       work_area_height = workarea().workHeight();
+       width_ = width;
+       height_ = height;
 
        if (buffer_ && widthChange) {
                // The visible LyXView need a resize
@@ -671,8 +620,6 @@ void BufferView::Pimpl::workAreaResize()
        if (widthChange || heightChange)
                update();
 
-       // Always make sure that the scrollbar is sane.
-       updateScrollbar();
        owner_->updateLayoutChoice();
 }
 
@@ -684,7 +631,7 @@ bool BufferView::Pimpl::fitCursor()
                int const asc = font_metrics::maxAscent(font);
                int const des = font_metrics::maxDescent(font);
                Point const p = bv_funcs::getPos(cursor_, cursor_.boundary());
-               if (p.y_ - asc >= 0 && p.y_ + des < workarea().workHeight())
+               if (p.y_ - asc >= 0 && p.y_ + des < height_)
                        return false;
        }
        center();
@@ -703,71 +650,49 @@ bool BufferView::Pimpl::multiParSel()
 }
 
 
+ViewMetricsInfo const & BufferView::Pimpl::viewMetricsInfo()
+{
+       return metrics_info_;
+}
+
+
 void BufferView::Pimpl::update(Update::flags flags)
 {
-       lyxerr[Debug::DEBUG]
-                << BOOST_CURRENT_FUNCTION
-                << "[fitcursor = " << (flags & Update::FitCursor)
-                << ", forceupdate = " << (flags & Update::Force)
-                << ", singlepar = " << (flags & Update::SinglePar)
-                << "]  buffer: " << buffer_ << endl;
+       // This is close to a hot-path.
+       if (lyxerr.debugging(Debug::DEBUG)) {
+               lyxerr[Debug::DEBUG]
+                       << BOOST_CURRENT_FUNCTION
+                       << "[fitcursor = " << (flags & Update::FitCursor)
+                       << ", forceupdate = " << (flags & Update::Force)
+                       << ", singlepar = " << (flags & Update::SinglePar)
+                       << "]  buffer: " << buffer_ << endl;
+       }
 
        // Check needed to survive LyX startup
        if (buffer_) {
                // Update macro store
                buffer_->buildMacros();
 
-               CoordCache backup;
-               std::swap(theCoords, backup);
-
-               // This, together with doneUpdating(), verifies (using
-               // asserts) that screen redraw is not called from
-               // within itself.
-               theCoords.startUpdating();
-
                // First drawing step
-               ViewMetricsInfo vi = metrics(flags & Update::SinglePar);
-               bool forceupdate(flags & (Update::Force | Update::SinglePar));
+               bool singlePar = flags & Update::SinglePar;
+               needs_redraw_ = flags & (Update::Force | Update::SinglePar);
 
-               if ((flags & Update::FitCursor) && fitCursor()) {
-                       forceupdate = true;
-                       vi = metrics();
-               }
-               if ((flags & Update::MultiParSel) && multiParSel()) {
-                       forceupdate = true;
-                       vi = metrics();
+               updateMetrics(singlePar);
+
+               if ((flags & (Update::FitCursor | Update::MultiParSel))
+                   && (fitCursor() || multiParSel())) {
+                       needs_redraw_ = true;
+                       singlePar = false;
                }
-               if (forceupdate) {
+
+               if (needs_redraw_) {
                        // Second drawing step
-                       screen().redraw(*bv_, vi);
-               } else {
-                       // Abort updating of the coord
-                       // cache - just restore the old one
-                       std::swap(theCoords, backup);
+                       updateMetrics(singlePar);
                }
-       } else
-               screen().greyOut();
-
-       // And the scrollbar
-       updateScrollbar();
-       owner_->view_state_changed();
-}
-
-
-// Callback for cursor timer
-void BufferView::Pimpl::cursorToggle()
-{
-       if (buffer_) {
-               screen().toggleCursor(*bv_);
-
-               // Use this opportunity to deal with any child processes that
-               // have finished but are waiting to communicate this fact
-               // to the rest of LyX.
-               ForkedcallsController & fcc = ForkedcallsController::get();
-               fcc.handleCompletedProcesses();
        }
 
-       cursor_timeout.restart();
+       owner_->redrawWorkArea();
+       owner_->view_state_changed();
 }
 
 
@@ -789,7 +714,7 @@ Change const BufferView::Pimpl::getCurrentChange()
                return Change(Change::UNCHANGED);
 
        return text->getPar(cur.selBegin().pit()).
-                       lookupChangeFull(cur.selBegin().pos());
+                       lookupChange(cur.selBegin().pos());
 }
 
 
@@ -853,7 +778,7 @@ void BufferView::Pimpl::saveSavedPositions()
        for (unsigned int i=1; i < saved_positions_num; ++i) {
                if ( isSavedPosition(i) )
                        LyX::ref().session().saveBookmark( boost::tie(
-                               i, 
+                               i,
                                saved_positions[i].filename,
                                saved_positions[i].par_id,
                                saved_positions[i].par_pos) );
@@ -869,10 +794,10 @@ void BufferView::Pimpl::switchKeyMap()
        Intl & intl = owner_->getIntl();
        if (bv_->getLyXText()->real_current_font.isRightToLeft()) {
                if (intl.keymap == Intl::PRIMARY)
-                       intl.KeyMapSec();
+                       intl.keyMapSec();
        } else {
                if (intl.keymap == Intl::SECONDARY)
-                       intl.KeyMapPrim();
+                       intl.keyMapPrim();
        }
 }
 
@@ -885,17 +810,12 @@ void BufferView::Pimpl::center()
        Paragraph const & par = bot.text()->paragraphs()[pit];
        anchor_ref_ = pit;
        offset_ref_ = bv_funcs::coordOffset(cursor_, cursor_.boundary()).y_
-               + par.ascent() - workarea().workHeight() / 2;
+               + par.ascent() - height_ / 2;
 }
 
 
-void BufferView::Pimpl::stuffClipboard(string const & content) const
-{
-       workarea().putClipboard(content);
-}
-
 
-void BufferView::Pimpl::MenuInsertLyXFile(string const & filenm)
+void BufferView::Pimpl::menuInsertLyXFile(string const & filenm)
 {
        BOOST_ASSERT(cursor_.inTexted());
        string filename = filenm;
@@ -907,7 +827,7 @@ void BufferView::Pimpl::MenuInsertLyXFile(string const & filenm)
                if (available()) {
                        string const trypath = owner_->buffer()->filePath();
                        // If directory is writeable, use this as default.
-                       if (IsDirWriteable(trypath))
+                       if (isDirWriteable(trypath))
                                initpath = trypath;
                }
 
@@ -916,7 +836,7 @@ void BufferView::Pimpl::MenuInsertLyXFile(string const & filenm)
                        make_pair(string(_("Documents|#o#O")),
                                  string(lyxrc.document_path)),
                        make_pair(string(_("Examples|#E#e")),
-                                 string(AddPath(package().system_support(), "examples"))));
+                                 string(addPath(package().system_support(), "examples"))));
 
                FileDialog::Result result =
                        fileDlg.open(initpath,
@@ -937,16 +857,16 @@ void BufferView::Pimpl::MenuInsertLyXFile(string const & filenm)
 
        // Get absolute path of file and add ".lyx"
        // to the filename if necessary
-       filename = FileSearch(string(), filename, "lyx");
+       filename = fileSearch(string(), filename, "lyx");
 
-       string const disp_fn = MakeDisplayPath(filename);
+       string const disp_fn = makeDisplayPath(filename);
        owner_->message(bformat(_("Inserting document %1$s..."), disp_fn));
 
        string res;
        Buffer buf("", false);
        buf.error.connect(boost::bind(&BufferView::Pimpl::addError, this, _1));
-       if (::loadLyXFile(&buf, MakeAbsPath(filename))) {
-               lyx::cap::pasteParagraphList(cursor_, buf.paragraphs(), 
+       if (::loadLyXFile(&buf, makeAbsPath(filename))) {
+               lyx::cap::pasteParagraphList(cursor_, buf.paragraphs(),
                                             buf.params().textclass);
                res = _("Document %1$s inserted.");
        } else
@@ -1016,13 +936,11 @@ bool BufferView::Pimpl::workAreaDispatch(FuncRequest const & cmd0)
        if (!available())
                return false;
 
-       screen().hideCursor();
-
        // Either the inset under the cursor or the
        // surrounding LyXText will handle this event.
 
        // Build temporary cursor.
-       cmd.y = min(max(cmd.y,-1), workarea().workHeight());
+       cmd.y = min(max(cmd.y, -1), height_);
        InsetBase * inset = bv_->text()->editXY(cur, cmd.x, cmd.y);
        //lyxerr << BOOST_CURRENT_FUNCTION
        //       << " * hit inset at tip: " << inset << endl;
@@ -1052,10 +970,6 @@ bool BufferView::Pimpl::workAreaDispatch(FuncRequest const & cmd0)
                        update(Update::FitCursor | Update::MultiParSel);
        }
 
-       // See workAreaKeyPress
-       cursor_timeout.restart();
-       screen().showCursor(*bv_);
-
        // Skip these when selecting
        if (cmd.action != LFUN_MOUSE_MOTION) {
                owner_->updateLayoutChoice();
@@ -1085,25 +999,29 @@ FuncStatus BufferView::Pimpl::getStatus(FuncRequest const & cmd)
        case LFUN_FILE_INSERT:
        case LFUN_FILE_INSERT_ASCII_PARA:
        case LFUN_FILE_INSERT_ASCII:
+       case LFUN_BOOKMARK_SAVE:
                // FIXME: Actually, these LFUNS should be moved to LyXText
                flag.enabled(cursor_.inTexted());
                break;
        case LFUN_FONT_STATE:
-       case LFUN_INSERT_LABEL:
-       case LFUN_BOOKMARK_SAVE:
-       case LFUN_GOTO_PARAGRAPH:
-       case LFUN_OUTLINE:
-       case LFUN_GOTOERROR:
-       case LFUN_GOTONOTE:
-       case LFUN_REFERENCE_GOTO:
+       case LFUN_LABEL_INSERT:
+       case LFUN_PARAGRAPH_GOTO:
+       // FIXME handle non-trivially
+       case LFUN_OUTLINE_UP:
+       case LFUN_OUTLINE_DOWN:
+       case LFUN_OUTLINE_IN:
+       case LFUN_OUTLINE_OUT:
+       case LFUN_ERROR_NEXT:
+       case LFUN_NOTE_NEXT:
+       case LFUN_REFERENCE_NEXT:
        case LFUN_WORD_FIND:
        case LFUN_WORD_REPLACE:
        case LFUN_MARK_OFF:
        case LFUN_MARK_ON:
-       case LFUN_SETMARK:
-       case LFUN_CENTER:
-       case LFUN_BIBDB_ADD:
-       case LFUN_BIBDB_DEL:
+       case LFUN_MARK_TOGGLE:
+       case LFUN_SCREEN_RECENTER:
+       case LFUN_BIBTEX_DATABASE_ADD:
+       case LFUN_BIBTEX_DATABASE_DEL:
        case LFUN_WORDS_COUNT:
                flag.enabled(true);
                break;
@@ -1117,12 +1035,12 @@ FuncStatus BufferView::Pimpl::getStatus(FuncRequest const & cmd)
        case LFUN_BOOKMARK_GOTO:
                flag.enabled(isSavedPosition(convert<unsigned int>(cmd.argument)));
                break;
-       case LFUN_TRACK_CHANGES:
+       case LFUN_CHANGES_TRACK:
                flag.enabled(true);
                flag.setOnOff(buffer_->params().tracking_changes);
                break;
 
-       case LFUN_OUTPUT_CHANGES: {
+       case LFUN_CHANGES_OUTPUT: {
                OutputParams runparams;
                LaTeXFeatures features(*buffer_, buffer_->params(), runparams);
                flag.enabled(buffer_ && buffer_->params().tracking_changes
@@ -1131,13 +1049,19 @@ FuncStatus BufferView::Pimpl::getStatus(FuncRequest const & cmd)
                break;
        }
 
-       case LFUN_MERGE_CHANGES:
-       case LFUN_ACCEPT_CHANGE: // what about these two
-       case LFUN_REJECT_CHANGE: // what about these two
-       case LFUN_ACCEPT_ALL_CHANGES:
-       case LFUN_REJECT_ALL_CHANGES:
+       case LFUN_CHANGES_MERGE:
+       case LFUN_CHANGE_ACCEPT: // what about these two
+       case LFUN_CHANGE_REJECT: // what about these two
+       case LFUN_ALL_CHANGES_ACCEPT:
+       case LFUN_ALL_CHANGES_REJECT:
                flag.enabled(buffer_ && buffer_->params().tracking_changes);
                break;
+
+       case LFUN_BUFFER_TOGGLE_COMPRESSION: {
+               flag.setOnOff(buffer_->params().compressed);
+               break;
+       }
+
        default:
                flag.enabled(false);
        }
@@ -1188,15 +1112,15 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
 
        case LFUN_FILE_INSERT:
-               MenuInsertLyXFile(cmd.argument);
+               menuInsertLyXFile(cmd.argument);
                break;
 
        case LFUN_FILE_INSERT_ASCII_PARA:
-               InsertAsciiFile(bv_, cmd.argument, true);
+               insertAsciiFile(bv_, cmd.argument, true);
                break;
 
        case LFUN_FILE_INSERT_ASCII:
-               InsertAsciiFile(bv_, cmd.argument, false);
+               insertAsciiFile(bv_, cmd.argument, false);
                break;
 
        case LFUN_FONT_STATE:
@@ -1228,7 +1152,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
        }
 
-       case LFUN_GOTO_PARAGRAPH: {
+       case LFUN_PARAGRAPH_GOTO: {
                int const id = convert<int>(cmd.argument);
                ParIterator par = buffer_->getParFromID(id);
                if (par == buffer_->par_iterator_end()) {
@@ -1248,25 +1172,34 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
        }
 
-       case LFUN_OUTLINE: {
-               lyx::toc::OutlineOp const op =
-                   static_cast<lyx::toc::OutlineOp>(convert<int>(cmd.argument));
-               lyx::toc::Outline(op, buffer_, cursor_.pit());
-               bv_->text()->setCursor(cursor_, cursor_.pit(), 0);
-               buffer_->markDirty();
-               updateCounters(*buffer_);
-               update();
-       }
-                                 
-       case LFUN_GOTOERROR:
+       case LFUN_OUTLINE_UP:
+               lyx::toc::outline(lyx::toc::Up, cursor_);
+               cursor_.text()->setCursor(cursor_, cursor_.pit(), 0);
+               updateLabels(*buffer_);
+               break;
+       case LFUN_OUTLINE_DOWN:
+               lyx::toc::outline(lyx::toc::Down, cursor_);
+               cursor_.text()->setCursor(cursor_, cursor_.pit(), 0);
+               updateLabels(*buffer_);
+               break;
+       case LFUN_OUTLINE_IN:
+               lyx::toc::outline(lyx::toc::In, cursor_);
+               updateLabels(*buffer_);
+               break;
+       case LFUN_OUTLINE_OUT:
+               lyx::toc::outline(lyx::toc::Out, cursor_);
+               updateLabels(*buffer_);
+               break;
+
+       case LFUN_ERROR_NEXT:
                bv_funcs::gotoInset(bv_, InsetBase::ERROR_CODE, false);
                break;
 
-       case LFUN_GOTONOTE:
+       case LFUN_NOTE_NEXT:
                bv_funcs::gotoInset(bv_, InsetBase::NOTE_CODE, false);
                break;
 
-       case LFUN_REFERENCE_GOTO: {
+       case LFUN_REFERENCE_NEXT: {
                vector<InsetBase_code> tmp;
                tmp.push_back(InsetBase::LABEL_CODE);
                tmp.push_back(InsetBase::REF_CODE);
@@ -1274,22 +1207,22 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
        }
 
-       case LFUN_TRACK_CHANGES:
+       case LFUN_CHANGES_TRACK:
                trackChanges();
                break;
 
-       case LFUN_OUTPUT_CHANGES: {
+       case LFUN_CHANGES_OUTPUT: {
                bool const state = buffer_->params().output_changes;
                buffer_->params().output_changes = !state;
                break;
        }
 
-       case LFUN_MERGE_CHANGES:
+       case LFUN_CHANGES_MERGE:
                if (lyx::find::findNextChange(bv_))
                        owner_->getDialogs().show("changes");
                break;
 
-       case LFUN_ACCEPT_ALL_CHANGES: {
+       case LFUN_ALL_CHANGES_ACCEPT: {
                cursor_.reset(buffer_->inset());
 #ifdef WITH_WARNINGS
 #warning FIXME changes
@@ -1300,7 +1233,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                break;
        }
 
-       case LFUN_REJECT_ALL_CHANGES: {
+       case LFUN_ALL_CHANGES_REJECT: {
                cursor_.reset(buffer_->inset());
 #ifdef WITH_WARNINGS
 #warning FIXME changes
@@ -1331,7 +1264,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                cur.message(N_("Mark on"));
                break;
 
-       case LFUN_SETMARK:
+       case LFUN_MARK_TOGGLE:
                cur.clearSelection();
                if (cur.mark()) {
                        cur.mark() = false;
@@ -1343,27 +1276,31 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                cur.resetAnchor();
                break;
 
-       case LFUN_CENTER:
+       case LFUN_SCREEN_RECENTER:
                center();
                break;
 
-       case LFUN_BIBDB_ADD: {
+       case LFUN_BIBTEX_DATABASE_ADD: {
                LCursor tmpcur = cursor_;
                bv_funcs::findInset(tmpcur, InsetBase::BIBTEX_CODE, false);
                InsetBibtex * inset = getInsetByCode<InsetBibtex>(tmpcur,
                                                InsetBase::BIBTEX_CODE);
-               if (inset)
-                       inset->addDatabase(cmd.argument);
+               if (inset) {
+                       if (inset->addDatabase(cmd.argument))
+                               buffer_->updateBibfilesCache();
+               }
                break;
        }
 
-       case LFUN_BIBDB_DEL: {
+       case LFUN_BIBTEX_DATABASE_DEL: {
                LCursor tmpcur = cursor_;
                bv_funcs::findInset(tmpcur, InsetBase::BIBTEX_CODE, false);
                InsetBibtex * inset = getInsetByCode<InsetBibtex>(tmpcur,
                                                InsetBase::BIBTEX_CODE);
-               if (inset)
-                       inset->delDatabase(cmd.argument);
+               if (inset) {
+                       if (inset->delDatabase(cmd.argument))
+                               buffer_->updateBibfilesCache();
+               }
                break;
        }
 
@@ -1396,6 +1333,12 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
                Alert::information(_("Count words"), message);
        }
                break;
+
+       case LFUN_BUFFER_TOGGLE_COMPRESSION:
+               // turn compression on/off
+               buffer_->params().compressed = !buffer_->params().compressed;
+               break;
+
        default:
                return false;
        }
@@ -1404,7 +1347,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & cmd)
 }
 
 
-ViewMetricsInfo BufferView::Pimpl::metrics(bool singlepar)
+void BufferView::Pimpl::updateMetrics(bool singlepar)
 {
        // Remove old position cache
        theCoords.clear();
@@ -1424,7 +1367,7 @@ ViewMetricsInfo BufferView::Pimpl::metrics(bool singlepar)
 
        // Rebreak anchor paragraph. In Single Paragraph mode, rebreak only
        // the (main text, not inset!) paragraph containing the cursor.
-       // (if this paragraph contains insets etc., rebreaking will 
+       // (if this paragraph contains insets etc., rebreaking will
        // recursively descend)
        if (!singlepar || pit == cursor_.bottom().pit())
                text->redoParagraph(pit);
@@ -1472,16 +1415,18 @@ ViewMetricsInfo BufferView::Pimpl::metrics(bool singlepar)
 
        // The coordinates of all these paragraphs are correct, cache them
        int y = y1;
+       CoordCache::InnerParPosCache & parPos = theCoords.parPos()[text];
        for (lyx::pit_type pit = pit1; pit <= pit2; ++pit) {
-               y += text->getPar(pit).ascent();
-               theCoords.parPos()[text][pit] = Point(0, y);
+               Paragraph & par = text->getPar(pit);
+               y += par.ascent();
+               parPos[pit] = Point(0, y);
                if (singlepar && pit == cursor_.bottom().pit()) {
-                       // In Single Paragraph mode, collect here the 
-                       // y1 and y2 of the (one) paragraph the cursor is in
-                       y1 = y - text->getPar(pit).ascent();
-                       y2 = y + text->getPar(pit).descent();
+                       // In Single Paragraph mode, collect here the
+                       // y1 and y2 of the (one) paragraph the cursor is in
+                       y1 = y - par.ascent();
+                       y2 = y + par.descent();
                }
-               y += text->getPar(pit).descent();
+               y += par.descent();
        }
 
        if (singlepar) {
@@ -1489,17 +1434,17 @@ ViewMetricsInfo BufferView::Pimpl::metrics(bool singlepar)
                pit1 = cursor_.bottom().pit();
                pit2 = cursor_.bottom().pit();
        }
-       
+
        lyxerr[Debug::DEBUG]
-                << BOOST_CURRENT_FUNCTION
-                << " y1: " << y1
-                << " y2: " << y2
-                << " pit1: " << pit1
-                << " pit2: " << pit2
-                << " npit: " << npit
-                << " singlepar: " << singlepar
-                << "size: " << size
-                << endl;
-
-       return ViewMetricsInfo(pit1, pit2, y1, y2, singlepar, size);
+               << BOOST_CURRENT_FUNCTION
+               << " y1: " << y1
+               << " y2: " << y2
+               << " pit1: " << pit1
+               << " pit2: " << pit2
+               << " npit: " << npit
+               << " singlepar: " << singlepar
+               << "size: " << size
+               << endl;
+
+       metrics_info_ = ViewMetricsInfo(pit1, pit2, y1, y2, singlepar, size);
 }