#include "frontends/alert.h"
#include "frontends/Delegates.h"
-#include "frontends/FileDialog.h"
#include "frontends/FontMetrics.h"
#include "frontends/Painter.h"
#include "frontends/Selection.h"
#include <iterator>
#include <vector>
-using std::distance;
-using std::endl;
-using std::ifstream;
-using std::istringstream;
-using std::istream_iterator;
-using std::make_pair;
-using std::min;
-using std::max;
-using std::mem_fun_ref;
-using std::string;
-using std::vector;
+using namespace std;
+using namespace lyx::support;
namespace lyx {
-using support::addPath;
-using support::bformat;
-using support::FileFilterList;
-using support::FileName;
-using support::fileSearch;
-using support::makeDisplayPath;
-using support::makeAbsPath;
-using support::package;
-
namespace Alert = frontend::Alert;
namespace {
/// A map from a Text to the associated text metrics
-typedef std::map<Text const *, TextMetrics> TextMetricsCache;
+typedef map<Text const *, TextMetrics> TextMetricsCache;
enum ScreenUpdateStrategy {
NoScreenUpdate,
struct BufferView::Private
{
Private(BufferView & bv): wh_(0), cursor_(bv),
- anchor_ref_(0), offset_ref_(0), need_centering_(false),
+ anchor_pit_(0), anchor_ypos_(0),
last_inset_(0), gui_(0)
{}
///
Cursor cursor_;
///
- pit_type anchor_ref_;
+ pit_type anchor_pit_;
///
- int offset_ref_;
+ int anchor_ypos_;
///
- bool need_centering_;
+ vector<int> par_height_;
/// keyboard mapping object.
Intl intl_;
if (p.y_ - asc >= 0 && p.y_ + des < height_)
return false;
}
- center();
return true;
}
<< ", singlepar = " << (flags & Update::SinglePar)
<< "] buffer: " << &buffer_);
- // Update macro store
- if (!(cursor().inMathed() && cursor().inMacroMode()))
- buffer_.updateMacros();
+ buffer_.updateMacros();
// Now do the first drawing step if needed. This consists on updating
// the CoordCache in updateMetrics().
if (flags == Update::FitCursor
|| flags == (Update::Decoration | Update::FitCursor)) {
- bool const fit_cursor = fitCursor();
// tell the frontend to update the screen if needed.
- if (fit_cursor) {
- updateMetrics();
- buffer_.changed();
+ if (fitCursor()) {
+ showCursor();
return;
}
if (flags & Update::Decoration) {
return;
}
- bool const full_metrics = flags & Update::Force;
+ bool const full_metrics = flags & Update::Force || !singleParUpdate();
- if (full_metrics || !singleParUpdate())
+ if (full_metrics)
// We have to update the full screen metrics.
updateMetrics();
if (!(flags & Update::FitCursor)) {
+ // Nothing to do anymore. Trigger a redraw and return
buffer_.changed();
return;
}
- //FIXME: updateMetrics() does not update paragraph position
+ // updateMetrics() does not update paragraph position
// This is done at draw() time. So we need a redraw!
buffer_.changed();
- if (!fitCursor())
- // The screen has already been updated thanks to the
- // 'buffer_.changed()' call three line above. So no need
- // to redraw again.
- return;
- // The screen has been recentered around the cursor position so
- // refresh it:
- updateMetrics();
- buffer_.changed();
+ if (fitCursor()) {
+ // The cursor is off screen so ensure it is visible.
+ // refresh it:
+ showCursor();
+ }
}
void BufferView::updateScrollbar()
{
- Text & t = buffer_.text();
- TextMetrics & tm = d->text_metrics_[&t];
+ if (height_ == 0)
+ return;
- int const parsize = int(t.paragraphs().size() - 1);
- if (d->anchor_ref_ > parsize) {
- d->anchor_ref_ = parsize;
- d->offset_ref_ = 0;
- }
+ Text & t = buffer_.text();
+ TextMetrics & tm = d->text_metrics_[&t];
LYXERR(Debug::GUI, " Updating scrollbar: height: "
<< t.paragraphs().size()
<< " curr par: " << d->cursor_.bottom().pit()
<< " default height " << defaultRowHeight());
+ int const parsize = int(t.paragraphs().size());
+ if (d->par_height_.size() != parsize) {
+ d->par_height_.clear();
+ // FIXME: We assume a default paragraph height of 2 rows. This
+ // should probably be pondered with the screen width.
+ d->par_height_.resize(parsize, defaultRowHeight() * 2);
+ }
+
// It would be better to fix the scrollbar to understand
// values in [0..1] and divide everything by wh
- // estimated average paragraph height:
- if (d->wh_ == 0)
- d->wh_ = height_ / 4;
-
- int h = tm.parMetrics(d->anchor_ref_).height();
-
- // Normalize anchor/offset (MV):
- while (d->offset_ref_ > h && d->anchor_ref_ < parsize) {
- d->anchor_ref_++;
- d->offset_ref_ -= h;
- h = tm.parMetrics(d->anchor_ref_).height();
- }
// Look at paragraph heights on-screen
- int sumh = 0;
- int nh = 0;
- for (pit_type pit = d->anchor_ref_; pit <= parsize; ++pit) {
- if (sumh > height_)
- break;
- int const h2 = tm.parMetrics(pit).height();
- sumh += h2;
- nh++;
+ pit_type first_visible_pit = -1;
+ pair<pit_type, ParagraphMetrics const *> first = tm.first();
+ pair<pit_type, ParagraphMetrics const *> last = tm.last();
+ for (pit_type pit = first.first; pit <= last.first; ++pit) {
+ ParagraphMetrics const & pm = tm.parMetrics(pit);
+ d->par_height_[pit] = pm.height();
+ if (first_visible_pit >= 0 || pm.position() + pm.descent() <= 0)
+ continue;
+ first_visible_pit = pit;
+ LYXERR(Debug::SCROLLING, "first visible pit " << first_visible_pit);
+ // FIXME: we should look for the first visible row within
+ // the deepest inset!
+ int row_pos = pm.position();
+ size_t const nrows = pm.rows().size();
+ for (size_t i = 0; i != nrows; ++i) {
+ Row const & row = pm.rows()[i];
+ if (row_pos >= 0) {
+ LYXERR(Debug::SCROLLING, "first visible row " << i
+ << "(row pos = " << row_pos << ");");
+ break;
+ }
+ row_pos += row.height();
+ }
+ d->scrollbarParameters_.position = row_pos;
}
- BOOST_ASSERT(nh);
- int const hav = sumh / nh;
- // More realistic average paragraph height
- if (hav > d->wh_)
- d->wh_ = hav;
+ d->scrollbarParameters_.height = 0;
+ for (size_t i = 0; i != d->par_height_.size(); ++i) {
+ if (i == first_visible_pit)
+ d->scrollbarParameters_.position += d->scrollbarParameters_.height;
+ d->scrollbarParameters_.height += d->par_height_[i];
+ }
- BOOST_ASSERT(h);
- d->scrollbarParameters_.height = (parsize + 1) * d->wh_;
- d->scrollbarParameters_.position = d->anchor_ref_ * d->wh_ + int(d->offset_ref_ * d->wh_ / float(h));
- d->scrollbarParameters_.lineScrollHeight = int(d->wh_ * defaultRowHeight() / float(h));
+ // We prefer fixed size line scrolling.
+ d->scrollbarParameters_.lineScrollHeight = defaultRowHeight();
}
void BufferView::scrollDocView(int value)
{
- LYXERR(Debug::GUI, "[ value = " << value << "]");
-
- Text & t = buffer_.text();
- TextMetrics & tm = d->text_metrics_[&t];
+ int const offset = value - d->scrollbarParameters_.position;
+ // If the offset is less than 2 screen height, prefer to scroll instead.
+ if (abs(offset) <= 2 * height_) {
+ scroll(offset);
+ return;
+ }
- float const bar = value / float(d->wh_ * t.paragraphs().size());
+ int par_pos = 0;
+ for (size_t i = 0; i != d->par_height_.size(); ++i) {
+ par_pos += d->par_height_[i];
+ if (par_pos >= value) {
+ d->anchor_pit_ = pit_type(i);
+ break;
+ }
+ }
- d->anchor_ref_ = int(bar * t.paragraphs().size());
- if (d->anchor_ref_ > int(t.paragraphs().size()) - 1)
- d->anchor_ref_ = int(t.paragraphs().size()) - 1;
+ LYXERR(Debug::SCROLLING, "value = " << value
+ << "\tanchor_ref_ = " << d->anchor_pit_
+ << "\tpar_pos = " << par_pos);
- tm.redoParagraph(d->anchor_ref_);
- int const h = tm.parMetrics(d->anchor_ref_).height();
- d->offset_ref_ = int((bar * t.paragraphs().size() - d->anchor_ref_) * h);
+ d->anchor_ypos_ = par_pos - value;
updateMetrics();
buffer_.changed();
}
+// FIXME: this method is not working well.
void BufferView::setCursorFromScrollbar()
{
TextMetrics & tm = d->text_metrics_[&buffer_.text()];
// So we need a redraw!
buffer_.changed();
if (fitCursor())
- // We need another redraw because of the screen recentering.
- buffer_.changed();
+ showCursor();
}
return success;
}
-void BufferView::updateOffsetRef()
+void BufferView::showCursor()
{
- // No need to update d->offset_ref_ in this case.
- if (!d->need_centering_)
- return;
-
// We are not properly started yet, delay until resizing is
// done.
if (height_ == 0)
return;
+ LYXERR(Debug::SCROLLING, "recentering!");
+
CursorSlice & bot = d->cursor_.bottom();
TextMetrics & tm = d->text_metrics_[bot.text()];
- ParagraphMetrics const & pm = tm.parMetrics(bot.pit());
- int y = coordOffset(d->cursor_, d->cursor_.boundary()).y_;
- d->offset_ref_ = y + pm.ascent() - height_ / 2;
- d->need_centering_ = false;
-}
+ int const bot_pit = d->cursor_.bottom().pit();
+ if (bot_pit == tm.first().first - 1)
+ tm.newParMetricsUp();
+ else if (bot_pit == tm.last().first + 1)
+ tm.newParMetricsDown();
+
+ if (tm.has(bot_pit)) {
+ ParagraphMetrics const & pm = tm.parMetrics(bot_pit);
+ int offset = coordOffset(d->cursor_, d->cursor_.boundary()).y_;
+ int ypos = pm.position() + offset;
+ Dimension const & row_dim = d->cursor_.textRow().dimension();
+ if (ypos - row_dim.ascent() < 0)
+ scrollUp(- ypos + row_dim.ascent());
+ else if (ypos + row_dim.descent() > height_)
+ scrollDown(ypos - height_ + row_dim.descent());
+ // else, nothing to do, the cursor is already visible so we just return.
+ return;
+ }
+ tm.redoParagraph(bot_pit);
+ ParagraphMetrics const & pm = tm.parMetrics(bot_pit);
+ int offset = coordOffset(d->cursor_, d->cursor_.boundary()).y_;
-void BufferView::center()
-{
- d->anchor_ref_ = d->cursor_.bottom().pit();
- d->need_centering_ = true;
+ d->anchor_pit_ = bot_pit;
+ Dimension const & row_dim = d->cursor_.textRow().dimension();
+
+ if (d->anchor_pit_ == 0)
+ d->anchor_ypos_ = offset + pm.ascent();
+ else if (d->anchor_pit_ >= pos_type(bot.text()->paragraphs().size() - 1)) {
+ d->anchor_pit_ = bot.text()->paragraphs().size() - 1;
+ d->anchor_ypos_ = height_ - offset - row_dim.descent();
+ } else {
+ d->anchor_ypos_ = offset + pm.ascent() - height_ / 2;
+ }
+
+ updateMetrics();
+ buffer_.changed();
}
}
-Update::flags BufferView::dispatch(FuncRequest const & cmd)
+bool BufferView::dispatch(FuncRequest const & cmd)
{
//lyxerr << [ cmd = " << cmd << "]" << endl;
<< " button[" << cmd.button() << ']');
Cursor & cur = d->cursor_;
- // Default Update flags.
- Update::flags updateFlags = Update::Force | Update::FitCursor;
switch (cmd.action) {
case LFUN_UNDO:
cur.message(_("Undo"));
cur.clearSelection();
- if (!cur.textUndo()) {
+ if (!cur.textUndo())
cur.message(_("No further undo information"));
- updateFlags = Update::None;
- }
break;
case LFUN_REDO:
cur.message(_("Redo"));
cur.clearSelection();
- if (!cur.textRedo()) {
+ if (!cur.textRedo())
cur.message(_("No further redo information"));
- updateFlags = Update::None;
- }
- break;
-
- case LFUN_FILE_INSERT:
- // FIXME UNICODE
- menuInsertLyXFile(to_utf8(cmd.argument()));
- break;
-
- case LFUN_FILE_INSERT_PLAINTEXT_PARA:
- // FIXME UNICODE
- insertPlaintextFile(FileName(to_utf8(cmd.argument())), true);
- break;
-
- case LFUN_FILE_INSERT_PLAINTEXT:
- // FIXME UNICODE
- insertPlaintextFile(FileName(to_utf8(cmd.argument())), false);
break;
case LFUN_FONT_STATE:
theLyXFunc().dispatch(FuncRequest(
LFUN_BUFFER_SWITCH, b->absFileName()));
theLyXFunc().dispatch(cmd);
- updateFlags = Update::None;
}
break;
}
break;
case LFUN_SCREEN_RECENTER:
- center();
+ showCursor();
break;
case LFUN_BIBTEX_DATABASE_ADD: {
Point p = getPos(cur, cur.boundary());
if (p.y_ < 0 || p.y_ > height_) {
// The cursor is off-screen so recenter before proceeding.
- center();
- updateMetrics();
- //FIXME: updateMetrics() does not update paragraph position
- // This is done at draw() time. So we need a redraw!
- // But no screen update is needed.
- d->update_strategy_ = NoScreenUpdate;
- buffer_.changed();
+ showCursor();
p = getPos(cur, cur.boundary());
}
scroll(cmd.action == LFUN_SCREEN_UP? - height_ : height_);
d->text_metrics_[&buffer_.text()].editXY(cur, p.x_, p.y_);
//FIXME: what to do with cur.x_target()?
cur.finishUndo();
- // The metrics are already up to date. see scroll()
- updateFlags = Update::None;
break;
}
case LFUN_SCREEN_UP_SELECT:
case LFUN_SCREEN_DOWN_SELECT: {
+ // Those two are not ready yet for consumption.
+ return false;
+
cur.selHandle(true);
size_t initial_depth = cur.depth();
Point const p = getPos(cur, cur.boundary());
// But no screen update is needed.
d->update_strategy_ = NoScreenUpdate;
buffer_.changed();
- updateFlags = Update::Force | Update::FitCursor;
break;
}
default:
- updateFlags = Update::None;
+ return false;
}
- return updateFlags;
+ return true;
}
width_ = width;
height_ = height;
+ // Clear the paragraph height cache.
+ d->par_height_.clear();
+
updateMetrics();
}
TextMetrics & tm = d->text_metrics_[text];
int ymax = height_ + offset;
while (true) {
-
std::pair<pit_type, ParagraphMetrics const *> last = tm.last();
+ pair<pit_type, ParagraphMetrics const *> last = tm.last();
int bottom_pos = last.second->position() + last.second->descent();
if (last.first + 1 == int(text->paragraphs().size())) {
if (bottom_pos <= height_)
break;
tm.newParMetricsDown();
}
- d->offset_ref_ += offset;
+ d->anchor_ypos_ -= offset;
updateMetrics();
buffer_.changed();
}
TextMetrics & tm = d->text_metrics_[text];
int ymin = - offset;
while (true) {
-
std::pair<pit_type, ParagraphMetrics const *> first = tm.first();
+ pair<pit_type, ParagraphMetrics const *> first = tm.first();
int top_pos = first.second->position() - first.second->ascent();
if (first.first == 0) {
if (top_pos >= 0)
break;
tm.newParMetricsUp();
}
- d->offset_ref_ -= offset;
+ d->anchor_ypos_ += offset;
updateMetrics();
buffer_.changed();
}
for (InsetIterator it = inset_iterator_begin(buffer_.inset()); it; ++it) {
vector<docstring> labels;
it->getLabelList(buffer_, labels);
- if (std::find(labels.begin(), labels.end(), label) != labels.end()) {
+ if (find(labels.begin(), labels.end(), label) != labels.end()) {
setCursor(it);
processUpdateFlags(Update::FitCursor);
return;
// For an example, see bug 2933:
// http://bugzilla.lyx.org/show_bug.cgi?id=2933
// The code below could maybe be moved to a DocIterator method.
- //lyxerr << "cur before " << cur <<std::endl;
+ //lyxerr << "cur before " << cur <<endl;
DocIterator dit(cur.inset());
dit.push_back(cur.bottom());
size_t i = 1;
dit.push_back(cur[i]);
++i;
}
- //lyxerr << "5 cur after" << dit <<std::endl;
+ //lyxerr << "5 cur after" << dit <<endl;
d->cursor_.setCursor(dit);
d->cursor_.boundary(cur.boundary());
pit_type BufferView::anchor_ref() const
{
- return d->anchor_ref_;
+ return d->anchor_pit_;
}
Text & buftext = buffer_.text();
pit_type const npit = int(buftext.paragraphs().size());
- if (d->anchor_ref_ > int(npit - 1)) {
- d->anchor_ref_ = int(npit - 1);
- d->offset_ref_ = 0;
- }
-
// Clear out the position cache in case of full screen redraw,
d->coord_cache_.clear();
TextMetrics & tm = textMetrics(&buftext);
- pit_type const pit = d->anchor_ref_;
- int pit1 = pit;
- int pit2 = pit;
-
// Rebreak anchor paragraph.
- tm.redoParagraph(pit);
-
- // Take care of anchor offset if case a recentering is needed.
- updateOffsetRef();
+ tm.redoParagraph(d->anchor_pit_);
+ ParagraphMetrics & anchor_pm = tm.par_metrics_[d->anchor_pit_];
+ anchor_pm.setPosition(d->anchor_ypos_);
- int y0 = tm.parMetrics(pit).ascent() - d->offset_ref_;
+ LYXERR(Debug::PAINTING, "metrics: "
+ << " anchor pit = " << d->anchor_pit_
+ << " anchor ypos = " << d->anchor_ypos_);
// Redo paragraphs above anchor if necessary.
- int y1 = y0;
- while (y1 > 0 && pit1 > 0) {
- y1 -= tm.parMetrics(pit1).ascent();
- --pit1;
+ int y1 = d->anchor_ypos_ - anchor_pm.ascent();
+ // We are now just above the anchor paragraph.
+ pit_type pit1 = d->anchor_pit_ - 1;
+ for (; pit1 >= 0 && y1 > 0; --pit1) {
tm.redoParagraph(pit1);
- y1 -= tm.parMetrics(pit1).descent();
- }
-
- // Take care of ascent of first line
- y1 -= tm.parMetrics(pit1).ascent();
-
- // Normalize anchor for next time
- d->anchor_ref_ = pit1;
- d->offset_ref_ = -y1;
-
- // Grey at the beginning is ugly
- if (pit1 == 0 && y1 > 0) {
- y0 -= y1;
- y1 = 0;
- d->anchor_ref_ = 0;
+ ParagraphMetrics & pm = tm.par_metrics_[pit1];
+ y1 -= pm.descent();
+ // Save the paragraph position in the cache.
+ pm.setPosition(y1);
+ y1 -= pm.ascent();
}
// Redo paragraphs below the anchor if necessary.
- int y2 = y0;
- while (y2 < height_ && pit2 < int(npit) - 1) {
- y2 += tm.parMetrics(pit2).descent();
- ++pit2;
+ int y2 = d->anchor_ypos_ + anchor_pm.descent();
+ // We are now just below the anchor paragraph.
+ pit_type pit2 = d->anchor_pit_ + 1;
+ for (; pit2 < npit && y2 < height_; ++pit2) {
tm.redoParagraph(pit2);
- y2 += tm.parMetrics(pit2).ascent();
+ ParagraphMetrics & pm = tm.par_metrics_[pit2];
+ y2 += pm.ascent();
+ // Save the paragraph position in the cache.
+ pm.setPosition(y2);
+ y2 += pm.descent();
}
- // Take care of descent of last line
- y2 += tm.parMetrics(pit2).descent();
-
- LYXERR(Debug::PAINTING, "\n y1: " << y1
- << " y2: " << y2
- << " pit1: " << pit1
- << " pit2: " << pit2
- << " npit: " << npit
- << " singlepar: 0");
+ LYXERR(Debug::PAINTING, "Metrics: "
+ << " anchor pit = " << d->anchor_pit_
+ << " anchor ypos = " << d->anchor_ypos_
+ << " y1 = " << y1
+ << " y2 = " << y2
+ << " pit1 = " << pit1
+ << " pit2 = " << pit2);
d->update_strategy_ = FullScreenUpdate;
}
-void BufferView::menuInsertLyXFile(string const & filenm)
+void BufferView::insertLyXFile(FileName const & fname)
{
BOOST_ASSERT(d->cursor_.inTexted());
- string filename = filenm;
-
- if (filename.empty()) {
- // Launch a file browser
- // FIXME UNICODE
- string initpath = lyxrc.document_path;
- string const trypath = buffer_.filePath();
- // If directory is writeable, use this as default.
- if (FileName(trypath).isDirWritable())
- initpath = trypath;
-
- // FIXME UNICODE
- FileDialog dlg(_("Select LyX document to insert"), LFUN_FILE_INSERT);
- dlg.setButton1(_("Documents|#o#O"), from_utf8(lyxrc.document_path));
- dlg.setButton2(_("Examples|#E#e"),
- from_utf8(addPath(package().system_support().absFilename(),
- "examples")));
-
- FileDialog::Result result =
- dlg.open(from_utf8(initpath),
- FileFilterList(_("LyX Documents (*.lyx)")),
- docstring());
-
- if (result.first == FileDialog::Later)
- return;
-
- // FIXME UNICODE
- filename = to_utf8(result.second);
-
- // check selected filename
- if (filename.empty()) {
- // emit message signal.
- message(_("Canceled."));
- return;
- }
- }
// Get absolute path of file and add ".lyx"
// to the filename if necessary
- filename = fileSearch(string(), filename, "lyx").absFilename();
+ FileName filename = fileSearch(string(), fname.absFilename(), "lyx");
- docstring const disp_fn = makeDisplayPath(filename);
+ docstring const disp_fn = makeDisplayPath(filename.absFilename());
// emit message signal.
message(bformat(_("Inserting document %1$s..."), disp_fn));
docstring res;
Buffer buf("", false);
- if (buf.loadLyXFile(FileName(filename))) {
+ if (buf.loadLyXFile(filename)) {
ErrorList & el = buffer_.errorList("Parse");
// Copy the inserted document error list into the current buffer one.
el = buf.errorList("Parse");
res = _("Could not insert document %1$s");
}
+ updateMetrics();
+ buffer_.changed();
// emit message signal.
message(bformat(res, disp_fn));
buffer_.errors("Parse");
- updateMetrics();
}
int pos = sl.pos();
if (pos && boundary)
--pos;
-// lyxerr << "coordOffset: boundary:" << boundary << " depth:" << dit.depth() << " pos:" << pos << " sl.pos:" << sl.pos() << std::endl;
+// lyxerr << "coordOffset: boundary:" << boundary << " depth:" << dit.depth() << " pos:" << pos << " sl.pos:" << sl.pos() << endl;
rend = pm.pos2row(pos);
} else
rend = pm.pos2row(sl.pos());
LYXERR(Debug::PAINTING, "\t\t*** START DRAWING ***");
Text & text = buffer_.text();
TextMetrics const & tm = d->text_metrics_[&text];
- int const y = - d->offset_ref_ + tm.parMetrics(d->anchor_ref_).ascent();
+ int const y = tm.first().second->position();
PainterInfo pi(this, pain);
switch (d->update_strategy_) {
// Clear background.
pain.fillRectangle(0, 0, width_, height_,
buffer_.inset().backgroundColor());
+
+ // Draw everything.
tm.draw(pi, 0, y);
// and possibly grey out below
-
std::pair<pit_type, ParagraphMetrics const *> lastpm = tm.last();
+ pair<pit_type, ParagraphMetrics const *> lastpm = tm.last();
int const y2 = lastpm.second->position() + lastpm.second->descent();
if (y2 < height_)
pain.fillRectangle(0, y2, width_, height_ - y2, Color_bottomarea);
break;
}
-
LYXERR(Debug::PAINTING, "\n\t\t*** END DRAWING ***");
+
+ // The scrollbar needs an update.
+ updateScrollbar();
+
+ // Normalize anchor for next time
+ pair<pit_type, ParagraphMetrics const *> firstpm = tm.first();
+ pair<pit_type, ParagraphMetrics const *> lastpm = tm.last();
+ for (pit_type pit = firstpm.first; pit <= lastpm.first; ++pit) {
+ ParagraphMetrics const & pm = tm.parMetrics(pit);
+ if (pm.position() + pm.descent() > 0) {
+ d->anchor_pit_ = pit;
+ d->anchor_ypos_ = pm.position();
+ break;
+ }
+ }
+ LYXERR(Debug::PAINTING, "Found new anchor pit = " << d->anchor_pit_
+ << " anchor ypos = " << d->anchor_ypos_);
}
}
-void BufferView::showDialog(std::string const & name)
+void BufferView::showDialog(string const & name)
{
if (d->gui_)
d->gui_->showDialog(name, string());
}
-void BufferView::showDialog(std::string const & name,
- std::string const & data, Inset * inset)
+void BufferView::showDialog(string const & name,
+ string const & data, Inset * inset)
{
if (d->gui_)
d->gui_->showDialog(name, data, inset);
}
-void BufferView::updateDialog(std::string const & name, std::string const & data)
+void BufferView::updateDialog(string const & name, string const & data)
{
if (d->gui_)
d->gui_->updateDialog(name, data);
// FIXME: Move this out of BufferView again
-docstring BufferView::contentsOfPlaintextFile(FileName const & fname,
- bool asParagraph)
+docstring BufferView::contentsOfPlaintextFile(FileName const & fname)
{
- if (fname.empty()) {
- FileDialog dlg(_("Select file to insert"),
- ( asParagraph
- ? LFUN_FILE_INSERT_PLAINTEXT_PARA
- : LFUN_FILE_INSERT_PLAINTEXT) );
-
- FileDialog::Result result =
- dlg.open(from_utf8(buffer().filePath()),
- FileFilterList(), docstring());
-
- if (result.first == FileDialog::Later)
- return docstring();
-
- if (result.second.empty())
- return docstring();
-
- return contentsOfPlaintextFile(FileName(to_utf8(result.second)), false);
- }
-
if (!fname.isReadableFile()) {
docstring const error = from_ascii(strerror(errno));
docstring const file = makeDisplayPath(fname.absFilename(), 50);
void BufferView::insertPlaintextFile(FileName const & f, bool asParagraph)
{
- docstring const tmpstr = contentsOfPlaintextFile(f, asParagraph);
+ docstring const tmpstr = contentsOfPlaintextFile(f);
if (tmpstr.empty())
return;
cur.innerText()->insertStringAsParagraphs(cur, tmpstr);
else
cur.innerText()->insertStringAsLines(cur, tmpstr);
+
+ updateMetrics();
+ buffer_.changed();
}
} // namespace lyx
projects / features.git / blobdiff