]> git.lyx.org Git - features.git/blobdiff - src/BufferView.cpp
Whitespace cleanup
[features.git] / src / BufferView.cpp
index 3fe66acbb2cf70f462e0b8cd19827f3b504cc3ba..e5ded3926747f5b843a29f0d7419df9f6a5f8333 100644 (file)
@@ -40,8 +40,8 @@
 #include "lyxfind.h"
 #include "LyXFunc.h"
 #include "Layout.h"
-#include "LyXText.h"
-#include "LyXTextClass.h"
+#include "Text.h"
+#include "TextClass.h"
 #include "LyXRC.h"
 #include "Session.h"
 #include "Paragraph.h"
@@ -183,14 +183,20 @@ void BufferView::setBuffer(Buffer * b)
                return;
        }
 
+       //FIXME Fix for bug 3440 is here.
        // If we are closing current buffer, switch to the first in
        // buffer list.
        if (!b) {
                LYXERR(Debug::INFO) << BOOST_CURRENT_FUNCTION
                                    << " No Buffer!" << endl;
                // We are closing the buffer, use the first buffer as current
+               //FIXME 3440
+               // if (last_buffer_) buffer_ = last_buffer_;
+               // also check that this is in theBufferList()?
                buffer_ = theBufferList().first();
        } else {
+               //FIXME 3440
+               // last_buffer = buffer_;
                // Set current buffer
                buffer_ = b;
        }
@@ -200,7 +206,9 @@ void BufferView::setBuffer(Buffer * b)
        anchor_ref_ = 0;
        offset_ref_ = 0;
 
-       if (buffer_) {
+       if (!buffer_)
+               return;
+
                LYXERR(Debug::INFO) << BOOST_CURRENT_FUNCTION
                                    << "Buffer addr: " << buffer_ << endl;
                cursor_.push(buffer_->inset());
@@ -215,13 +223,13 @@ void BufferView::setBuffer(Buffer * b)
                        cursor_.setSelection();
                        // do not set selection to the new buffer because we
                        // only paste recent selection.
-               }
-       }
 
-       if (buffer_)
-               updateMetrics(false);    
-
-       if (buffer_ && graphics::Previews::status() != LyXRC::PREVIEW_OFF)
+                       // Make sure that the restored cursor is not broken. This can happen for
+                       // example if this Buffer has been modified by another view.
+                       cursor_.fixIfBroken();
+               }
+               updateMetrics(false);
+       if (graphics::Previews::status() != LyXRC::PREVIEW_OFF)
                graphics::Previews::get().generateBufferPreviews(*buffer_);
 }
 
@@ -376,7 +384,7 @@ bool BufferView::update(Update::flags flags)
                return true;
        }
 
-       if (flags == Update::FitCursor 
+       if (flags == Update::FitCursor
                || flags == (Update::Decoration | Update::FitCursor)) {
                bool const fit_cursor = fitCursor();
                // tell the frontend to update the screen if needed.
@@ -417,7 +425,7 @@ void BufferView::updateScrollbar()
                return;
        }
 
-       LyXText & t = buffer_->text();
+       Text & t = buffer_->text();
        TextMetrics & tm = text_metrics_[&t];
 
        int const parsize = int(t.paragraphs().size() - 1);
@@ -485,7 +493,7 @@ void BufferView::scrollDocView(int value)
        if (!buffer_)
                return;
 
-       LyXText & t = buffer_->text();
+       Text & t = buffer_->text();
        TextMetrics & tm = text_metrics_[&t];
 
        float const bar = value / float(wh_ * t.paragraphs().size());
@@ -506,7 +514,7 @@ void BufferView::setCursorFromScrollbar()
        if (!buffer_)
                return;
 
-       LyXText & t = buffer_->text();
+       Text & t = buffer_->text();
 
        int const height = 2 * defaultRowHeight();
        int const first = height;
@@ -555,7 +563,7 @@ void BufferView::saveBookmark(unsigned int idx)
 {
        // tenatively save bookmark, id and pos will be used to
        // acturately locate a bookmark in a 'live' lyx session.
-       // pit and pos will be updated with bottom level pit/pos 
+       // pit and pos will be updated with bottom level pit/pos
        // when lyx exits.
        LyX::ref().session().bookmarks().save(
                FileName(buffer_->fileName()),
@@ -583,9 +591,12 @@ boost::tuple<pit_type, pos_type, int> BufferView::moveToPosition(pit_type bottom
                ParIterator par = buffer_->getParFromID(top_id);
                if (par != buffer_->par_iterator_end()) {
                        DocIterator dit = makeDocIterator(par, min(par->size(), top_pos));
-                       // Some slices of the iterator may not be reachable (e.g. closed collapsable inset)
-                       // so the dociterator may need to be shortened. Otherwise, setCursor may
-                       // crash lyx when the cursor can not be set to these insets.
+                       // Some slices of the iterator may not be
+                       // reachable (e.g. closed collapsable inset)
+                       // so the dociterator may need to be
+                       // shortened. Otherwise, setCursor may crash
+                       // lyx when the cursor can not be set to these
+                       // insets.
                        size_t const n = dit.depth();
                        for (size_t i = 0; i < n; ++i)
                                if (dit[i].inset().editable() != Inset::HIGHLY_EDITABLE) {
@@ -598,20 +609,18 @@ boost::tuple<pit_type, pos_type, int> BufferView::moveToPosition(pit_type bottom
                }
        }
        // if top_id == 0, or searching through top_id failed
-       // This is the case for a 'restored' bookmark when only bottom 
+       // This is the case for a 'restored' bookmark when only bottom
        // (document level) pit was saved. Because of this, bookmark
        // restoration is inaccurate. If a bookmark was within an inset,
        // it will be restored to the left of the outmost inset that contains
        // the bookmark.
        if (static_cast<size_t>(bottom_pit) < buffer_->paragraphs().size()) {
-               ParIterator it = buffer_->par_iterator_begin();
-               ParIterator const end = buffer_->par_iterator_end();
-               for (; it != end; ++it)
-                       if (it.pit() == bottom_pit) {
-                               // restored pos may be bigger than it->size
-                               setCursor(makeDocIterator(it, min(bottom_pos, it->size())));
-                               return boost::make_tuple(bottom_pit, bottom_pos, it->id());
-                       }
+               DocIterator it = doc_iterator_begin(buffer_->inset());
+               it.pit() = bottom_pit;
+               it.pos() = min(bottom_pos, it.paragraph().size());
+               setCursor(it);
+               return boost::make_tuple(it.pit(), it.pos(),
+                                        it.paragraph().id());
        }
        // both methods fail
        return boost::make_tuple(pit_type(0), pos_type(0), 0);
@@ -668,7 +677,7 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
        case LFUN_FILE_INSERT_PLAINTEXT_PARA:
        case LFUN_FILE_INSERT_PLAINTEXT:
        case LFUN_BOOKMARK_SAVE:
-               // FIXME: Actually, these LFUNS should be moved to LyXText
+               // FIXME: Actually, these LFUNS should be moved to Text
                flag.enabled(cursor_.inTexted());
                break;
        case LFUN_FONT_STATE:
@@ -706,7 +715,7 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
                break;
 
        case LFUN_CHANGES_OUTPUT:
-               flag.enabled(buffer_ && LaTeXFeatures::isAvailable("dvipost"));
+               flag.enabled(buffer_);
                flag.setOnOff(buffer_->params().outputChanges);
                break;
 
@@ -889,6 +898,25 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
 
        case LFUN_CHANGES_OUTPUT:
                buffer_->params().outputChanges = !buffer_->params().outputChanges;
+               if (buffer_->params().outputChanges) {
+                       bool dvipost    = LaTeXFeatures::isAvailable("dvipost");
+                       bool xcolorsoul = LaTeXFeatures::isAvailable("soul") &&
+                                         LaTeXFeatures::isAvailable("xcolor");
+
+                       if (!dvipost && !xcolorsoul) {
+                               Alert::warning(_("Changes not shown in LaTeX output"),
+                                              _("Changes will not be highlighted in LaTeX output, "
+                                                "because neither dvipost nor xcolor/soul are installed.\n"
+                                                "Please install these packages or redefine "
+                                                "\\lyxadded and \\lyxdeleted in the LaTeX preamble."));
+                       } else if (!xcolorsoul) {
+                               Alert::warning(_("Changes not shown in LaTeX output"),
+                                              _("Changes will not be highlighted in LaTeX output "
+                                                "when using pdflatex, because xcolor and soul are not installed.\n"
+                                                "Please install both packages or redefine "
+                                                "\\lyxadded and \\lyxdeleted in the LaTeX preamble."));
+                       }
+               }
                break;
 
        case LFUN_CHANGE_NEXT:
@@ -906,7 +934,7 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                cursor_.selHandle(true);
                buffer_->text().cursorBottom(cursor_);
                // accept everything in a single step to support atomic undo
-               buffer_->text().acceptOrRejectChanges(cursor_, LyXText::ACCEPT);
+               buffer_->text().acceptOrRejectChanges(cursor_, Text::ACCEPT);
                break;
 
        case LFUN_ALL_CHANGES_REJECT:
@@ -916,7 +944,7 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                buffer_->text().cursorBottom(cursor_);
                // reject everything in a single step to support atomic undo
                // Note: reject does not work recursively; the user may have to repeat the operation
-               buffer_->text().acceptOrRejectChanges(cursor_, LyXText::REJECT);
+               buffer_->text().acceptOrRejectChanges(cursor_, Text::REJECT);
                break;
 
        case LFUN_WORD_FIND:
@@ -1102,7 +1130,7 @@ void BufferView::workAreaResize(int width, int height)
 }
 
 
-Inset const * BufferView::getCoveringInset(LyXText const & text, int x, int y)
+Inset const * BufferView::getCoveringInset(Text const & text, int x, int y)
 {
        pit_type pit = text.getPitNearY(*this, y);
        BOOST_ASSERT(pit != -1);
@@ -1120,17 +1148,17 @@ Inset const * BufferView::getCoveringInset(LyXText const & text, int x, int y)
                Inset * const inset = iit->inset;
                if (inset->covers(*this, x, y)) {
                        if (!inset->descendable())
-                               // No need to go further down if the inset is not 
+                               // No need to go further down if the inset is not
                                // descendable.
                                return inset;
 
                        size_t cell_number = inset->nargs();
                        // Check all the inner cell.
                        for (size_t i = 0; i != cell_number; ++i) {
-                               LyXText const * inner_text = inset->getText(i);
+                               Text const * inner_text = inset->getText(i);
                                if (inner_text) {
                                        // Try deeper.
-                                       Inset const * inset_deeper = 
+                                       Inset const * inset_deeper =
                                                getCoveringInset(*inner_text, x, y);
                                        if (inset_deeper)
                                                return inset_deeper;
@@ -1167,15 +1195,15 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
        cur.selection() = cursor_.selection();
 
        // Either the inset under the cursor or the
-       // surrounding LyXText will handle this event.
+       // surrounding Text will handle this event.
 
        // make sure we stay within the screen...
        cmd.y = min(max(cmd.y, -1), height_);
-       
+
        if (cmd.action == LFUN_MOUSE_MOTION && cmd.button() == mouse_button::none) {
-               
+
                // Get inset under mouse, if there is one.
-               Inset const * covering_inset = 
+               Inset const * covering_inset =
                        getCoveringInset(buffer_->text(), cmd.x, cmd.y);
                if (covering_inset == last_inset_)
                        // Same inset, no need to do anything...
@@ -1196,9 +1224,9 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
                // not expose the button for redraw. We adjust here the metrics dimension
                // to enable a full redraw.
                // FIXME: It is possible to redraw only the area around the button!
-               if (need_redraw 
+               if (need_redraw
                        && metrics_info_.update_strategy == SingleParUpdate) {
-                       // FIXME: It should be possible to redraw only the area around 
+                       // FIXME: It should be possible to redraw only the area around
                        // the button by doing this:
                        //
                        //metrics_info_.singlepar = false;
@@ -1209,7 +1237,7 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
                        // between background updates and text updates. So we use the hammer
                        // solution for now. We could also avoid the updateMetrics() below
                        // by using the first and last pit of the CoordCache. Have a look
-                       // at LyXText::getPitNearY() to see what I mean.
+                       // at Text::getPitNearY() to see what I mean.
                        //
                        //metrics_info_.pit1 = first pit of CoordCache;
                        //metrics_info_.pit2 = last pit of CoordCache;
@@ -1224,7 +1252,7 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
                // This should be changed if it is further utilized.
                return need_redraw;
        }
-       
+
        // Build temporary cursor.
        Inset * inset = buffer_->text().editXY(cur, cmd.x, cmd.y);
 
@@ -1257,7 +1285,7 @@ void BufferView::scroll(int /*lines*/)
 //     if (!buffer_)
 //             return;
 //
-//     LyXText const * t = &buffer_->text();
+//     Text const * t = &buffer_->text();
 //     int const line_height = defaultRowHeight();
 //
 //     // The new absolute coordinate
@@ -1300,24 +1328,24 @@ void BufferView::gotoLabel(docstring const & label)
 }
 
 
-TextMetrics const & BufferView::textMetrics(LyXText const * t) const
+TextMetrics const & BufferView::textMetrics(Text const * t) const
 {
        return const_cast<BufferView *>(this)->textMetrics(t);
 }
 
 
-TextMetrics & BufferView::textMetrics(LyXText const * t)
+TextMetrics & BufferView::textMetrics(Text const * t)
 {
        TextMetricsCache::iterator tmc_it  = text_metrics_.find(t);
        if (tmc_it == text_metrics_.end()) {
                tmc_it = text_metrics_.insert(
-                       make_pair(t, TextMetrics(this, const_cast<LyXText *>(t)))).first;
-       }       
+                       make_pair(t, TextMetrics(this, const_cast<Text *>(t)))).first;
+       }
        return tmc_it->second;
 }
 
 
-ParagraphMetrics const & BufferView::parMetrics(LyXText const * t,
+ParagraphMetrics const & BufferView::parMetrics(Text const * t,
                pit_type pit) const
 {
        return textMetrics(t).parMetrics(pit);
@@ -1353,7 +1381,7 @@ bool BufferView::checkDepm(Cursor & cur, Cursor & old)
 
        if (need_anchor_change)
                cur.resetAnchor();
-       
+
        if (!changed)
                return false;
 
@@ -1387,8 +1415,8 @@ bool BufferView::mouseSetCursor(Cursor & cur)
        // position is in the nucleus of the inset, notifyCursorLeaves
        // will kill the script inset itself. So we check all the
        // elements of the cursor to make sure that they are correct.
-       // For an example, see bug 2933: 
-       // http://bugzilla.lyx.org/show_bug.cgi?id=2933
+       // For an example, see bug 2933:
+       // http://bugzilla.lyx.org/show_bug.cgi?id=2933
        // The code below could maybe be moved to a DocIterator method.
        //lyxerr << "cur before " << cur <<std::endl;
        DocIterator dit(cur.inset());
@@ -1401,6 +1429,7 @@ bool BufferView::mouseSetCursor(Cursor & cur)
        //lyxerr << "5 cur after" << dit <<std::endl;
 
        cursor_.setCursor(dit);
+       cursor_.boundary(cur.boundary());
        cursor_.clearSelection();
        finishUndo();
        return update;
@@ -1452,7 +1481,7 @@ ViewMetricsInfo const & BufferView::viewMetricsInfo()
 // FIXME: We should split-up updateMetrics() for the singlepar case.
 void BufferView::updateMetrics(bool singlepar)
 {
-       LyXText & buftext = buffer_->text();
+       Text & buftext = buffer_->text();
        TextMetrics & tm = textMetrics(&buftext);
        pit_type size = int(buftext.paragraphs().size());
 
@@ -1460,7 +1489,7 @@ void BufferView::updateMetrics(bool singlepar)
                anchor_ref_ = int(buftext.paragraphs().size() - 1);
                offset_ref_ = 0;
        }
-       
+
        // If the paragraph metrics has changed, we can not
        // use the singlepar optimisation.
        if (singlepar
@@ -1479,7 +1508,7 @@ void BufferView::updateMetrics(bool singlepar)
        // Rebreak anchor paragraph.
        if (!singlepar)
                tm.redoParagraph(pit);
-       
+
        // Clear out the position cache in case of full screen redraw.
        if (!singlepar)
                coord_cache_.clear();
@@ -1557,7 +1586,7 @@ void BufferView::updateMetrics(bool singlepar)
                << "size: " << size
                << endl;
 
-       metrics_info_ = ViewMetricsInfo(pit1, pit2, y1, y2, 
+       metrics_info_ = ViewMetricsInfo(pit1, pit2, y1, y2,
                singlepar? SingleParUpdate: FullScreenUpdate, size);
 
        if (lyxerr.debugging(Debug::WORKAREA)) {