]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView.cpp
Add LFUN_BRANCH_ACTIVATE and LFUN_BRANCH_DEACTIVATE, fixing bug 4341.
[lyx.git] / src / BufferView.cpp
index 1ccc1c3c9dff698de5fe01edbf0761a867131f39..a3f3672e5c0996d77813ec0f23e7223b3999c54b 100644 (file)
@@ -16,6 +16,7 @@
 
 #include "BufferView.h"
 
+#include "BranchList.h"
 #include "Buffer.h"
 #include "buffer_funcs.h"
 #include "BufferList.h"
@@ -24,7 +25,6 @@
 #include "Cursor.h"
 #include "CutAndPaste.h"
 #include "DispatchResult.h"
-#include "EmbeddedFiles.h"
 #include "ErrorList.h"
 #include "factory.h"
 #include "FloatList.h"
 #include "TextClass.h"
 #include "TextMetrics.h"
 #include "TexRow.h"
+#include "TocBackend.h"
 #include "VSpace.h"
 #include "WordLangTuple.h"
 
 #include "insets/InsetBibtex.h"
 #include "insets/InsetCommand.h" // ChangeRefs
+#include "insets/InsetExternal.h"
+#include "insets/InsetGraphics.h"
 #include "insets/InsetRef.h"
 #include "insets/InsetText.h"
 
 #include "frontends/alert.h"
+#include "frontends/Application.h"
 #include "frontends/Delegates.h"
 #include "frontends/FontMetrics.h"
 #include "frontends/Painter.h"
@@ -67,7 +71,7 @@
 
 #include "support/convert.h"
 #include "support/debug.h"
-#include "support/FileFilterList.h"
+#include "support/ExceptionMessage.h"
 #include "support/filetools.h"
 #include "support/gettext.h"
 #include "support/lstrings.h"
@@ -112,7 +116,7 @@ bool findNextInset(DocIterator & dit, vector<InsetCode> const & codes,
        while (tmpdit) {
                Inset const * inset = tmpdit.nextInset();
                if (inset
-                   && find(codes.begin(), codes.end(), inset->lyxCode()) != codes.end()
+                   && std::find(codes.begin(), codes.end(), inset->lyxCode()) != codes.end()
                    && (contents.empty() ||
                    static_cast<InsetCommand const *>(inset)->getFirstNonOptParam() == contents)) {
                        dit = tmpdit;
@@ -138,7 +142,7 @@ bool findInset(DocIterator & dit, vector<InsetCode> const & codes,
        if (same_content) {
                Inset const * inset = tmpdit.nextInset();
                if (inset
-                   && find(codes.begin(), codes.end(), inset->lyxCode()) != codes.end()) {
+                   && std::find(codes.begin(), codes.end(), inset->lyxCode()) != codes.end()) {
                        contents = static_cast<InsetCommand const *>(inset)->getFirstNonOptParam();
                }
        }
@@ -176,6 +180,7 @@ void gotoInset(BufferView * bv, vector<InsetCode> const & codes,
 
        tmpcur.clearSelection();
        bv->setCursor(tmpcur);
+       bv->showCursor();
 }
 
 
@@ -209,6 +214,7 @@ struct BufferView::Private
 {
        Private(BufferView & bv): wh_(0), cursor_(bv),
                anchor_pit_(0), anchor_ypos_(0),
+               inlineCompletionUniqueChars_(0),
                last_inset_(0), gui_(0)
        {}
 
@@ -236,6 +242,13 @@ struct BufferView::Private
        ///
        vector<int> par_height_;
 
+       ///
+       DocIterator inlineCompletionPos_;
+       ///
+       docstring inlineCompletion_;
+       ///
+       size_t inlineCompletionUniqueChars_;
+
        /// keyboard mapping object.
        Intl intl_;
 
@@ -251,11 +264,14 @@ struct BufferView::Private
        /** Not owned, so don't delete.
          */
        frontend::GuiBufferViewDelegate * gui_;
+
+       /// Cache for Find Next
+       FuncRequest search_request_cache_;
 };
 
 
 BufferView::BufferView(Buffer & buf)
-       : width_(0), height_(0), buffer_(buf), d(new Private(*this))
+       : width_(0), height_(0), full_screen_(false), buffer_(buf), d(new Private(*this))
 {
        d->xsel_cache_.set = false;
        d->intl_.initKeyMapper(lyxrc.use_kbmap);
@@ -285,6 +301,36 @@ BufferView::~BufferView()
 }
 
 
+int BufferView::rightMargin() const
+{
+       // The additional test for the case the outliner is opened.
+       if (!full_screen_ ||
+               !lyxrc.full_screen_limit ||
+               width_ < lyxrc.full_screen_width + 20)
+                       return 10;
+
+       return (width_ - lyxrc.full_screen_width) / 2;
+}
+
+
+int BufferView::leftMargin() const
+{
+       return rightMargin();
+}
+
+
+bool BufferView::isTopScreen() const
+{
+       return d->scrollbarParameters_.position == d->scrollbarParameters_.min;
+}
+
+
+bool BufferView::isBottomScreen() const
+{
+       return d->scrollbarParameters_.position == d->scrollbarParameters_.max;
+}
+
+
 Intl & BufferView::getIntl()
 {
        return d->intl_;
@@ -349,9 +395,7 @@ void BufferView::processUpdateFlags(Update::flags flags)
                << ", singlepar = " << (flags & Update::SinglePar)
                << "]  buffer: " << &buffer_);
 
-       // Update macro store
-       if (!(cursor().inMathed() && cursor().inMacroMode()))
-               buffer_.updateMacros();
+       buffer_.updateMacros();
 
        // Now do the first drawing step if needed. This consists on updating
        // the CoordCache in updateMetrics().
@@ -416,6 +460,11 @@ void BufferView::updateScrollbar()
        if (height_ == 0)
                return;
 
+       // We prefer fixed size line scrolling.
+       d->scrollbarParameters_.single_step = defaultRowHeight();
+       // We prefer full screen page scrolling.
+       d->scrollbarParameters_.page_step = height_;
+
        Text & t = buffer_.text();
        TextMetrics & tm = d->text_metrics_[&t];                
 
@@ -424,42 +473,43 @@ void BufferView::updateScrollbar()
                << " curr par: " << d->cursor_.bottom().pit()
                << " default height " << defaultRowHeight());
 
-       int const parsize = int(t.paragraphs().size() - 1);
+       size_t const parsize = t.paragraphs().size();
        if (d->par_height_.size() != parsize) {
                d->par_height_.clear();
-               // FIXME: We assume a default paragraph height of 4 rows. This
+               // FIXME: We assume a default paragraph height of 2 rows. This
                // should probably be pondered with the screen width.
-               d->par_height_.resize(parsize, defaultRowHeight() * 4);
+               d->par_height_.resize(parsize, defaultRowHeight() * 2);
        }
 
-       // It would be better to fix the scrollbar to understand
-       // values in [0..1] and divide everything by wh
-
        // Look at paragraph heights on-screen
-       pit_type first_visible_pit = -1;
        pair<pit_type, ParagraphMetrics const *> first = tm.first();
        pair<pit_type, ParagraphMetrics const *> last = tm.last();
        for (pit_type pit = first.first; pit <= last.first; ++pit) {
-               ParagraphMetrics const & pm = tm.parMetrics(pit);
-               d->par_height_[pit] = pm.height();
-               if (first_visible_pit < 0 && pm.position() + pm.descent() > 0)
-                       first_visible_pit = pit;
+               d->par_height_[pit] = tm.parMetrics(pit).height();
+               LYXERR(Debug::SCROLLING, "storing height for pit " << pit << " : "
+                       << d->par_height_[pit]);
        }
 
-       LYXERR(Debug::SCROLLING, "first_visible_pit " << first_visible_pit);
-
-       d->scrollbarParameters_.height = 0;
-       for (size_t i = 0; i != d->par_height_.size(); ++i) {
-               d->scrollbarParameters_.height += d->par_height_[i];
-               if (i != first_visible_pit)
-                       continue;
-               // FIXME: we should look for the first visible row within
-               // the deepest inset!
-               d->scrollbarParameters_.position = d->scrollbarParameters_.height;
+       int top_pos = first.second->position() - first.second->ascent();
+       int bottom_pos = last.second->position() + last.second->descent();
+       bool first_visible = first.first == 0 && top_pos >= 0;
+       bool last_visible = last.first + 1 == int(parsize) && bottom_pos <= height_;
+       if (first_visible && last_visible) {
+               d->scrollbarParameters_.min = 0;
+               d->scrollbarParameters_.max = 0;
+               return;
        }
 
-       d->scrollbarParameters_.lineScrollHeight =
-               tm.parMetrics(first_visible_pit).rows()[0].height();
+       d->scrollbarParameters_.min = top_pos;
+       for (size_t i = 0; i != size_t(first.first); ++i)
+               d->scrollbarParameters_.min -= d->par_height_[i];
+       d->scrollbarParameters_.max = bottom_pos;
+       for (size_t i = last.first + 1; i != parsize; ++i)
+               d->scrollbarParameters_.max += d->par_height_[i];
+
+       d->scrollbarParameters_.position = 0;
+       // The reference is the top position so we remove one page.
+       d->scrollbarParameters_.max -= d->scrollbarParameters_.page_step;
 }
 
 
@@ -469,31 +519,75 @@ ScrollbarParameters const & BufferView::scrollbarParameters() const
 }
 
 
+docstring BufferView::toolTip(int x, int y) const
+{
+       // Get inset under mouse, if there is one.
+       Inset const * covering_inset = getCoveringInset(buffer_.text(), x, y);
+       if (!covering_inset)
+               // No inset, no tooltip...
+               return docstring();
+       return covering_inset->toolTip(*this, x, y);
+}
+
+
+docstring BufferView::contextMenu(int x, int y) const
+{
+       // Get inset under mouse, if there is one.
+       Inset const * covering_inset = getCoveringInset(buffer_.text(), x, y);
+       if (covering_inset)
+               return covering_inset->contextMenu(*this, x, y);
+
+       return buffer_.inset().contextMenu(*this, x, y);
+}
+
+
 void BufferView::scrollDocView(int value)
 {
        int const offset = value - d->scrollbarParameters_.position;
-       //TextMetrics & tm = d->text_metrics_[&buffer_.text()];
-       if (abs(offset) <= 3*height_) {
+       // If the offset is less than 2 screen height, prefer to scroll instead.
+       if (abs(offset) <= 2 * height_) {
                scroll(offset);
                return;
        }
 
-       int par_pos = 0;
-       for (size_t i = 0; i != d->par_height_.size(); ++i) {
+       // cut off at the top
+       if (value <= d->scrollbarParameters_.min) {
+               DocIterator dit = doc_iterator_begin(buffer_.inset());
+               showCursor(dit);
+               LYXERR(Debug::SCROLLING, "scroll to top");
+               return;
+       }
+
+       // cut off at the bottom
+       if (value >= d->scrollbarParameters_.max) {
+               DocIterator dit = doc_iterator_end(buffer_.inset());
+               dit.backwardPos();
+               showCursor(dit);
+               LYXERR(Debug::SCROLLING, "scroll to bottom");
+               return;
+       }
+
+       // find paragraph at target position
+       int par_pos = d->scrollbarParameters_.min;
+       pit_type i = 0;
+       for (; i != int(d->par_height_.size()); ++i) {
                par_pos += d->par_height_[i];
-               if (par_pos >= value) {
-                       d->anchor_pit_ = pit_type(i);
+               if (par_pos >= value)
                        break;
-               }
        }
 
-       LYXERR(Debug::SCROLLING, "value = " << value
-               << "\tanchor_ref_ = " << d->anchor_pit_
-               << "\tpar_pos = " << par_pos);
+       if (par_pos < value) {
+               // It seems we didn't find the correct pit so stay on the safe side and
+               // scroll to bottom.
+               LYXERR0("scrolling position not found!");
+               scrollDocView(d->scrollbarParameters_.max);
+               return;
+       }
 
-       d->anchor_ypos_ = par_pos - value;
-       updateMetrics();
-       buffer_.changed();
+       DocIterator dit = doc_iterator_begin(buffer_.inset());
+       dit.pit() = i;
+       LYXERR(Debug::SCROLLING, "value = " << value << " -> scroll to pit " << i);
+       showCursor(dit);
 }
 
 
@@ -580,7 +674,7 @@ bool BufferView::moveToPosition(pit_type bottom_pit, pos_type bottom_pos,
        int top_id, pos_type top_pos)
 {
        bool success = false;
-       DocIterator doc_it;
+       DocIterator dit;
 
        d->cursor_.clearSelection();
 
@@ -588,19 +682,19 @@ bool BufferView::moveToPosition(pit_type bottom_pit, pos_type bottom_pos,
        // This is the case for a 'live' bookmark when unique paragraph ID
        // is used to track bookmarks.
        if (top_id > 0) {
-               ParIterator par = buffer_.getParFromID(top_id);
-               if (par != buffer_.par_iterator_end()) {
-                       doc_it = makeDocIterator(par, min(par->size(), top_pos));
+               dit = buffer_.getParFromID(top_id);
+               if (!dit.atEnd()) {
+                       dit.pos() = min(dit.paragraph().size(), top_pos);
                        // Some slices of the iterator may not be
                        // reachable (e.g. closed collapsable inset)
                        // so the dociterator may need to be
                        // shortened. Otherwise, setCursor may crash
                        // lyx when the cursor can not be set to these
                        // insets.
-                       size_t const n = doc_it.depth();
+                       size_t const n = dit.depth();
                        for (size_t i = 0; i < n; ++i)
-                               if (doc_it[i].inset().editable() != Inset::HIGHLY_EDITABLE) {
-                                       doc_it.resize(i);
+                               if (dit[i].inset().editable() != Inset::HIGHLY_EDITABLE) {
+                                       dit.resize(i);
                                        break;
                                }
                        success = true;
@@ -613,16 +707,17 @@ bool BufferView::moveToPosition(pit_type bottom_pit, pos_type bottom_pos,
        // restoration is inaccurate. If a bookmark was within an inset,
        // it will be restored to the left of the outmost inset that contains
        // the bookmark.
-       if (static_cast<size_t>(bottom_pit) < buffer_.paragraphs().size()) {
-               doc_it = doc_iterator_begin(buffer_.inset());
-               doc_it.pit() = bottom_pit;
-               doc_it.pos() = min(bottom_pos, doc_it.paragraph().size());
+       if (bottom_pit < int(buffer_.paragraphs().size())) {
+               dit = doc_iterator_begin(buffer_.inset());
+                               
+               dit.pit() = bottom_pit;
+               dit.pos() = min(bottom_pos, dit.paragraph().size());
                success = true;
        }
 
        if (success) {
                // Note: only bottom (document) level pit is set.
-               setCursor(doc_it);
+               setCursor(dit);
                // set the current font.
                d->cursor_.setCurrentFont();
                // To center the screen on this new position we need the
@@ -660,6 +755,12 @@ int BufferView::workWidth() const
 
 
 void BufferView::showCursor()
+{
+       showCursor(d->cursor_);
+}
+
+
+void BufferView::showCursor(DocIterator const & dit)
 {
        // We are not properly started yet, delay until resizing is
        // done.
@@ -668,20 +769,32 @@ void BufferView::showCursor()
 
        LYXERR(Debug::SCROLLING, "recentering!");
 
-       CursorSlice & bot = d->cursor_.bottom();
+       CursorSlice const & bot = dit.bottom();
        TextMetrics & tm = d->text_metrics_[bot.text()];
 
-       int const bot_pit = d->cursor_.bottom().pit();
+       pos_type const max_pit = pos_type(bot.text()->paragraphs().size() - 1);
+       int bot_pit = bot.pit();
+       if (bot_pit > max_pit) {
+               // FIXME: Why does this happen?
+               LYXERR0("bottom pit is greater that max pit: "
+                       << bot_pit << " > " << max_pit);
+               bot_pit = max_pit;
+       }
+
        if (bot_pit == tm.first().first - 1)
                tm.newParMetricsUp();
        else if (bot_pit == tm.last().first + 1)
                tm.newParMetricsDown();
 
-       if (tm.has(bot_pit)) {
+       if (tm.contains(bot_pit)) {
                ParagraphMetrics const & pm = tm.parMetrics(bot_pit);
-               int offset = coordOffset(d->cursor_, d->cursor_.boundary()).y_;
+               LASSERT(!pm.rows().empty(), /**/);
+               // FIXME: smooth scrolling doesn't work in mathed.
+               CursorSlice const & cs = dit.innerTextSlice();
+               int offset = coordOffset(dit, dit.boundary()).y_;
                int ypos = pm.position() + offset;
-               Dimension const & row_dim = d->cursor_.textRow().dimension();
+               Dimension const & row_dim =
+                       pm.getRow(cs.pos(), dit.boundary()).dimension();
                if (ypos - row_dim.ascent() < 0)
                        scrollUp(- ypos + row_dim.ascent());
                else if (ypos + row_dim.descent() > height_)
@@ -690,20 +803,25 @@ void BufferView::showCursor()
                return;
        }
 
+       // fix inline completion position
+       if (d->inlineCompletionPos_.fixIfBroken())
+               d->inlineCompletionPos_ = DocIterator();
+
        tm.redoParagraph(bot_pit);
        ParagraphMetrics const & pm = tm.parMetrics(bot_pit);
-       int offset = coordOffset(d->cursor_, d->cursor_.boundary()).y_;
+       int offset = coordOffset(dit, dit.boundary()).y_;
 
        d->anchor_pit_ = bot_pit;
+       CursorSlice const & cs = dit.innerTextSlice();
+       Dimension const & row_dim =
+               pm.getRow(cs.pos(), dit.boundary()).dimension();
 
        if (d->anchor_pit_ == 0)
                d->anchor_ypos_ = offset + pm.ascent();
-       else if (d->anchor_pit_ >= pos_type(bot.text()->paragraphs().size() - 1)) {
-               d->anchor_pit_ = bot.text()->paragraphs().size() - 1;
-               d->anchor_ypos_ = offset + pm.height() - height_;
-       } else {
-               d->anchor_ypos_ = offset + pm.ascent() - height_ / 2;
-       }
+       else if (d->anchor_pit_ == max_pit)
+               d->anchor_ypos_ = height_ - offset - row_dim.descent();
+       else
+               d->anchor_ypos_ = defaultRowHeight() * 2 - offset - row_dim.descent();
 
        updateMetrics();
        buffer_.changed();
@@ -734,6 +852,7 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
        case LFUN_FONT_STATE:
        case LFUN_LABEL_INSERT:
        case LFUN_INFO_INSERT:
+       case LFUN_INSET_EDIT:
        case LFUN_PARAGRAPH_GOTO:
        case LFUN_NOTE_NEXT:
        case LFUN_REFERENCE_NEXT:
@@ -745,11 +864,24 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
        case LFUN_SCREEN_RECENTER:
        case LFUN_BIBTEX_DATABASE_ADD:
        case LFUN_BIBTEX_DATABASE_DEL:
-       case LFUN_WORDS_COUNT:
-       case LFUN_NEXT_INSET_TOGGLE:
+       case LFUN_STATISTICS:
                flag.enabled(true);
                break;
 
+       case LFUN_NEXT_INSET_TOGGLE: 
+       case LFUN_NEXT_INSET_MODIFY: {
+               // this is the real function we want to invoke
+               FuncRequest tmpcmd = cmd;
+               tmpcmd.action = (cmd.action == LFUN_NEXT_INSET_TOGGLE) 
+                       ? LFUN_INSET_TOGGLE : LFUN_INSET_MODIFY;
+               // if there is an inset at cursor, see whether it
+               // handles the lfun, other start from scratch
+               Inset * inset = cur.nextInset();
+               if (!inset || !inset->getStatus(cur, tmpcmd, flag))
+                       flag = lyx::getStatus(tmpcmd);
+               break;
+       }
+
        case LFUN_LABEL_GOTO: {
                flag.enabled(!cmd.argument().empty()
                    || getInsetByCode<InsetRef>(cur, REF_CODE));
@@ -782,21 +914,12 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
                break;
        }
        
-       case LFUN_BUFFER_TOGGLE_EMBEDDING: {
-               flag.setOnOff(buffer_.params().embedded);
-               break;
-       }
-
        case LFUN_SCREEN_UP:
        case LFUN_SCREEN_DOWN:
-               flag.enabled(true);
-               break;
-
-       // FIXME: LFUN_SCREEN_DOWN_SELECT should be removed from
-       // everywhere else before this can enabled:
+       case LFUN_SCROLL:
        case LFUN_SCREEN_UP_SELECT:
        case LFUN_SCREEN_DOWN_SELECT:
-               flag.enabled(false);
+               flag.enabled(true);
                break;
 
        case LFUN_LAYOUT_TABULAR:
@@ -804,37 +927,33 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
                break;
 
        case LFUN_LAYOUT:
+               flag.enabled(!cur.inset().forceEmptyLayout(cur.idx()));
+               break;
+
        case LFUN_LAYOUT_PARAGRAPH:
-               flag.enabled(cur.inset().forceDefaultParagraphs(cur.idx()));
+               flag.enabled(cur.inset().allowParagraphCustomization(cur.idx()));
                break;
 
        case LFUN_INSET_SETTINGS: {
                InsetCode code = cur.inset().lyxCode();
+               if (cmd.getArg(0) == insetName(code)) {
+                       flag.enabled(true);
+                       break;
+               }
                bool enable = false;
-               switch (code) {
+               InsetCode next_code = cur.nextInset()
+                       ? cur.nextInset()->lyxCode() : NO_CODE;
+               switch (next_code) {
                        case TABULAR_CODE:
-                               enable = cmd.argument() == "tabular";
-                               break;
                        case ERT_CODE:
-                               enable = cmd.argument() == "ert";
-                               break;
                        case FLOAT_CODE:
-                               enable = cmd.argument() == "float";
-                               break;
                        case WRAP_CODE:
-                               enable = cmd.argument() == "wrap";
-                               break;
                        case NOTE_CODE:
-                               enable = cmd.argument() == "note";
-                               break;
                        case BRANCH_CODE:
-                               enable = cmd.argument() == "branch";
-                               break;
                        case BOX_CODE:
-                               enable = cmd.argument() == "box";
-                               break;
                        case LISTINGS_CODE:
-                               enable = cmd.argument() == "listings";
+                               enable = (cmd.argument().empty() ||
+                                         cmd.getArg(0) == insetName(next_code));
                                break;
                        default:
                                break;
@@ -853,6 +972,16 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
                }
                break;
 
+       case LFUN_BRANCH_ACTIVATE: 
+       case LFUN_BRANCH_DEACTIVATE: {
+               bool enable = false;
+               docstring const branchName = cmd.argument();
+               if (!branchName.empty())
+                       enable = buffer_.params().branchlist().find(branchName);
+               flag.enabled(enable);
+               break;
+       }
+
        default:
                flag.enabled(false);
        }
@@ -861,7 +990,7 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
 }
 
 
-Update::flags BufferView::dispatch(FuncRequest const & cmd)
+bool BufferView::dispatch(FuncRequest const & cmd)
 {
        //lyxerr << [ cmd = " << cmd << "]" << endl;
 
@@ -873,27 +1002,25 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                << " button[" << cmd.button() << ']');
 
        Cursor & cur = d->cursor_;
-       // Default Update flags.
-       Update::flags updateFlags = Update::Force | Update::FitCursor;
 
        switch (cmd.action) {
 
        case LFUN_UNDO:
                cur.message(_("Undo"));
                cur.clearSelection();
-               if (!cur.textUndo()) {
+               if (!cur.textUndo())
                        cur.message(_("No further undo information"));
-                       updateFlags = Update::None;
-               }
+               else
+                       processUpdateFlags(Update::Force | Update::FitCursor);
                break;
 
        case LFUN_REDO:
                cur.message(_("Redo"));
                cur.clearSelection();
-               if (!cur.textRedo()) {
+               if (!cur.textRedo())
                        cur.message(_("No further redo information"));
-                       updateFlags = Update::None;
-               }
+               else
+                       processUpdateFlags(Update::Force | Update::FitCursor);
                break;
 
        case LFUN_FONT_STATE:
@@ -921,34 +1048,52 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                        gotoLabel(label);
                break;
        }
+       
+       case LFUN_INSET_EDIT: {
+               FuncRequest fr(cmd);
+               // if there is an inset at cursor, see whether it
+               // can be modified.
+               Inset * inset = cur.nextInset();
+               if (inset)
+                       inset->dispatch(cur, fr);
+               // if it did not work, try the underlying inset.
+               if (!inset || !cur.result().dispatched())
+                       cur.dispatch(cmd);
+
+               if (!cur.result().dispatched())
+                       // It did not work too; no action needed.
+                       break;
+       }
 
        case LFUN_PARAGRAPH_GOTO: {
-               int const id = convert<int>(to_utf8(cmd.argument()));
+               int const id = convert<int>(cmd.getArg(0));
+               int const pos = convert<int>(cmd.getArg(1));
                int i = 0;
                for (Buffer * b = &buffer_; i == 0 || b != &buffer_;
                        b = theBufferList().next(b)) {
 
-                       ParIterator par = b->getParFromID(id);
-                       if (par == b->par_iterator_end()) {
+                       DocIterator dit = b->getParFromID(id);
+                       if (dit.atEnd()) {
                                LYXERR(Debug::INFO, "No matching paragraph found! [" << id << "].");
+                               ++i;
+                               continue;
+                       }
+                       LYXERR(Debug::INFO, "Paragraph " << dit.paragraph().id()
+                               << " found in buffer `"
+                               << b->absFileName() << "'.");
+
+                       if (b == &buffer_) {
+                               // Set the cursor
+                               dit.pos() = pos;
+                               setCursor(dit);
+                               processUpdateFlags(Update::Force | Update::FitCursor);
                        } else {
-                               LYXERR(Debug::INFO, "Paragraph " << par->id()
-                                       << " found in buffer `"
-                                       << b->absFileName() << "'.");
-
-                               if (b == &buffer_) {
-                                       // Set the cursor
-                                       setCursor(makeDocIterator(par, 0));
-                               } else {
-                                       // Switch to other buffer view and resend cmd
-                                       theLyXFunc().dispatch(FuncRequest(
-                                               LFUN_BUFFER_SWITCH, b->absFileName()));
-                                       theLyXFunc().dispatch(cmd);
-                                       updateFlags = Update::None;
-                               }
-                               break;
+                               // Switch to other buffer view and resend cmd
+                               theLyXFunc().dispatch(FuncRequest(
+                                       LFUN_BUFFER_SWITCH, b->absFileName()));
+                               theLyXFunc().dispatch(cmd);
                        }
-                       ++i;
+                       break;
                }
                break;
        }
@@ -1020,9 +1165,17 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                buffer_.text().acceptOrRejectChanges(d->cursor_, Text::REJECT);
                break;
 
-       case LFUN_WORD_FIND:
-               find(this, cmd);
+       case LFUN_WORD_FIND: {
+               FuncRequest req = cmd;
+               if (cmd.argument().empty() && !d->search_request_cache_.argument().empty())
+                       req = d->search_request_cache_;
+               if (find(this, req))
+                       showCursor();
+               else
+                       message(_("String not found!"));
+               d->search_request_cache_ = req;
                break;
+       }
 
        case LFUN_WORD_REPLACE: {
                bool has_deleted = false;
@@ -1075,7 +1228,7 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                InsetBibtex * inset = getInsetByCode<InsetBibtex>(tmpcur,
                                                BIBTEX_CODE);
                if (inset) {
-                       if (inset->addDatabase(to_utf8(cmd.argument())))
+                       if (inset->addDatabase(cmd.argument()))
                                buffer_.updateBibfilesCache();
                }
                break;
@@ -1087,13 +1240,13 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                InsetBibtex * inset = getInsetByCode<InsetBibtex>(tmpcur,
                                                BIBTEX_CODE);
                if (inset) {
-                       if (inset->delDatabase(to_utf8(cmd.argument())))
+                       if (inset->delDatabase(cmd.argument()))
                                buffer_.updateBibfilesCache();
                }
                break;
        }
 
-       case LFUN_WORDS_COUNT: {
+       case LFUN_STATISTICS: {
                DocIterator from, to;
                if (cur.selection()) {
                        from = cur.selectionBegin();
@@ -1102,24 +1255,33 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                        from = doc_iterator_begin(buffer_.inset());
                        to = doc_iterator_end(buffer_.inset());
                }
-               int const count = countWords(from, to);
+               int const words = countWords(from, to);
+               int const chars = countChars(from, to, false);
+               int const chars_blanks = countChars(from, to, true);
                docstring message;
-               if (count != 1) {
-                       if (cur.selection())
-                               message = bformat(_("%1$d words in selection."),
-                                         count);
-                               else
-                                       message = bformat(_("%1$d words in document."),
-                                                         count);
-               }
-               else {
-                       if (cur.selection())
-                               message = _("One word in selection.");
-                       else
-                               message = _("One word in document.");
-               }
-
-               Alert::information(_("Count words"), message);
+               if (cur.selection())
+                       message = _("Statistics for the selection:");
+               else
+                       message = _("Statistics for the document:");
+               message += "\n\n";
+               if (words != 1)
+                       message += bformat(_("%1$d words"), words);
+               else
+                       message += _("One word");
+               message += "\n";
+               if (chars_blanks != 1)
+                       message += bformat(_("%1$d characters (including blanks)"),
+                                         chars_blanks);
+               else
+                       message += _("One character (including blanks)");
+               message += "\n";
+               if (chars != 1)
+                       message += bformat(_("%1$d characters (excluding blanks)"),
+                                         chars);
+               else
+                       message += _("One character (excluding blanks)");
+
+               Alert::information(_("Statistics"), message);
        }
                break;
 
@@ -1128,14 +1290,10 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                buffer_.params().compressed = !buffer_.params().compressed;
                break;
        
-       case LFUN_BUFFER_TOGGLE_EMBEDDING:
-               // turn embedding on/off
-               buffer_.embeddedFiles().enable(!buffer_.params().embedded);
-               break;
-
        case LFUN_NEXT_INSET_TOGGLE: {
-               // this is the real function we want to invoke
-               FuncRequest tmpcmd = FuncRequest(LFUN_INSET_TOGGLE, cmd.origin);
+               // create the the real function we want to invoke
+               FuncRequest tmpcmd = cmd;
+               tmpcmd.action = LFUN_INSET_TOGGLE;
                // if there is an inset at cursor, see whether it
                // wants to toggle.
                Inset * inset = cur.nextInset();
@@ -1144,20 +1302,41 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                                Cursor tmpcur = cur;
                                tmpcur.pushBackward(*inset);
                                inset->dispatch(tmpcur, tmpcmd);
-                               if (tmpcur.result().dispatched()) {
+                               if (tmpcur.result().dispatched())
                                        cur.dispatched();
-                               }
-                       } else if (inset->editable() == Inset::IS_EDITABLE) {
-                               inset->edit(cur, true);
-                       }
+                       } else 
+                               inset->dispatch(cur, tmpcmd);
                }
                // if it did not work, try the underlying inset.
-               if (!cur.result().dispatched())
+               if (!inset || !cur.result().dispatched())
                        cur.dispatch(tmpcmd);
 
-               if (cur.result().dispatched())
-                       cur.clearSelection();
+               if (!cur.result().dispatched())
+                       // It did not work too; no action needed.
+                       break;
+               cur.clearSelection();
+               processUpdateFlags(Update::SinglePar | Update::FitCursor);
+               break;
+       }
+
+       case LFUN_NEXT_INSET_MODIFY: {
+               // create the the real function we want to invoke
+               FuncRequest tmpcmd = cmd;
+               tmpcmd.action = LFUN_INSET_MODIFY;
+               // if there is an inset at cursor, see whether it
+               // can be modified.
+               Inset * inset = cur.nextInset();
+               if (inset)
+                       inset->dispatch(cur, tmpcmd);
+               // if it did not work, try the underlying inset.
+               if (!inset || !cur.result().dispatched())
+                       cur.dispatch(tmpcmd);
 
+               if (!cur.result().dispatched())
+                       // It did not work too; no action needed.
+                       break;
+               cur.clearSelection();
+               processUpdateFlags(Update::Force | Update::FitCursor);
                break;
        }
 
@@ -1174,37 +1353,58 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                d->text_metrics_[&buffer_.text()].editXY(cur, p.x_, p.y_);
                //FIXME: what to do with cur.x_target()?
                cur.finishUndo();
-               // The metrics are already up to date. see scroll()
-               updateFlags = Update::None;
                break;
        }
 
-       case LFUN_SCREEN_UP_SELECT:
-       case LFUN_SCREEN_DOWN_SELECT: {
+       case LFUN_SCROLL:
+               lfunScroll(cmd);
+               break;
+
+       case LFUN_SCREEN_UP_SELECT: {
                cur.selHandle(true);
-               size_t initial_depth = cur.depth();
-               Point const p = getPos(cur, cur.boundary());
-               scroll(cmd.action == LFUN_SCREEN_UP_SELECT? - height_ : height_);
-               // FIXME: We need to verify if the cursor stayed within an inset...
-               //cur.reset(buffer_.inset());
-               d->text_metrics_[&buffer_.text()].editXY(cur, p.x_, p.y_);
+               if (isTopScreen()) {
+                       lyx::dispatch(FuncRequest(LFUN_BUFFER_BEGIN_SELECT));
+                       cur.finishUndo();
+                       break;
+               }
+               int y = getPos(cur, cur.boundary()).y_;
+               int const ymin = y - height_ + defaultRowHeight();
+               while (y > ymin && cur.up())
+                       y = getPos(cur, cur.boundary()).y_;
+
                cur.finishUndo();
-               while (cur.depth() > initial_depth) {
-                       cur.forwardInset();
+               processUpdateFlags(Update::SinglePar | Update::FitCursor);
+               break;
+       }
+
+       case LFUN_SCREEN_DOWN_SELECT: {
+               cur.selHandle(true);
+               if (isBottomScreen()) {
+                       lyx::dispatch(FuncRequest(LFUN_BUFFER_END_SELECT));
+                       cur.finishUndo();
+                       break;
                }
-               // FIXME: we need to do a redraw again because of the selection
-               // But no screen update is needed.
-               d->update_strategy_ = NoScreenUpdate;
-               buffer_.changed();
-               updateFlags = Update::Force | Update::FitCursor;
+               int y = getPos(cur, cur.boundary()).y_;
+               int const ymax = y + height_ - defaultRowHeight();
+               while (y < ymax && cur.down())
+                       y = getPos(cur, cur.boundary()).y_;
+
+               cur.finishUndo();
+               processUpdateFlags(Update::SinglePar | Update::FitCursor);
                break;
        }
 
+       case LFUN_BRANCH_ACTIVATE:
+       case LFUN_BRANCH_DEACTIVATE:
+               buffer_.dispatch(cmd);
+               processUpdateFlags(Update::Force);
+               break;
+
        default:
-               updateFlags = Update::None;
+               return false;
        }
 
-       return updateFlags;
+       return true;
 }
 
 
@@ -1252,12 +1452,13 @@ void BufferView::resize(int width, int height)
 
        // Clear the paragraph height cache.
        d->par_height_.clear();
-
+       // Redo the metrics.
        updateMetrics();
 }
 
 
-Inset const * BufferView::getCoveringInset(Text const & text, int x, int y)
+Inset const * BufferView::getCoveringInset(Text const & text,
+               int x, int y) const
 {
        TextMetrics & tm = d->text_metrics_[&text];
        Inset * inset = tm.checkInsetHit(x, y);
@@ -1294,6 +1495,7 @@ void BufferView::mouseEventDispatch(FuncRequest const & cmd0)
        // LFUN_FILE_OPEN generated by drag-and-drop.
        FuncRequest cmd = cmd0;
 
+       Cursor old = cursor();
        Cursor cur(*this);
        cur.push(buffer_.inset());
        cur.selection() = d->cursor_.selection();
@@ -1352,20 +1554,47 @@ void BufferView::mouseEventDispatch(FuncRequest const & cmd0)
 
        // Now dispatch to the temporary cursor. If the real cursor should
        // be modified, the inset's dispatch has to do so explicitly.
-       if (!cur.result().dispatched())
+       if (!inset || !cur.result().dispatched())
                cur.dispatch(cmd);
 
-       //Do we have a selection?
+       // Notify left insets
+       if (cur != old) {
+               old.fixIfBroken();
+               bool badcursor = notifyCursorLeaves(old, cur);
+               if (badcursor)
+                       cursor().fixIfBroken();
+       }
+       
+       // Do we have a selection?
        theSelection().haveSelection(cursor().selection());
 
        // If the command has been dispatched,
-       if (cur.result().dispatched()
-               // an update is asked,
-               && cur.result().update())
+       if (cur.result().dispatched() || cur.result().update())
                processUpdateFlags(cur.result().update());
 }
 
 
+void BufferView::lfunScroll(FuncRequest const & cmd)
+{
+       string const scroll_type = cmd.getArg(0);
+       int const scroll_step = 
+               (scroll_type == "line") ? d->scrollbarParameters_.single_step
+               : (scroll_type == "page") ? d->scrollbarParameters_.page_step : 0;
+       if (scroll_step == 0)
+               return;
+       string const scroll_quantity = cmd.getArg(1);
+       if (scroll_quantity == "up")
+               scrollUp(scroll_step);
+       else if (scroll_quantity == "down")
+               scrollDown(scroll_step);
+       else {
+               int const scroll_value = convert<int>(scroll_quantity);
+               if (scroll_value)
+                       scroll(scroll_step * scroll_value);
+       }
+}
+
+
 void BufferView::scroll(int y)
 {
        if (y > 0)
@@ -1440,15 +1669,15 @@ void BufferView::setCursorFromRow(int row)
 
 void BufferView::gotoLabel(docstring const & label)
 {
-       for (InsetIterator it = inset_iterator_begin(buffer_.inset()); it; ++it) {
-               vector<docstring> labels;
-               it->getLabelList(buffer_, labels);
-               if (find(labels.begin(), labels.end(), label) != labels.end()) {
-                       setCursor(it);
-                       processUpdateFlags(Update::FitCursor);
-                       return;
-               }
+       Toc & toc = buffer().tocBackend().toc("label");
+       TocIterator toc_it = toc.begin();
+       TocIterator end = toc.end();
+       for (; toc_it != end; ++toc_it) {
+               if (label == toc_it->str())
+                       dispatch(toc_it->action());
        }
+       //FIXME: We could do a bit more searching thanks to this:
+       //InsetLabel const * inset = buffer_.insetLabel(label);
 }
 
 
@@ -1509,6 +1738,8 @@ bool BufferView::checkDepm(Cursor & cur, Cursor & old)
        if (!changed)
                return false;
 
+       d->cursor_ = cur;
+
        updateLabels(buffer_);
 
        updateMetrics();
@@ -1519,7 +1750,7 @@ bool BufferView::checkDepm(Cursor & cur, Cursor & old)
 
 bool BufferView::mouseSetCursor(Cursor & cur, bool select)
 {
-       BOOST_ASSERT(&cur.bv() == this);
+       LASSERT(&cur.bv() == this, /**/);
 
        if (!select)
                // this event will clear selection so we save selection for
@@ -1529,8 +1760,12 @@ bool BufferView::mouseSetCursor(Cursor & cur, bool select)
        // Has the cursor just left the inset?
        bool badcursor = false;
        bool leftinset = (&d->cursor_.inset() != &cur.inset());
-       if (leftinset)
+       if (leftinset) {
+               d->cursor_.fixIfBroken();
                badcursor = notifyCursorLeaves(d->cursor_, cur);
+               if (badcursor)
+                       cur.fixIfBroken();
+       }
 
        // FIXME: shift-mouse selection doesn't work well across insets.
        bool do_selection = select && &d->cursor_.anchor().inset() == &cur.inset();
@@ -1543,24 +1778,7 @@ bool BufferView::mouseSetCursor(Cursor & cur, bool select)
        if (!do_selection && !badcursor && d->cursor_.inTexted())
                update |= checkDepm(cur, d->cursor_);
 
-       // if the cursor was in an empty script inset and the new
-       // position is in the nucleus of the inset, notifyCursorLeaves
-       // will kill the script inset itself. So we check all the
-       // elements of the cursor to make sure that they are correct.
-       // For an example, see bug 2933:
-       // http://bugzilla.lyx.org/show_bug.cgi?id=2933
-       // The code below could maybe be moved to a DocIterator method.
-       //lyxerr << "cur before " << cur <<endl;
-       DocIterator dit(cur.inset());
-       dit.push_back(cur.bottom());
-       size_t i = 1;
-       while (i < cur.depth() && dit.nextInset() == &cur[i].inset()) {
-               dit.push_back(cur[i]);
-               ++i;
-       }
-       //lyxerr << "5 cur after" << dit <<endl;
-
-       d->cursor_.setCursor(dit);
+       d->cursor_.setCursor(cur);
        d->cursor_.boundary(cur.boundary());
        if (do_selection)
                d->cursor_.setSelection();
@@ -1587,6 +1805,9 @@ void BufferView::putSelectionAt(DocIterator const & cur,
                } else
                        d->cursor_.setSelection(d->cursor_, length);
        }
+       // Ensure a redraw happens in any case because the new selection could 
+       // possibly be on the same screen as the previous selection.
+       processUpdateFlags(Update::Force | Update::FitCursor);
 }
 
 
@@ -1615,6 +1836,10 @@ bool BufferView::singleParUpdate()
        TextMetrics & tm = textMetrics(&buftext);
        int old_height = tm.parMetrics(bottom_pit).height();
 
+       // make sure inline completion pointer is ok
+       if (d->inlineCompletionPos_.fixIfBroken())
+               d->inlineCompletionPos_ = DocIterator();
+
        // In Single Paragraph mode, rebreak only
        // the (main text, not inset!) paragraph containing the cursor.
        // (if this paragraph contains insets etc., rebreaking will
@@ -1651,9 +1876,30 @@ void BufferView::updateMetrics()
 
        TextMetrics & tm = textMetrics(&buftext);
 
+       // make sure inline completion pointer is ok
+       if (d->inlineCompletionPos_.fixIfBroken())
+               d->inlineCompletionPos_ = DocIterator();
+       
+       if (d->anchor_pit_ >= npit)
+               // The anchor pit must have been deleted...
+               d->anchor_pit_ = npit - 1;
+
        // Rebreak anchor paragraph.
        tm.redoParagraph(d->anchor_pit_);
        ParagraphMetrics & anchor_pm = tm.par_metrics_[d->anchor_pit_];
+       
+       // position anchor
+       if (d->anchor_pit_ == 0) {
+               int scrollRange = d->scrollbarParameters_.max - d->scrollbarParameters_.min;
+               
+               // Complete buffer visible? Then it's easy.
+               if (scrollRange == 0)
+                       d->anchor_ypos_ = anchor_pm.ascent();
+       
+               // FIXME: Some clever handling needed to show
+               // the _first_ paragraph up to the top if the cursor is
+               // in the first line.
+       }               
        anchor_pm.setPosition(d->anchor_ypos_);
 
        LYXERR(Debug::PAINTING, "metrics: "
@@ -1664,7 +1910,7 @@ void BufferView::updateMetrics()
        int y1 = d->anchor_ypos_ - anchor_pm.ascent();
        // We are now just above the anchor paragraph.
        pit_type pit1 = d->anchor_pit_ - 1;
-       for (; pit1 >= 0 && y1 > 0; --pit1) {
+       for (; pit1 >= 0 && y1 >= 0; --pit1) {
                tm.redoParagraph(pit1);
                ParagraphMetrics & pm = tm.par_metrics_[pit1];
                y1 -= pm.descent();
@@ -1677,7 +1923,7 @@ void BufferView::updateMetrics()
        int y2 = d->anchor_ypos_ + anchor_pm.descent();
        // We are now just below the anchor paragraph.
        pit_type pit2 = d->anchor_pit_ + 1;
-       for (; pit2 < npit && y2 < height_; ++pit2) {
+       for (; pit2 < npit && y2 <= height_; ++pit2) {
                tm.redoParagraph(pit2);
                ParagraphMetrics & pm = tm.par_metrics_[pit2];
                y2 += pm.ascent();
@@ -1705,7 +1951,7 @@ void BufferView::updateMetrics()
 
 void BufferView::insertLyXFile(FileName const & fname)
 {
-       BOOST_ASSERT(d->cursor_.inTexted());
+       LASSERT(d->cursor_.inTexted(), /**/);
 
        // Get absolute path of file and add ".lyx"
        // to the filename if necessary
@@ -1723,7 +1969,7 @@ void BufferView::insertLyXFile(FileName const & fname)
                el = buf.errorList("Parse");
                buffer_.undo().recordUndo(d->cursor_);
                cap::pasteParagraphList(d->cursor_, buf.paragraphs(),
-                                            buf.params().getTextClassPtr(), el);
+                                            buf.params().documentClassPtr(), el);
                res = _("Document %1$s inserted.");
        } else {
                res = _("Could not insert document %1$s");
@@ -1790,7 +2036,7 @@ Point BufferView::coordOffset(DocIterator const & dit, bool boundary) const
        CursorSlice const & sl = dit[0];
        TextMetrics const & tm = textMetrics(sl.text());
        ParagraphMetrics const & pm = tm.parMetrics(sl.pit());
-       BOOST_ASSERT(!pm.rows().empty());
+       LASSERT(!pm.rows().empty(), /**/);
        y -= pm.rows()[0].ascent();
 #if 1
        // FIXME: document this mess
@@ -1831,7 +2077,7 @@ Point BufferView::getPos(DocIterator const & dit, bool boundary) const
 {
        CursorSlice const & bot = dit.bottom();
        TextMetrics const & tm = textMetrics(bot.text());
-       if (!tm.has(bot.pit()))
+       if (!tm.contains(bot.pit()))
                return Point(-1, -1);
 
        Point p = coordOffset(dit, boundary); // offset from outer paragraph
@@ -2001,4 +2247,67 @@ void BufferView::insertPlaintextFile(FileName const & f, bool asParagraph)
        buffer_.changed();
 }
 
+
+docstring const & BufferView::inlineCompletion() const
+{
+       return d->inlineCompletion_;
+}
+
+
+size_t const & BufferView::inlineCompletionUniqueChars() const
+{
+       return d->inlineCompletionUniqueChars_;
+}
+
+
+DocIterator const & BufferView::inlineCompletionPos() const
+{
+       return d->inlineCompletionPos_;
+}
+
+
+bool samePar(DocIterator const & a, DocIterator const & b)
+{
+       if (a.empty() && b.empty())
+               return true;
+       if (a.empty() || b.empty())
+               return false;
+       return &a.innerParagraph() == &b.innerParagraph();
+}
+
+
+void BufferView::setInlineCompletion(Cursor & cur, DocIterator const & pos, 
+       docstring const & completion, size_t uniqueChars)
+{
+       uniqueChars = min(completion.size(), uniqueChars);
+       bool changed = d->inlineCompletion_ != completion
+               || d->inlineCompletionUniqueChars_ != uniqueChars;
+       bool singlePar = true;
+       d->inlineCompletion_ = completion;
+       d->inlineCompletionUniqueChars_ = min(completion.size(), uniqueChars);
+       
+       //lyxerr << "setInlineCompletion pos=" << pos << " completion=" << completion << " uniqueChars=" << uniqueChars << std::endl;
+       
+       // at new position?
+       DocIterator const & old = d->inlineCompletionPos_;
+       if (old != pos) {
+               //lyxerr << "inlineCompletionPos changed" << std::endl;
+               // old or pos are in another paragraph?
+               if ((!samePar(cur, pos) && !pos.empty())
+                   || (!samePar(cur, old) && !old.empty())) {
+                       singlePar = false;
+                       //lyxerr << "different paragraph" << std::endl;
+               }
+               d->inlineCompletionPos_ = pos;
+       }
+       
+       // set update flags
+       if (changed) {
+               if (singlePar && !(cur.disp_.update() & Update::Force))
+                       cur.updateFlags(cur.disp_.update() | Update::SinglePar);
+               else
+                       cur.updateFlags(cur.disp_.update() | Update::Force);
+       }
+}
+
 } // namespace lyx