]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView.cpp
Transfer current_font and real_current_font from Text to Cursor.
[lyx.git] / src / BufferView.cpp
index ba9be957aada167799202bfa4bf290154f9e8fa8..7fbd7187be614a96428e28cd8da0884345738d13 100644 (file)
@@ -21,6 +21,7 @@
 #include "BufferList.h"
 #include "BufferParams.h"
 #include "bufferview_funcs.h"
+#include "callback.h" // added for Dispatch functions
 #include "CoordCache.h"
 #include "CutAndPaste.h"
 #include "debug.h"
 #include "InsetIterator.h"
 #include "Language.h"
 #include "LaTeXFeatures.h"
-#include "callback.h" // added for Dispatch functions
 #include "LyX.h"
 #include "lyxfind.h"
 #include "LyXFunc.h"
 #include "Layout.h"
-#include "Text.h"
-#include "TextClass.h"
 #include "LyXRC.h"
-#include "Session.h"
+#include "MetricsInfo.h"
 #include "Paragraph.h"
 #include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
 #include "ParIterator.h"
+#include "Session.h"
 #include "TexRow.h"
+#include "Text.h"
+#include "TextClass.h"
 #include "toc.h"
 #include "Undo.h"
 #include "VSpace.h"
 #include "WordLangTuple.h"
-#include "MetricsInfo.h"
 
 #include "insets/InsetBibtex.h"
 #include "insets/InsetCommand.h" // ChangeRefs
@@ -63,6 +63,8 @@
 #include "frontends/alert.h"
 #include "frontends/FileDialog.h"
 #include "frontends/FontMetrics.h"
+#include "frontends/Painter.h"
+#include "frontends/Selection.h"
 
 #include "graphics/Previews.h"
 
@@ -121,139 +123,46 @@ T * getInsetByCode(Cursor & cur, Inset::Code code)
 } // anon namespace
 
 
-BufferView::BufferView()
-       : width_(0), height_(0), buffer_(0), wh_(0),
+BufferView::BufferView(Buffer & buf)
+       : width_(0), height_(0), buffer_(buf), wh_(0),
          cursor_(*this),
          multiparsel_cache_(false), anchor_ref_(0), offset_ref_(0),
-         intl_(new Intl), last_inset_(0)
+         need_centering_(false), intl_(new Intl), last_inset_(0)
 {
        xsel_cache_.set = false;
        intl_->initKeyMapper(lyxrc.use_kbmap);
-}
 
+       cursor_.push(buffer_.inset());
+       cursor_.resetAnchor();
+       cursor_.setCurrentFont();
 
-BufferView::~BufferView()
-{
+       if (graphics::Previews::status() != LyXRC::PREVIEW_OFF)
+               graphics::Previews::get().generateBufferPreviews(buffer_);
 }
 
 
-Buffer * BufferView::buffer() const
+BufferView::~BufferView()
 {
-       return buffer_;
+       // current buffer is going to be switched-off, save cursor pos
+       // Ideally, the whole cursor stack should be saved, but session
+       // currently can only handle bottom (whole document) level pit and pos.
+       // That is to say, if a cursor is in a nested inset, it will be
+       // restore to the left of the top level inset.
+       LyX::ref().session().lastFilePos().save(
+               support::FileName(buffer_.fileName()),
+               boost::tie(cursor_.bottom().pit(), cursor_.bottom().pos()) );
 }
 
 
-void BufferView::setBuffer(Buffer * b)
+Buffer & BufferView::buffer()
 {
-       LYXERR(Debug::INFO) << BOOST_CURRENT_FUNCTION
-                           << "[ b = " << b << "]" << endl;
-
-       if (buffer_) {
-               // Save the current selection if any
-               cap::saveSelection(cursor_);
-               // Save the actual cursor position and anchor inside the
-               // buffer so that it can be restored in case we rechange
-               // to this buffer later on.
-               buffer_->saveCursor(cursor_.selectionBegin(),
-                                   cursor_.selectionEnd());
-               // update bookmark pit of the current buffer before switch
-               for (size_t i = 0; i < LyX::ref().session().bookmarks().size(); ++i) {
-                       BookmarksSection::Bookmark const & bm = LyX::ref().session().bookmarks().bookmark(i);
-                       if (buffer()->fileName() != bm.filename.absFilename())
-                               continue;
-                       // if top_id or bottom_pit, bottom_pos has been changed, update bookmark
-                       // see http://bugzilla.lyx.org/show_bug.cgi?id=3092
-                       pit_type new_pit;
-                       pos_type new_pos;
-                       int new_id;
-                       boost::tie(new_pit, new_pos, new_id) = moveToPosition(bm.bottom_pit, bm.bottom_pos, bm.top_id, bm.top_pos);
-                       if (bm.bottom_pit != new_pit || bm.bottom_pos != new_pos || bm.top_id != new_id )
-                               const_cast<BookmarksSection::Bookmark &>(bm).updatePos(new_pit, new_pos, new_id);
-               }
-               // current buffer is going to be switched-off, save cursor pos
-               // Ideally, the whole cursor stack should be saved, but session
-               // currently can only handle bottom (whole document) level pit and pos.
-               // That is to say, if a cursor is in a nested inset, it will be
-               // restore to the left of the top level inset.
-               LyX::ref().session().lastFilePos().save(FileName(buffer_->fileName()),
-                       boost::tie(cursor_.bottom().pit(), cursor_.bottom().pos()) );
-       }
-
-       // If we're quitting lyx, don't bother updating stuff
-       if (quitting) {
-               buffer_ = 0;
-               return;
-       }
-
-       //FIXME Fix for bug 3440 is here.
-       // If we are closing current buffer, switch to the first in
-       // buffer list.
-       if (!b) {
-               LYXERR(Debug::INFO) << BOOST_CURRENT_FUNCTION
-                                   << " No Buffer!" << endl;
-               // We are closing the buffer, use the first buffer as current
-               //FIXME 3440
-               // if (last_buffer_) buffer_ = last_buffer_;
-               // also check that this is in theBufferList()?
-               buffer_ = theBufferList().first();
-       } else {
-               //FIXME 3440
-               // last_buffer = buffer_;
-               // Set current buffer
-               buffer_ = b;
-       }
-
-       // Reset old cursor
-       cursor_ = Cursor(*this);
-       anchor_ref_ = 0;
-       offset_ref_ = 0;
-
-       if (!buffer_)
-               return;
-
-       LYXERR(Debug::INFO) << BOOST_CURRENT_FUNCTION
-                                       << "Buffer addr: " << buffer_ << endl;
-       cursor_.push(buffer_->inset());
-       cursor_.resetAnchor();
-       buffer_->text().setCurrentFont(cursor_);
-
-       // Update the metrics now that we have a proper Cursor.
-       updateMetrics(false);
-
-       // FIXME: This code won't be needed once we switch to
-       // "one Buffer" / "one BufferView".
-       if (buffer_->getCursor().size() > 0 &&
-                       buffer_->getAnchor().size() > 0)
-       {
-               cursor_.setCursor(buffer_->getAnchor().asDocIterator(&(buffer_->inset())));
-               cursor_.resetAnchor();
-               cursor_.setCursor(buffer_->getCursor().asDocIterator(&(buffer_->inset())));
-               cursor_.setSelection();
-               // do not set selection to the new buffer because we
-               // only paste recent selection.
-
-               // Make sure that the restored cursor is not broken. This can happen for
-               // example if this Buffer has been modified by another view.
-               cursor_.fixIfBroken();
-
-               if (fitCursor())
-                       // Update the metrics if the cursor new position was off screen.
-                       updateMetrics(false);
-       }
-
-       if (graphics::Previews::status() != LyXRC::PREVIEW_OFF)
-               graphics::Previews::get().generateBufferPreviews(*buffer_);
+       return buffer_;
 }
 
 
-void BufferView::resize()
+Buffer const & BufferView::buffer() const
 {
-       if (!buffer_)
-               return;
-
-       LYXERR(Debug::DEBUG) << BOOST_CURRENT_FUNCTION << endl;
-
-       updateMetrics(false);
+       return buffer_;
 }
 
 
@@ -296,17 +205,11 @@ bool BufferView::update(Update::flags flags)
                << "[fitcursor = " << (flags & Update::FitCursor)
                << ", forceupdate = " << (flags & Update::Force)
                << ", singlepar = " << (flags & Update::SinglePar)
-               << "]  buffer: " << buffer_ << endl;
-
-       // Check needed to survive LyX startup
-       if (!buffer_)
-               return false;
-
-       LYXERR(Debug::WORKAREA) << "BufferView::update" << std::endl;
+               << "]  buffer: " << &buffer_ << endl;
 
        // Update macro store
        if (!(cursor().inMathed() && cursor().inMacroMode()))
-               buffer_->buildMacros();
+               buffer_.buildMacros();
 
        // Now do the first drawing step if needed. This consists on updating
        // the CoordCache in updateMetrics().
@@ -358,14 +261,7 @@ bool BufferView::update(Update::flags flags)
 
 void BufferView::updateScrollbar()
 {
-       if (!buffer_) {
-               LYXERR(Debug::DEBUG) << BOOST_CURRENT_FUNCTION
-                                    << " no text in updateScrollbar" << endl;
-               scrollbarParameters_.reset();
-               return;
-       }
-
-       Text & t = buffer_->text();
+       Text & t = buffer_.text();
        TextMetrics & tm = text_metrics_[&t];
 
        int const parsize = int(t.paragraphs().size() - 1);
@@ -430,10 +326,7 @@ void BufferView::scrollDocView(int value)
        LYXERR(Debug::GUI) << BOOST_CURRENT_FUNCTION
                           << "[ value = " << value << "]" << endl;
 
-       if (!buffer_)
-               return;
-
-       Text & t = buffer_->text();
+       Text & t = buffer_.text();
        TextMetrics & tm = text_metrics_[&t];
 
        float const bar = value / float(wh_ * t.paragraphs().size());
@@ -451,10 +344,7 @@ void BufferView::scrollDocView(int value)
 
 void BufferView::setCursorFromScrollbar()
 {
-       if (!buffer_)
-               return;
-
-       Text & t = buffer_->text();
+       TextMetrics & tm = text_metrics_[&buffer_.text()];
 
        int const height = 2 * defaultRowHeight();
        int const first = height;
@@ -467,23 +357,23 @@ void BufferView::setCursorFromScrollbar()
        case bv_funcs::CUR_ABOVE:
                // We reset the cursor because bv_funcs::status() does not
                // work when the cursor is within mathed.
-               cur.reset(buffer_->inset());
-               t.setCursorFromCoordinates(cur, 0, first);
+               cur.reset(buffer_.inset());
+               tm.setCursorFromCoordinates(cur, 0, first);
                cur.clearSelection();
                break;
        case bv_funcs::CUR_BELOW:
                // We reset the cursor because bv_funcs::status() does not
                // work when the cursor is within mathed.
-               cur.reset(buffer_->inset());
-               t.setCursorFromCoordinates(cur, 0, last);
+               cur.reset(buffer_.inset());
+               tm.setCursorFromCoordinates(cur, 0, last);
                cur.clearSelection();
                break;
        case bv_funcs::CUR_INSIDE:
                int const y = bv_funcs::getPos(*this, cur, cur.boundary()).y_;
                int const newy = min(last, max(y, first));
                if (y != newy) {
-                       cur.reset(buffer_->inset());
-                       t.setCursorFromCoordinates(cur, 0, newy);
+                       cur.reset(buffer_.inset());
+                       tm.setCursorFromCoordinates(cur, 0, newy);
                }
        }
 }
@@ -506,7 +396,7 @@ void BufferView::saveBookmark(unsigned int idx)
        // pit and pos will be updated with bottom level pit/pos
        // when lyx exits.
        LyX::ref().session().bookmarks().save(
-               FileName(buffer_->fileName()),
+               FileName(buffer_.fileName()),
                cursor_.bottom().pit(),
                cursor_.bottom().pos(),
                cursor_.paragraph().id(),
@@ -519,58 +409,67 @@ void BufferView::saveBookmark(unsigned int idx)
 }
 
 
-boost::tuple<pit_type, pos_type, int> BufferView::moveToPosition(pit_type bottom_pit, pos_type bottom_pos,
+bool BufferView::moveToPosition(pit_type bottom_pit, pos_type bottom_pos,
        int top_id, pos_type top_pos)
 {
+       bool success = false;
+       DocIterator doc_it;
+
        cursor_.clearSelection();
 
        // if a valid par_id is given, try it first
        // This is the case for a 'live' bookmark when unique paragraph ID
        // is used to track bookmarks.
        if (top_id > 0) {
-               ParIterator par = buffer_->getParFromID(top_id);
-               if (par != buffer_->par_iterator_end()) {
-                       DocIterator dit = makeDocIterator(par, min(par->size(), top_pos));
+               ParIterator par = buffer_.getParFromID(top_id);
+               if (par != buffer_.par_iterator_end()) {
+                       doc_it = makeDocIterator(par, min(par->size(), top_pos));
                        // Some slices of the iterator may not be
                        // reachable (e.g. closed collapsable inset)
                        // so the dociterator may need to be
                        // shortened. Otherwise, setCursor may crash
                        // lyx when the cursor can not be set to these
                        // insets.
-                       size_t const n = dit.depth();
+                       size_t const n = doc_it.depth();
                        for (size_t i = 0; i < n; ++i)
-                               if (dit[i].inset().editable() != Inset::HIGHLY_EDITABLE) {
-                                       dit.resize(i);
+                               if (doc_it[i].inset().editable() != Inset::HIGHLY_EDITABLE) {
+                                       doc_it.resize(i);
                                        break;
                                }
-                       setCursor(dit);
-                       // Note: return bottom (document) level pit.
-                       return boost::make_tuple(cursor_.bottom().pit(), cursor_.bottom().pos(), top_id);
+                       success = true;
                }
        }
+
        // if top_id == 0, or searching through top_id failed
        // This is the case for a 'restored' bookmark when only bottom
        // (document level) pit was saved. Because of this, bookmark
        // restoration is inaccurate. If a bookmark was within an inset,
        // it will be restored to the left of the outmost inset that contains
        // the bookmark.
-       if (static_cast<size_t>(bottom_pit) < buffer_->paragraphs().size()) {
-               DocIterator it = doc_iterator_begin(buffer_->inset());
-               it.pit() = bottom_pit;
-               it.pos() = min(bottom_pos, it.paragraph().size());
-               setCursor(it);
-               return boost::make_tuple(it.pit(), it.pos(),
-                                        it.paragraph().id());
+       if (static_cast<size_t>(bottom_pit) < buffer_.paragraphs().size()) {
+               doc_it = doc_iterator_begin(buffer_.inset());
+               doc_it.pit() = bottom_pit;
+               doc_it.pos() = min(bottom_pos, doc_it.paragraph().size());
+               success = true;
        }
-       // both methods fail
-       return boost::make_tuple(pit_type(0), pos_type(0), 0);
+
+       if (success) {
+               // Note: only bottom (document) level pit is set.
+               setCursor(doc_it);
+               // set the current font.
+               cursor_.setCurrentFont();
+               // center the screen on this new position.
+               center();
+       }
+
+       return success;
 }
 
 
 void BufferView::translateAndInsert(char_type c, Text * t, Cursor & cur)
 {
        if (lyxrc.rtl_support) {
-               if (cursor_.innerText()->real_current_font.isRightToLeft()) {
+               if (cursor_.real_current_font.isRightToLeft()) {
                        if (intl_->keymap == Intl::PRIMARY)
                                intl_->keyMapSec();
                } else {
@@ -589,16 +488,31 @@ int BufferView::workWidth() const
 }
 
 
-void BufferView::center()
+void BufferView::updateOffsetRef()
 {
+       // No need to update offset_ref_ in this case.
+       if (!need_centering_)
+               return;
+
+       // We are not properly started yet, delay until resizing is
+       // done.
+       if (height_ == 0)
+               return;
+
        CursorSlice & bot = cursor_.bottom();
        TextMetrics & tm = text_metrics_[bot.text()];
-       pit_type const pit = bot.pit();
-       tm.redoParagraph(pit);
-       ParagraphMetrics const & pm = tm.parMetrics(pit);
-       anchor_ref_ = pit;
-       offset_ref_ = bv_funcs::coordOffset(*this, cursor_, cursor_.boundary()).y_
-               + pm.ascent() - height_ / 2;
+       ParagraphMetrics const & pm = tm.parMetrics(bot.pit());
+       Point p = bv_funcs::coordOffset(*this, cursor_, cursor_.boundary());
+       offset_ref_ = p.y_ + pm.ascent() - height_ / 2;
+
+       need_centering_ = false;
+}
+
+
+void BufferView::center()
+{
+       anchor_ref_ = cursor_.bottom().pit();
+       need_centering_ = true;
 }
 
 
@@ -611,10 +525,10 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
        switch (cmd.action) {
 
        case LFUN_UNDO:
-               flag.enabled(!buffer_->undostack().empty());
+               flag.enabled(!buffer_.undostack().empty());
                break;
        case LFUN_REDO:
-               flag.enabled(!buffer_->redostack().empty());
+               flag.enabled(!buffer_.redostack().empty());
                break;
        case LFUN_FILE_INSERT:
        case LFUN_FILE_INSERT_PLAINTEXT_PARA:
@@ -654,12 +568,12 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
 
        case LFUN_CHANGES_TRACK:
                flag.enabled(true);
-               flag.setOnOff(buffer_->params().trackChanges);
+               flag.setOnOff(buffer_.params().trackChanges);
                break;
 
        case LFUN_CHANGES_OUTPUT:
-               flag.enabled(buffer_);
-               flag.setOnOff(buffer_->params().outputChanges);
+               flag.enabled(true);
+               flag.setOnOff(buffer_.params().outputChanges);
                break;
 
        case LFUN_CHANGES_MERGE:
@@ -670,11 +584,11 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
                // In principle, these command should only be enabled if there
                // is a change in the document. However, without proper
                // optimizations, this will inevitably result in poor performance.
-               flag.enabled(buffer_);
+               flag.enabled(true);
                break;
 
        case LFUN_BUFFER_TOGGLE_COMPRESSION: {
-               flag.setOnOff(buffer_->params().compressed);
+               flag.setOnOff(buffer_.params().compressed);
                break;
        }
 
@@ -700,10 +614,6 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                << " button[" << cmd.button() << ']'
                << endl;
 
-       // FIXME: this should not be possible.
-       if (!buffer_)
-               return Update::None;
-
        Cursor & cur = cursor_;
        // Default Update flags.
        Update::flags updateFlags = Update::Force | Update::FitCursor;
@@ -772,7 +682,9 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
        case LFUN_PARAGRAPH_GOTO: {
                int const id = convert<int>(to_utf8(cmd.argument()));
                int i = 0;
-               for (Buffer * b = buffer_; i == 0 || b != buffer_; b = theBufferList().next(b)) {
+               for (Buffer * b = &buffer_; i == 0 || b != &buffer_;
+                       b = theBufferList().next(b)) {
+
                        ParIterator par = b->getParFromID(id);
                        if (par == b->par_iterator_end()) {
                                LYXERR(Debug::INFO)
@@ -784,7 +696,7 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                                        << " found in buffer `"
                                        << b->fileName() << "'." << endl;
 
-                               if (b == buffer_) {
+                               if (b == &buffer_) {
                                        // Set the cursor
                                        setCursor(makeDocIterator(par, 0));
                                } else {
@@ -804,20 +716,20 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
        case LFUN_OUTLINE_UP:
                toc::outline(toc::Up, cursor_);
                cursor_.text()->setCursor(cursor_, cursor_.pit(), 0);
-               updateLabels(*buffer_);
+               updateLabels(buffer_);
                break;
        case LFUN_OUTLINE_DOWN:
                toc::outline(toc::Down, cursor_);
                cursor_.text()->setCursor(cursor_, cursor_.pit(), 0);
-               updateLabels(*buffer_);
+               updateLabels(buffer_);
                break;
        case LFUN_OUTLINE_IN:
                toc::outline(toc::In, cursor_);
-               updateLabels(*buffer_);
+               updateLabels(buffer_);
                break;
        case LFUN_OUTLINE_OUT:
                toc::outline(toc::Out, cursor_);
-               updateLabels(*buffer_);
+               updateLabels(buffer_);
                break;
 
        case LFUN_NOTE_NEXT:
@@ -833,12 +745,12 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
        }
 
        case LFUN_CHANGES_TRACK:
-               buffer_->params().trackChanges = !buffer_->params().trackChanges;
+               buffer_.params().trackChanges = !buffer_.params().trackChanges;
                break;
 
        case LFUN_CHANGES_OUTPUT:
-               buffer_->params().outputChanges = !buffer_->params().outputChanges;
-               if (buffer_->params().outputChanges) {
+               buffer_.params().outputChanges = !buffer_.params().outputChanges;
+               if (buffer_.params().outputChanges) {
                        bool dvipost    = LaTeXFeatures::isAvailable("dvipost");
                        bool xcolorsoul = LaTeXFeatures::isAvailable("soul") &&
                                          LaTeXFeatures::isAvailable("xcolor");
@@ -870,21 +782,21 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
 
        case LFUN_ALL_CHANGES_ACCEPT:
                // select complete document
-               cursor_.reset(buffer_->inset());
+               cursor_.reset(buffer_.inset());
                cursor_.selHandle(true);
-               buffer_->text().cursorBottom(cursor_);
+               buffer_.text().cursorBottom(cursor_);
                // accept everything in a single step to support atomic undo
-               buffer_->text().acceptOrRejectChanges(cursor_, Text::ACCEPT);
+               buffer_.text().acceptOrRejectChanges(cursor_, Text::ACCEPT);
                break;
 
        case LFUN_ALL_CHANGES_REJECT:
                // select complete document
-               cursor_.reset(buffer_->inset());
+               cursor_.reset(buffer_.inset());
                cursor_.selHandle(true);
-               buffer_->text().cursorBottom(cursor_);
+               buffer_.text().cursorBottom(cursor_);
                // reject everything in a single step to support atomic undo
                // Note: reject does not work recursively; the user may have to repeat the operation
-               buffer_->text().acceptOrRejectChanges(cursor_, Text::REJECT);
+               buffer_.text().acceptOrRejectChanges(cursor_, Text::REJECT);
                break;
 
        case LFUN_WORD_FIND:
@@ -943,7 +855,7 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                                                Inset::BIBTEX_CODE);
                if (inset) {
                        if (inset->addDatabase(to_utf8(cmd.argument())))
-                               buffer_->updateBibfilesCache();
+                               buffer_.updateBibfilesCache();
                }
                break;
        }
@@ -955,7 +867,7 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                                                Inset::BIBTEX_CODE);
                if (inset) {
                        if (inset->delDatabase(to_utf8(cmd.argument())))
-                               buffer_->updateBibfilesCache();
+                               buffer_.updateBibfilesCache();
                }
                break;
        }
@@ -966,8 +878,8 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
                        from = cur.selectionBegin();
                        to = cur.selectionEnd();
                } else {
-                       from = doc_iterator_begin(buffer_->inset());
-                       to = doc_iterator_end(buffer_->inset());
+                       from = doc_iterator_begin(buffer_.inset());
+                       to = doc_iterator_end(buffer_.inset());
                }
                int const count = countWords(from, to);
                docstring message;
@@ -992,7 +904,7 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
 
        case LFUN_BUFFER_TOGGLE_COMPRESSION:
                // turn compression on/off
-               buffer_->params().compressed = !buffer_->params().compressed;
+               buffer_.params().compressed = !buffer_.params().compressed;
                break;
 
        case LFUN_NEXT_INSET_TOGGLE: {
@@ -1029,9 +941,6 @@ Update::flags BufferView::dispatch(FuncRequest const & cmd)
 
 docstring const BufferView::requestSelection()
 {
-       if (!buffer_)
-               return docstring();
-
        Cursor & cur = cursor_;
 
        if (!cur.selection()) {
@@ -1054,37 +963,31 @@ docstring const BufferView::requestSelection()
 
 void BufferView::clearSelection()
 {
-       if (buffer_) {
-               cursor_.clearSelection();
-               // Clear the selection buffer. Otherwise a subsequent
-               // middle-mouse-button paste would use the selection buffer,
-               // not the more current external selection.
-               cap::clearSelection();
-               xsel_cache_.set = false;
-               // The buffer did not really change, but this causes the
-               // redraw we need because we cleared the selection above.
-               buffer_->changed();
-       }
+       cursor_.clearSelection();
+       // Clear the selection buffer. Otherwise a subsequent
+       // middle-mouse-button paste would use the selection buffer,
+       // not the more current external selection.
+       cap::clearSelection();
+       xsel_cache_.set = false;
+       // The buffer did not really change, but this causes the
+       // redraw we need because we cleared the selection above.
+       buffer_.changed();
 }
 
 
-void BufferView::workAreaResize(int width, int height)
+void BufferView::resize(int width, int height)
 {
        // Update from work area
        width_ = width;
        height_ = height;
 
-       // The complete text metrics will be redone.
-       text_metrics_.clear();
-
-       if (buffer_)
-               resize();
+       updateMetrics(false);
 }
 
 
 Inset const * BufferView::getCoveringInset(Text const & text, int x, int y)
 {
-       pit_type pit = text.getPitNearY(*this, y);
+       pit_type pit = text_metrics_[&text].getPitNearY(y);
        BOOST_ASSERT(pit != -1);
        Paragraph const & par = text.getPar(pit);
 
@@ -1138,12 +1041,8 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
        // LFUN_FILE_OPEN generated by drag-and-drop.
        FuncRequest cmd = cmd0;
 
-       // E.g. Qt mouse press when no buffer
-       if (!buffer_)
-               return false;
-
        Cursor cur(*this);
-       cur.push(buffer_->inset());
+       cur.push(buffer_.inset());
        cur.selection() = cursor_.selection();
 
        // Either the inset under the cursor or the
@@ -1156,7 +1055,7 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
 
                // Get inset under mouse, if there is one.
                Inset const * covering_inset =
-                       getCoveringInset(buffer_->text(), cmd.x, cmd.y);
+                       getCoveringInset(buffer_.text(), cmd.x, cmd.y);
                if (covering_inset == last_inset_)
                        // Same inset, no need to do anything...
                        return false;
@@ -1185,7 +1084,7 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
                        //metrics_info_.y1 = ymin of button;
                        //metrics_info_.y2 = ymax of button;
                        //
-                       // Unfortunately, rowpainter.cpp:paintText() does not distinguish
+                       // Unfortunately, BufferView::draw() does not distinguish
                        // between background updates and text updates. So we use the hammer
                        // solution for now. We could also avoid the updateMetrics() below
                        // by using the first and last pit of the CoordCache. Have a look
@@ -1206,7 +1105,7 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
        }
 
        // Build temporary cursor.
-       Inset * inset = buffer_->text().editXY(cur, cmd.x, cmd.y);
+       Inset * inset = text_metrics_[&buffer_.text()].editXY(cur, cmd.x, cmd.y);
 
        // Put anchor at the same position.
        cur.resetAnchor();
@@ -1224,6 +1123,9 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
        if (!cur.result().dispatched())
                cur.dispatch(cmd);
 
+       //Do we have a selection?
+       theSelection().haveSelection(cursor().selection());
+
        // Redraw if requested and necessary.
        if (cur.result().dispatched() && cur.result().update())
                return update(cur.result().update());
@@ -1234,10 +1136,7 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
 
 void BufferView::scroll(int /*lines*/)
 {
-//     if (!buffer_)
-//             return;
-//
-//     Text const * t = &buffer_->text();
+//     Text const * t = buffer_.text();
 //     int const line_height = defaultRowHeight();
 //
 //     // The new absolute coordinate
@@ -1257,21 +1156,21 @@ void BufferView::setCursorFromRow(int row)
        int tmpid = -1;
        int tmppos = -1;
 
-       buffer_->texrow().getIdFromRow(row, tmpid, tmppos);
+       buffer_.texrow().getIdFromRow(row, tmpid, tmppos);
 
-       cursor_.reset(buffer_->inset());
+       cursor_.reset(buffer_.inset());
        if (tmpid == -1)
-               buffer_->text().setCursor(cursor_, 0, 0);
+               buffer_.text().setCursor(cursor_, 0, 0);
        else
-               buffer_->text().setCursor(cursor_, buffer_->getParFromID(tmpid).pit(), tmppos);
+               buffer_.text().setCursor(cursor_, buffer_.getParFromID(tmpid).pit(), tmppos);
 }
 
 
 void BufferView::gotoLabel(docstring const & label)
 {
-       for (InsetIterator it = inset_iterator_begin(buffer_->inset()); it; ++it) {
+       for (InsetIterator it = inset_iterator_begin(buffer_.inset()); it; ++it) {
                vector<docstring> labels;
-               it->getLabelList(*buffer_, labels);
+               it->getLabelList(buffer_, labels);
                if (std::find(labels.begin(), labels.end(), label) != labels.end()) {
                        setCursor(it);
                        update();
@@ -1338,10 +1237,10 @@ bool BufferView::checkDepm(Cursor & cur, Cursor & old)
        if (!changed)
                return false;
 
-       updateLabels(*buffer_);
+       updateLabels(buffer_);
 
        updateMetrics(false);
-       buffer_->changed();
+       buffer_.changed();
        return true;
 }
 
@@ -1437,8 +1336,7 @@ ViewMetricsInfo const & BufferView::viewMetricsInfo()
 // FIXME: We should split-up updateMetrics() for the singlepar case.
 void BufferView::updateMetrics(bool singlepar)
 {
-       Text & buftext = buffer_->text();
-       TextMetrics & tm = textMetrics(&buftext);
+       Text & buftext = buffer_.text();
        pit_type size = int(buftext.paragraphs().size());
 
        if (anchor_ref_ > int(buftext.paragraphs().size() - 1)) {
@@ -1452,9 +1350,12 @@ void BufferView::updateMetrics(bool singlepar)
        
                // Clear out paragraph metrics to avoid having invalid metrics
                // in the cache from paragraphs not relayouted below
-               tm.clear();
+               // The complete text metrics will be redone.
+               text_metrics_.clear();
        }
 
+       TextMetrics & tm = textMetrics(&buftext);
+
        // If the paragraph metrics has changed, we can not
        // use the singlepar optimisation.
        if (singlepar
@@ -1474,6 +1375,8 @@ void BufferView::updateMetrics(bool singlepar)
        if (!singlepar)
                tm.redoParagraph(pit);
 
+       updateOffsetRef();
+
        int y0 = tm.parMetrics(pit).ascent() - offset_ref_;
 
        // Redo paragraphs above anchor if necessary.
@@ -1566,13 +1469,10 @@ void BufferView::menuInsertLyXFile(string const & filenm)
                // Launch a file browser
                // FIXME UNICODE
                string initpath = lyxrc.document_path;
-
-               if (buffer_) {
-                       string const trypath = buffer_->filePath();
-                       // If directory is writeable, use this as default.
-                       if (isDirWriteable(FileName(trypath)))
-                               initpath = trypath;
-               }
+               string const trypath = buffer_.filePath();
+               // If directory is writeable, use this as default.
+               if (isDirWriteable(FileName(trypath)))
+                       initpath = trypath;
 
                // FIXME UNICODE
                FileDialog fileDlg(_("Select LyX document to insert"),
@@ -1612,20 +1512,69 @@ void BufferView::menuInsertLyXFile(string const & filenm)
        docstring res;
        Buffer buf("", false);
        if (lyx::loadLyXFile(&buf, FileName(filename))) {
-               ErrorList & el = buffer_->errorList("Parse");
+               ErrorList & el = buffer_.errorList("Parse");
                // Copy the inserted document error list into the current buffer one.
                el = buf.errorList("Parse");
                recordUndo(cursor_);
                cap::pasteParagraphList(cursor_, buf.paragraphs(),
-                                            buf.params().textclass, el);
+                                            buf.params().getTextClass_ptr(), el);
                res = _("Document %1$s inserted.");
        } else
                res = _("Could not insert document %1$s");
 
        // emit message signal.
        message(bformat(res, disp_fn));
-       buffer_->errors("Parse");
-       resize();
+       buffer_.errors("Parse");
+       updateMetrics(false);
+}
+
+
+void BufferView::draw(frontend::Painter & pain)
+{
+       Text & text = buffer_.text();
+       bool const select = cursor_.selection();
+
+       PainterInfo pi(this, pain);
+       // Should the whole screen, including insets, be refreshed?
+       // FIXME: We should also distinguish DecorationUpdate to avoid text
+       // drawing if possible. This is not possible to do easily right now
+       // because of the single backing pixmap.
+       pi.full_repaint = select 
+               || metrics_info_.update_strategy != SingleParUpdate;
+
+       if (pi.full_repaint)
+               // Clear background (if not delegated to rows)
+               pain.fillRectangle(0, metrics_info_.y1, width_,
+                       metrics_info_.y2 - metrics_info_.y1, text.backgroundColor());
+
+       TextMetrics const & tm = text_metrics_[&text];
+
+       if (select)
+               tm.drawSelection(pi, 0, 0);
+
+       int yy = metrics_info_.y1;
+       // draw contents
+       LYXERR(Debug::PAINTING) << "\t\t*** START DRAWING ***" << endl;
+       for (pit_type pit = metrics_info_.p1; pit <= metrics_info_.p2; ++pit) {
+               ParagraphMetrics const & pm = tm.parMetrics(pit);
+               yy += pm.ascent();
+               tm.drawParagraph(pi, pit, 0, yy);
+               yy += pm.descent();
+       }
+       LYXERR(Debug::PAINTING) << "\n\t\t*** END DRAWING  ***" << endl;
+
+       // and grey out above (should not happen later)
+//     lyxerr << "par ascent: " << text.getPar(metrics_info_.p1).ascent() << endl;
+       if (metrics_info_.y1 > 0 
+               && metrics_info_.update_strategy == FullScreenUpdate)
+               pain.fillRectangle(0, 0, width_, metrics_info_.y1, Color::bottomarea);
+
+       // and possibly grey out below
+//     lyxerr << "par descent: " << text.getPar(metrics_info_.p1).ascent() << endl;
+       if (metrics_info_.y2 < height_ 
+               && metrics_info_.update_strategy == FullScreenUpdate)
+               pain.fillRectangle(0, metrics_info_.y2, width_,
+                       height_ - metrics_info_.y2, Color::bottomarea);
 }
 
 } // namespace lyx