]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView.cpp
* InsetListings.cpp:
[lyx.git] / src / BufferView.cpp
index 68b6047138282acf9168caf2027c84869fdb5583..5c49a8145a34e29bd306caacd80bf3cb17696fce 100644 (file)
@@ -315,6 +315,9 @@ BufferView::~BufferView()
        fp.pit = d->cursor_.bottom().pit();
        fp.pos = d->cursor_.bottom().pos();
        theSession().lastFilePos().save(buffer_.fileName(), fp);
+       
+       if (d->last_inset_)
+               d->last_inset_->setMouseHover(this, false);     
 
        delete d;
 }
@@ -393,7 +396,7 @@ bool BufferView::fitCursor()
                        theFontMetrics(d->cursor_.getFont().fontInfo());
                int const asc = fm.maxAscent();
                int const des = fm.maxDescent();
-               Point const p = getPos(d->cursor_, d->cursor_.boundary());
+               Point const p = getPos(d->cursor_);
                if (p.y_ - asc >= 0 && p.y_ + des < height_)
                        return false;
        }
@@ -641,7 +644,7 @@ void BufferView::setCursorFromScrollbar()
                newy = last;
                break;
        case CUR_INSIDE:
-               int const y = getPos(oldcur, oldcur.boundary()).y_;
+               int const y = getPos(oldcur).y_;
                newy = min(last, max(y, first));
                if (y == newy) 
                        return;
@@ -676,7 +679,7 @@ Change const BufferView::getCurrentChange() const
 // FIXME: This does not work within mathed!
 CursorStatus BufferView::cursorStatus(DocIterator const & dit) const
 {
-       Point const p = getPos(dit, dit.boundary());
+       Point const p = getPos(dit);
        if (p.y_ < 0)
                return CUR_ABOVE;
        if (p.y_ > workHeight())
@@ -862,17 +865,29 @@ bool BufferView::scrollToCursor(DocIterator const & dit, bool recenter)
                LASSERT(!pm.rows().empty(), /**/);
                // FIXME: smooth scrolling doesn't work in mathed.
                CursorSlice const & cs = dit.innerTextSlice();
-               int offset = coordOffset(dit, dit.boundary()).y_;
+               int offset = coordOffset(dit).y_;
                int ypos = pm.position() + offset;
                Dimension const & row_dim =
                        pm.getRow(cs.pos(), dit.boundary()).dimension();
                int scrolled = 0;
                if (recenter)
                        scrolled = scroll(ypos - height_/2);
+
+               // If the top part of the row falls of the screen, we scroll
+               // up to align the top of the row with the top of the screen.
                else if (ypos - row_dim.ascent() < 0)
-                       scrolled = scrollUp(- ypos + row_dim.ascent());
-               else if (ypos + row_dim.descent() > height_)
-                       scrolled = scrollDown(ypos - height_ + defaultRowHeight() ); 
+                       scrolled = scrollUp(-ypos + row_dim.ascent());
+
+               // If the bottom of the row falls of the screen, we scroll down.
+               // However, we have to be careful not to scroll that much that
+               // the top falls of the screen.
+               else if (ypos + row_dim.descent() > height_) {
+                       int ynew = height_ - row_dim.descent();
+                       if (ynew < row_dim.ascent())
+                               ynew = row_dim.ascent();
+                       int const scroll = ypos - ynew;
+                       scrolled = scrollDown(scroll);
+               }
 
                // else, nothing to do, the cursor is already visible so we just return.
                return scrolled != 0;
@@ -884,7 +899,7 @@ bool BufferView::scrollToCursor(DocIterator const & dit, bool recenter)
 
        tm.redoParagraph(bot_pit);
        ParagraphMetrics const & pm = tm.parMetrics(bot_pit);
-       int offset = coordOffset(dit, dit.boundary()).y_;
+       int offset = coordOffset(dit).y_;
 
        d->anchor_pit_ = bot_pit;
        CursorSlice const & cs = dit.innerTextSlice();
@@ -946,18 +961,21 @@ static Change::Type lookupChangeType(DocIterator const & dit, bool outer = false
 
 bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
 {
+       FuncCode const act = cmd.action();
+
        // Can we use a readonly buffer?
        if (buffer_.isReadonly()
-           && !lyxaction.funcHasFlag(cmd.action, LyXAction::ReadOnly)
-           && !lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer)) {
+           && !lyxaction.funcHasFlag(act, LyXAction::ReadOnly)
+           && !lyxaction.funcHasFlag(act, LyXAction::NoBuffer)) {
                flag.message(from_utf8(N_("Document is read-only")));
                flag.setEnabled(false);
                return true;
        }
+
        // Are we in a DELETED change-tracking region?
        if (lookupChangeType(d->cursor_, true) == Change::DELETED
-           && !lyxaction.funcHasFlag(cmd.action, LyXAction::ReadOnly)
-           && !lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer)) {
+           && !lyxaction.funcHasFlag(act, LyXAction::ReadOnly)
+           && !lyxaction.funcHasFlag(act, LyXAction::NoBuffer)) {
                flag.message(from_utf8(N_("This portion of the document is deleted.")));
                flag.setEnabled(false);
                return true;
@@ -968,9 +986,9 @@ bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
        if (cur.getStatus(cmd, flag))
                return true;
 
-       switch (cmd.action) {
+       switch (act) {
 
-       // FIXME: This is a bit problematic because we don't check is if this is
+       // FIXME: This is a bit problematic because we don't check if this is
        // a document BufferView or not for these LFUNs. We probably have to
        // dispatch both to currentBufferView() and, if that fails,
        // to documentBufferView(); same as we do know for current Buffer and
@@ -1004,7 +1022,6 @@ bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
        case LFUN_FONT_STATE:
        case LFUN_LABEL_INSERT:
        case LFUN_INFO_INSERT:
-       case LFUN_INSET_EDIT:
        case LFUN_PARAGRAPH_GOTO:
        case LFUN_NOTE_NEXT:
        case LFUN_REFERENCE_NEXT:
@@ -1020,7 +1037,6 @@ bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
        case LFUN_SCREEN_SHOW_CURSOR:
        case LFUN_BIBTEX_DATABASE_ADD:
        case LFUN_BIBTEX_DATABASE_DEL:
-       case LFUN_ALL_INSETS_TOGGLE:
        case LFUN_STATISTICS:
        case LFUN_BRANCH_ADD_INSERT:
        case LFUN_KEYMAP_OFF:
@@ -1030,15 +1046,6 @@ bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
                flag.setEnabled(true);
                break;
 
-       case LFUN_LABEL_COPY_AS_REF: {
-               // if there is an inset at cursor, see whether it
-               // handles the lfun
-               Inset * inset = cur.nextInset();
-               if (!inset || !inset->getStatus(cur, cmd, flag))
-                       flag.setEnabled(false);
-               break;
-       }
-
        case LFUN_LABEL_GOTO: {
                flag.setEnabled(!cmd.argument().empty()
                    || getInsetByCode<InsetRef>(cur, REF_CODE));
@@ -1071,7 +1078,12 @@ bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
                flag.setOnOff(buffer_.params().compressed);
                break;
        }
-       
+
+       case LFUN_BUFFER_TOGGLE_OUTPUT_SYNC: {
+               flag.setOnOff(buffer_.params().output_sync);
+               break;
+       }
+
        case LFUN_SCREEN_UP:
        case LFUN_SCREEN_DOWN:
        case LFUN_SCROLL:
@@ -1114,21 +1126,18 @@ bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
                Inset * inset = editedInset(name);
                if (inset) {
                        FuncRequest fr(LFUN_INSET_MODIFY, cmd.argument());
-                       FuncStatus fs;
-                       if (!inset->getStatus(cur, fr, fs)) {
+                       if (!inset->getStatus(cur, fr, flag)) {
                                // Every inset is supposed to handle this
                                LASSERT(false, break);
                        }
-                       flag |= fs;
                } else {
                        FuncRequest fr(LFUN_INSET_INSERT, cmd.argument());
-                       flag |= lyx::getStatus(fr);
+                       flag = lyx::getStatus(fr);
                }
                break;
        }
 
        default:
-               flag.setEnabled(false);
                return false;
        }
 
@@ -1154,10 +1163,10 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
        //lyxerr << [ cmd = " << cmd << "]" << endl;
 
        // Make sure that the cached BufferView is correct.
-       LYXERR(Debug::ACTION, " action[" << cmd.action << ']'
+       LYXERR(Debug::ACTION, " action[" << cmd.action() << ']'
                << " arg[" << to_utf8(cmd.argument()) << ']'
-               << " x[" << cmd.x << ']'
-               << " y[" << cmd.y << ']'
+               << " x[" << cmd.x() << ']'
+               << " y[" << cmd.y() << ']'
                << " button[" << cmd.button() << ']');
 
        string const argument = to_utf8(cmd.argument());
@@ -1165,14 +1174,15 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
 
        // Don't dispatch function that does not apply to internal buffers.
        if (buffer_.isInternal() 
-           && lyxaction.funcHasFlag(cmd.action, LyXAction::NoInternal))
+           && lyxaction.funcHasFlag(cmd.action(), LyXAction::NoInternal))
                return;
 
        // We'll set this back to false if need be.
        bool dispatched = true;
        buffer_.undo().beginUndoGroup();
 
-       switch (cmd.action) {
+       FuncCode const act = cmd.action();
+       switch (act) {
 
        case LFUN_BUFFER_PARAMS_APPLY: {
                DocumentClass const * const oldClass = buffer_.params().documentClassPtr();
@@ -1304,25 +1314,6 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                break;
        }
        
-       case LFUN_INSET_EDIT: {
-               FuncRequest fr(cmd);
-               // if there is an inset at cursor, see whether it
-               // can be modified.
-               Inset * inset = cur.nextInset();
-               if (inset)
-                       inset->dispatch(cur, fr);
-               // if it did not work, try the underlying inset.
-               if (!inset || !cur.result().dispatched())
-                       cur.dispatch(cmd);
-
-               // FIXME I'm adding the last break to solve a crash,
-               // but that is obviously not right.
-               if (!cur.result().dispatched())
-                       // It did not work too; no action needed.
-                       break;
-               break;
-       }
-
        case LFUN_PARAGRAPH_GOTO: {
                int const id = convert<int>(cmd.getArg(0));
                int const pos = convert<int>(cmd.getArg(1));
@@ -1452,7 +1443,7 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                if (searched_string.empty())
                        break;
 
-               bool const fw = cmd.action == LFUN_WORD_FIND_FORWARD;
+               bool const fw = act == LFUN_WORD_FIND_FORWARD;
                docstring const data =
                        find2string(searched_string, true, false, fw);
                find(this, FuncRequest(LFUN_WORD_FIND, data));
@@ -1602,38 +1593,25 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                buffer_.params().compressed = !buffer_.params().compressed;
                break;
 
-       case LFUN_LABEL_COPY_AS_REF: {
-               // if there is an inset at cursor, try to copy it
-               Inset * inset = &cur.inset();
-               if (!inset || !inset->asInsetMath())
-                       inset = cur.nextInset();
-               if (inset) {
-                       FuncRequest tmpcmd = cmd;
-                       inset->dispatch(cur, tmpcmd);
-               }
-               if (!cur.result().dispatched())
-                       // It did not work too; no action needed.
-                       break;
-               cur.clearSelection();
-               dr.update(Update::SinglePar | Update::FitCursor);
+       case LFUN_BUFFER_TOGGLE_OUTPUT_SYNC:
+               buffer_.params().output_sync = !buffer_.params().output_sync;
                break;
-       }
 
        case LFUN_SCREEN_UP:
        case LFUN_SCREEN_DOWN: {
-               Point p = getPos(cur, cur.boundary());
+               Point p = getPos(cur);
                // This code has been commented out to enable to scroll down a
                // document, even if there are large insets in it (see bug #5465).
                /*if (p.y_ < 0 || p.y_ > height_) {
                        // The cursor is off-screen so recenter before proceeding.
                        showCursor();
-                       p = getPos(cur, cur.boundary());
+                       p = getPos(cur);
                }*/
-               int const scrolled = scroll(cmd.action == LFUN_SCREEN_UP
+               int const scrolled = scroll(act == LFUN_SCREEN_UP
                        ? -height_ : height_);
-               if (cmd.action == LFUN_SCREEN_UP && scrolled > -height_)
+               if (act == LFUN_SCREEN_UP && scrolled > -height_)
                        p = Point(0, 0);
-               if (cmd.action == LFUN_SCREEN_DOWN && scrolled < height_)
+               if (act == LFUN_SCREEN_DOWN && scrolled < height_)
                        p = Point(width_, height_);
                Cursor old = cur;
                bool const in_texted = cur.inTexted();
@@ -1642,7 +1620,7 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                updateHoveredInset();
 
                d->text_metrics_[&buffer_.text()].editXY(cur, p.x_, p.y_,
-                       true, cmd.action == LFUN_SCREEN_UP); 
+                       true, act == LFUN_SCREEN_UP); 
                //FIXME: what to do with cur.x_target()?
                bool update = in_texted && cur.bv().checkDepm(cur, old);
                cur.finishUndo();
@@ -1662,10 +1640,10 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                        cur.finishUndo();
                        break;
                }
-               int y = getPos(cur, cur.boundary()).y_;
+               int y = getPos(cur).y_;
                int const ymin = y - height_ + defaultRowHeight();
                while (y > ymin && cur.up())
-                       y = getPos(cur, cur.boundary()).y_;
+                       y = getPos(cur).y_;
 
                cur.finishUndo();
                dr.update(Update::SinglePar | Update::FitCursor);
@@ -1679,10 +1657,10 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                        cur.finishUndo();
                        break;
                }
-               int y = getPos(cur, cur.boundary()).y_;
+               int y = getPos(cur).y_;
                int const ymax = y + height_ - defaultRowHeight();
                while (y < ymax && cur.down())
-                       y = getPos(cur, cur.boundary()).y_;
+                       y = getPos(cur).y_;
 
                cur.finishUndo();
                dr.update(Update::SinglePar | Update::FitCursor);
@@ -1714,7 +1692,7 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                        while (!insname.empty()) {
                                if (insname == name || name == from_utf8("*")) {
                                        cur.recordUndo();
-                                       lyx::dispatch(fr);
+                                       lyx::dispatch(fr, dr);
                                        ++iterations;
                                        break;
                                }
@@ -1739,29 +1717,6 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
        }
 
 
-       case LFUN_ALL_INSETS_TOGGLE: {
-               string action;
-               string const name = split(to_utf8(cmd.argument()), action, ' ');
-               InsetCode const inset_code = insetCode(name);
-
-               FuncRequest fr(LFUN_INSET_TOGGLE, action);
-
-               Inset & inset = cur.buffer()->inset();
-               InsetIterator it  = inset_iterator_begin(inset);
-               InsetIterator const end = inset_iterator_end(inset);
-               for (; it != end; ++it) {
-                       if (it->asInsetCollapsable()
-                           && (inset_code == NO_CODE
-                           || inset_code == it->lyxCode())) {
-                               Cursor tmpcur = cur;
-                               tmpcur.pushBackward(*it);
-                               it->dispatch(tmpcur, fr);
-                       }
-               }
-               dr.update(Update::Force | Update::FitCursor);
-               break;
-       }
-
        case LFUN_BRANCH_ADD_INSERT: {
                docstring branch_name = from_utf8(cmd.getArg(0));
                if (branch_name.empty())
@@ -1874,10 +1829,10 @@ docstring const BufferView::requestSelection()
        LYXERR(Debug::SELECTION, "requestSelection: xsel_cache.set: " << d->xsel_cache_.set);
        if (!d->xsel_cache_.set ||
            cur.top() != d->xsel_cache_.cursor ||
-           cur.anchor_.top() != d->xsel_cache_.anchor)
+           cur.realAnchor().top() != d->xsel_cache_.anchor)
        {
                d->xsel_cache_.cursor = cur.top();
-               d->xsel_cache_.anchor = cur.anchor_.top();
+               d->xsel_cache_.anchor = cur.realAnchor().top();
                d->xsel_cache_.set = cur.selection();
                return cur.selectionAsString(false);
        }
@@ -1952,18 +1907,22 @@ void BufferView::updateHoveredInset() const
                return;
 
        bool need_redraw = false;
-       if (d->last_inset_)
+       if (d->last_inset_) {
                // Remove the hint on the last hovered inset (if any).
-               need_redraw |= d->last_inset_->setMouseHover(false);
+               need_redraw |= d->last_inset_->setMouseHover(this, false);
+               d->last_inset_ = 0;
+       }
        
        // const_cast because of setMouseHover().
        Inset * inset = const_cast<Inset *>(covering_inset);
-       if (inset)
-               // Highlight the newly hovered inset (if any).
-               need_redraw |= inset->setMouseHover(true);
+       if (inset && inset->setMouseHover(this, true)) {
+               need_redraw = true;
+               // Only the insets that accept the hover state, do 
+               // clear the last_inset_, so only set the last_inset_
+               // member if the hovered setting is accepted.
+               d->last_inset_ = inset;
+       }
 
-       d->last_inset_ = inset;
-       
        if (need_redraw) {
                LYXERR(Debug::PAINTING, "Mouse hover detected at: ("
                                << d->mouse_position_cache_.x_ << ", " 
@@ -1978,6 +1937,16 @@ void BufferView::updateHoveredInset() const
 }
 
 
+void BufferView::clearLastInset(Inset * inset) const
+{
+       if (d->last_inset_ != inset) {
+               LYXERR0("Wrong last_inset!");
+               LASSERT(false, /**/);
+       }
+       d->last_inset_ = 0;
+}
+
+
 void BufferView::mouseEventDispatch(FuncRequest const & cmd0)
 {
        //lyxerr << "[ cmd0 " << cmd0 << "]" << endl;
@@ -1995,18 +1964,18 @@ void BufferView::mouseEventDispatch(FuncRequest const & cmd0)
        // surrounding Text will handle this event.
 
        // make sure we stay within the screen...
-       cmd.y = min(max(cmd.y, -1), height_);
+       cmd.set_y(min(max(cmd.y(), -1), height_));
 
-       d->mouse_position_cache_.x_ = cmd.x;
-       d->mouse_position_cache_.y_ = cmd.y;
+       d->mouse_position_cache_.x_ = cmd.x();
+       d->mouse_position_cache_.y_ = cmd.y();
 
-       if (cmd.action == LFUN_MOUSE_MOTION && cmd.button() == mouse_button::none) {
+       if (cmd.action() == LFUN_MOUSE_MOTION && cmd.button() == mouse_button::none) {
                updateHoveredInset();
                return;
        }
 
        // Build temporary cursor.
-       Inset * inset = d->text_metrics_[&buffer_.text()].editXY(cur, cmd.x, cmd.y);
+       Inset * inset = d->text_metrics_[&buffer_.text()].editXY(cur, cmd.x(), cmd.y());
 
        // Put anchor at the same position.
        cur.resetAnchor();
@@ -2273,7 +2242,7 @@ bool BufferView::mouseSetCursor(Cursor & cur, bool select)
                d->cursor_.fixIfBroken();
 
        // FIXME: shift-mouse selection doesn't work well across insets.
-       bool do_selection = select && &d->cursor_.anchor().inset() == &cur.inset();
+       bool do_selection = select && &d->cursor_.normalAnchor().inset() == &cur.inset();
 
        // do the dEPM magic if needed
        // FIXME: (1) move this to InsetText::notifyCursorLeaves?
@@ -2465,9 +2434,9 @@ void BufferView::insertLyXFile(FileName const & fname)
 
        // Get absolute path of file and add ".lyx"
        // to the filename if necessary
-       FileName filename = fileSearch(string(), fname.absFilename(), "lyx");
+       FileName filename = fileSearch(string(), fname.absFileName(), "lyx");
 
-       docstring const disp_fn = makeDisplayPath(filename.absFilename());
+       docstring const disp_fn = makeDisplayPath(filename.absFileName());
        // emit message signal.
        message(bformat(_("Inserting document %1$s..."), disp_fn));
 
@@ -2492,7 +2461,7 @@ void BufferView::insertLyXFile(FileName const & fname)
 }
 
 
-Point BufferView::coordOffset(DocIterator const & dit, bool boundary) const
+Point BufferView::coordOffset(DocIterator const & dit) const
 {
        int x = 0;
        int y = 0;
@@ -2506,7 +2475,7 @@ Point BufferView::coordOffset(DocIterator const & dit, bool boundary) const
                int yy = 0;
                
                // get relative position inside sl.inset()
-               sl.inset().cursorPos(*this, sl, boundary && (i + 1 == dit.depth()), xx, yy);
+               sl.inset().cursorPos(*this, sl, dit.boundary() && (i + 1 == dit.depth()), xx, yy);
                
                // Make relative position inside of the edited inset relative to sl.inset()
                x += xx;
@@ -2515,7 +2484,7 @@ Point BufferView::coordOffset(DocIterator const & dit, bool boundary) const
                // In case of an RTL inset, the edited inset will be positioned to the left
                // of xx:yy
                if (sl.text()) {
-                       bool boundary_i = boundary && i + 1 == dit.depth();
+                       bool boundary_i = dit.boundary() && i + 1 == dit.depth();
                        bool rtl = textMetrics(sl.text()).isRTL(sl, boundary_i);
                        if (rtl)
                                x -= lastw;
@@ -2552,9 +2521,9 @@ Point BufferView::coordOffset(DocIterator const & dit, bool boundary) const
        size_t rend;
        if (sl.pos() > 0 && dit.depth() == 1) {
                int pos = sl.pos();
-               if (pos && boundary)
+               if (pos && dit.boundary())
                        --pos;
-//             lyxerr << "coordOffset: boundary:" << boundary << " depth:" << dit.depth() << " pos:" << pos << " sl.pos:" << sl.pos() << endl;
+//             lyxerr << "coordOffset: boundary:" << dit.boundary() << " depth:" << dit.depth() << " pos:" << pos << " sl.pos:" << sl.pos() << endl;
                rend = pm.pos2row(pos);
        } else
                rend = pm.pos2row(sl.pos());
@@ -2568,12 +2537,12 @@ Point BufferView::coordOffset(DocIterator const & dit, bool boundary) const
        TextMetrics const & bottom_tm = textMetrics(dit.bottom().text());
        
        // Make relative position from the nested inset now bufferview absolute.
-       int xx = bottom_tm.cursorX(dit.bottom(), boundary && dit.depth() == 1);
+       int xx = bottom_tm.cursorX(dit.bottom(), dit.boundary() && dit.depth() == 1);
        x += xx;
        
        // In the RTL case place the nested inset at the left of the cursor in 
        // the outer paragraph
-       bool boundary_1 = boundary && 1 == dit.depth();
+       bool boundary_1 = dit.boundary() && 1 == dit.depth();
        bool rtl = bottom_tm.isRTL(dit.bottom(), boundary_1);
        if (rtl)
                x -= lastw;
@@ -2582,7 +2551,7 @@ Point BufferView::coordOffset(DocIterator const & dit, bool boundary) const
 }
 
 
-Point BufferView::getPos(DocIterator const & dit, bool boundary) const
+Point BufferView::getPos(DocIterator const & dit) const
 {
        if (!paragraphVisible(dit))
                return Point(-1, -1);
@@ -2590,7 +2559,8 @@ Point BufferView::getPos(DocIterator const & dit, bool boundary) const
        CursorSlice const & bot = dit.bottom();
        TextMetrics const & tm = textMetrics(bot.text());
 
-       Point p = coordOffset(dit, boundary); // offset from outer paragraph
+       // offset from outer paragraph
+       Point p = coordOffset(dit); 
        p.y_ += tm.parMetrics(bot.pit()).position();
        return p;
 }
@@ -2613,7 +2583,7 @@ void BufferView::cursorPosAndHeight(Point & p, int & h) const
        int const asc = fm.maxAscent();
        int const des = fm.maxDescent();
        h = asc + des;
-       p = getPos(cur, cur.boundary());
+       p = getPos(cur);
        p.y_ -= asc;
 }
 
@@ -2745,7 +2715,7 @@ docstring BufferView::contentsOfPlaintextFile(FileName const & fname)
 {
        if (!fname.isReadableFile()) {
                docstring const error = from_ascii(strerror(errno));
-               docstring const file = makeDisplayPath(fname.absFilename(), 50);
+               docstring const file = makeDisplayPath(fname.absFileName(), 50);
                docstring const text =
                  bformat(_("Could not read the specified document\n"
                            "%1$s\ndue to the error: %2$s"), file, error);
@@ -2754,7 +2724,7 @@ docstring BufferView::contentsOfPlaintextFile(FileName const & fname)
        }
 
        if (!fname.isReadableFile()) {
-               docstring const file = makeDisplayPath(fname.absFilename(), 50);
+               docstring const file = makeDisplayPath(fname.absFileName(), 50);
                docstring const text =
                  bformat(_("%1$s\n is not readable."), file);
                Alert::error(_("Could not open file"), text);
@@ -2853,10 +2823,10 @@ void BufferView::setInlineCompletion(Cursor & cur, DocIterator const & pos,
        
        // set update flags
        if (changed) {
-               if (singlePar && !(cur.disp_.update() & Update::Force))
-                       cur.updateFlags(cur.disp_.update() | Update::SinglePar);
+               if (singlePar && !(cur.result().update() & Update::Force))
+                       cur.updateFlags(cur.result().update() | Update::SinglePar);
                else
-                       cur.updateFlags(cur.disp_.update() | Update::Force);
+                       cur.updateFlags(cur.result().update() | Update::Force);
        }
 }