]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView.cpp
Paragraph::inInset() shall not be used if the owner inset was not initialized. Make...
[lyx.git] / src / BufferView.cpp
index 9dec257ac40ca59a60e96fe6aaafc709b22db227..2620dd65f730ee44aace1187eaf4a8165c609707 100644 (file)
@@ -282,7 +282,7 @@ BufferView::BufferView(Buffer & buf)
        d->cursor_.setCurrentFont();
 
        if (graphics::Previews::status() != LyXRC::PREVIEW_OFF)
-               graphics::Previews::get().generateBufferPreviews(buffer_);
+               thePreviews().generateBufferPreviews(buffer_);
 }
 
 
@@ -296,7 +296,7 @@ BufferView::~BufferView()
        LastFilePosSection::FilePos fp;
        fp.pit = d->cursor_.bottom().pit();
        fp.pos = d->cursor_.bottom().pos();
-       LyX::ref().session().lastFilePos().save(buffer_.fileName(), fp);
+       theSession().lastFilePos().save(buffer_.fileName(), fp);
 
        delete d;
 }
@@ -533,6 +533,10 @@ docstring BufferView::toolTip(int x, int y) const
 
 docstring BufferView::contextMenu(int x, int y) const
 {
+       //If there is a selection, return the containing inset menu
+       if (d->cursor_.selection())
+               return d->cursor_.inset().contextMenu(*this, x, y);
+
        // Get inset under mouse, if there is one.
        Inset const * covering_inset = getCoveringInset(buffer_.text(), x, y);
        if (covering_inset)
@@ -548,6 +552,8 @@ void BufferView::scrollDocView(int value)
        // If the offset is less than 2 screen height, prefer to scroll instead.
        if (abs(offset) <= 2 * height_) {
                scroll(offset);
+               updateMetrics();
+               buffer_.changed();
                return;
        }
 
@@ -600,31 +606,28 @@ void BufferView::setCursorFromScrollbar()
        int const height = 2 * defaultRowHeight();
        int const first = height;
        int const last = height_ - height;
-       Cursor & cur = d->cursor_;
+       int newy = 0;
+       Cursor const & oldcur = d->cursor_;
 
-       switch (cursorStatus(cur)) {
+       switch (cursorStatus(oldcur)) {
        case CUR_ABOVE:
-               // We reset the cursor because cursorStatus() does not
-               // work when the cursor is within mathed.
-               cur.reset(buffer_.inset());
-               tm.setCursorFromCoordinates(cur, 0, first);
-               cur.clearSelection();
+               newy = first;
                break;
        case CUR_BELOW:
-               // We reset the cursor because cursorStatus() does not
-               // work when the cursor is within mathed.
-               cur.reset(buffer_.inset());
-               tm.setCursorFromCoordinates(cur, 0, last);
-               cur.clearSelection();
+               newy = last;
                break;
        case CUR_INSIDE:
-               int const y = getPos(cur, cur.boundary()).y_;
-               int const newy = min(last, max(y, first));
-               if (y != newy) {
-                       cur.reset(buffer_.inset());
-                       tm.setCursorFromCoordinates(cur, 0, newy);
-               }
+               int const y = getPos(oldcur, oldcur.boundary()).y_;
+               newy = min(last, max(y, first));
+               if (y == newy) 
+                       return;
        }
+       // We reset the cursor because cursorStatus() does not
+       // work when the cursor is within mathed.
+       Cursor cur(*this);
+       cur.reset(buffer_.inset());
+       tm.setCursorFromCoordinates(cur, 0, newy);
+       mouseSetCursor(cur);
 }
 
 
@@ -657,7 +660,7 @@ void BufferView::saveBookmark(unsigned int idx)
        // acturately locate a bookmark in a 'live' lyx session.
        // pit and pos will be updated with bottom level pit/pos
        // when lyx exits.
-       LyX::ref().session().bookmarks().save(
+       theSession().bookmarks().save(
                buffer_.fileName(),
                d->cursor_.bottom().pit(),
                d->cursor_.bottom().pos(),
@@ -796,11 +799,16 @@ void BufferView::showCursor(DocIterator const & dit)
                int ypos = pm.position() + offset;
                Dimension const & row_dim =
                        pm.getRow(cs.pos(), dit.boundary()).dimension();
+               int scrolled = 0;
                if (ypos - row_dim.ascent() < 0)
-                       scrollUp(- ypos + row_dim.ascent());
+                       scrolled = scrollUp(- ypos + row_dim.ascent());
                else if (ypos + row_dim.descent() > height_)
-                       scrollDown(ypos - height_ + row_dim.descent());
+                       scrolled = scrollDown(ypos - height_ + row_dim.descent());
                // else, nothing to do, the cursor is already visible so we just return.
+               if (scrolled != 0) {
+                       updateMetrics();
+                       buffer_.changed();
+               }
                return;
        }
 
@@ -867,6 +875,7 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
        case LFUN_BIBTEX_DATABASE_DEL:
        case LFUN_GRAPHICS_GROUPS_UNIFY:
        case LFUN_NOTES_MUTATE:
+       case LFUN_ALL_INSETS_TOGGLE:
        case LFUN_STATISTICS:
                flag.setEnabled(true);
                break;
@@ -930,7 +939,7 @@ FuncStatus BufferView::getStatus(FuncRequest const & cmd)
                break;
 
        case LFUN_LAYOUT:
-               flag.setEnabled(!cur.inset().forceEmptyLayout(cur.idx()));
+               flag.setEnabled(!cur.inset().forcePlainLayout(cur.idx()));
                break;
 
        case LFUN_LAYOUT_PARAGRAPH:
@@ -1064,9 +1073,12 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                if (!inset || !cur.result().dispatched())
                        cur.dispatch(cmd);
 
+               // FIXME I'm adding the last break to solve a crash,
+               // but that is obviously not right.
                if (!cur.result().dispatched())
                        // It did not work too; no action needed.
                        break;
+               break;
        }
 
        case LFUN_PARAGRAPH_GOTO: {
@@ -1157,6 +1169,8 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                buffer_.text().cursorBottom(d->cursor_);
                // accept everything in a single step to support atomic undo
                buffer_.text().acceptOrRejectChanges(d->cursor_, Text::ACCEPT);
+               // FIXME: Move this LFUN to Buffer so that we don't have to do this:
+               processUpdateFlags(Update::Force | Update::FitCursor);
                break;
 
        case LFUN_ALL_CHANGES_REJECT:
@@ -1167,6 +1181,8 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                // reject everything in a single step to support atomic undo
                // Note: reject does not work recursively; the user may have to repeat the operation
                buffer_.text().acceptOrRejectChanges(d->cursor_, Text::REJECT);
+               // FIXME: Move this LFUN to Buffer so that we don't have to do this:
+               processUpdateFlags(Update::Force | Update::FitCursor);
                break;
 
        case LFUN_WORD_FIND: {
@@ -1352,8 +1368,15 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                        showCursor();
                        p = getPos(cur, cur.boundary());
                }
-               scroll(cmd.action == LFUN_SCREEN_UP? - height_ : height_);
+               int const scrolled = scroll(cmd.action == LFUN_SCREEN_UP
+                       ? - height_ : height_);
+               if (cmd.action == LFUN_SCREEN_UP && scrolled > - height_)
+                       p = Point(0, 0);
+               if (cmd.action == LFUN_SCREEN_DOWN && scrolled < height_)
+                       p = Point(width_, height_);
                cur.reset(buffer_.inset());
+               updateMetrics();
+               buffer_.changed();
                d->text_metrics_[&buffer_.text()].editXY(cur, p.x_, p.y_);
                //FIXME: what to do with cur.x_target()?
                cur.finishUndo();
@@ -1404,7 +1427,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                processUpdateFlags(Update::Force);
                break;
 
-       // These Two could be rewriten using some command like forall <insetname> <command>
+       // These two could be rewriten using some command like forall <insetname> <command>
        // once the insets refactoring is done.
        case LFUN_GRAPHICS_GROUPS_UNIFY: {
                if (cmd.argument().empty())
@@ -1426,6 +1449,29 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                break;
        }
 
+       case LFUN_ALL_INSETS_TOGGLE: {
+               string action;
+               string const name = split(to_utf8(cmd.argument()), action, ' ');
+               InsetCode const inset_code = insetCode(name);
+
+               FuncRequest fr(LFUN_INSET_TOGGLE, action);
+
+               Inset & inset = cur.buffer().inset();
+               InsetIterator it  = inset_iterator_begin(inset);
+               InsetIterator const end = inset_iterator_end(inset);
+               for (; it != end; ++it) {
+                       if (it->asInsetCollapsable()
+                           && (inset_code == NO_CODE
+                           || inset_code == it->lyxCode())) {
+                               Cursor tmpcur = cur;
+                               tmpcur.pushBackward(*it);
+                               it->dispatch(tmpcur, fr);
+                       }
+               }
+               processUpdateFlags(Update::Force | Update::FitCursor);
+               break;
+       }
+
        default:
                return false;
        }
@@ -1438,11 +1484,13 @@ docstring const BufferView::requestSelection()
 {
        Cursor & cur = d->cursor_;
 
+       LYXERR(Debug::SELECTION, "requestSelection: cur.selection: " << cur.selection());
        if (!cur.selection()) {
                d->xsel_cache_.set = false;
                return docstring();
        }
 
+       LYXERR(Debug::SELECTION, "requestSelection: xsel_cache.set: " << d->xsel_cache_.set);
        if (!d->xsel_cache_.set ||
            cur.top() != d->xsel_cache_.cursor ||
            cur.anchor_.top() != d->xsel_cache_.anchor)
@@ -1618,19 +1666,22 @@ void BufferView::lfunScroll(FuncRequest const & cmd)
                if (scroll_value)
                        scroll(scroll_step * scroll_value);
        }
+       updateMetrics();
+       buffer_.changed();
 }
 
 
-void BufferView::scroll(int y)
+int BufferView::scroll(int y)
 {
        if (y > 0)
-               scrollDown(y);
-       else if (y < 0)
-               scrollUp(-y);
+               return scrollDown(y);
+       if (y < 0)
+               return scrollUp(-y);
+       return 0;
 }
 
 
-void BufferView::scrollDown(int offset)
+int BufferView::scrollDown(int offset)
 {
        Text * text = &buffer_.text();
        TextMetrics & tm = d->text_metrics_[text];
@@ -1640,7 +1691,7 @@ void BufferView::scrollDown(int offset)
                int bottom_pos = last.second->position() + last.second->descent();
                if (last.first + 1 == int(text->paragraphs().size())) {
                        if (bottom_pos <= height_)
-                               return;
+                               return 0;
                        offset = min(offset, bottom_pos - height_);
                        break;
                }
@@ -1649,12 +1700,11 @@ void BufferView::scrollDown(int offset)
                tm.newParMetricsDown();
        }
        d->anchor_ypos_ -= offset;
-       updateMetrics();
-       buffer_.changed();
+       return -offset;
 }
 
 
-void BufferView::scrollUp(int offset)
+int BufferView::scrollUp(int offset)
 {
        Text * text = &buffer_.text();
        TextMetrics & tm = d->text_metrics_[text];
@@ -1664,7 +1714,7 @@ void BufferView::scrollUp(int offset)
                int top_pos = first.second->position() - first.second->ascent();
                if (first.first == 0) {
                        if (top_pos >= 0)
-                               return;
+                               return 0;
                        offset = min(offset, - top_pos);
                        break;
                }
@@ -1673,8 +1723,7 @@ void BufferView::scrollUp(int offset)
                tm.newParMetricsUp();
        }
        d->anchor_ypos_ += offset;
-       updateMetrics();
-       buffer_.changed();
+       return offset;
 }