]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView.cpp
Micro-optimization.
[lyx.git] / src / BufferView.cpp
index 330daa786fadc0a7697dbd509f97d856b0c09ff9..1e0f4b249dac13f86c04cf4d2f22f7a49dae9df8 100644 (file)
@@ -39,7 +39,6 @@
 #include "LyX.h"
 #include "LyXAction.h"
 #include "lyxfind.h"
-#include "LyXFunc.h"
 #include "Layout.h"
 #include "LyXRC.h"
 #include "MetricsInfo.h"
@@ -913,7 +912,7 @@ void BufferView::updateLayout(DocumentClass const * const oldlayout)
        setCursor(backcur.asDocIterator(&buffer_));
 
        buffer_.errors("Class Switch");
-       buffer_.updateLabels();
+       buffer_.updateBuffer();
 }
 
 /** Return the change status at cursor position, taking in account the
@@ -1024,11 +1023,6 @@ bool BufferView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
                flag.setEnabled(true);
                break;
 
-       case LFUN_REGEXP_MODE:
-               // FIXME: Test if current WorkArea is the search WorkArea
-               flag.setEnabled(buffer().isInternal() && !cur.inRegexped());
-               break;
-
        case LFUN_LABEL_COPY_AS_REF: {
                // if there is an inset at cursor, see whether it
                // handles the lfun
@@ -1148,7 +1142,7 @@ void BufferView::editInset(string const & name, Inset * inset)
 }
 
 
-bool BufferView::dispatch(FuncRequest const & cmd)
+void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
 {
        //lyxerr << [ cmd = " << cmd << "]" << endl;
 
@@ -1165,7 +1159,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
        // Don't dispatch function that does not apply to internal buffers.
        if (buffer_.isInternal() 
            && lyxaction.funcHasFlag(cmd.action, LyXAction::NoInternal))
-               return false;
+               return;
 
        // We'll set this back to false if need be.
        bool dispatched = true;
@@ -1190,7 +1184,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                // We are most certainly here because of a change in the document
                // It is then better to make sure that all dialogs are in sync with
                // current document settings.
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
        }
                
@@ -1201,7 +1195,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                buffer_.params().clearLayoutModules();
                buffer_.params().makeDocumentClass();
                updateLayout(oldClass);
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
        }
 
@@ -1218,7 +1212,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                buffer_.params().addLayoutModule(argument);
                buffer_.params().makeDocumentClass();
                updateLayout(oldClass);
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
        }
 
@@ -1241,7 +1235,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                buffer_.params().setBaseClass(argument);
                buffer_.params().makeDocumentClass();
                updateLayout(oldDocClass);
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
        }
 
@@ -1257,30 +1251,30 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                buffer_.params().setBaseClass(bc);
                buffer_.params().makeDocumentClass();
                updateLayout(oldClass);
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
        }
 
        case LFUN_UNDO:
-               cur.message(_("Undo"));
+               dr.setMessage(_("Undo"));
                cur.clearSelection();
                if (!cur.textUndo())
-                       cur.message(_("No further undo information"));
+                       dr.setMessage(_("No further undo information"));
                else
-                       processUpdateFlags(Update::Force | Update::FitCursor);
+                       dr.update(Update::Force | Update::FitCursor);
                break;
 
        case LFUN_REDO:
-               cur.message(_("Redo"));
+               dr.setMessage(_("Redo"));
                cur.clearSelection();
                if (!cur.textRedo())
-                       cur.message(_("No further redo information"));
+                       dr.setMessage(_("No further redo information"));
                else
-                       processUpdateFlags(Update::Force | Update::FitCursor);
+                       dr.update(Update::Force | Update::FitCursor);
                break;
 
        case LFUN_FONT_STATE:
-               cur.message(cur.currentState());
+               dr.setMessage(cur.currentState());
                break;
 
        case LFUN_BOOKMARK_SAVE:
@@ -1343,12 +1337,12 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                                // Set the cursor
                                dit.pos() = pos;
                                setCursor(dit);
-                               processUpdateFlags(Update::Force | Update::FitCursor);
+                               dr.update(Update::Force | Update::FitCursor);
                        } else {
                                // Switch to other buffer view and resend cmd
-                               theLyXFunc().dispatch(FuncRequest(
+                               lyx::dispatch(FuncRequest(
                                        LFUN_BUFFER_SWITCH, b->absFileName()));
-                               theLyXFunc().dispatch(cmd);
+                               lyx::dispatch(cmd);
                        }
                        break;
                }
@@ -1397,18 +1391,18 @@ bool BufferView::dispatch(FuncRequest const & cmd)
        case LFUN_CHANGE_NEXT:
                findNextChange(this);
                // FIXME: Move this LFUN to Buffer so that we don't have to do this:
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
        
        case LFUN_CHANGE_PREVIOUS:
                findPreviousChange(this);
                // FIXME: Move this LFUN to Buffer so that we don't have to do this:
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
 
        case LFUN_CHANGES_MERGE:
                if (findNextChange(this) || findPreviousChange(this)) {
-                       processUpdateFlags(Update::Force | Update::FitCursor);
+                       dr.update(Update::Force | Update::FitCursor);
                        showDialog("changes");
                }
                break;
@@ -1421,7 +1415,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                // accept everything in a single step to support atomic undo
                buffer_.text().acceptOrRejectChanges(cur, Text::ACCEPT);
                // FIXME: Move this LFUN to Buffer so that we don't have to do this:
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
 
        case LFUN_ALL_CHANGES_REJECT:
@@ -1433,7 +1427,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                // Note: reject does not work recursively; the user may have to repeat the operation
                buffer_.text().acceptOrRejectChanges(cur, Text::REJECT);
                // FIXME: Move this LFUN to Buffer so that we don't have to do this:
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
 
        case LFUN_WORD_FIND_FORWARD:
@@ -1463,7 +1457,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                if (cmd.argument().empty() && !d->search_request_cache_.argument().empty())
                        req = d->search_request_cache_;
                if (req.argument().empty()) {
-                       theLyXFunc().dispatch(FuncRequest(LFUN_DIALOG_SHOW, "findreplace"));
+                       lyx::dispatch(FuncRequest(LFUN_DIALOG_SHOW, "findreplace"));
                        break;
                }
                if (find(this, req))
@@ -1504,23 +1498,23 @@ bool BufferView::dispatch(FuncRequest const & cmd)
 
        case LFUN_MARK_OFF:
                cur.clearSelection();
-               cur.message(from_utf8(N_("Mark off")));
+               dr.setMessage(from_utf8(N_("Mark off")));
                break;
 
        case LFUN_MARK_ON:
                cur.clearSelection();
                cur.setMark(true);
-               cur.message(from_utf8(N_("Mark on")));
+               dr.setMessage(from_utf8(N_("Mark on")));
                break;
 
        case LFUN_MARK_TOGGLE:
                cur.setSelection(false);
                if (cur.mark()) {
                        cur.setMark(false);
-                       cur.message(from_utf8(N_("Mark removed")));
+                       dr.setMessage(from_utf8(N_("Mark removed")));
                } else {
                        cur.setMark(true);
-                       cur.message(from_utf8(N_("Mark set")));
+                       dr.setMessage(from_utf8(N_("Mark set")));
                }
                cur.resetAnchor();
                break;
@@ -1614,7 +1608,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                        // It did not work too; no action needed.
                        break;
                cur.clearSelection();
-               processUpdateFlags(Update::SinglePar | Update::FitCursor);
+               dr.update(Update::SinglePar | Update::FitCursor);
                break;
        }
 
@@ -1644,7 +1638,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                bool update = in_texted && cur.bv().checkDepm(cur, old);
                cur.finishUndo();
                if (update)
-                       processUpdateFlags(Update::Force | Update::FitCursor);
+                       dr.update(Update::Force | Update::FitCursor);
                break;
        }
 
@@ -1665,7 +1659,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                        y = getPos(cur, cur.boundary()).y_;
 
                cur.finishUndo();
-               processUpdateFlags(Update::SinglePar | Update::FitCursor);
+               dr.update(Update::SinglePar | Update::FitCursor);
                break;
        }
 
@@ -1682,7 +1676,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                        y = getPos(cur, cur.boundary()).y_;
 
                cur.finishUndo();
-               processUpdateFlags(Update::SinglePar | Update::FitCursor);
+               dr.update(Update::SinglePar | Update::FitCursor);
                break;
        }
 
@@ -1725,12 +1719,13 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                cur.endUndoGroup();
                cur = savecur;
                cur.fixIfBroken();
-               processUpdateFlags(Update::Force);
+               dr.update(Update::Force);
 
-               if (iterations >= max_iter)
-                       cur.errorMessage(bformat(_("`inset-forall' interrupted because number of actions is larger than %1$d"), max_iter));
-               else
-                       cur.message(bformat(_("Applied \"%1$s\" to %2$d insets"), from_utf8(commandstr), iterations));
+               if (iterations >= max_iter) {
+                       dr.setError(true);
+                       dr.setMessage(bformat(_("`inset-forall' interrupted because number of actions is larger than %1$d"), max_iter));
+               } else
+                       dr.setMessage(bformat(_("Applied \"%1$s\" to %2$d insets"), from_utf8(commandstr), iterations));
                break;
        }
 
@@ -1754,7 +1749,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                                it->dispatch(tmpcur, fr);
                        }
                }
-               processUpdateFlags(Update::Force | Update::FitCursor);
+               dr.update(Update::Force | Update::FitCursor);
                break;
        }
 
@@ -1842,7 +1837,7 @@ bool BufferView::dispatch(FuncRequest const & cmd)
                cur.recordUndo();
                FuncRequest fr(LFUN_INSET_MODIFY, cmd.argument());
                inset->dispatch(cur, fr);
-               processUpdateFlags(Update::SinglePar | Update::FitCursor);
+               dr.update(Update::SinglePar | Update::FitCursor);
                break;
        }
 
@@ -1852,7 +1847,8 @@ bool BufferView::dispatch(FuncRequest const & cmd)
        }
 
        buffer_.undo().endUndoGroup();
-       return dispatched;
+       dr.dispatched(dispatched);
+       return;
 }
 
 
@@ -2163,7 +2159,7 @@ void BufferView::gotoLabel(docstring const & label)
                TocIterator end = toc.end();
                for (; toc_it != end; ++toc_it) {
                        if (label == toc_it->str()) {
-                               dispatch(toc_it->action());
+                               lyx::dispatch(toc_it->action());
                                return;
                        }
                }
@@ -2231,7 +2227,7 @@ bool BufferView::checkDepm(Cursor & cur, Cursor & old)
 
        d->cursor_ = cur;
 
-       buffer_.updateLabels();
+       buffer_.updateBuffer();
        buffer_.changed(true);
        return true;
 }