]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView.C
fixes because of SUN CC warnings, bmtable now compiled with C compilator, countChar...
[lyx.git] / src / BufferView.C
index 9222ed91412f104402ec4503c2330b5488251ec0..c6ab81144be94ff7c440c77d47d32fa159d5c916 100644 (file)
@@ -1,21 +1,24 @@
 // -*- C++ -*-
 /* This file is part of
-* ======================================================
-* 
-*           LyX, The Document Processor
-*        
-*           Copyright (C) 1995 Matthias Ettrich
-*           Copyright (C) 1995-1998 The LyX Team.
-*
-*======================================================*/
+ * ====================================================== 
+ 
+ *           LyX, The Document Processor
+ *        
+ *           Copyright 1995 Matthias Ettrich
+ *           Copyright 1995-1999 The LyX Team.
+ *
+ * ====================================================== */
 
 #include <config.h>
 
-#include <stdlib.h>
+#include <cstdlib>
+#include <csignal>
+
 #include <unistd.h>
-#include <signal.h>
 #include <sys/wait.h>
 
+#include "support/lstrings.h"
+
 #ifdef __GNUG__
 #pragma implementation
 #endif
 #include "lyxscreen.h"
 #include "up.xpm"
 #include "down.xpm"
-#include "error.h"
+#include "debug.h"
 #include "lyxdraw.h"
 #include "lyx_gui_misc.h"
 #include "BackStack.h"
 #include "lyxtext.h"
 #include "lyx_cb.h"
 #include "gettext.h"
-
-//     $Id: BufferView.C,v 1.2 1999/10/02 14:01:03 larsbj Exp $        
-
-#if !defined(lint) && !defined(WITH_WARNINGS)
-static char vcid[] = "$Id: BufferView.C,v 1.2 1999/10/02 14:01:03 larsbj Exp $";
-#endif /* lint */
+#include "layout.h"
 
 extern BufferList bufferlist;
-void sigchldhandler(pid_t pid, int *status);
+void sigchldhandler(pid_t pid, int * status);
 
 extern void SetXtermCursor(Window win);
 extern bool input_prohibited;
 extern bool selection_possible;
 extern void BeforeChange();
 extern char ascii_type;
-extern int UnlockInset(UpdatableInset* inset);
+extern int UnlockInset(UpdatableInset * inset);
 extern void ToggleFloat();
 extern void MenuPasteSelection(char at);
-extern InsetUpdateStruct *InsetUpdateList;
+extern InsetUpdateStruct * InsetUpdateList;
 extern void UpdateInsetUpdateList();
+extern void FreeUpdateTimer();
 
 // This is _very_ temporary
-FL_OBJECT *figinset_canvas;
+FL_OBJECT * figinset_canvas;
 
-BufferView::BufferView(LyXView *o, int xpos, int ypos,
+BufferView::BufferView(LyXView * o, int xpos, int ypos,
                       int width, int height)
-       : _owner(o)
+       : owner_(o)
 {
-       _buffer = 0;
-       
+       buffer_ = 0;
+       text = 0;
        screen = 0;
        work_area = 0;
        figinset_canvas = 0;
@@ -78,48 +77,50 @@ BufferView::BufferView(LyXView *o, int xpos, int ypos,
        create_view(xpos, ypos, width, height);
        // Activate the timer for the cursor 
        fl_set_timer(timer_cursor, 0.4);
-       fl_set_focus_object(_owner->getForm(), work_area);
+       fl_set_focus_object(owner_->getForm(), work_area);
        work_area_focus = true;
        lyx_focus = false;
-        backstack = new BackStack(16);
 }
 
 
 BufferView::~BufferView()
 {
-       delete backstack;
-}   
+       delete text;
+}
 
 
-void BufferView::setBuffer(Buffer *b)
+void BufferView::buffer(Buffer * b)
 {
-       lyxerr.debug("Setting buffer in BufferView");
-       if (_buffer) {
-               _buffer->InsetSleep();
-               _buffer->delUser(this);
+       lyxerr[Debug::INFO] << "Setting buffer in BufferView" << endl;
+       if (buffer_) {
+               buffer_->InsetSleep();
+               buffer_->delUser(this);
+               delete text;
+               text = 0;
        }
 
        // Set current buffer
-       _buffer = b;
+       buffer_ = b;
 
        if (bufferlist.getState() == BufferList::CLOSING) return;
        
        // Nuke old image
+       // screen is always deleted when the buffer is changed.
        if (screen)
                delete screen;
        screen = 0;
 
        // If we are closing the buffer, use the first buffer as current
-       if (!_buffer) {
-               _buffer = bufferlist.first();
+       if (!buffer_) {
+               buffer_ = bufferlist.first();
        }
 
-       if (_buffer) {
-               lyxerr.debug(LString("  Buffer addr: ") + PTR_AS_INT(_buffer));
-               _buffer->addUser(this);
-               _owner->getMenus()->showMenus();
+       if (buffer_) {
+               lyxerr[Debug::INFO] << "  Buffer addr: " << buffer_ << endl;
+               buffer_->addUser(this);
+               owner_->getMenus()->showMenus();
                // If we don't have a text object for this, we make one
-               if (_buffer->text == 0)
+               if (text == 0)
                        resizeCurrentBuffer();
                else {
                        updateScreen();
@@ -128,18 +129,17 @@ void BufferView::setBuffer(Buffer *b)
                screen->first = screen->TopCursorVisible();
                redraw();
                updateAllVisibleBufferRelatedPopups();
-               _buffer->InsetWakeup();
+               buffer_->InsetWakeup();
        } else {
-               lyxerr.debug("  No Buffer!");
-               _owner->getMenus()->hideMenus();
-               //workAreaExpose();
+               lyxerr[Debug::INFO] << "  No Buffer!" << endl;
+               owner_->getMenus()->hideMenus();
                updateScrollbar();
                fl_redraw_object(work_area);
        }
        // should update layoutchoice even if we don't have a buffer.
-       _owner->updateLayoutChoice();
-       _owner->getMiniBuffer()->Init();
-       _owner->updateWindowTitle();
+       owner_->updateLayoutChoice();
+       owner_->getMiniBuffer()->Init();
+       owner_->updateWindowTitle();
 }
 
 
@@ -153,14 +153,14 @@ void BufferView::updateScreen()
                               work_area->h,
                               work_area->x,
                               work_area->y,
-                              _buffer->text);
+                              text);
 }
 
 
 void BufferView::resize()
 {
        // This will resize the buffer. (Asger)
-       if (_buffer)
+       if (buffer_)
                resizeCurrentBuffer();
 }
 
@@ -169,7 +169,7 @@ static bool lgb_hack = false;
 
 void BufferView::redraw()
 {
-       lyxerr.debug("BufferView::redraw()");
+       lyxerr[Debug::INFO] << "BufferView::redraw()" << endl;
        lgb_hack = true;
        fl_redraw_object(work_area);
        fl_redraw_object(scrollbar);
@@ -197,7 +197,7 @@ void BufferView::updateScrollbar()
         * maximum must be the working area height. No scrolling will 
         * be possible */
 
-       if (!_buffer) {
+       if (!buffer_) {
                fl_set_slider_value(scrollbar, 0);
                fl_set_slider_size(scrollbar, scrollbar->h);
                return;
@@ -209,8 +209,8 @@ void BufferView::updateScrollbar()
        long cbth = 0;
        long cbsf = 0;
 
-       if (_buffer->text)
-               cbth = _buffer->text->height;
+       if (text)
+               cbth = text->height;
        if (screen)
                cbsf = screen->first;
 
@@ -229,10 +229,10 @@ void BufferView::updateScrollbar()
                return;
        }
        
-       long maximum_height = work_area->h * 3/4 + cbth;
+       long maximum_height = work_area->h * 3 / 4 + cbth;
        long value = cbsf;
 
-       /* set the scrollbar */
+       // set the scrollbar
        double hfloat = work_area->h;
        double maxfloat = maximum_height;
    
@@ -240,16 +240,16 @@ void BufferView::updateScrollbar()
        fl_set_slider_bounds(scrollbar, 0,
                             maximum_height - work_area->h);
 #if FL_REVISION > 85
-       double lineh = _buffer->text->DefaultHeight();
-       fl_set_slider_increment(scrollbar,work_area->h-lineh,lineh);
+       double lineh = text->DefaultHeight();
+       fl_set_slider_increment(scrollbar, work_area->h-lineh, lineh);
 #endif
-       if (maxfloat>0){
-               if ((hfloat/maxfloat) * (float) height2 < 3)
+       if (maxfloat > 0){
+               if ((hfloat / maxfloat) * float(height2) < 3)
                        fl_set_slider_size(scrollbar,
-                                          3/(float)height2);
+                                          3 / float(height2));
                else
                        fl_set_slider_size(scrollbar,
-                                          hfloat/maxfloat);
+                                          hfloat / maxfloat);
        } else
                fl_set_slider_size(scrollbar, hfloat);
        fl_set_slider_precision(scrollbar, 0);
@@ -258,21 +258,21 @@ void BufferView::updateScrollbar()
 
 void BufferView::redoCurrentBuffer()
 {
-       lyxerr.debug("BufferView::redoCurrentBuffer");
-       if (_buffer && _buffer->text) {
+       lyxerr[Debug::INFO] << "BufferView::redoCurrentBuffer" << endl;
+       if (buffer_ && text) {
                resize();
-               _owner->updateLayoutChoice();
+               owner_->updateLayoutChoice();
        }
 }
 
 
 int BufferView::resizeCurrentBuffer()
 {
-       lyxerr.debug("resizeCurrentBuffer");
+       lyxerr[Debug::INFO] << "resizeCurrentBuffer" << endl;
        
-       LyXParagraph *par = 0;
-       LyXParagraph *selstartpar = 0;
-       LyXParagraph *selendpar = 0;
+       LyXParagraph * par = 0;
+       LyXParagraph * selstartpar = 0;
+       LyXParagraph * selendpar = 0;
        int pos = 0;
        int selstartpos = 0;
        int selendpos = 0;
@@ -281,41 +281,38 @@ int BufferView::resizeCurrentBuffer()
 
        ProhibitInput();
 
-       _owner->getMiniBuffer()->Set(_("Formatting document..."));   
-
-       if (_buffer->text) {
-               par = _buffer->text->cursor.par;
-               pos = _buffer->text->cursor.pos;
-               selstartpar = _buffer->text->sel_start_cursor.par;
-               selstartpos = _buffer->text->sel_start_cursor.pos;
-               selendpar = _buffer->text->sel_end_cursor.par;
-               selendpos = _buffer->text->sel_end_cursor.pos;
-               selection = _buffer->text->selection;
-               mark_set = _buffer->text->mark_set;
-               delete _buffer->text;
+       owner_->getMiniBuffer()->Set(_("Formatting document..."));   
+
+       if (text) {
+               par = text->cursor.par;
+               pos = text->cursor.pos;
+               selstartpar = text->sel_start_cursor.par;
+               selstartpos = text->sel_start_cursor.pos;
+               selendpar = text->sel_end_cursor.par;
+               selendpos = text->sel_end_cursor.pos;
+               selection = text->selection;
+               mark_set = text->mark_set;
+               delete text;
        }
-       _buffer->text = new LyXText(work_area->w, _buffer);
+       text = new LyXText(work_area->w, buffer_);
 
        updateScreen();
-   
+
        if (par) {
-               _buffer->text->selection = true;
-               /* at this point just
-                * to avoid the Delete-
-                * Empty-Paragraph
-                * Mechanism when
-                * setting the cursor */
-               _buffer->text->mark_set = mark_set;
+               text->selection = true;
+               /* at this point just to avoid the Delete-Empty-Paragraph
+                * Mechanism when setting the cursor */
+               text->mark_set = mark_set;
                if (selection) {
-                       _buffer->text->SetCursor(selstartpar, selstartpos);
-                       _buffer->text->sel_cursor = _buffer->text->cursor;
-                       _buffer->text->SetCursor(selendpar, selendpos);
-                       _buffer->text->SetSelection();
-                       _buffer->text->SetCursor(par, pos);
+                       text->SetCursor(selstartpar, selstartpos);
+                       text->sel_cursor = text->cursor;
+                       text->SetCursor(selendpar, selendpos);
+                       text->SetSelection();
+                       text->SetCursor(par, pos);
                } else {
-                       _buffer->text->SetCursor(par, pos);
-                       _buffer->text->sel_cursor = _buffer->text->cursor;
-                       _buffer->text->selection = false;
+                       text->SetCursor(par, pos);
+                       text->sel_cursor = text->cursor;
+                       text->selection = false;
                }
        }
        screen->first = screen->TopCursorVisible(); /* this will scroll the
@@ -324,11 +321,11 @@ int BufferView::resizeCurrentBuffer()
                                                     * visible */ 
        updateScrollbar();
        redraw();
-       _owner->getMiniBuffer()->Init();
+       owner_->getMiniBuffer()->Init();
        AllowInput();
 
        // Now if the title form still exist kill it
-       TimerCB(0,0);
+       TimerCB(0, 0);
 
        return 0;
 }
@@ -341,65 +338,99 @@ void BufferView::gotoError()
    
        screen->HideCursor();
        BeforeChange();
-       _buffer->update(-2);
+       update(-2);
        LyXCursor tmp;
-   
-       if (!_buffer->text->GotoNextError()) {
-               if (_buffer->text->cursor.pos 
-                   || _buffer->text->cursor.par !=
-                   _buffer->text->FirstParagraph()) {
-                       tmp = _buffer->text->cursor;
-                       _buffer->text->cursor.par =
-                               _buffer->text->FirstParagraph();
-                       _buffer->text->cursor.pos = 0;
-                       if (!_buffer->text->GotoNextError()) {
-                               _buffer->text->cursor = tmp;
-                               _owner->getMiniBuffer()->Set(_("No more errors"));
+
+       if (!text->GotoNextError()) {
+               if (text->cursor.pos 
+                   || text->cursor.par != text->FirstParagraph()) {
+                       tmp = text->cursor;
+                       text->cursor.par = text->FirstParagraph();
+                       text->cursor.pos = 0;
+                       if (!text->GotoNextError()) {
+                               text->cursor = tmp;
+                               owner_->getMiniBuffer()
+                                       ->Set(_("No more errors"));
                                LyXBell();
                        }
                } else {
-                       _owner->getMiniBuffer()->Set(_("No more errors"));
+                       owner_->getMiniBuffer()->Set(_("No more errors"));
                        LyXBell();
                }
        }
-       _buffer->update(0);
-       _buffer->text->sel_cursor =
-               _buffer->text->cursor;
+       update(0);
+       text->sel_cursor = text->cursor;
+}
+
+
+extern "C" {
+// Just a bunch of C wrappers around static members of BufferView
+       void C_BufferView_UpCB(FL_OBJECT * ob, long buf)
+       {
+               BufferView::UpCB(ob, buf);
+       }
+
+
+       void C_BufferView_DownCB(FL_OBJECT * ob, long buf)
+       {
+               BufferView::DownCB(ob, buf);
+       }
+
+
+       void C_BufferView_ScrollCB(FL_OBJECT * ob, long buf)
+       {
+               BufferView::ScrollCB(ob, buf);
+       }
+
+
+       void C_BufferView_CursorToggleCB(FL_OBJECT * ob, long buf)
+       {
+               BufferView::CursorToggleCB(ob, buf);
+       }
+
+
+       int C_BufferView_work_area_handler(FL_OBJECT * ob, int event,
+                                          FL_Coord, FL_Coord, 
+                                          int key, void * xev)
+       {
+               return BufferView::work_area_handler(ob, event,
+                                                    0, 0, key, xev);
+       }
 }
 
 
 void BufferView::create_view(int xpos, int ypos, int width, int height)
 {
-       FL_OBJECT *obj;
-       const int bw = abs(fl_get_border_width());
+       FL_OBJECT * obj;
+       int const bw = abs(fl_get_border_width());
 
        // a hack for the figinsets (Matthias)
        // This one first, then it will probably be invisible. (Lgb)
-       ::figinset_canvas = figinset_canvas = obj =
-               fl_add_canvas(FL_NORMAL_CANVAS,
-                             xpos + 1,
-                             ypos + 1,1,1,"");
-       fl_set_object_boxtype(obj,FL_NO_BOX);
+       ::figinset_canvas = figinset_canvas = obj = 
+                 fl_add_canvas(FL_NORMAL_CANVAS,
+                               xpos + 1,
+                               ypos + 1, 1, 1, "");
+       fl_set_object_boxtype(obj, FL_NO_BOX);
        fl_set_object_resize(obj, FL_RESIZE_ALL);
        fl_set_object_gravity(obj, NorthWestGravity, NorthWestGravity);
 
        // a box
        obj = fl_add_box(FL_BORDER_BOX, xpos, ypos,
                         width - 15,
-                        height,"");
+                        height, "");
        fl_set_object_resize(obj, FL_RESIZE_ALL);
        fl_set_object_gravity(obj, NorthWestGravity, SouthEastGravity);
 
        // the free object
        work_area = obj = fl_add_free(FL_INPUT_FREE,
-                                     xpos +bw, ypos+bw,
-                                     width-15-2*bw /* scrollbarwidth */,
-                                     height-2*bw,"",
-                                     work_area_handler);
+                                     xpos + bw, ypos + bw,
+                                     width - 15 - 2 * bw /* scrollbarwidth */,
+                                     height - 2 * bw, "",
+                                     C_BufferView_work_area_handler);
        obj->wantkey = FL_KEY_TAB;
-       obj->u_vdata = (void*) this; /* This is how we pass the BufferView
-                                      to the work_area_handler. */
-       fl_set_object_boxtype(obj,FL_DOWN_BOX);
+       obj->u_vdata = this; /* This is how we pass the BufferView
+                               to the work_area_handler. */
+       fl_set_object_boxtype(obj, FL_DOWN_BOX);
        fl_set_object_resize(obj, FL_RESIZE_ALL);
        fl_set_object_gravity(obj, NorthWestGravity, SouthEastGravity);
 
@@ -414,32 +445,34 @@ void BufferView::create_view(int xpos, int ypos, int width, int height)
        fl_set_border_width(-2); // to get visible feedback
 #endif
        button_up = obj = fl_add_pixmapbutton(FL_TOUCH_BUTTON,
-                                             width-15+4*bw,
+                                             width - 15 + 4 * bw,
                                              ypos,
-                                             15,15,"");
-       fl_set_object_boxtype(obj,FL_UP_BOX);
-       fl_set_object_color(obj,FL_MCOL,FL_BLUE);
+                                             15, 15, "");
+       fl_set_object_boxtype(obj, FL_UP_BOX);
+       fl_set_object_color(obj, FL_MCOL, FL_BLUE);
        fl_set_object_resize(obj, FL_RESIZE_ALL);
-       fl_set_object_gravity(obj,NorthEastGravity, NorthEastGravity);
-       fl_set_object_callback(obj,UpCB,(long)this);
-       fl_set_pixmapbutton_data(obj, up_xpm);
+       fl_set_object_gravity(obj, NorthEastGravity, NorthEastGravity);
+       fl_set_object_callback(obj, C_BufferView_UpCB, 0);
+       obj->u_vdata = this;
+       fl_set_pixmapbutton_data(obj, const_cast<char**>(up_xpm));
 
-#if FL_REVISION >85
+#if FL_REVISION > 85
        // Remove the blue feedback rectangle
-       fl_set_pixmapbutton_focus_outline(obj,0);
+       fl_set_pixmapbutton_focus_outline(obj, 0);
 #endif 
 
        // the scrollbar slider
        fl_set_border_width(-bw);
        scrollbar = obj = fl_add_slider(FL_VERT_SLIDER,
-                                       width-15+4*bw,
+                                       width - 15 + 4 * bw,
                                        ypos + 15,
-                                       15,height-30,"");
-       fl_set_object_color(obj,FL_COL1,FL_MCOL);
+                                       15, height - 30, "");
+       fl_set_object_color(obj, FL_COL1, FL_MCOL);
        fl_set_object_boxtype(obj, FL_UP_BOX);
        fl_set_object_resize(obj, FL_RESIZE_ALL);
        fl_set_object_gravity(obj, NorthEastGravity, SouthEastGravity);
-       fl_set_object_callback(obj,ScrollCB,(long)this);
+       fl_set_object_callback(obj, C_BufferView_ScrollCB, 0);
+       obj->u_vdata = this;
        
        // down - scrollbar button
 #if FL_REVISION > 85
@@ -448,20 +481,21 @@ void BufferView::create_view(int xpos, int ypos, int width, int height)
        fl_set_border_width(-2); // to get visible feedback
 #endif
        button_down = obj = fl_add_pixmapbutton(FL_TOUCH_BUTTON,
-                                                     width-15+4*bw,
-                                                     ypos + height-15,
-                                                     15,15,"");
-       fl_set_object_boxtype(obj,FL_UP_BOX);
-       fl_set_object_color(obj,FL_MCOL,FL_BLUE);
+                                               width - 15 + 4 * bw,
+                                               ypos + height - 15,
+                                               15, 15, "");
+       fl_set_object_boxtype(obj, FL_UP_BOX);
+       fl_set_object_color(obj, FL_MCOL, FL_BLUE);
        fl_set_object_resize(obj, FL_RESIZE_ALL);
        fl_set_object_gravity(obj, SouthEastGravity, SouthEastGravity);
-       fl_set_object_callback(obj,DownCB,(long)this);
-       fl_set_pixmapbutton_data(obj, down_xpm);
+       fl_set_object_callback(obj, C_BufferView_DownCB, 0);
+       obj->u_vdata = this;
+       fl_set_pixmapbutton_data(obj, const_cast<char**>(down_xpm));
        fl_set_border_width(-bw);
 
-#if FL_REVISION >85
+#if FL_REVISION > 85
        // Remove the blue feedback rectangle
-       fl_set_pixmapbutton_focus_outline(obj,0);
+       fl_set_pixmapbutton_focus_outline(obj, 0);
 #endif 
 
        //
@@ -470,22 +504,21 @@ void BufferView::create_view(int xpos, int ypos, int width, int height)
        
        // timer_cursor
        timer_cursor = obj = fl_add_timer(FL_HIDDEN_TIMER,
-                                         0,0,0,0,"Timer");
-       fl_set_object_callback(obj,CursorToggleCB,0);
-       obj->u_vdata = (void*) this;
+                                         0, 0, 0, 0, "Timer");
+       fl_set_object_callback(obj, C_BufferView_CursorToggleCB, 0);
+       obj->u_vdata = this;
 }
 
 
 // Callback for scrollbar up button
-void BufferView::UpCB(FL_OBJECT *ob, long buf)
+void BufferView::UpCB(FL_OBJECT * ob, long)
 {
-       BufferView *view = (BufferView*) buf;
+       BufferView * view = static_cast<BufferView*>(ob->u_vdata);
        
-       if (view->_buffer == 0) return;
+       if (view->buffer_ == 0) return;
 
-       const XEvent*ev2;
        static long time = 0;
-       ev2 = fl_last_event();
+       XEvent const * ev2 = fl_last_event();
        if (ev2->type == ButtonPress || ev2->type == ButtonRelease) 
                time = 0;
        int button = fl_get_button_numb(ob);
@@ -503,6 +536,7 @@ void BufferView::UpCB(FL_OBJECT *ob, long buf)
 static
 void waitForX()
 {
+#if 0
        static Window w = 0;
        static Atom a = 0;
        if (!a)
@@ -520,20 +554,23 @@ void waitForX()
        }
        static XEvent ev;
        XChangeProperty(fl_display, w, a, a, 8,
-                       PropModeAppend, (unsigned char *)"", 0);
+                       PropModeAppend,
+                       reinterpret_cast<unsigned char*>(""), 0);
        XWindowEvent(fl_display, w, PropertyChangeMask, &ev);
+#endif
+       XSync(fl_get_display(), 0);
 }
 
 
 // Callback for scrollbar slider
-void BufferView::ScrollCB(FL_OBJECT *ob, long buf)
+void BufferView::ScrollCB(FL_OBJECT * ob, long)
 {
-       BufferView *view = (BufferView*) buf;
+       BufferView * view = static_cast<BufferView*>(ob->u_vdata);
        extern bool cursor_follows_scrollbar;
        
-       if (view->_buffer == 0) return;
+       if (view->buffer_ == 0) return;
 
-       view->current_scrollbar_value = (long)fl_get_slider_value(ob);
+       view->current_scrollbar_value = long(fl_get_slider_value(ob));
        if (view->current_scrollbar_value < 0)
                view->current_scrollbar_value = 0;
    
@@ -543,7 +580,7 @@ void BufferView::ScrollCB(FL_OBJECT *ob, long buf)
        view->screen->Draw(view->current_scrollbar_value);
 
        if (cursor_follows_scrollbar) {
-               LyXText * vbt = view->_buffer->text;
+               LyXText * vbt = view->text;
                int height = vbt->DefaultHeight();
                
                if (vbt->cursor.y < view->screen->first + height) {
@@ -564,13 +601,13 @@ void BufferView::ScrollCB(FL_OBJECT *ob, long buf)
 
 
 // Callback for scrollbar down button
-void BufferView::DownCB(FL_OBJECT *ob, long buf)
+void BufferView::DownCB(FL_OBJECT * ob, long)
 {
-       BufferView *view = (BufferView*) buf;
+       BufferView * view = static_cast<BufferView*>(ob->u_vdata);
 
-       if (view->_buffer == 0) return;
+       if (view->buffer_ == 0) return;
        
-       const XEvent*ev2;
+       XEvent const * ev2;
        static long time = 0;
        ev2 = fl_last_event();
        if (ev2->type == ButtonPress || ev2->type == ButtonRelease) 
@@ -589,21 +626,19 @@ void BufferView::DownCB(FL_OBJECT *ob, long buf)
 
 int BufferView::ScrollUp(long time)
 {
-       if (_buffer == 0) return 0;
-       if (!screen)
-               return 0;
+       if (buffer_ == 0) return 0;
+       if (!screen) return 0;
    
-       double value= fl_get_slider_value(scrollbar);
+       double value = fl_get_slider_value(scrollbar);
    
-       if (value == 0)
-               return 0;
-   
-       float add_value =  (_buffer->text->DefaultHeight()
-                           + (float)(time) * (float)(time) * 0.125);
+       if (value == 0) return 0;
+
+       float add_value =  (text->DefaultHeight()
+                           + float(time) * float(time) * 0.125);
    
        if (add_value > work_area->h)
-               add_value = (float) (work_area->h -
-                                    _buffer->text->DefaultHeight());
+               add_value = float(work_area->h -
+                                 text->DefaultHeight());
    
        value -= add_value;
 
@@ -612,30 +647,28 @@ int BufferView::ScrollUp(long time)
    
        fl_set_slider_value(scrollbar, value);
    
-       ScrollCB(scrollbar,(long)this); 
+       ScrollCB(scrollbar, 0); 
        return 0;
 }
 
 
 int BufferView::ScrollDown(long time)
 {
-       if (_buffer == 0) return 0;
-       if (!screen)
-               return 0;
+       if (buffer_ == 0) return 0;
+       if (!screen) return 0;
    
        double value= fl_get_slider_value(scrollbar);
        double min, max;
        fl_get_slider_bounds(scrollbar, &min, &max);
 
-       if (value == max)
-               return 0;
-   
-       float add_value =  (_buffer->text->DefaultHeight()
-                           + (float)(time) * (float)(time) * 0.125);
+       if (value == max) return 0;
+
+       float add_value =  (text->DefaultHeight()
+                           + float(time) * float(time) * 0.125);
    
        if (add_value > work_area->h)
-               add_value = (float) (work_area->h -
-                                    _buffer->text->DefaultHeight());
+               add_value = float(work_area->h -
+                                 text->DefaultHeight());
    
        value += add_value;
    
@@ -644,62 +677,61 @@ int BufferView::ScrollDown(long time)
    
        fl_set_slider_value(scrollbar, value);
    
-       ScrollCB(scrollbar,(long)this); 
+       ScrollCB(scrollbar, 0); 
        return 0;
 }
 
 
 void BufferView::ScrollUpOnePage(long /*time*/)
 {
-       if (_buffer == 0) return;
-       if (!screen)
-               return;
+       if (buffer_ == 0) return;
+       if (!screen) return;
    
        long y = screen->first;
 
        if (!y) return;
-   
-       Row* row = _buffer->text->GetRowNearY(y);
+
+       Row * row = text->GetRowNearY(y);
+
        y = y - work_area->h + row->height;
        
        fl_set_slider_value(scrollbar, y);
    
-       ScrollCB(scrollbar,(long)this); 
+       ScrollCB(scrollbar, 0); 
 }
 
 
 void BufferView::ScrollDownOnePage(long /*time*/)
 {
-       if (_buffer == 0) return;
-       if (!screen)
-               return;
+       if (buffer_ == 0) return;
+       if (!screen) return;
    
        double min, max;
        fl_get_slider_bounds(scrollbar, &min, &max);
        long y = screen->first;
-   
-       if (y > _buffer->text->height - work_area->h)
+
+       if (y > text->height - work_area->h)
                return;
    
        y += work_area->h;
-       _buffer->text->GetRowNearY(y);
-       
+       text->GetRowNearY(y);
+
        fl_set_slider_value(scrollbar, y);
    
-       ScrollCB(scrollbar,(long)this); 
+       ScrollCB(scrollbar, 0); 
 }
 
 
 int BufferView::work_area_handler(FL_OBJECT * ob, int event,
                                  FL_Coord, FL_Coord ,
-                                 int /*key*/, void *xev)
+                                 int /*key*/, void * xev)
 {
        static int x_old = -1;
        static int y_old = -1;
        static long scrollbar_value_old = -1;
        
-       XEvent* ev = (XEvent*) xev;
-       BufferView *view = (BufferView*) ob->u_vdata;
+       XEvent * ev = static_cast<XEvent*>(xev);
+       BufferView * view = static_cast<BufferView*>(ob->u_vdata);
 
        // If we don't have a view yet; return
        if (!view || quitting) return 0;
@@ -709,10 +741,10 @@ int BufferView::work_area_handler(FL_OBJECT * ob, int event,
                view->workAreaExpose(); 
                break;
        case FL_PUSH:
-               view->WorkAreaButtonPress(ob, 0,0,0,ev,0);
+               view->WorkAreaButtonPress(ob, 0, 0, 0, ev, 0);
                break; 
        case FL_RELEASE:
-               view->WorkAreaButtonRelease(ob, 0,0,0,ev,0);
+               view->WorkAreaButtonRelease(ob, 0, 0, 0, ev, 0);
                break;
        case FL_MOUSE:
                if (ev->xmotion.x != x_old || 
@@ -721,24 +753,25 @@ int BufferView::work_area_handler(FL_OBJECT * ob, int event,
                        x_old = ev->xmotion.x;
                        y_old = ev->xmotion.y;
                        scrollbar_value_old = view->current_scrollbar_value;
-                       view->WorkAreaMotionNotify(ob, 0,0,0,ev,0);
+                       view->WorkAreaMotionNotify(ob, 0, 0, 0, ev, 0);
                }
                break;
-       // Done by the raw callback:
-       //  case FL_KEYBOARD: WorkAreaKeyPress(ob, 0,0,0,ev,0); break;
+               // Done by the raw callback:
+               //  case FL_KEYBOARD:
+               //  WorkAreaKeyPress(ob, 0, 0, 0, ev, 0); break;
        case FL_FOCUS:
-               if (!view->_owner->getMiniBuffer()->shows_no_match)
-                       view->_owner->getMiniBuffer()->Init();
-               view->_owner->getMiniBuffer()->shows_no_match = false;
+               if (!view->owner_->getMiniBuffer()->shows_no_match)
+                       view->owner_->getMiniBuffer()->Init();
+               view->owner_->getMiniBuffer()->shows_no_match = false;
                view->work_area_focus = true;
                fl_set_timer(view->timer_cursor, 0.4);
                break;
        case FL_UNFOCUS:
-               view->_owner->getMiniBuffer()->ExecCommand();
+               view->owner_->getMiniBuffer()->ExecCommand();
                view->work_area_focus = false;
                break;
        case FL_ENTER:
-               SetXtermCursor(view->_owner->getForm()->window);
+               SetXtermCursor(view->owner_->getForm()->window);
                // reset the timer
                view->lyx_focus = true;
                fl_set_timer(view->timer_cursor, 0.4);
@@ -746,7 +779,7 @@ int BufferView::work_area_handler(FL_OBJECT * ob, int event,
        case FL_LEAVE: 
                if (!input_prohibited)
                        XUndefineCursor(fl_display,
-                                       view->_owner->getForm()->window);
+                                       view->owner_->getForm()->window);
                view->lyx_focus = false; // This is not an absolute truth
                // but if it is not true, it will be changed within a blink
                // of an eye. ... Not good enough... use regulare timeperiod
@@ -755,55 +788,53 @@ int BufferView::work_area_handler(FL_OBJECT * ob, int event,
                break;
        case FL_DBLCLICK: 
                // select a word 
-               if (view->_buffer && !view->_buffer->the_locking_inset) {
+               if (view->buffer_ && !view->buffer_->the_locking_inset) {
                        if (view->screen && ev->xbutton.button == 1) {
                                view->screen->HideCursor();
-                               view->screen->ToggleSelection(); 
-                               view->_buffer->text->SelectWord();
+                               view->screen->ToggleSelection();
+                               view->text->SelectWord();
                                view->screen->ToggleSelection(false);
                                /* This will fit the cursor on the screen
-                                * if necessary */ 
-                               view->_buffer->update(0); 
+                                * if necessary */
+                               view->update(0);
                        }
                }
                break;
        case FL_TRPLCLICK:
                // select a line
-               if (view->_buffer && view->screen && ev->xbutton.button == 1) {
+               if (view->buffer_ && view->screen && ev->xbutton.button == 1) {
                        view->screen->HideCursor(); 
-                       view->screen->ToggleSelection(); 
-                       view->_buffer->text->CursorHome();
-                       view->_buffer->text->sel_cursor =
-                               view->_buffer->text->cursor;
-                       view->_buffer->text->CursorEnd();
-                       view->_buffer->text->SetSelection();
+                       view->screen->ToggleSelection();
+                       view->text->CursorHome();
+                       view->text->sel_cursor = view->text->cursor;
+                       view->text->CursorEnd();
+                       view->text->SetSelection();
                        view->screen->ToggleSelection(false); 
                        /* This will fit the cursor on the screen
-                        * if necessary */ 
-                       view->_buffer->update(0); 
+                        * if necessary */
+                       view->update(0);
                }
                break;
        case FL_OTHER:
                view->WorkAreaSelectionNotify(ob,
-                                             view->_owner->getForm()->window,
-                                             0,0,ev,0); 
+                                             view->owner_->getForm()->window,
+                                             0, 0, ev, 0); 
                break;
        }
        return 1;
 }
 
-int BufferView::WorkAreaMotionNotify(FL_OBJECT *ob, Window,
+int BufferView::WorkAreaMotionNotify(FL_OBJECT * ob, Window,
                                     int /*w*/, int /*h*/,
-                                    XEvent *ev, void */*d*/)
+                                    XEvent * ev, void * /*d*/)
 {
-
-       if (_buffer == 0) return 0;
+       if (buffer_ == 0) return 0;
        if (!screen) return 0;
 
        // Check for inset locking
-       if (_buffer->the_locking_inset) {
-               LyXCursor cursor = _buffer->text->cursor;
-               _buffer->the_locking_inset->
+       if (buffer_->the_locking_inset) {
+               LyXCursor cursor = text->cursor;
+               buffer_->the_locking_inset->
                        InsetMotionNotify(ev->xbutton.x - ob->x - cursor.x,
                                          ev->xbutton.y - ob->y -
                                          (cursor.y),
@@ -820,15 +851,14 @@ int BufferView::WorkAreaMotionNotify(FL_OBJECT *ob, Window,
        if (selection_possible) {
                screen->HideCursor();
 
-               _buffer->text->
-                       SetCursorFromCoordinates(ev->xbutton.x - ob->x,
-                                                ev->xbutton.y - ob->y +
-                                                screen->first);
+               text->SetCursorFromCoordinates(ev->xbutton.x - ob->x,
+                                              ev->xbutton.y - ob->y +
+                                              screen->first);
       
-               if (!_buffer->text->selection)
-                   _buffer->update(-3); // Maybe an empty line was deleted
+               if (!text->selection)
+                       update(-3); // Maybe an empty line was deleted
       
-               _buffer->text->SetSelection();
+               text->SetSelection();
                screen->ToggleToggle();
                if (screen->FitCursor())
                        updateScrollbar(); 
@@ -838,16 +868,17 @@ int BufferView::WorkAreaMotionNotify(FL_OBJECT *ob, Window,
 }
 
 
-extern int bibitemMaxWidth(const class LyXFont &);
+extern int bibitemMaxWidth(LyXFont const &);
 
 // Single-click on work area
-int BufferView::WorkAreaButtonPress(FL_OBJECT *ob, Window,
-                       int /*w*/, int /*h*/, XEvent *ev, void */*d*/)
+int BufferView::WorkAreaButtonPress(FL_OBJECT * ob, Window,
+                                   int /*w*/, int /*h*/,
+                                   XEvent * ev, void */*d*/)
 {
        last_click_x = -1;
        last_click_y = -1;
 
-       if (_buffer == 0) return 0;
+       if (buffer_ == 0) return 0;
        if (!screen) return 0;
 
        int const x = ev->xbutton.x - ob->x;
@@ -865,158 +896,141 @@ int BufferView::WorkAreaButtonPress(FL_OBJECT *ob, Window,
 
        {
                
-       if (_buffer->the_locking_inset) {
-               // We are in inset locking mode
+               if (buffer_->the_locking_inset) {
+                       // We are in inset locking mode
                
-               /* Check whether the inset was hit. If not reset mode,
-                  otherwise give the event to the inset */
-               if (inset_hit != 0) {
-                       _buffer->the_locking_inset->
-                               InsetButtonPress(inset_x, inset_y, button);
-                       return 0;
-               } else {
-                       UnlockInset(_buffer->the_locking_inset);
+                       /* Check whether the inset was hit. If not reset mode,
+                          otherwise give the event to the inset */
+                       if (inset_hit != 0) {
+                               buffer_->the_locking_inset->
+                                       InsetButtonPress(inset_x, inset_y,
+                                                        button);
+                               return 0;
+                       } else {
+                               UnlockInset(buffer_->the_locking_inset);
+                       }
                }
-       }
        
-       selection_possible = true;
-       screen->HideCursor();
+               selection_possible = true;
+               screen->HideCursor();
        
-       // Right button mouse click on a table
-       if (button == 3 &&
-           (_buffer->text->cursor.par->table ||
-            _buffer->text->MouseHitInTable(x, y+screen->first))) {
-               // Set the cursor to the press-position
-               _buffer->text->SetCursorFromCoordinates(x, y + screen->first);
-               bool doit = true;
+               // Right button mouse click on a table
+               if (button == 3 &&
+                   (text->cursor.par->table ||
+                    text->MouseHitInTable(x, y + screen->first))) {
+                       // Set the cursor to the press-position
+                       text->SetCursorFromCoordinates(x, y + screen->first);
+                       bool doit = true;
                
-               // Only show the table popup if the hit is in the table, too
-               if (!_buffer->text->HitInTable(_buffer->text->cursor.row, x))
-                       doit = false;
+                       // Only show the table popup if the hit is in
+                       // the table, too
+                       if (!text->HitInTable(text->cursor.row, x))
+                               doit = false;
                
-               // Hit above or below the table?
-               if (doit) {
-                       long y_tmp = y + screen->first;
-                       Row*  row =  _buffer->text->GetRowNearY(y_tmp);
-#if 0
-                       // Isn't this empty code anyway? (Lgb)
-                       if (row->par != _buffer->text->cursor.par)
-                               doit = true;
-               }
-               
-               if (doit) {
-#endif
-                       if (!_buffer->text->selection) {
-                               screen->ToggleSelection();
-                               _buffer->text->ClearSelection();
-                               _buffer->text->FullRebreak();
-                               screen->Update();
-                               updateScrollbar();
+                       // Hit above or below the table?
+                       if (doit) {
+                               if (!text->selection) {
+                                       screen->ToggleSelection();
+                                       text->ClearSelection();
+                                       text->FullRebreak();
+                                       screen->Update();
+                                       updateScrollbar();
+                               }
+                               // Popup table popup when on a table.
+                               // This is obviously temporary, since we
+                               // should be able to popup various
+                               // context-sensitive-menus with the
+                               // the right mouse. So this should be done more
+                               // general in the future. Matthias.
+                               selection_possible = false;
+                               owner_->getLyXFunc()
+                                       ->Dispatch(LFUN_LAYOUT_TABLE,
+                                                  "true");
+                               return 0;
                        }
-                       // Popup table popup when on a table.
-                       // This is obviously temporary, since we should be
-                       // able to 
-                       // popup various context-sensitive-menus with the
-                       // the right mouse. So this should be done more
-                       // general in the future. Matthias.
-                       selection_possible = false;
-                       _owner->getLyXFunc()->Dispatch(LFUN_LAYOUT_TABLE,
-                                                      "true");
-                       return 0;
                }
-       }
        
-       int screen_first = screen->first;
+               int screen_first = screen->first;
        
-       // Middle button press pastes if we have a selection
-       bool paste_internally = false;
-       if (button == 2  // && !_buffer->the_locking_inset
-           && _buffer->text->selection) {
-               _owner->getLyXFunc()->Dispatch(LFUN_COPY);
-               paste_internally = true;
-       }
+               // Middle button press pastes if we have a selection
+               bool paste_internally = false;
+               if (button == 2  // && !buffer_->the_locking_inset
+                   && text->selection) {
+                       owner_->getLyXFunc()->Dispatch(LFUN_COPY);
+                       paste_internally = true;
+               }
        
-       // Clear the selection
-       screen->ToggleSelection();
-       _buffer->text->ClearSelection();
-       _buffer->text->FullRebreak();
-       screen->Update();
-       updateScrollbar();
+               // Clear the selection
+               screen->ToggleSelection();
+               text->ClearSelection();
+               text->FullRebreak();
+               screen->Update();
+               updateScrollbar();
                
-       // Single left click in math inset?
-       if (inset_hit != 0 && inset_hit->Editable() == 2) {
-               // Highly editable inset, like math
-               selection_possible = false;
-               _owner->updateLayoutChoice();
-               _owner->getMiniBuffer()->Set(inset_hit->EditMessage());
-               inset_hit->Edit(inset_x, inset_y);
-               return 0;
-       } 
+               // Single left click in math inset?
+               if (inset_hit != 0 && inset_hit->Editable() == 2) {
+                       // Highly editable inset, like math
+                       selection_possible = false;
+                       owner_->updateLayoutChoice();
+                       owner_->getMiniBuffer()->Set(inset_hit->EditMessage());
+                       inset_hit->Edit(inset_x, inset_y);
+                       return 0;
+               
 
-       // Right click on a footnote flag opens float menu
-       if (button == 3) { 
-#if 0
-               // Isn't this empty code anyway? (Lgb)
-               if (_buffer->text->cursor.par->footnoteflag == 
-                   LyXParagraph::OPEN_FOOTNOTE) {
+               // Right click on a footnote flag opens float menu
+               if (button == 3) { 
                        selection_possible = false;
-                       lyxerr.debug("LyX: Sorry not implemented yet.");
                        return 0;
                }
-       }
        
-       if (button == 3) {
-#endif
-               selection_possible = false;
-               return 0;
-       }
+               text->SetCursorFromCoordinates(x, y + screen_first);
+               text->FinishUndo();
+               text->sel_cursor = text->cursor;
+               text->cursor.x_fix = text->cursor.x;
        
-       _buffer->text->SetCursorFromCoordinates(x, y + screen_first);
-       _buffer->text->FinishUndo();
-       _buffer->text->sel_cursor = _buffer->text->cursor;
-       _buffer->text->cursor.x_fix = _buffer->text->cursor.x;
-       
-       _owner->updateLayoutChoice();
-       if (screen->FitCursor()){
-               updateScrollbar();
-               selection_possible = false;
-       }
+               owner_->updateLayoutChoice();
+               if (screen->FitCursor()){
+                       updateScrollbar();
+                       selection_possible = false;
+               }
 
-       // Insert primary selection with middle mouse
-       // if there is a local selection in the current buffer, insert this
-       if (button == 2) { //  && !_buffer->the_locking_inset){
-               if (paste_internally)
-                       _owner->getLyXFunc()->Dispatch(LFUN_PASTE);
-               else
-                       _owner->getLyXFunc()->Dispatch(LFUN_PASTESELECTION,
-                                                      "paragraph");
-               selection_possible = false;
-               return 0;
-       }
+               // Insert primary selection with middle mouse
+               // if there is a local selection in the current buffer,
+               // insert this
+               if (button == 2) { //  && !buffer_->the_locking_inset){
+                       if (paste_internally)
+                               owner_->getLyXFunc()->Dispatch(LFUN_PASTE);
+                       else
+                               owner_->getLyXFunc()->Dispatch(LFUN_PASTESELECTION,
+                                                              "paragraph");
+                       selection_possible = false;
+                       return 0;
+               }
        }
        goto out;
- wheel: {
-       // I am not quite sure if this is the correct place to put this,
-       // but it will not cause any harm.
-       // Patch from Mark Huang (markman@mit.edu) to make LyX recognise
-       // button 4 and 5. This enables LyX use use the scrollwhell on
-       // certain mice for something useful. (Lgb)
-       // Added wheel acceleration detection code. (Rvdk)
-       static Time lastTime = 0;
-       int diff = ev->xbutton.time - lastTime;
-       int scroll = int(1.0 + (4.0/(abs(diff)+1.0))*200.0);
-       switch (button) {
-       case 4:
-               ScrollUp(scroll);
-               break;
-       case 5:
-               ScrollDown(scroll);
-               break;
-       }
-       lastTime = ev->xbutton.time;
-       return 0;
+  wheel:
+       {
+               // I am not quite sure if this is the correct place to put
+               // this, but it will not cause any harm.
+               // Patch from Mark Huang (markman@mit.edu) to make LyX
+               // recognise button 4 and 5. This enables LyX use use
+               // the scrollwhell on certain mice for something useful. (Lgb)
+               // Added wheel acceleration detection code. (Rvdk)
+               static Time lastTime = 0;
+               int diff = ev->xbutton.time - lastTime;
+               int scroll = int(1.0 + (4.0 / (abs(diff) + 1.0)) * 200.0);
+               switch (button) {
+               case 4:
+                       ScrollUp(scroll);
+                       break;
+               case 5:
+                       ScrollDown(scroll);
+                       break;
+               }
+               lastTime = ev->xbutton.time;
+               return 0;
        }
- out:
 out:
        last_click_x = x;
        last_click_y = y;
        
@@ -1024,10 +1038,11 @@ int BufferView::WorkAreaButtonPress(FL_OBJECT *ob, Window,
 }
 
 
-int BufferView::WorkAreaButtonRelease(FL_OBJECT *ob, Window ,
-                         int /*w*/, int /*h*/, XEvent *ev, void */*d*/)
+int BufferView::WorkAreaButtonRelease(FL_OBJECT * ob, Window ,
+                                     int /*w*/, int /*h*/,
+                                     XEvent * ev, void * /*d*/)
 {
-       if (_buffer == 0 || screen == 0) return 0;
+       if (buffer_ == 0 || screen == 0) return 0;
 
        int const x = ev->xbutton.x - ob->x;
        int const y = ev->xbutton.y - ob->y;
@@ -1039,28 +1054,28 @@ int BufferView::WorkAreaButtonRelease(FL_OBJECT *ob, Window ,
        int inset_y = y;
        Inset * inset_hit = checkInsetHit(inset_x, inset_y);
 
-       if (_buffer->the_locking_inset) {
+       if (buffer_->the_locking_inset) {
                // We are in inset locking mode.
 
                /* LyX does a kind of work-area grabbing for insets.
                   Only a ButtonPress Event outside the inset will 
                   force a InsetUnlock. */
-               _buffer->the_locking_inset->
+               buffer_->the_locking_inset->
                        InsetButtonRelease(inset_x, inset_y, 
                                           ev->xbutton.button);
                return 0;
        }
   
        selection_possible = false;
-        if (_buffer->text->cursor.par->table) {
-                int cell = _buffer->text->
-                        NumberOfCell(_buffer->text->cursor.par,
-                                     _buffer->text->cursor.pos);
-                if (_buffer->text->cursor.par->table->IsContRow(cell) &&
-                    _buffer->text->cursor.par->table->
-                    CellHasContRow(_buffer->text->cursor.par->table->
+        if (text->cursor.par->table) {
+                int cell = text->
+                        NumberOfCell(text->cursor.par,
+                                     text->cursor.pos);
+                if (text->cursor.par->table->IsContRow(cell) &&
+                    text->cursor.par->table->
+                    CellHasContRow(text->cursor.par->table->
                                    GetCellAbove(cell))<0) {
-                        _buffer->text->CursorUp();
+                        text->CursorUp();
                 }
         }
        
@@ -1094,38 +1109,43 @@ int BufferView::WorkAreaButtonRelease(FL_OBJECT *ob, Window ,
                // ...or maybe the SetCursorParUndo()
                // below isn't necessary at all anylonger?
                if (inset_hit->LyxCode() == Inset::REF_CODE) {
-                       _buffer->text->SetCursorParUndo();
+                       text->SetCursorParUndo();
                }
 
-               _owner->getMiniBuffer()->Set(inset_hit->EditMessage());
+               owner_->getMiniBuffer()->Set(inset_hit->EditMessage());
                inset_hit->Edit(inset_x, inset_y);
                return 0;
        }
 
        // check whether we want to open a float
-       if (_buffer->text) {
+       if (text) {
                bool hit = false;
                char c = ' ';
-               if (_buffer->text->cursor.pos <
-                   _buffer->text->cursor.par->Last()) {
-                       c = _buffer->text->cursor.par->
-                               GetChar(_buffer->text->cursor.pos);
+               if (text->cursor.pos <
+                   text->cursor.par->Last()) {
+                       c = text->cursor.par->
+                               GetChar(text->cursor.pos);
                }
-               if (c == LYX_META_FOOTNOTE || c == LYX_META_MARGIN
-                   || c == LYX_META_FIG || c == LYX_META_TAB
-                   || c == LYX_META_WIDE_FIG || c == LYX_META_WIDE_TAB
-                    || c == LYX_META_ALGORITHM){
+               if (c == LyXParagraph::META_FOOTNOTE
+                   || c == LyXParagraph::META_MARGIN
+                   || c == LyXParagraph::META_FIG
+                   || c == LyXParagraph::META_TAB
+                   || c == LyXParagraph::META_WIDE_FIG
+                   || c == LyXParagraph::META_WIDE_TAB
+                    || c == LyXParagraph::META_ALGORITHM){
                        hit = true;
-               } else if (_buffer->text->cursor.pos - 1 >= 0) {
-                       c = _buffer->text->cursor.par->
-                               GetChar(_buffer->text->cursor.pos - 1);
-                       if (c == LYX_META_FOOTNOTE || c == LYX_META_MARGIN
-                           || c == LYX_META_FIG || c == LYX_META_TAB
-                           || c == LYX_META_WIDE_FIG 
-                           || c == LYX_META_WIDE_TAB
-                           || c == LYX_META_ALGORITHM){
+               } else if (text->cursor.pos - 1 >= 0) {
+                       c = text->cursor.par->
+                               GetChar(text->cursor.pos - 1);
+                       if (c == LyXParagraph::META_FOOTNOTE
+                           || c == LyXParagraph::META_MARGIN
+                           || c == LyXParagraph::META_FIG
+                           || c == LyXParagraph::META_TAB
+                           || c == LyXParagraph::META_WIDE_FIG 
+                           || c == LyXParagraph::META_WIDE_TAB
+                           || c == LyXParagraph::META_ALGORITHM){
                                // We are one step too far to the right
-                               _buffer->text->CursorLeft();
+                               text->CursorLeft();
                                hit = true;
                        }
                }
@@ -1137,11 +1157,11 @@ int BufferView::WorkAreaButtonRelease(FL_OBJECT *ob, Window ,
        }
 
        // Do we want to close a float? (click on the float-label)
-       if (_buffer->text->cursor.row->par->footnoteflag ==
+       if (text->cursor.row->par->footnoteflag == 
            LyXParagraph::OPEN_FOOTNOTE
-           && _buffer->text->cursor.pos == 0
-           && _buffer->text->cursor.row->previous &&
-           _buffer->text->cursor.row->previous->par->
+           && text->cursor.pos == 0
+           && text->cursor.row->previous &&
+           text->cursor.row->previous->par->
            footnoteflag != LyXParagraph::OPEN_FOOTNOTE){
                LyXFont font (LyXFont::ALL_SANE);
                font.setSize(LyXFont::SIZE_SMALL);
@@ -1152,11 +1172,11 @@ int BufferView::WorkAreaButtonRelease(FL_OBJECT *ob, Window ,
                int screen_first = screen->first;
 
                if (x < box_x
-                   && y + screen_first > _buffer->text->cursor.y -
-                   _buffer->text->cursor.row->baseline
-                   && y + screen_first < _buffer->text->cursor.y -
-                   _buffer->text->cursor.row->baseline
-                   + font.maxAscent()*1.2 + font.maxDescent()*1.2) {
+                   && y + screen_first > text->cursor.y -
+                   text->cursor.row->baseline
+                   && y + screen_first < text->cursor.y -
+                   text->cursor.row->baseline
+                   + font.maxAscent() * 1.2 + font.maxDescent() * 1.2) {
                        ToggleFloat();
                        selection_possible = false;
                        return 0;
@@ -1164,10 +1184,11 @@ int BufferView::WorkAreaButtonRelease(FL_OBJECT *ob, Window ,
        }
 
        // Maybe we want to edit a bibitem ale970302
-       if (_buffer->text->cursor.par->bibkey && x < 20 + 
-           bibitemMaxWidth(lyxstyle.TextClass(_buffer->
-                                       params.textclass)->defaultfont)) {
-               _buffer->text->cursor.par->bibkey->Edit(0, 0);
+       if (text->cursor.par->bibkey && x < 20 + 
+           bibitemMaxWidth(textclasslist
+                           .TextClass(buffer_->
+                                      params.textclass).defaultfont())) {
+               text->cursor.par->bibkey->Edit(0, 0);
        }
 
        return 0;
@@ -1179,22 +1200,22 @@ int BufferView::WorkAreaButtonRelease(FL_OBJECT *ob, Window ,
  * If hit, the coordinates are changed relative to the inset. 
  * Otherwise coordinates are not changed, and false is returned.
  */
-Inset * BufferView::checkInsetHit(int &x, int &y)
+Inset * BufferView::checkInsetHit(int & x, int & y)
 {
        if (!getScreen())
                return 0;
   
        int y_tmp = y + getScreen()->first;
   
-       LyXCursor cursor = _buffer->text->cursor;
+       LyXCursor cursor = text->cursor;
        if (cursor.pos < cursor.par->Last() 
-           && cursor.par->GetChar(cursor.pos) == LYX_META_INSET
+           && cursor.par->GetChar(cursor.pos) == LyXParagraph::META_INSET
            && cursor.par->GetInset(cursor.pos)
            && cursor.par->GetInset(cursor.pos)->Editable()) {
 
                // Check whether the inset really was hit
-               Inset* tmpinset = cursor.par->GetInset(cursor.pos);
-               LyXFont font = _buffer->text->GetFont(cursor.par, cursor.pos);
+               Inset * tmpinset = cursor.par->GetInset(cursor.pos);
+               LyXFont font = text->GetFont(cursor.par, cursor.pos);
                if (x > cursor.x
                    && x < cursor.x + tmpinset->Width(font) 
                    && y_tmp > cursor.y - tmpinset->Ascent(font)
@@ -1205,13 +1226,13 @@ Inset * BufferView::checkInsetHit(int &x, int &y)
                        return tmpinset;
                }
        } else if (cursor.pos - 1 >= 0 
-                  && cursor.par->GetChar(cursor.pos - 1) == LYX_META_INSET
+                  && cursor.par->GetChar(cursor.pos - 1) == LyXParagraph::META_INSET
                   && cursor.par->GetInset(cursor.pos - 1)
                   && cursor.par->GetInset(cursor.pos - 1)->Editable()) {
-               _buffer->text->CursorLeft();
+               text->CursorLeft();
                Inset * result = checkInsetHit(x, y);
                if (result == 0) {
-                       _buffer->text->CursorRight();
+                       text->CursorRight();
                        return 0;
                } else {
                        return result;
@@ -1241,7 +1262,7 @@ int BufferView::workAreaExpose()
        // update from work area
        work_area_width = work_area->w;
        work_area_height = work_area->h;
-       if (_buffer != 0) {
+       if (buffer_ != 0) {
                if (widthChange) {
                        // All buffers need a resize
                        bufferlist.resize();
@@ -1256,7 +1277,7 @@ int BufferView::workAreaExpose()
                        // The main window size has changed, repaint most stuff
                        redraw();
                        // ...including the minibuffer
-                       _owner->getMiniBuffer()->Init();
+                       owner_->getMiniBuffer()->Init();
 
                } else if (screen) screen->Redraw();
        } else {
@@ -1268,26 +1289,24 @@ int BufferView::workAreaExpose()
 
        // always make sure that the scrollbar is sane.
        updateScrollbar();
-       _owner->updateLayoutChoice();
+       owner_->updateLayoutChoice();
        return 1;
 }
 
 
 // Callback for cursor timer
-void BufferView::CursorToggleCB(FL_OBJECT *ob, long)
+void BufferView::CursorToggleCB(FL_OBJECT * ob, long)
 {
-       BufferView *view = (BufferView*) ob->u_vdata;
+       BufferView * view = static_cast<BufferView*>(ob->u_vdata);
        
-       /* quite a nice place for asyncron Inset updating, isn't it? */
-       // actually no! This is run even if no buffer exist... so (Lgb)
-       if (view && !view->_buffer) {
+       // Quite a nice place for asyncron Inset updating, isn't it?
+       // Actually no! This is run even if no buffer exist... so (Lgb)
+       if (view && !view->buffer_) {
                goto set_timer_and_return;
        }
-#ifdef WITH_WARNINGS
-#warning NOTE!
-#endif
 
-       // On my quest to solve the gs rendre hangups I am now
+       // NOTE:
+       // On my quest to solve the gs render hangups I am now
        // disabling the SIGHUP completely, and will do a wait
        // now and then instead. If the guess that xforms somehow
        // destroys something is true, this is likely (hopefully)
@@ -1314,16 +1333,14 @@ void BufferView::CursorToggleCB(FL_OBJECT *ob, long)
        // rendering process.
 
        // these comments posted to lyx@via
-//#if 0
        {
-       int status = 1;
-       int pid = waitpid((pid_t)0, &status, WNOHANG);
-       if (pid == -1) // error find out what is wrong
-               ; // ignore it for now.
-       else if (pid > 0)
-               sigchldhandler(pid, &status);
+               int status = 1;
+               int pid = waitpid(static_cast<pid_t>(0), &status, WNOHANG);
+               if (pid == -1) // error find out what is wrong
+                       ; // ignore it for now.
+               else if (pid > 0)
+                       sigchldhandler(pid, &status);
        }
-//#endif
        if (InsetUpdateList) 
                UpdateInsetUpdateList();
 
@@ -1332,20 +1349,20 @@ void BufferView::CursorToggleCB(FL_OBJECT *ob, long)
        }
 
        if (view->lyx_focus && view->work_area_focus) {
-               if (!view->_buffer->the_locking_inset){
+               if (!view->buffer_->the_locking_inset) {
                        view->screen->CursorToggle();
                } else {
-                       view->_buffer->the_locking_inset->
+                       view->buffer_->the_locking_inset->
                                ToggleInsetCursor();
                }
                goto set_timer_and_return;
        } else {
                // Make sure that the cursor is visible.
-               if (!view->_buffer->the_locking_inset){
+               if (!view->buffer_->the_locking_inset) {
                        view->screen->ShowCursor();
                } else {
-                       if (!view->_buffer->the_locking_inset->isCursorVisible())
-                               view->_buffer->the_locking_inset->
+                       if (!view->buffer_->the_locking_inset->isCursorVisible())
+                               view->buffer_->the_locking_inset->
                                        ToggleInsetCursor();
                }
 
@@ -1353,14 +1370,14 @@ void BufferView::CursorToggleCB(FL_OBJECT *ob, long)
                Window tmpwin;
                int tmp;
                XGetInputFocus(fl_display, &tmpwin, &tmp);
-               lyxerr.debug(LString("tmpwin: ") + int(tmpwin));
-               lyxerr.debug(LString("window: ")
-                            + int(view->_owner->getForm()->window));
-               lyxerr.debug(LString("work_area_focus: ")
-                            + int(view->work_area_focus));
-               lyxerr.debug(LString("lyx_focus      : ")
-                            + int(view->lyx_focus));
-               if (tmpwin != view->_owner->getForm()->window) {
+               if (lyxerr.debugging(Debug::INFO)) {
+                       lyxerr << "tmpwin: " << tmpwin
+                              << "\nwindow: " << view->owner_->getForm()->window
+                              << "\nwork_area_focus: " << view->work_area_focus
+                              << "\nlyx_focus      : " << view->lyx_focus
+                              << endl;
+               }
+               if (tmpwin != view->owner_->getForm()->window) {
                        view->lyx_focus = false;
                        goto skip_timer;
                } else {
@@ -1380,16 +1397,17 @@ void BufferView::CursorToggleCB(FL_OBJECT *ob, long)
 
 
 int BufferView::WorkAreaSelectionNotify(FL_OBJECT *, Window win,
-                           int /*w*/, int /*h*/, XEvent *event, void */*d*/)
+                                       int /*w*/, int /*h*/,
+                                       XEvent * event, void */*d*/)
 {
-       if (_buffer == 0) return 0;
+       if (buffer_ == 0) return 0;
        if (event->type != SelectionNotify)
                return 0;
 
        Atom tmpatom;
        unsigned long ul1;
        unsigned long ul2;
-       unsigned char* uc = 0;
+       unsigned char * uc = 0;
        int tmpint;
        screen->HideCursor();
        BeforeChange();
@@ -1414,7 +1432,7 @@ int BufferView::WorkAreaSelectionNotify(FL_OBJECT *, Window win,
                }
                XFlush(fl_display);
 
-               if (uc){
+               if (uc) {
                        free(uc);
                        uc = 0;
                }
@@ -1437,18 +1455,17 @@ int BufferView::WorkAreaSelectionNotify(FL_OBJECT *, Window win,
                }
                XFlush(fl_display);
         
-               if (uc){
-                       if (!ascii_type)
-                               _buffer->text->
-                                       InsertStringA((char*)uc);
-                       else
-                               _buffer->text->
-                                       InsertStringB((char*)uc);
+               if (uc) {
+                       if (!ascii_type) {
+                               text->InsertStringA(reinterpret_cast<char*>(uc));
+                       } else {
+                               text->InsertStringB(reinterpret_cast<char*>(uc));
+                       }
                        free(uc);
                        uc = 0;
                }
-    
-               _buffer->update(1);
+
+               update(1);
        }
        return 0;
 }
@@ -1456,74 +1473,98 @@ int BufferView::WorkAreaSelectionNotify(FL_OBJECT *, Window win,
 
 void BufferView::cursorPrevious()
 {
-       if (!currentBuffer()->text->cursor.row->previous) return;
+       if (!text->cursor.row->previous) return;
        
        long y = getScreen()->first;
-       Row* cursorrow = currentBuffer()->text->cursor.row;
-       currentBuffer()->text->
-         SetCursorFromCoordinates(currentBuffer()->text->
-                                  cursor.x_fix,
-                                  y);
-       currentBuffer()->text->FinishUndo();
-       /* this is to allow jumping over large insets */
-       if ((cursorrow == currentBuffer()->text->cursor.row))
-         currentBuffer()->text->CursorUp();
+       Row * cursorrow = text->cursor.row;
+       text->SetCursorFromCoordinates(text->cursor.x_fix, y);
+       text->FinishUndo();
+       // This is to allow jumping over large insets
+       if ((cursorrow == text->cursor.row))
+               text->CursorUp();
        
-       if (currentBuffer()->text->cursor.row->height < work_area->h)
-         getScreen()->Draw(currentBuffer()->text->cursor.y
-                           - currentBuffer()->text->cursor.row->baseline
-                           + currentBuffer()->text->cursor.row->height
-                           - work_area->h +1 );
+       if (text->cursor.row->height < work_area->h)
+               getScreen()->Draw(text->cursor.y
+                                 - text->cursor.row->baseline
+                                 + text->cursor.row->height
+                                 - work_area->h +1 );
 }
 
 
 void BufferView::cursorNext()
 {
-       if (!currentBuffer()->text->cursor.row->next) return;
+       if (!text->cursor.row->next) return;
        
        long y = getScreen()->first;
-       currentBuffer()->text->GetRowNearY(y);
-       Row* cursorrow = currentBuffer()->text->cursor.row;
-       currentBuffer()->text->
-               SetCursorFromCoordinates(currentBuffer()->text->
-                                        cursor.x_fix, 
-                                        y + work_area->h);
-       currentBuffer()->text->FinishUndo();
-       /* this is to allow jumping over large insets */
-       if ((cursorrow == currentBuffer()->text->cursor.row))
-         currentBuffer()->text->CursorDown();
+       text->GetRowNearY(y);
+       Row * cursorrow = text->cursor.row;
+       text->SetCursorFromCoordinates(text->cursor.x_fix, y + work_area->h);
+       text->FinishUndo();
+       // This is to allow jumping over large insets
+       if ((cursorrow == text->cursor.row))
+               text->CursorDown();
        
-       if (currentBuffer()->text->cursor.row->height < work_area->h)
-         getScreen()->Draw(currentBuffer()->text->cursor.y
-                           - currentBuffer()->text->cursor.row->baseline);
+       if (text->cursor.row->height < work_area->h)
+               getScreen()->Draw(text->cursor.y
+                                 - text->cursor.row->baseline);
 }
 
 
 bool BufferView::available() const
 {
-       if (_buffer && _buffer->text) return true;
+       if (buffer_ && text) return true;
        return false;
 }
 
 
 void BufferView::savePosition()
 {
-       backstack->push(currentBuffer()->getFileName(),
-                       currentBuffer()->text->cursor.x,
-                       currentBuffer()->text->cursor.y);
+       backstack.push(buffer()->fileName(),
+                      text->cursor.x,
+                      text->cursor.y);
 }
 
 
 void BufferView::restorePosition()
 {
+       if (backstack.empty()) return;
+       
        int  x, y;
-       LString fname = backstack->pop(&x, &y);
+       string fname = backstack.pop(&x, &y);
        
        BeforeChange();
-       Buffer *b = (bufferlist.exists(fname)) ? bufferlist.getBuffer(fname):
+       Buffer * b = bufferlist.exists(fname) ?
+               bufferlist.getBuffer(fname) :
                bufferlist.loadLyXFile(fname); // don't ask, just load it
-       setBuffer(b);
-       currentBuffer()->text->SetCursorFromCoordinates(x, y);
-       currentBuffer()->update(0);
+       buffer(b);
+       text->SetCursorFromCoordinates(x, y);
+       update(0);
 } 
 
+
+void BufferView::update(signed char f)
+{
+       owner()->updateLayoutChoice();
+
+       if (!text->selection && f > -3)
+               text->sel_cursor = text->cursor;
+       
+       FreeUpdateTimer();
+       text->FullRebreak();
+
+       update();
+
+       if (f != 3 && f != -3) {
+               fitCursor();
+               updateScrollbar();
+       }
+
+       if (f == 1 || f == -1) {
+               if (buffer()->isLyxClean()) {
+                       buffer()->markDirty();
+                       owner()->getMiniBuffer()->setTimer(4);
+               } else {
+                       buffer()->markDirty();
+               }
+       }
+}