#include "frontends/Alert.h"
#include "frontends/FileDialog.h"
#include "frontends/FontMetrics.h"
-#include "frontends/Selection.h"
#include "graphics/Previews.h"
void BufferView::setBuffer(Buffer * b)
{
- lyxerr[Debug::INFO] << BOOST_CURRENT_FUNCTION
+ LYXERR(Debug::INFO) << BOOST_CURRENT_FUNCTION
<< "[ b = " << b << "]" << endl;
if (buffer_) {
BookmarksSection::Bookmark const & bm = LyX::ref().session().bookmarks().bookmark(i);
if (buffer()->fileName() != bm.filename.absFilename())
continue;
- // if par_id or pit has been changed, reset par_pit and par_id
+ // if top_id or bottom_pit, bottom_pos has been changed, update bookmark
// see http://bugzilla.lyx.org/show_bug.cgi?id=3092
pit_type new_pit;
+ pos_type new_pos;
int new_id;
- boost::tie(new_pit, new_id) = moveToPosition(bm.par_pit, bm.par_id, bm.par_pos);
- if (bm.par_pit != new_pit || bm.par_id != new_id)
- const_cast<BookmarksSection::Bookmark &>(bm).setPos(new_pit, new_id);
+ boost::tie(new_pit, new_pos, new_id) = moveToPosition(bm.bottom_pit, bm.bottom_pos, bm.top_id, bm.top_pos);
+ if (bm.bottom_pit != new_pit || bm.bottom_pos != new_pos || bm.top_id != new_id )
+ const_cast<BookmarksSection::Bookmark &>(bm).updatePos(new_pit, new_pos, new_id);
}
// current buffer is going to be switched-off, save cursor pos
+ // Ideally, the whole cursor stack should be saved, but session
+ // currently can only handle bottom (whole document) level pit and pos.
+ // That is to say, if a cursor is in a nested inset, it will be
+ // restore to the left of the top level inset.
LyX::ref().session().lastFilePos().save(FileName(buffer_->fileName()),
- boost::tie(cursor_.pit(), cursor_.pos()) );
+ boost::tie(cursor_.bottom().pit(), cursor_.bottom().pos()) );
}
// If we're quitting lyx, don't bother updating stuff
// If we are closing current buffer, switch to the first in
// buffer list.
if (!b) {
- lyxerr[Debug::INFO] << BOOST_CURRENT_FUNCTION
+ LYXERR(Debug::INFO) << BOOST_CURRENT_FUNCTION
<< " No Buffer!" << endl;
// We are closing the buffer, use the first buffer as current
buffer_ = theBufferList().first();
offset_ref_ = 0;
if (buffer_) {
- lyxerr[Debug::INFO] << BOOST_CURRENT_FUNCTION
+ LYXERR(Debug::INFO) << BOOST_CURRENT_FUNCTION
<< "Buffer addr: " << buffer_ << endl;
cursor_.push(buffer_->inset());
cursor_.resetAnchor();
cursor_.resetAnchor();
cursor_.setCursor(buffer_->getCursor().asDocIterator(&(buffer_->inset())));
cursor_.setSelection();
- theSelection().haveSelection(cursor_.selection());
+ // do not set selection to the new buffer because we
+ // only paste recent selection.
}
}
pit_type pit;
pos_type pos;
boost::tie(pit, pos) = LyX::ref().session().lastFilePos().load(filename);
- // if successfully move to pit (returned par_id is not zero), update metrics
- if (moveToPosition(pit, 0, pos).get<1>()) {
+ // if successfully move to pit (returned par_id is not zero), update metrics and reset font
+ if (moveToPosition(pit, pos, 0, 0).get<1>()) {
if (fitCursor())
updateMetrics(false);
+ buffer_->text().setCurrentFont(cursor_);
}
}
if (!buffer_)
return;
- lyxerr[Debug::DEBUG] << BOOST_CURRENT_FUNCTION << endl;
+ LYXERR(Debug::DEBUG) << BOOST_CURRENT_FUNCTION << endl;
updateMetrics(false);
switchKeyMap();
// causes screen update(), I reset last_inset_ to avoid such a problem.
last_inset_ = 0;
// This is close to a hot-path.
- if (lyxerr.debugging(Debug::DEBUG)) {
- lyxerr[Debug::DEBUG]
- << BOOST_CURRENT_FUNCTION
- << "[fitcursor = " << (flags & Update::FitCursor)
- << ", forceupdate = " << (flags & Update::Force)
- << ", singlepar = " << (flags & Update::SinglePar)
- << "] buffer: " << buffer_ << endl;
- }
+ LYXERR(Debug::DEBUG)
+ << BOOST_CURRENT_FUNCTION
+ << "[fitcursor = " << (flags & Update::FitCursor)
+ << ", forceupdate = " << (flags & Update::Force)
+ << ", singlepar = " << (flags & Update::SinglePar)
+ << "] buffer: " << buffer_ << endl;
// Check needed to survive LyX startup
if (!buffer_)
return false;
- if (lyxerr.debugging(Debug::WORKAREA)) {
- lyxerr[Debug::WORKAREA] << "BufferView::update" << std::endl;
- }
+ LYXERR(Debug::WORKAREA) << "BufferView::update" << std::endl;
// Update macro store
buffer_->buildMacros();
void BufferView::updateScrollbar()
{
if (!buffer_) {
- lyxerr[Debug::DEBUG] << BOOST_CURRENT_FUNCTION
+ LYXERR(Debug::DEBUG) << BOOST_CURRENT_FUNCTION
<< " no text in updateScrollbar" << endl;
scrollbarParameters_.reset();
return;
offset_ref_ = 0;
}
- if (lyxerr.debugging(Debug::GUI)) {
- lyxerr[Debug::GUI]
- << BOOST_CURRENT_FUNCTION
- << " Updating scrollbar: height: " << t.paragraphs().size()
- << " curr par: " << cursor_.bottom().pit()
- << " default height " << defaultRowHeight() << endl;
- }
+ LYXERR(Debug::GUI)
+ << BOOST_CURRENT_FUNCTION
+ << " Updating scrollbar: height: " << t.paragraphs().size()
+ << " curr par: " << cursor_.bottom().pit()
+ << " default height " << defaultRowHeight() << endl;
// It would be better to fix the scrollbar to understand
// values in [0..1] and divide everything by wh
void BufferView::scrollDocView(int value)
{
- lyxerr[Debug::GUI] << BOOST_CURRENT_FUNCTION
+ LYXERR(Debug::GUI) << BOOST_CURRENT_FUNCTION
<< "[ value = " << value << "]" << endl;
if (!buffer_)
}
-void BufferView::saveBookmark(bool persistent)
+void BufferView::saveBookmark(unsigned int idx)
{
+ // tenatively save bookmark, id and pos will be used to
+ // acturately locate a bookmark in a 'live' lyx session.
+ // pit and pos will be updated with bottom level pit/pos
+ // when lyx exits.
LyX::ref().session().bookmarks().save(
FileName(buffer_->fileName()),
- cursor_.pit(),
+ cursor_.bottom().pit(),
+ cursor_.bottom().pos(),
cursor_.paragraph().id(),
cursor_.pos(),
- persistent
+ idx
);
- if (persistent)
+ if (idx)
// emit message signal.
message(_("Save bookmark"));
}
-boost::tuple<pit_type, int> BufferView::moveToPosition(pit_type par_pit, int par_id, pos_type par_pos)
+boost::tuple<pit_type, pos_type, int> BufferView::moveToPosition(pit_type bottom_pit, pos_type bottom_pos,
+ int top_id, pos_type top_pos)
{
cursor_.clearSelection();
// if a valid par_id is given, try it first
- if (par_id > 0) {
- ParIterator par = buffer_->getParFromID(par_id);
+ // This is the case for a 'live' bookmark when unique paragraph ID
+ // is used to track bookmarks.
+ if (top_id > 0) {
+ ParIterator par = buffer_->getParFromID(top_id);
if (par != buffer_->par_iterator_end()) {
- setCursor(makeDocIterator(par, min(par->size(), par_pos)));
- return boost::make_tuple(cursor_.pit(), par_id);
+ DocIterator dit = makeDocIterator(par, min(par->size(), top_pos));
+ // Some slices of the iterator may not be reachable (e.g. closed collapsable inset)
+ // so the dociterator may need to be shortened. Otherwise, setCursor may
+ // crash lyx when the cursor can not be set to these insets.
+ size_t const n = dit.depth();
+ for (size_t i = 0; i < n; ++i)
+ if (dit[i].inset().editable() != InsetBase::HIGHLY_EDITABLE) {
+ dit.resize(i);
+ break;
+ }
+ setCursor(dit);
+ // Note: return bottom (document) level pit.
+ return boost::make_tuple(cursor_.bottom().pit(), cursor_.bottom().pos(), top_id);
}
}
- // if par_id == 0, or searching through par_id failed
- if (static_cast<size_t>(par_pit) < buffer_->paragraphs().size()) {
+ // if top_id == 0, or searching through top_id failed
+ // This is the case for a 'restored' bookmark when only bottom
+ // (document level) pit was saved. Because of this, bookmark
+ // restoration is inaccurate. If a bookmark was within an inset,
+ // it will be restored to the left of the outmost inset that contains
+ // the bookmark.
+ if (static_cast<size_t>(bottom_pit) < buffer_->paragraphs().size()) {
ParIterator it = buffer_->par_iterator_begin();
ParIterator const end = buffer_->par_iterator_end();
for (; it != end; ++it)
- if (it.pit() == par_pit) {
+ if (it.pit() == bottom_pit) {
// restored pos may be bigger than it->size
- setCursor(makeDocIterator(it, min(par_pos, it->size())));
- return boost::make_tuple(par_pit, it->id());
+ setCursor(makeDocIterator(it, min(bottom_pos, it->size())));
+ return boost::make_tuple(bottom_pit, bottom_pos, it->id());
}
}
// both methods fail
- return boost::make_tuple(pit_type(0), 0);
+ return boost::make_tuple(pit_type(0), pos_type(0), 0);
}
if (!lyxrc.rtl_support)
return;
- if (getLyXText()->real_current_font.isRightToLeft()) {
+ if (cursor_.innerText()->real_current_font.isRightToLeft()) {
if (intl_->keymap == Intl::PRIMARY)
intl_->keyMapSec();
} else {
flag.setOnOff(buffer_->params().trackChanges);
break;
- case LFUN_CHANGES_OUTPUT: {
- OutputParams runparams;
- LaTeXFeatures features(*buffer_, buffer_->params(), runparams);
- flag.enabled(buffer_ && features.isAvailable("dvipost"));
+ case LFUN_CHANGES_OUTPUT:
+ flag.enabled(buffer_ && LaTeXFeatures::isAvailable("dvipost"));
flag.setOnOff(buffer_->params().outputChanges);
break;
- }
case LFUN_CHANGES_MERGE:
case LFUN_CHANGE_NEXT:
// << [ cmd = " << cmd << "]" << endl;
// Make sure that the cached BufferView is correct.
- lyxerr[Debug::ACTION] << BOOST_CURRENT_FUNCTION
+ LYXERR(Debug::ACTION) << BOOST_CURRENT_FUNCTION
<< " action[" << cmd.action << ']'
<< " arg[" << to_utf8(cmd.argument()) << ']'
<< " x[" << cmd.x << ']'
if (inset) {
label = inset->getParam("reference");
// persistent=false: use temp_bookmark
- saveBookmark(false);
+ saveBookmark(0);
}
}
for (Buffer * b = buffer_; i == 0 || b != buffer_; b = theBufferList().next(b)) {
ParIterator par = b->getParFromID(id);
if (par == b->par_iterator_end()) {
- lyxerr[Debug::INFO]
+ LYXERR(Debug::INFO)
<< "No matching paragraph found! ["
<< id << "]." << endl;
} else {
- lyxerr[Debug::INFO]
+ LYXERR(Debug::INFO)
<< "Paragraph " << par->id()
<< " found in buffer `"
<< b->fileName() << "'." << endl;
showDialog("changes");
break;
- case LFUN_ALL_CHANGES_ACCEPT: {
+ case LFUN_ALL_CHANGES_ACCEPT:
+ // select complete document
cursor_.reset(buffer_->inset());
-#ifdef WITH_WARNINGS
-#warning FIXME changes
-#endif
- while (findNextChange(this))
- getLyXText()->acceptOrRejectChanges(cursor_, LyXText::ACCEPT);
+ cursor_.selHandle(true);
+ buffer_->text().cursorBottom(cursor_);
+ // accept everything in a single step to support atomic undo
+ buffer_->text().acceptOrRejectChanges(cursor_, LyXText::ACCEPT);
break;
- }
- case LFUN_ALL_CHANGES_REJECT: {
+ case LFUN_ALL_CHANGES_REJECT:
+ // select complete document
cursor_.reset(buffer_->inset());
-#ifdef WITH_WARNINGS
-#warning FIXME changes
-#endif
- while (findNextChange(this))
- getLyXText()->acceptOrRejectChanges(cursor_, LyXText::REJECT);
+ cursor_.selHandle(true);
+ buffer_->text().cursorBottom(cursor_);
+ // reject everything in a single step to support atomic undo
+ // Note: reject does not work recursively; the user may have to repeat the operation
+ buffer_->text().acceptOrRejectChanges(cursor_, LyXText::REJECT);
break;
- }
case LFUN_WORD_FIND:
find(this, cmd);
{
if (buffer_) {
cursor_.clearSelection();
+ // Clear the selection buffer. Otherwise a subsequent
+ // middle-mouse-button paste would use the selection buffer,
+ // not the more current external selection.
+ cap::clearSelection();
xsel_cache_.set = false;
// The buffer did not really change, but this causes the
// redraw we need because we cleared the selection above.
}
+InsetBase const * BufferView::getCoveringInset(LyXText const & text, int x, int y)
+{
+ pit_type pit = text.getPitNearY(*this, y);
+ BOOST_ASSERT(pit != -1);
+ Paragraph const & par = text.getPar(pit);
+
+ LYXERR(Debug::DEBUG)
+ << BOOST_CURRENT_FUNCTION
+ << ": x: " << x
+ << " y: " << y
+ << " pit: " << pit
+ << endl;
+ InsetList::const_iterator iit = par.insetlist.begin();
+ InsetList::const_iterator iend = par.insetlist.end();
+ for (; iit != iend; ++iit) {
+ InsetBase * const inset = iit->inset;
+ if (inset->covers(*this, x, y)) {
+ if (!inset->descendable())
+ // No need to go further down if the inset is not
+ // descendable.
+ return inset;
+
+ size_t cell_number = inset->nargs();
+ // Check all the inner cell.
+ for (size_t i = 0; i != cell_number; ++i) {
+ LyXText const * inner_text = inset->getText(i);
+ if (inner_text) {
+ // Try deeper.
+ InsetBase const * inset_deeper =
+ getCoveringInset(*inner_text, x, y);
+ if (inset_deeper)
+ return inset_deeper;
+ }
+ }
+
+ LYXERR(Debug::DEBUG)
+ << BOOST_CURRENT_FUNCTION
+ << ": Hit inset: " << inset << endl;
+ return inset;
+ }
+ }
+ LYXERR(Debug::DEBUG)
+ << BOOST_CURRENT_FUNCTION
+ << ": No inset hit. " << endl;
+ return 0;
+}
+
+
bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
{
//lyxerr << BOOST_CURRENT_FUNCTION << "[ cmd0 " << cmd0 << "]" << endl;
// Either the inset under the cursor or the
// surrounding LyXText will handle this event.
- // Build temporary cursor.
+ // make sure we stay within the screen...
cmd.y = min(max(cmd.y, -1), height_);
- InsetBase * inset = buffer_->text().editXY(cur, cmd.x, cmd.y);
-
- //lyxerr << BOOST_CURRENT_FUNCTION
- // << " * hit inset at tip: " << inset << endl;
- //lyxerr << BOOST_CURRENT_FUNCTION
- // << " * created temp cursor:" << cur << endl;
-
- // NOTE: editXY returns the top level inset of nested insets. If you happen
- // to move from a text (inset=0) to a text inside an inset (e.g. an opened
- // footnote inset, again inset=0), that inset will not be redrawn.
+
if (cmd.action == LFUN_MOUSE_MOTION && cmd.button() == mouse_button::none) {
- bool need_redraw = false;
- if (inset != last_inset_) {
- if (last_inset_)
- need_redraw |= last_inset_->setMouseHover(false);
- if (inset)
- need_redraw |= inset->setMouseHover(true);
- last_inset_ = inset;
- }
+ // Get inset under mouse, if there is one.
+ InsetBase const * covering_inset =
+ getCoveringInset(buffer_->text(), cmd.x, cmd.y);
+ if (covering_inset == last_inset_)
+ // Same inset, no need to do anything...
+ return false;
+
+ bool need_redraw = false;
+ // const_cast because of setMouseHover().
+ InsetBase * inset = const_cast<InsetBase *>(covering_inset);
+ if (last_inset_)
+ // Remove the hint on the last hovered inset (if any).
+ need_redraw |= last_inset_->setMouseHover(false);
+ if (inset)
+ // Highlighted the newly hovered inset (if any).
+ need_redraw |= inset->setMouseHover(true);
+ last_inset_ = inset;
// if last metrics update was in singlepar mode, WorkArea::redraw() will
// not expose the button for redraw. We adjust here the metrics dimension
// This should be changed if it is further utilized.
return need_redraw;
}
+
+ // Build temporary cursor.
+ InsetBase * inset = buffer_->text().editXY(cur, cmd.x, cmd.y);
// Put anchor at the same position.
cur.resetAnchor();
}
-LyXText * BufferView::getLyXText()
-{
- LyXText * text = cursor_.innerText();
- BOOST_ASSERT(text);
- return text;
-}
-
-
-LyXText const * BufferView::getLyXText() const
-{
- LyXText const * text = cursor_.innerText();
- BOOST_ASSERT(text);
- return text;
-}
-
-
TextMetrics const & BufferView::textMetrics(LyXText const * t) const
{
return const_cast<BufferView *>(this)->textMetrics(t);
// Has the cursor just left the inset?
bool badcursor = false;
- if (&cursor_.inset() != &cur.inset())
+ bool leftinset = (&cursor_.inset() != &cur.inset());
+ if (leftinset)
badcursor = cursor_.inset().notifyCursorLeaves(cursor_);
// do the dEPM magic if needed
- // FIXME: move this to InsetText::notifyCursorLeaves?
- bool update = false;
+ // FIXME: (1) move this to InsetText::notifyCursorLeaves?
+ // FIXME: (2) if we had a working InsetText::notifyCursorLeaves,
+ // the leftinset bool would not be necessary (badcursor instead).
+ bool update = leftinset;
if (!badcursor && cursor_.inTexted())
- checkDepm(cur, cursor_);
+ update |= checkDepm(cur, cursor_);
// if the cursor was in an empty script inset and the new
// position is in the nucleus of the inset, notifyCursorLeaves
cursor_.setCursor(dit);
cursor_.clearSelection();
- // remember new position.
- cursor_.setTargetX();
finishUndo();
return update;
}
cursor_.setSelection(cursor_, -length);
} else
cursor_.setSelection(cursor_, length);
- theSelection().haveSelection(cursor_.selection());
+ cap::saveSelection(cursor_);
}
}
pit2 = cursor_.bottom().pit();
}
- lyxerr[Debug::DEBUG]
+ LYXERR(Debug::DEBUG)
<< BOOST_CURRENT_FUNCTION
<< " y1: " << y1
<< " y2: " << y2
singlepar? SingleParUpdate: FullScreenUpdate, size);
if (lyxerr.debugging(Debug::WORKAREA)) {
- lyxerr[Debug::WORKAREA] << "BufferView::updateMetrics" << endl;
+ LYXERR(Debug::WORKAREA) << "BufferView::updateMetrics" << endl;
coord_cache_.dump();
}
}
FileDialog fileDlg(_("Select LyX document to insert"),
LFUN_FILE_INSERT,
make_pair(_("Documents|#o#O"), from_utf8(lyxrc.document_path)),
- make_pair(_("Examples|#E#e"), from_utf8(addPath(package().system_support(), "examples"))));
+ make_pair(_("Examples|#E#e"), from_utf8(addPath(package().system_support().absFilename(), "examples"))));
FileDialog::Result result =
fileDlg.open(from_utf8(initpath),
projects / lyx.git / blobdiff