* allow resizing of detached panel

[lyx.git] / src / BufferView.C

diff --git a/src/BufferView.C b/src/BufferView.C
index a5f7956928ef3ff0e2cad8b09813d6db2885ad1d..9c0b961567d35c5e771d3f40e445b9f6d8155567 100644 (file)
--- a/src/BufferView.C
+++ b/src/BufferView.C
@@ -197,7 +197,8 @@ void BufferView::setBuffer(Buffer * b)
                }
        }
 
-       update();
+       if (buffer_)
+               updateMetrics(false);    
 
        if (buffer_ && graphics::Previews::status() != LyXRC::PREVIEW_OFF)
                graphics::Previews::get().generateBufferPreviews(*buffer_);
@@ -278,7 +279,9 @@ bool BufferView::loadLyXFile(string const & filename, bool tolastfiles)
                                if (it.pit() == pit) {
                                        // restored pos may be bigger than it->size
                                        setCursor(makeDocIterator(it, min(pos, it->size())));
-                                       update(Update::FitCursor);
+                                       // No need to update the metrics if fitCursor returns false.
+                                       if (fitCursor())
+                                               updateMetrics(false);
                                        break;
                                }
                }
@@ -339,7 +342,7 @@ bool BufferView::multiParSel()
 }
 
 
-bool BufferView::update(Update::flags flags)
+std::pair<bool, bool> BufferView::update(Update::flags flags)
 {
        // This is close to a hot-path.
        if (lyxerr.debugging(Debug::DEBUG)) {
@@ -353,7 +356,7 @@ bool BufferView::update(Update::flags flags)
 
        // Check needed to survive LyX startup
        if (!buffer_)
-               return false;
+               return make_pair(false, false);
 
        if (lyxerr.debugging(Debug::WORKAREA)) {
                lyxerr[Debug::WORKAREA] << "BufferView::update" << std::endl;
@@ -362,15 +365,28 @@ bool BufferView::update(Update::flags flags)
        // Update macro store
        buffer_->buildMacros();
 
-       // First drawing step
-       updateMetrics(flags & Update::SinglePar);
-
+       // Now do the first drawing step if needed. This consists on updating
+       // the CoordCache in updateMetrics().
        // The second drawing step is done in WorkArea::redraw() if needed.
-       bool const need_second_step =
-               (flags & (Update::SinglePar | Update::Force | Update::FitCursor | Update::MultiParSel))
-               && (fitCursor() || multiParSel());
 
-       return need_second_step;
+       // Case when no explicit update is requested.
+       if (!flags) {
+               // no need to do anything.
+               return make_pair(false, false);
+       }
+
+       bool full_metrics = flags & Update::Force;
+       if (flags & Update::MultiParSel)
+               full_metrics |= multiParSel();
+
+       bool const single_par = !full_metrics;
+       updateMetrics(single_par);
+
+       if (flags & Update::FitCursor && fitCursor())
+               updateMetrics(false);
+
+       // tell the frontend to update the screen.
+       return make_pair(true, single_par);
 }
 
 
@@ -460,6 +476,7 @@ void BufferView::scrollDocView(int value)
        t.redoParagraph(*this, anchor_ref_);
        int const h = t.getPar(anchor_ref_).height();
        offset_ref_ = int((bar * t.paragraphs().size() - anchor_ref_) * h);
+       updateMetrics(false);
 }
 
 
@@ -1006,7 +1023,7 @@ void BufferView::workAreaResize(int width, int height)
 }
 
 
-bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
+std::pair<bool, bool> BufferView::workAreaDispatch(FuncRequest const & cmd0)
 {
        //lyxerr << BOOST_CURRENT_FUNCTION << "[ cmd0 " << cmd0 << "]" << endl;
 
@@ -1016,14 +1033,11 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
 
        // E.g. Qt mouse press when no buffer
        if (!buffer_)
-               return false;
-
-       bool needRedraw = false;
+               return make_pair(false, false);
 
        LCursor cur(*this);
        cur.push(buffer_->inset());
        cur.selection() = cursor_.selection();
-       needRedraw |= cur.selection();
 
        // Either the inset under the cursor or the
        // surrounding LyXText will handle this event.
@@ -1046,7 +1060,6 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
        //  cur.bv().cursor() = cur;  (or similar)
        if (inset) {
                inset->dispatch(cur, cmd);
-               needRedraw = true;
        }
 
        // Now dispatch to the temporary cursor. If the real cursor should
@@ -1054,17 +1067,12 @@ bool BufferView::workAreaDispatch(FuncRequest const & cmd0)
        if (!cur.result().dispatched())
                cur.dispatch(cmd);
 
-       if (cur.result().dispatched()) {
-               // Redraw if requested or necessary.
-               if (cur.result().update())
-                       needRedraw |= update(Update::FitCursor | Update::Force);
-               else
-                       needRedraw |= update(Update::FitCursor | Update::MultiParSel);
-       }
+       // Redraw if requested and necessary.
+       if (cur.result().dispatched() && cur.result().update())
+               return update(cur.result().update());
 
        // When the above and the inner function are fixed, we can do this:
-       //return needRedraw;
-       return true;
+       return make_pair(false, false);
 }
 
 
@@ -1217,7 +1225,7 @@ ViewMetricsInfo const & BufferView::viewMetricsInfo()
 void BufferView::updateMetrics(bool singlepar)
 {
        // Clear out the position cache in case of full screen redraw.
-       //if (!singlepar)
+       if (!singlepar)
                coord_cache_.clear();
 
        LyXText & buftext = buffer_->text();