]> git.lyx.org Git - lyx.git/blobdiff - src/Buffer.cpp
Fixed some lines that were too long. It compiled afterwards.
[lyx.git] / src / Buffer.cpp
index 2216084ed123c8c45a7573979dcc28eaa785a917..5e9972138cb09dce281f4ccf29087e79fadbfcc1 100644 (file)
@@ -33,7 +33,8 @@
 #include "LaTeXFeatures.h"
 #include "LyXAction.h"
 #include "Lexer.h"
-#include "LyXText.h"
+#include "Text.h"
+#include "LyX.h"
 #include "LyXRC.h"
 #include "LyXVC.h"
 #include "Messages.h"
@@ -46,6 +47,7 @@
 #include "ParIterator.h"
 #include "sgml.h"
 #include "TexRow.h"
+#include "TexStream.h"
 #include "TocBackend.h"
 #include "Undo.h"
 #include "version.h"
 #include "insets/InsetText.h"
 
 #include "mathed/MathMacroTemplate.h"
-#include "mathed/MathMacroTable.h"
+#include "mathed/MacroTable.h"
 #include "mathed/MathSupport.h"
 
-#include "frontends/Alert.h"
+#include "frontends/alert.h"
 
 #include "graphics/Previews.h"
 
 #include "support/lyxalgo.h"
 #include "support/filetools.h"
 #include "support/fs_extras.h"
+#include "support/gzstream.h"
 #include "support/lyxlib.h"
 #include "support/os.h"
 #include "support/Path.h"
 #include "support/textutils.h"
 #include "support/convert.h"
 
-#include <boost/iostreams/filtering_stream.hpp>
-#include <boost/iostreams/filter/gzip.hpp>
-#include <boost/iostreams/device/file.hpp>
 #include <boost/bind.hpp>
 #include <boost/filesystem/exception.hpp>
 #include <boost/filesystem/operations.hpp>
 
-#if defined (HAVE_UTIME_H)
-#include <utime.h>
-#elif defined (HAVE_SYS_UTIME_H)
-#include <sys/utime.h>
-#endif
-
+#include <algorithm>
 #include <iomanip>
 #include <stack>
 #include <sstream>
 #include <fstream>
 
+using std::endl;
+using std::for_each;
+using std::make_pair;
+
+using std::ios;
+using std::map;
+using std::ostream;
+using std::ostringstream;
+using std::ofstream;
+using std::pair;
+using std::stack;
+using std::vector;
+using std::string;
+using std::time_t;
+
 
 namespace lyx {
 
@@ -118,30 +128,15 @@ using support::split;
 using support::subst;
 using support::tempName;
 using support::trim;
+using support::sum;
 
 namespace Alert = frontend::Alert;
 namespace os = support::os;
 namespace fs = boost::filesystem;
-namespace io = boost::iostreams;
-
-using std::endl;
-using std::for_each;
-using std::make_pair;
-
-using std::ios;
-using std::map;
-using std::ostream;
-using std::ostringstream;
-using std::ofstream;
-using std::pair;
-using std::stack;
-using std::vector;
-using std::string;
-
 
 namespace {
 
-int const LYX_FORMAT = 265;
+int const LYX_FORMAT = 278;
 
 } // namespace anon
 
@@ -184,7 +179,7 @@ public:
         */
        bool file_fully_loaded;
 
-       /// our LyXText that should be wrapped in an InsetText
+       /// our Text that should be wrapped in an InsetText
        InsetText inset;
 
        ///
@@ -192,13 +187,21 @@ public:
 
        ///
        TocBackend toc_backend;
+
+       /// Container for all sort of Buffer dependant errors.
+       map<string, ErrorList> errorLists;
+
+       /// timestamp and checksum used to test if the file has been externally
+       /// modified. (Used to properly enable 'File->Revert to saved', bug 4114).
+       time_t timestamp_;
+       unsigned long checksum_;
 };
 
 
 Buffer::Impl::Impl(Buffer & parent, FileName const & file, bool readonly_)
        : lyx_clean(true), bak_clean(true), unnamed(false), read_only(readonly_),
          filename(file), file_fully_loaded(false), inset(params),
-         toc_backend(&parent)
+         toc_backend(&parent), timestamp_(0), checksum_(0)
 {
        inset.setAutoBreakRows(true);
        lyxvc.buffer(&parent);
@@ -236,13 +239,13 @@ Buffer::~Buffer()
 }
 
 
-LyXText & Buffer::text() const
+Text & Buffer::text() const
 {
-       return const_cast<LyXText &>(pimpl_->inset.text_);
+       return const_cast<Text &>(pimpl_->inset.text_);
 }
 
 
-InsetBase & Buffer::inset() const
+Inset & Buffer::inset() const
 {
        return const_cast<InsetText &>(pimpl_->inset);
 }
@@ -426,12 +429,13 @@ int Buffer::readHeader(Lexer & lex)
        params().headheight.erase();
        params().headsep.erase();
        params().footskip.erase();
+       params().listings_params.clear();
        for (int i = 0; i < 4; ++i) {
                params().user_defined_bullet(i) = ITEMIZE_DEFAULTS[i];
                params().temp_bullet(i) = ITEMIZE_DEFAULTS[i];
        }
 
-       ErrorList & errorList = errorLists_["Parse"];
+       ErrorList & errorList = pimpl_->errorLists["Parse"];
 
        while (lex.isOK()) {
                lex.next();
@@ -482,7 +486,7 @@ int Buffer::readHeader(Lexer & lex)
 // Returns false if "\end_document" is not read (Asger)
 bool Buffer::readDocument(Lexer & lex)
 {
-       ErrorList & errorList = errorLists_["Parse"];
+       ErrorList & errorList = pimpl_->errorLists["Parse"];
        errorList.clear();
 
        lex.next();
@@ -497,14 +501,34 @@ bool Buffer::readDocument(Lexer & lex)
        BOOST_ASSERT(paragraphs().empty());
 
        readHeader(lex);
-       if (!params().getLyXTextClass().load(filePath())) {
-               string theclass = params().getLyXTextClass().name();
+       if (!params().getTextClass().load(filePath())) {
+               string theclass = params().getTextClass().name();
                Alert::error(_("Can't load document class"), bformat(
                        _("Using the default document class, because the "
                                     "class %1$s could not be loaded."), from_utf8(theclass)));
                params().textclass = 0;
        }
 
+       if (params().outputChanges) {
+               bool dvipost    = LaTeXFeatures::isAvailable("dvipost");
+               bool xcolorsoul = LaTeXFeatures::isAvailable("soul") &&
+                                 LaTeXFeatures::isAvailable("xcolor");
+
+               if (!dvipost && !xcolorsoul) {
+                       Alert::warning(_("Changes not shown in LaTeX output"),
+                                      _("Changes will not be highlighted in LaTeX output, "
+                                        "because neither dvipost nor xcolor/soul are installed.\n"
+                                        "Please install these packages or redefine "
+                                        "\\lyxadded and \\lyxdeleted in the LaTeX preamble."));
+               } else if (!xcolorsoul) {
+                       Alert::warning(_("Changes not shown in LaTeX output"),
+                                      _("Changes will not be highlighted in LaTeX output "
+                                        "when using pdflatex, because xcolor and soul are not installed.\n"
+                                        "Please install both packages or redefine "
+                                        "\\lyxadded and \\lyxdeleted in the LaTeX preamble."));
+               }
+       }
+
        bool const res = text().read(*this, lex, errorList);
        for_each(text().paragraphs().begin(),
                 text().paragraphs().end(),
@@ -517,9 +541,9 @@ bool Buffer::readDocument(Lexer & lex)
 // needed to insert the selection
 void Buffer::insertStringAsLines(ParagraphList & pars,
        pit_type & pit, pos_type & pos,
-       LyXFont const & fn, docstring const & str, bool autobreakrows)
+       Font const & fn, docstring const & str, bool autobreakrows)
 {
-       LyXFont font = fn;
+       Font font = fn;
 
        // insert the string, don't insert doublespace
        bool space_inserted = true;
@@ -696,10 +720,10 @@ Buffer::ReadStatus Buffer::readFile(Lexer & lex, FileName const & filename,
                }
                ostringstream command;
                command << os::python()
-                       << ' ' << quoteName(lyx2lyx.toFilesystemEncoding())
-                       << " -t " << convert<string>(LYX_FORMAT)
-                       << " -o " << quoteName(tmpfile.toFilesystemEncoding())
-                       << ' ' << quoteName(filename.toFilesystemEncoding());
+                       << ' ' << quoteName(lyx2lyx.toFilesystemEncoding())
+                       << " -t " << convert<string>(LYX_FORMAT)
+                       << " -o " << quoteName(tmpfile.toFilesystemEncoding())
+                       << ' ' << quoteName(filename.toFilesystemEncoding());
                string const command_str = command.str();
 
                LYXERR(Debug::INFO) << "Running '"
@@ -734,6 +758,9 @@ Buffer::ReadStatus Buffer::readFile(Lexer & lex, FileName const & filename,
        //MacroTable::localMacros().clear();
 
        pimpl_->file_fully_loaded = true;
+       // save the timestamp and checksum of disk file
+       pimpl_->timestamp_ = fs::last_write_time(filename.toFilesystemEncoding());
+       pimpl_->checksum_ = sum(filename);
        return success;
 }
 
@@ -754,23 +781,36 @@ bool Buffer::save() const
                backupName = FileName(fileName() + '~');
                if (!lyxrc.backupdir_path.empty())
                        backupName = FileName(addName(lyxrc.backupdir_path,
-                                             subst(os::internal_path(backupName.absFilename()), '/', '!')));
+                                             subst(os::internal_path(backupName.absFilename()), '/', '!')));
 
                try {
                        fs::copy_file(encodedFilename, backupName.toFilesystemEncoding(), false);
                        madeBackup = true;
                } catch (fs::filesystem_error const & fe) {
                        Alert::error(_("Backup failure"),
-                                    bformat(_("Cannot create backup file %1$s.\n"
-                                              "Please check whether the directory exists and is writeable."),
-                                            from_utf8(backupName.absFilename())));
+                                    bformat(_("Cannot create backup file %1$s.\n"
+                                              "Please check whether the directory exists and is writeable."),
+                                            from_utf8(backupName.absFilename())));
                        LYXERR(Debug::DEBUG) << "Fs error: " << fe.what() << endl;
                }
        }
 
+       // ask if the disk file has been externally modified (use checksum method)
+       if (fs::exists(encodedFilename) && isExternallyModified(checksum_method)) {
+               docstring const file = makeDisplayPath(fileName(), 20);
+               docstring text = bformat(_("Document %1$s has been externally modified. Are you sure "
+                                                            "you want to overwrite this file?"), file);
+               int const ret = Alert::prompt(_("Overwrite modified file?"),
+                       text, 1, 1, _("&Overwrite"), _("&Cancel"));
+               if (ret == 1)
+                       return false;
+       }
+
        if (writeFile(pimpl_->filename)) {
                markClean();
                removeAutosaveFile(fileName());
+               pimpl_->timestamp_ = fs::last_write_time(pimpl_->filename.toFilesystemEncoding());
+               pimpl_->checksum_ = sum(pimpl_->filename);
                return true;
        } else {
                // Saving failed, so backup is not backup
@@ -789,7 +829,7 @@ bool Buffer::writeFile(FileName const & fname) const
        bool retval = false;
 
        if (params().compressed) {
-               io::filtering_ostream ofs(io::gzip_compressor() | io::file_sink(fname.toFilesystemEncoding()));
+               gz::ogzstream ofs(fname.toFilesystemEncoding().c_str(), ios::out|ios::trunc);
                if (!ofs)
                        return false;
 
@@ -821,6 +861,19 @@ bool Buffer::write(ostream & ofs) const
            << "\\lyxformat " << LYX_FORMAT << "\n"
            << "\\begin_document\n";
 
+
+       /// For each author, set 'used' to true if there is a change
+       /// by this author in the document; otherwise set it to 'false'.
+       AuthorList::Authors::const_iterator a_it = params().authors().begin();
+       AuthorList::Authors::const_iterator a_end = params().authors().end();
+       for (; a_it != a_end; ++a_it)
+               a_it->second.used(false);
+
+       ParIterator const end = par_iterator_end();
+       ParIterator it = par_iterator_begin();
+       for ( ; it != end; ++it)
+               it->checkAuthors(params().authors());
+
        // now write out the buffer parameters.
        ofs << "\\begin_header\n";
        params().writeFile(ofs);
@@ -868,26 +921,38 @@ bool Buffer::makeLaTeXFile(FileName const & fname,
        if (!openFileWrite(ofs, fname))
                return false;
 
+       //TexStream ts(ofs.rdbuf(), &texrow());
+
+       bool failed_export = false;
        try {
                writeLaTeXSource(ofs, original_path,
                      runparams, output_preamble, output_body);
        }
-       catch (iconv_codecvt_facet_exception &) {
-               Alert::error(_("Encoding error"),
-                       _("Some characters of your document are not "
-                         "representable in the chosen encoding.\n"
-                         "Changing the document encoding to utf8 could help."));
-               return false;
+       catch (iconv_codecvt_facet_exception & e) {
+               lyxerr << "Caught iconv exception: " << e.what() << endl;
+               failed_export = true;
+       }
+       catch (std::exception const & e) {
+               lyxerr << "Caught \"normal\" exception: " << e.what() << endl;
+               failed_export = true;
+       }
+       catch (...) {
+               lyxerr << "Caught some really weird exception..." << endl;
+               LyX::cref().emergencyCleanup();
+               abort();
        }
 
        ofs.close();
        if (ofs.fail()) {
+               failed_export = true;
                lyxerr << "File '" << fname << "' was not closed properly." << endl;
-               Alert::error(_("Error closing file"),
-                       _("The output file could not be closed properly.\n"
-                         " Probably some characters of your document are not "
-                         "representable in the chosen encoding.\n"
-                         "Changing the document encoding to utf8 could help."));
+       }
+
+       if (failed_export) {
+               Alert::error(_("Encoding error"),
+                       _("Some characters of your document are probably not "
+                       "representable in the chosen encoding.\n"
+                       "Changing the document encoding to utf8 could help."));
                return false;
        }
        return true;
@@ -964,15 +1029,26 @@ void Buffer::writeLaTeXSource(odocstream & os,
        } // output_preamble
        LYXERR(Debug::INFO) << "preamble finished, now the body." << endl;
 
-       if (!lyxrc.language_auto_begin) {
+       if (!lyxrc.language_auto_begin &&
+           !params().language->babel().empty()) {
                // FIXME UNICODE
                os << from_utf8(subst(lyxrc.language_command_begin,
-                                          "$$lang",
-                                          params().language->babel()))
+                                          "$$lang",
+                                          params().language->babel()))
                   << '\n';
                texrow().newline();
        }
 
+       Encoding const & encoding = params().encoding();
+       if (encoding.package() == Encoding::CJK) {
+               // Open a CJK environment, since in contrast to the encodings
+               // handled by inputenc the document encoding is not set in
+               // the preamble if it is handled by CJK.sty.
+               os << "\\begin{CJK}{" << from_ascii(encoding.latexName())
+                  << "}{}\n";
+               texrow().newline();
+       }
+
        // if we are doing a real file with body, even if this is the
        // child of some other buffer, let's cut the link here.
        // This happens for example if only a child document is printed.
@@ -993,10 +1069,19 @@ void Buffer::writeLaTeXSource(odocstream & os,
        os << endl;
        texrow().newline();
 
-       if (!lyxrc.language_auto_end) {
+       if (encoding.package() == Encoding::CJK) {
+               // Close the open CJK environment.
+               // latexParagraphs will have opened one even if the last text
+               // was not CJK.
+               os << "\\end{CJK}\n";
+               texrow().newline();
+       }
+
+       if (!lyxrc.language_auto_end &&
+           !params().language->babel().empty()) {
                os << from_utf8(subst(lyxrc.language_command_end,
-                                          "$$lang",
-                                          params().language->babel()))
+                                          "$$lang",
+                                          params().language->babel()))
                   << '\n';
                texrow().newline();
        }
@@ -1023,19 +1108,19 @@ void Buffer::writeLaTeXSource(odocstream & os,
 
 bool Buffer::isLatex() const
 {
-       return params().getLyXTextClass().outputType() == LATEX;
+       return params().getTextClass().outputType() == LATEX;
 }
 
 
 bool Buffer::isLiterate() const
 {
-       return params().getLyXTextClass().outputType() == LITERATE;
+       return params().getTextClass().outputType() == LITERATE;
 }
 
 
 bool Buffer::isDocBook() const
 {
-       return params().getLyXTextClass().outputType() == DOCBOOK;
+       return params().getTextClass().outputType() == DOCBOOK;
 }
 
 
@@ -1046,7 +1131,7 @@ void Buffer::makeDocBookFile(FileName const & fname,
        LYXERR(Debug::LATEX) << "makeDocBookFile..." << endl;
 
        //ofstream ofs;
-        odocfstream ofs;
+       odocfstream ofs;
        if (!openFileWrite(ofs, fname))
                return;
 
@@ -1067,19 +1152,19 @@ void Buffer::writeDocBookSource(odocstream & os, string const & fname,
 
        texrow().reset();
 
-       LyXTextClass const & tclass = params().getLyXTextClass();
+       TextClass const & tclass = params().getTextClass();
        string const top_element = tclass.latexname();
 
        if (!only_body) {
                if (runparams.flavor == OutputParams::XML)
                        os << "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n";
 
-                // FIXME UNICODE
+               // FIXME UNICODE
                os << "<!DOCTYPE " << from_ascii(top_element) << ' ';
 
-                // FIXME UNICODE
+               // FIXME UNICODE
                if (! tclass.class_header().empty())
-                        os << from_ascii(tclass.class_header());
+                       os << from_ascii(tclass.class_header());
                else if (runparams.flavor == OutputParams::XML)
                        os << "PUBLIC \"-//OASIS//DTD DocBook XML//EN\" "
                            << "\"http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd\"";
@@ -1100,7 +1185,7 @@ void Buffer::writeDocBookSource(odocstream & os, string const & fname,
                preamble += features.getLyXSGMLEntities();
 
                if (!preamble.empty()) {
-                        os << "\n [ " << preamble << " ]";
+                       os << "\n [ " << preamble << " ]";
                }
                os << ">\n\n";
        }
@@ -1122,7 +1207,7 @@ void Buffer::writeDocBookSource(odocstream & os, string const & fname,
            << " file was created by LyX " << lyx_version
            << "\n  See http://www.lyx.org/ for more information -->\n";
 
-       params().getLyXTextClass().counters().reset();
+       params().getTextClass().counters().reset();
 
        sgml::openTag(os, top);
        os << '\n';
@@ -1159,7 +1244,7 @@ int Buffer::runChktex()
                Alert::error(_("chktex failure"),
                             _("Could not run chktex successfully."));
        } else if (res > 0) {
-               ErrorList & errorList = errorLists_["ChkTeX"];
+               ErrorList & errorList = pimpl_->errorLists["ChkTeX"];
                // Clear out old errors
                errorList.clear();
                // Fill-in the error list with the TeX errors
@@ -1176,10 +1261,35 @@ int Buffer::runChktex()
 
 void Buffer::validate(LaTeXFeatures & features) const
 {
-       LyXTextClass const & tclass = params().getLyXTextClass();
-
-       if (features.isAvailable("dvipost") && params().outputChanges)
-               features.require("dvipost");
+       TextClass const & tclass = params().getTextClass();
+
+       if (params().outputChanges) {
+               bool dvipost    = LaTeXFeatures::isAvailable("dvipost");
+               bool xcolorsoul = LaTeXFeatures::isAvailable("soul") &&
+                                 LaTeXFeatures::isAvailable("xcolor");
+
+               if (features.runparams().flavor == OutputParams::LATEX) {
+                       if (dvipost) {
+                               features.require("ct-dvipost");
+                               features.require("dvipost");
+                       } else if (xcolorsoul) {
+                               features.require("ct-xcolor-soul");
+                               features.require("soul");
+                               features.require("xcolor");
+                       } else {
+                               features.require("ct-none");
+                       }
+               } else if (features.runparams().flavor == OutputParams::PDFLATEX ) {
+                       if (xcolorsoul) {
+                               features.require("ct-xcolor-soul");
+                               features.require("soul");
+                               features.require("xcolor");
+                               features.require("pdfcolmk"); // improves color handling in PDF output
+                       } else {
+                               features.require("ct-none");
+                       }
+               }
+       }
 
        // AMS Style is at document level
        if (params().use_amsmath == BufferParams::package_on
@@ -1254,15 +1364,15 @@ void Buffer::fillWithBibKeys(vector<pair<string, docstring> > & keys)
        }
 
        for (InsetIterator it = inset_iterator_begin(inset()); it; ++it) {
-               if (it->lyxCode() == InsetBase::BIBTEX_CODE) {
+               if (it->lyxCode() == Inset::BIBTEX_CODE) {
                        InsetBibtex const & inset =
                                static_cast<InsetBibtex const &>(*it);
                        inset.fillWithBibKeys(*this, keys);
-               } else if (it->lyxCode() == InsetBase::INCLUDE_CODE) {
+               } else if (it->lyxCode() == Inset::INCLUDE_CODE) {
                        InsetInclude const & inset =
                                static_cast<InsetInclude const &>(*it);
                        inset.fillWithBibKeys(*this, keys);
-               } else if (it->lyxCode() == InsetBase::BIBITEM_CODE) {
+               } else if (it->lyxCode() == Inset::BIBITEM_CODE) {
                        InsetBibitem const & inset =
                                static_cast<InsetBibitem const &>(*it);
                        // FIXME UNICODE
@@ -1290,14 +1400,14 @@ void Buffer::updateBibfilesCache()
 
        bibfilesCache_.clear();
        for (InsetIterator it = inset_iterator_begin(inset()); it; ++it) {
-               if (it->lyxCode() == InsetBase::BIBTEX_CODE) {
+               if (it->lyxCode() == Inset::BIBTEX_CODE) {
                        InsetBibtex const & inset =
                                static_cast<InsetBibtex const &>(*it);
                        vector<FileName> const bibfiles = inset.getFiles(*this);
                        bibfilesCache_.insert(bibfilesCache_.end(),
                                bibfiles.begin(),
                                bibfiles.end());
-               } else if (it->lyxCode() == InsetBase::INCLUDE_CODE) {
+               } else if (it->lyxCode() == Inset::INCLUDE_CODE) {
                        InsetInclude & inset =
                                static_cast<InsetInclude &>(*it);
                        inset.updateBibfilesCache(*this);
@@ -1451,11 +1561,7 @@ Language const * Buffer::getLanguage() const
 
 docstring const Buffer::B_(string const & l10n) const
 {
-       Language const * lang = pimpl_->params.language;
-       if (lang)
-               return getMessages(lang->code()).get(l10n);
-
-       return _(l10n);
+       return params().B_(l10n);
 }
 
 
@@ -1471,6 +1577,16 @@ bool Buffer::isBakClean() const
 }
 
 
+bool Buffer::isExternallyModified(CheckMethod method) const
+{
+       BOOST_ASSERT(fs::exists(pimpl_->filename.toFilesystemEncoding()));
+       // if method == timestamp, check timestamp before checksum
+       return (method == checksum_method 
+               || pimpl_->timestamp_ != fs::last_write_time(pimpl_->filename.toFilesystemEncoding()))
+               && pimpl_->checksum_ != sum(pimpl_->filename);
+}
+
+
 void Buffer::markClean() const
 {
        if (!pimpl_->lyx_clean) {
@@ -1501,9 +1617,7 @@ bool Buffer::isUnnamed() const
 }
 
 
-#ifdef WITH_WARNINGS
-#warning this function should be moved to buffer_pimpl.C
-#endif
+// FIXME: this function should be moved to buffer_pimpl.C
 void Buffer::markDirty()
 {
        if (pimpl_->lyx_clean) {
@@ -1540,7 +1654,11 @@ bool Buffer::isReadonly() const
 
 void Buffer::setParentName(string const & name)
 {
-       params().parentname = name;
+       if (name == pimpl_->filename.absFilename())
+               // Avoids recursive include.
+               params().parentname.clear();
+       else
+               params().parentname = name;
 }
 
 
@@ -1549,7 +1667,10 @@ Buffer const * Buffer::getMasterBuffer() const
        if (!params().parentname.empty()
            && theBufferList().exists(params().parentname)) {
                Buffer const * buf = theBufferList().getBuffer(params().parentname);
-               if (buf)
+               //We need to check if the parent is us...
+               //FIXME RECURSIVE INCLUDE
+               //This is not sufficient, since recursive includes could be downstream.
+               if (buf && buf != this)
                        return buf->getMasterBuffer();
        }
 
@@ -1604,7 +1725,7 @@ void Buffer::buildMacros()
                InsetList::const_iterator end = insets.end();
                for ( ; it != end; ++it) {
                        //lyxerr << "found inset code " << it->inset->lyxCode() << std::endl;
-                       if (it->inset->lyxCode() == InsetBase::MATHMACRO_CODE) {
+                       if (it->inset->lyxCode() == Inset::MATHMACRO_CODE) {
                                MathMacroTemplate const & mac
                                        = static_cast<MathMacroTemplate const &>(*it->inset);
                                insertMacro(mac.name(), mac.asMacroData());
@@ -1622,14 +1743,14 @@ void Buffer::saveCursor(StableDocIterator cur, StableDocIterator anc)
 
 
 void Buffer::changeRefsIfUnique(docstring const & from, docstring const & to,
-       InsetBase::Code code)
+       Inset::Code code)
 {
        //FIXME: This does not work for child documents yet.
-       BOOST_ASSERT(code == InsetBase::CITE_CODE || code == InsetBase::REF_CODE);
+       BOOST_ASSERT(code == Inset::CITE_CODE || code == Inset::REF_CODE);
        // Check if the label 'from' appears more than once
        vector<docstring> labels;
 
-       if (code == InsetBase::CITE_CODE) {
+       if (code == Inset::CITE_CODE) {
                vector<pair<string, docstring> > keys;
                fillWithBibKeys(keys);
                vector<pair<string, docstring> >::const_iterator bit  = keys.begin();
@@ -1641,7 +1762,7 @@ void Buffer::changeRefsIfUnique(docstring const & from, docstring const & to,
        } else
                getLabelList(labels);
 
-       if (lyx::count(labels.begin(), labels.end(), from) > 1)
+       if (std::count(labels.begin(), labels.end(), from) > 1)
                return;
 
        for (InsetIterator it = inset_iterator_begin(inset()); it; ++it) {
@@ -1664,7 +1785,7 @@ void Buffer::getSourceCode(odocstream & os, pit_type par_begin,
        runparams.dryrun = true;
 
        if (full_source) {
-               os << "% Preview source code\n\n";
+               os << "% " << _("Preview source code") << "\n\n";
                if (isLatex())
                        writeLaTeXSource(os, filePath(), runparams, true, true);
                else {
@@ -1674,10 +1795,15 @@ void Buffer::getSourceCode(odocstream & os, pit_type par_begin,
                runparams.par_begin = par_begin;
                runparams.par_end = par_end;
                if (par_begin + 1 == par_end)
-                       os << "% Preview source code for paragraph " << par_begin << "\n\n";
+                       os << "% "
+                          << bformat(_("Preview source code for paragraph %1$d"), par_begin)
+                          << "\n\n";
                else
-                       os << "% Preview source code from paragraph " << par_begin
-                          << " to " << par_end - 1 << "\n\n";
+                       os << "% "
+                          << bformat(_("Preview source code from paragraph %1$s to %2$s"),
+                                       convert<docstring>(par_begin),
+                                       convert<docstring>(par_end - 1))
+                          << "\n\n";
                // output paragraphs
                if (isLatex()) {
                        texrow().reset();
@@ -1693,8 +1819,8 @@ void Buffer::getSourceCode(odocstream & os, pit_type par_begin,
 ErrorList const & Buffer::errorList(string const & type) const
 {
        static ErrorList const emptyErrorList;
-       std::map<string, ErrorList>::const_iterator I = errorLists_.find(type);
-       if (I == errorLists_.end())
+       std::map<string, ErrorList>::const_iterator I = pimpl_->errorLists.find(type);
+       if (I == pimpl_->errorLists.end())
                return emptyErrorList;
 
        return I->second;
@@ -1703,7 +1829,7 @@ ErrorList const & Buffer::errorList(string const & type) const
 
 ErrorList & Buffer::errorList(string const & type)
 {
-       return errorLists_[type];
+       return pimpl_->errorLists[type];
 }