Hack to display section symbol

[lyx.git] / src / Author.cpp

diff --git a/src/Author.cpp b/src/Author.cpp
index b70815c34912412fa00422e13d9c13797373fe03..ffb12983f050bc8c4bacca4d9b495bfff9de16ba 100644 (file)
--- a/src/Author.cpp
+++ b/src/Author.cpp
@@ -31,8 +31,8 @@ static int computeHash(docstring const & name,
        string const full_author_string = to_utf8(name + email);
        // Bernstein's hash function
        unsigned int hash = 5381;
-       for (unsigned int i = 0; i < full_author_string.length(); ++i)
-               hash = ((hash << 5) + hash) + (unsigned int)(full_author_string[i]);
+       for (char c : full_author_string)
+               hash = ((hash << 5) + hash) + (unsigned int)c;
        return int(hash);
 }
 
@@ -53,8 +53,7 @@ docstring Author::nameAndEmail() const
 {
        if (email().empty())
                return name();
-       else
-               return bformat(_("%1$s[[name]] (%2$s[[email]])"), name(), email());
+       return bformat(_("%1$s[[name]] (%2$s[[email]])"), name(), email());
 }
 
 
@@ -120,12 +119,13 @@ int AuthorList::record(Author const & a)
                if (valid && *it == a)
                        return it - beg;
                if (it->bufferId() == a.bufferId()) {
-                       int id = it - beg;
-                       if (!it->valid())
-                               // we need to handle the case of a valid author being registred
+                       int const id = it - beg;
+                       if (!it->valid()) {
+                               // we need to handle the case of a valid author being registered
                                // after an invalid one. For instance, because "buffer-reload"
                                // does not clear the buffer's author list.
                                record(id, a);
+                       }
                        return id;
                }
        }
@@ -178,13 +178,9 @@ ostream & operator<<(ostream & os, AuthorList const & a)
        // Copy the authorlist, because we don't want to sort the original
        AuthorList sorted = a;
        sorted.sort();
-
-       AuthorList::Authors::const_iterator a_it = sorted.begin();
-       AuthorList::Authors::const_iterator const a_end = sorted.end();
-
-       for (; a_it != a_end; ++a_it) {
-               if (a_it->used() && a_it->valid())
-                       os << "\\author " << *a_it << "\n";
+       for (auto const & aut : sorted) {
+               if (aut.used() && aut.valid())
+                       os << "\\author " << aut << "\n";
        }
        return os;
 }