Safe use of 'cut' with Win32 filenames.

[lyx.git] / lib / scripts / convertDefault.sh

diff --git a/lib/scripts/convertDefault.sh b/lib/scripts/convertDefault.sh
index 53bf1171411f4271a8f8be00e691ccba08eccc4b..5cfc73909dbb19265f8b4eaa1c397398f097d80f 100644 (file)
--- a/lib/scripts/convertDefault.sh
+++ b/lib/scripts/convertDefault.sh
@@ -1,10 +1,37 @@
-#!/bin/bash
-# this is the default converter if no one other was
-# defined by the user in edit->preferences->converter
-#
-# the user can also redefine this default converter
-# with an own shell script in ~/.lyx/scripts
-#
-# converts an image from $1 to $2 format 
-convert -depth 8 $1 $2 
-exit 0
+#! /bin/sh
+
+# file convertDefault.sh
+# This file is part of LyX, the document processor.
+# Licence details can be found in the file COPYING.
+
+# author Herbert Voß
+
+# Full author contact details are available in file CREDITS.
+
+# The default converter if no other has been defined by the user from the
+# Conversion->Converter tab of the Preferences dialog.
+
+# The user can also redefine this default converter, placing their
+# replacement in ~/.lyx/scripts
+
+# converts an image from $1 to $2 format
+convert -depth 8 $1 $2 || {
+       echo "$0 ERROR"
+       echo "Execution of \"convert\" failed."
+       exit 1
+}
+
+# It appears that convert succeeded, but we know better than to trust it ;-)
+# convert is passed strings in the form "FMT:FILENAME", so use the ':' to
+# delimit the two parts.
+# Note that Win32 filenames have the form 'C:\my\file',
+# so use everything from the first ':' to the end of the line.
+FILE=`echo $2 | cut -d ':' -f 2-`
+
+test -f $FILE || {
+       echo "$0 ERROR"
+       echo "Unable to find file \"${FILE}\""
+       exit 1
+}
+
+echo "$0 generated file \"${FILE}\" successfully."