src/frontends/qt4/GuiView.C

   1 /**
   2  * \file GuiView.C
   3  * This file is part of LyX, the document processor.
   4  * Licence details can be found in the file COPYING.
   5  *
   6  * \author Lars Gullik Bjønnes
   7  * \author John Levon
   8  * \author Abdelrazak Younes
   9  * \author Peter Kümmel
  10  *
  11  * Full author contact details are available in file CREDITS.
  12  */
  13
  14 #include <config.h>
  15
  16 #include "GuiView.h"
  17
  18 #include "GuiImplementation.h"
  19 #include "GuiWorkArea.h"
  20 #include "QLyXKeySym.h"
  21 #include "QLMenubar.h"
  22 #include "QLToolbar.h"
  23 #include "QCommandBuffer.h"
  24 #include "qt_helpers.h"
  25
  26 #include "frontends/Application.h"
  27 #include "frontends/Gui.h"
  28 #include "frontends/WorkArea.h"
  29
  30 #include "support/filetools.h"
  31 #include "support/convert.h"
  32 #include "support/lstrings.h"
  33
  34 #include "BufferView.h"
  35 #include "bufferlist.h"
  36 #include "debug.h"
  37 #include "funcrequest.h"
  38 #include "lyx_cb.h"
  39 #include "lyxrc.h"
  40 #include "lyx_main.h"
  41 #include "session.h"
  42 #include "lyxfunc.h"
  43 #include "MenuBackend.h"
  44 #include "buffer.h"
  45 #include "bufferlist.h"
  46
  47 #include <QAction>
  48 #include <QApplication>
  49 #include <QCloseEvent>
  50 #include <QPixmap>
  51 #include <QStatusBar>
  52 #include <QToolBar>
  53 #include <QTabBar>
  54 #include <QDesktopWidget>
  55 #include <QVBoxLayout>
  56
  57 #include <boost/bind.hpp>
  58 #include <boost/shared_ptr.hpp>
  59
  60 using std::endl;
  61 using std::string;
  62 using std::vector;
  63
  64 namespace lyx {
  65
  66 using support::FileName;
  67 using support::libFileSearch;
  68 using support::makeDisplayPath;
  69
  70 namespace frontend {
  71
  72 namespace {
  73
  74 int const statusbar_timer_value = 3000;
  75
  76 class TabWidget : public QWidget
  77 {
  78 public:
  79         QTabBar* tabbar;
  80
  81         TabWidget(QWidget* w, bool topTabBar)
  82         {
  83                 tabbar = new QTabBar;
  84                 QVBoxLayout* layout = new QVBoxLayout;
  85                 if (topTabBar) {
  86                         layout->addWidget(tabbar);
  87                         layout->addWidget(w);
  88                 } else {
  89                         tabbar->setShape(QTabBar::RoundedSouth);
  90                         layout->addWidget(w);
  91                         layout->addWidget(tabbar);
  92                 }
  93                 layout->setMargin(0);
  94                 setLayout(layout);
  95         }
  96
  97         void clearTabbar()
  98         {
  99                 for (int i = tabbar->count() - 1; i >= 0; --i)
 100                         tabbar->removeTab(i);
 101         }
 102 };
 103
 104 } // namespace anon
 105
 106
 107 struct GuiView::GuiViewPrivate
 108 {
 109         vector<string> tabnames;
 110         string cur_title;
 111
 112         TabWidget* tabWidget;
 113
 114         int posx_offset;
 115         int posy_offset;
 116
 117         GuiViewPrivate() : tabWidget(0), posx_offset(0), posy_offset(0)
 118         {}
 119
 120         unsigned int smallIconSize;
 121         unsigned int normalIconSize;
 122         unsigned int bigIconSize;
 123         // static needed by "New Window"
 124         static unsigned int lastIconSize;
 125
 126         QMenu* toolBarPopup(GuiView *parent)
 127         {
 128                 // FIXME: translation
 129                 QMenu* menu = new QMenu(parent);
 130                 QActionGroup *iconSizeGroup = new QActionGroup(parent);
 131
 132                 QAction *smallIcons = new QAction(iconSizeGroup);
 133                 smallIcons->setText(qt_("Small-sized icons"));
 134                 smallIcons->setCheckable(true);
 135                 QObject::connect(smallIcons, SIGNAL(triggered()), parent, SLOT(smallSizedIcons()));
 136                 menu->addAction(smallIcons);
 137
 138                 QAction *normalIcons = new QAction(iconSizeGroup);
 139                 normalIcons->setText(qt_("Normal-sized icons"));
 140                 normalIcons->setCheckable(true);
 141                 QObject::connect(normalIcons, SIGNAL(triggered()), parent, SLOT(normalSizedIcons()));
 142                 menu->addAction(normalIcons);
 143
 144
 145                 QAction *bigIcons = new QAction(iconSizeGroup);
 146                 bigIcons->setText(qt_("Big-sized icons"));
 147                 bigIcons->setCheckable(true);
 148                 QObject::connect(bigIcons, SIGNAL(triggered()), parent, SLOT(bigSizedIcons()));
 149                 menu->addAction(bigIcons);
 150
 151                 unsigned int cur = parent->iconSize().width();
 152                 if ( cur == parent->d.smallIconSize)
 153                         smallIcons->setChecked(true);
 154                 else if (cur == parent->d.normalIconSize)
 155                         normalIcons->setChecked(true);
 156                 else if (cur == parent->d.bigIconSize)
 157                         bigIcons->setChecked(true);
 158
 159                 return menu;
 160         }
 161 };
 162
 163
 164 unsigned int GuiView::GuiViewPrivate::lastIconSize = 0;
 165
 166
 167 GuiView::GuiView(int id)
 168         : QMainWindow(), LyXView(id), commandbuffer_(0), quitting_by_menu_(false),
 169           d(*new GuiViewPrivate)
 170 {
 171         // Qt bug? signal lastWindowClosed does not work
 172         setAttribute(Qt::WA_QuitOnClose, false);
 173         setAttribute(Qt::WA_DeleteOnClose, true);
 174
 175         // hardcode here the platform specific icon size
 176         d.smallIconSize = 14;   // scaling problems
 177         d.normalIconSize = 20;  // ok, default
 178         d.bigIconSize = 26;             // better for some math icons
 179
 180 #ifndef Q_WS_MACX
 181         //  assign an icon to main form. We do not do it under Qt/Mac,
 182         //  since the icon is provided in the application bundle.
 183         FileName const iconname = libFileSearch("images", "lyx", "xpm");
 184         if (!iconname.empty())
 185                 setWindowIcon(QPixmap(toqstr(iconname.absFilename())));
 186 #endif
 187 }
 188
 189
 190 GuiView::~GuiView()
 191 {
 192         menubar_.reset();
 193         delete &d;
 194 }
 195
 196
 197 void GuiView::close()
 198 {
 199         quitting_by_menu_ = true;
 200         QMainWindow::close();
 201         quitting_by_menu_ = false;
 202 }
 203
 204
 205 void GuiView::setFocus()
 206 {
 207         BOOST_ASSERT(work_area_);
 208         static_cast<GuiWorkArea *>(work_area_)->setFocus();
 209 }
 210
 211
 212 QMenu* GuiView::createPopupMenu()
 213 {
 214         return d.toolBarPopup(this);
 215 }
 216
 217
 218 void GuiView::init()
 219 {
 220         menubar_.reset(new QLMenubar(this, menubackend));
 221         QObject::connect(menuBar(), SIGNAL(triggered(QAction *)),
 222                 this, SLOT(updateMenu(QAction *)));
 223
 224         getToolbars().init();
 225
 226         statusBar()->setSizeGripEnabled(true);
 227
 228         QObject::connect(&statusbar_timer_, SIGNAL(timeout()),
 229                 this, SLOT(update_view_state_qt()));
 230
 231         BOOST_ASSERT(work_area_);
 232         if (!work_area_->bufferView().buffer() && !theBufferList().empty())
 233                 setBuffer(theBufferList().first());
 234
 235         // make sure the buttons are disabled if needed
 236         updateToolbars();
 237         updateLayoutChoice();
 238         updateMenubar();
 239 }
 240
 241
 242 void GuiView::closeEvent(QCloseEvent * close_event)
 243 {
 244         // we may have been called through the close window button
 245         // which bypasses the LFUN machinery.
 246         if (!quitting_by_menu_ && theApp()->gui().viewIds().size() == 1) {
 247                 if (!theBufferList().quitWriteAll()) {
 248                         close_event->ignore();
 249                         return;
 250                 }
 251         }
 252
 253         theApp()->gui().unregisterView(id());
 254         if (!theApp()->gui().viewIds().empty()) {
 255                 // Just close the window and do nothing else if this is not the
 256                 // last window.
 257                 close_event->accept();
 258                 return;
 259         }
 260
 261         if (view()->buffer()) {
 262                 // save cursor position for opened files to .lyx/session
 263                 LyX::ref().session().lastFilePos().save(
 264                         FileName(buffer()->fileName()),
 265                         boost::tie(view()->cursor().pit(),
 266                         view()->cursor().pos()));
 267         }
 268
 269         // this is the place where we leave the frontend.
 270         // it is the only point at which we start quitting.
 271         saveGeometry();
 272         close_event->accept();
 273         // quit the event loop
 274         qApp->quit();
 275 }
 276
 277
 278 void GuiView::saveGeometry()
 279 {
 280         static bool done = false;
 281         if (done)
 282                 return;
 283         else
 284                 done = true;
 285
 286         // FIXME:
 287         // change the ifdef to 'geometry = normalGeometry();' only
 288         // when Trolltech has fixed the broken normalGeometry on X11:
 289         // http://www.trolltech.com/developer/task-tracker/index_html?id=119684+&method=entry
 290         // Then also the moveEvent, resizeEvent, and the
 291         // code for floatingGeometry_ can be removed;
 292         // adjust GuiView::setGeometry()
 293
 294         QRect normal_geometry;
 295         int maximized;
 296 #ifdef Q_WS_WIN
 297         normal_geometry = normalGeometry();
 298         if (isMaximized()) {
 299                 maximized = CompletelyMaximized;
 300         } else {
 301                 maximized = NotMaximized;
 302         }
 303 #else
 304         normal_geometry = updateFloatingGeometry();
 305
 306         QDesktopWidget& dw = *qApp->desktop();
 307         QRect desk = dw.availableGeometry(dw.primaryScreen());
 308         // Qt bug on Linux: load completely maximized, vert max. save-> frameGeometry().height() is wrong
 309         if (isMaximized() && desk.width() <= frameGeometry().width() && desk.height() <= frameGeometry().height()) {
 310                 maximized = CompletelyMaximized;
 311                 // maximizing does not work when the window is allready hor. or vert. maximized
 312                 // Tested only on KDE
 313                 int dh = frameGeometry().height() - height();
 314                 if (desk.height() <= normal_geometry.height() + dh)
 315                         normal_geometry.setHeight(normal_geometry.height() - 1);
 316                 int dw = frameGeometry().width() - width();
 317                 if (desk.width() <= normal_geometry.width() + dw)
 318                         normal_geometry.setWidth(normal_geometry.width() - 1);
 319         } else if (desk.height() <= frameGeometry().height()) {
 320                 maximized = VerticallyMaximized;
 321         } else if (desk.width() <= frameGeometry().width()) {
 322                 maximized = HorizontallyMaximized;
 323         } else {
 324                 maximized = NotMaximized;
 325         }
 326
 327
 328 #endif
 329         // save windows size and position
 330         Session & session = LyX::ref().session();
 331         session.sessionInfo().save("WindowWidth", convert<string>(normal_geometry.width()));
 332         session.sessionInfo().save("WindowHeight", convert<string>(normal_geometry.height()));
 333         session.sessionInfo().save("WindowMaximized", convert<string>(maximized));
 334         session.sessionInfo().save("IconSizeXY", convert<string>(iconSize().width()));
 335         if (lyxrc.geometry_xysaved) {
 336                 session.sessionInfo().save("WindowPosX", convert<string>(normal_geometry.x() + d.posx_offset));
 337                 session.sessionInfo().save("WindowPosY", convert<string>(normal_geometry.y() + d.posy_offset));
 338         }
 339         getToolbars().saveToolbarInfo();
 340 }
 341
 342
 343 void GuiView::setGeometry(unsigned int width,
 344                           unsigned int height,
 345                           int posx, int posy,
 346                           int maximized,
 347                           unsigned int iconSizeXY,
 348                           const string & geometryArg)
 349 {
 350         // use last value (not at startup)
 351         if (d.lastIconSize != 0)
 352                 setIconSize(d.lastIconSize);
 353         else if (iconSizeXY != 0)
 354                 setIconSize(iconSizeXY);
 355         else
 356                 setIconSize(d.normalIconSize);
 357
 358         // only true when the -geometry option was NOT used
 359         if (width != 0 && height != 0) {
 360                 if (posx != -1 && posy != -1) {
 361                         // if there are ever startup positioning problems
 362                         // on a virtual desktop then check the 6 lines below
 363                         // http://doc.trolltech.com/4.2/qdesktopwidget.html
 364                         QDesktopWidget& dw = *qApp->desktop();
 365                         QRect desk = dw.availableGeometry(dw.primaryScreen());
 366                         (posx >= desk.width() ? posx = 50 : true);
 367                         (posy >= desk.height()? posy = 50 : true);
 368 #ifdef Q_WS_WIN
 369                         // FIXME: use setGeometry only when Trolltech has fixed the qt4/X11 bug
 370                         QWidget::setGeometry(posx, posy, width, height);
 371 #else
 372                         resize(width, height);
 373                         move(posx, posy);
 374 #endif
 375                 } else {
 376                         resize(width, height);
 377                 }
 378
 379                 // remember original size
 380                 floatingGeometry_ = QRect(posx, posy, width, height);
 381
 382                 if (maximized != NotMaximized) {
 383                         if (maximized == CompletelyMaximized) {
 384                                 setWindowState(Qt::WindowMaximized);
 385                         } else {
 386 #ifndef Q_WS_WIN
 387                                 // TODO How to set by the window manager?
 388                                 //      setWindowState(Qt::WindowVerticallyMaximized);
 389                                 //      is not possible
 390                                 QDesktopWidget& dw = *qApp->desktop();
 391                                 QRect desk = dw.availableGeometry(dw.primaryScreen());
 392                                 if (maximized == VerticallyMaximized)
 393                                         resize(width, desk.height());
 394                                 if (maximized == HorizontallyMaximized)
 395                                         resize(desk.width(), height);
 396 #endif
 397                         }
 398                 }
 399         }
 400         else
 401         {
 402                 // FIXME: move this code into parse_geometry() (lyx_main.C)
 403 #ifdef Q_WS_WIN
 404                 int x, y;
 405                 int w, h;
 406                 QRegExp re( "[=]*(?:([0-9]+)[xX]([0-9]+)){0,1}[ ]*(?:([+-][0-9]*)([+-][0-9]*)){0,1}" );
 407                 re.indexIn(toqstr(geometryArg.c_str()));
 408                 w = re.cap(1).toInt();
 409                 h = re.cap(2).toInt();
 410                 x = re.cap(3).toInt();
 411                 y = re.cap(4).toInt();
 412                 QWidget::setGeometry( x, y, w, h );
 413 #else
 414                 // silence warning
 415                 (void)geometryArg;
 416 #endif
 417         }
 418
 419         show();
 420
 421         // For an unknown reason, the Window title update is not effective for
 422         // the second windows up until it is shown on screen (Qt bug?).
 423         updateWindowTitle();
 424
 425         // after show geometry() has changed (Qt bug?)
 426         // we compensate the drift when storing the position
 427         d.posx_offset = 0;
 428         d.posy_offset = 0;
 429         if (width != 0 && height != 0)
 430                 if (posx != -1 && posy != -1) {
 431 #ifdef Q_WS_WIN
 432                         d.posx_offset = posx - normalGeometry().x();
 433                         d.posy_offset = posy - normalGeometry().y();
 434 #else
 435 #ifndef Q_WS_MACX
 436                         if (maximized == NotMaximized) {
 437                                 d.posx_offset = posx - geometry().x();
 438                                 d.posy_offset = posy - geometry().y();
 439                         }
 440 #endif
 441 #endif
 442                 }
 443 }
 444
 445
 446 void GuiView::updateMenu(QAction * /*action*/)
 447 {
 448         menubar_->update();
 449 }
 450
 451
 452 void GuiView::setWindowTitle(docstring const & t, docstring const & it)
 453 {
 454         QString title = windowTitle();
 455         QString new_title = toqstr(t);
 456         if (title != new_title) {
 457                 QMainWindow::setWindowTitle(new_title);
 458                 QMainWindow::setWindowIconText(toqstr(it));
 459         }
 460 }
 461
 462
 463 void GuiView::addCommandBuffer(QToolBar * toolbar)
 464 {
 465         commandbuffer_ = new QCommandBuffer(this, *controlcommand_);
 466         focus_command_buffer.connect(boost::bind(&GuiView::focus_command_widget, this));
 467         toolbar->addWidget(commandbuffer_);
 468 }
 469
 470
 471 void GuiView::message(docstring const & str)
 472 {
 473         statusBar()->showMessage(toqstr(str));
 474         statusbar_timer_.stop();
 475         statusbar_timer_.start(statusbar_timer_value);
 476 }
 477
 478
 479 void GuiView::clearMessage()
 480 {
 481         update_view_state_qt();
 482 }
 483
 484
 485 void GuiView::setIconSize(unsigned int size)
 486 {
 487         d.lastIconSize = size;
 488         QMainWindow::setIconSize(QSize(size, size));
 489 }
 490
 491
 492 void GuiView::smallSizedIcons()
 493 {
 494         setIconSize(d.smallIconSize);
 495 }
 496
 497
 498 void GuiView::normalSizedIcons()
 499 {
 500         setIconSize(d.normalIconSize);
 501 }
 502
 503
 504 void GuiView::bigSizedIcons()
 505 {
 506         setIconSize(d.bigIconSize);
 507 }
 508
 509
 510 void GuiView::focus_command_widget()
 511 {
 512         if (commandbuffer_)
 513                 commandbuffer_->focus_command();
 514 }
 515
 516
 517 void GuiView::update_view_state_qt()
 518 {
 519         statusBar()->showMessage(toqstr(theLyXFunc().viewStatusMessage()));
 520         statusbar_timer_.stop();
 521 }
 522
 523
 524 void GuiView::initTab(QWidget* workarea)
 525 {
 526         // construct the TabWidget with 'false' to have the tabbar at the bottom
 527         d.tabWidget = new TabWidget(workarea, true);
 528         setCentralWidget(d.tabWidget);
 529         QObject::connect(d.tabWidget->tabbar, SIGNAL(currentChanged(int)),
 530                         this, SLOT(currentTabChanged(int)));
 531 }
 532
 533
 534 void GuiView::updateTab()
 535 {
 536         std::vector<string> const & names = theBufferList().getFileNames();
 537
 538         string cur_title;
 539         if (view()->buffer()) {
 540                 cur_title = view()->buffer()->fileName();
 541         }
 542
 543         // avoid unnecessary tabbar rebuild:
 544         // check if something has changed
 545         if (d.tabnames == names && d.cur_title == cur_title)
 546                 return;
 547         d.tabnames = names;
 548         d.cur_title = cur_title;
 549
 550         QTabBar & tabbar = *d.tabWidget->tabbar;
 551
 552         // update when all is done
 553         tabbar.blockSignals(true);
 554
 555         // remove all tab bars
 556         d.tabWidget->clearTabbar();
 557
 558         // rebuild tabbar and function map from scratch
 559         if (names.size() > 1) {
 560                 for(size_t i = 0; i < names.size(); i++) {
 561                         tabbar.addTab(toqstr(makeDisplayPath(names[i], 30)));
 562                         // set current tab
 563                         if (names[i] == cur_title)
 564                                 tabbar.setCurrentIndex(i);
 565                 }
 566         }
 567         tabbar.blockSignals(false);
 568 }
 569
 570
 571 void GuiView::currentTabChanged(int i)
 572 {
 573         BOOST_ASSERT(i >= 0 && size_type(i) < d.tabnames.size());
 574         dispatch(FuncRequest(LFUN_BUFFER_SWITCH, d.tabnames[i]));
 575 }
 576
 577
 578 void GuiView::updateStatusBar()
 579 {
 580         // let the user see the explicit message
 581         if (statusbar_timer_.isActive())
 582                 return;
 583
 584         statusBar()->showMessage(toqstr(theLyXFunc().viewStatusMessage()));
 585 }
 586
 587
 588 void GuiView::activated(FuncRequest const & func)
 589 {
 590         dispatch(func);
 591 }
 592
 593
 594 bool GuiView::hasFocus() const
 595 {
 596         return qApp->activeWindow() == this;
 597 }
 598
 599
 600 QRect  GuiView::updateFloatingGeometry()
 601 {
 602         QDesktopWidget& dw = *qApp->desktop();
 603         QRect desk = dw.availableGeometry(dw.primaryScreen());
 604         // remember only non-maximized sizes
 605         if (!isMaximized() && desk.width() > frameGeometry().width() && desk.height() > frameGeometry().height()) {
 606                 floatingGeometry_ = QRect(x(), y(), width(), height());
 607         }
 608         return floatingGeometry_;
 609 }
 610
 611
 612 void GuiView::resizeEvent(QResizeEvent *)
 613 {
 614         updateFloatingGeometry();
 615 }
 616
 617
 618 void GuiView::moveEvent(QMoveEvent *)
 619 {
 620         updateFloatingGeometry();
 621 }
 622
 623
 624 bool GuiView::event(QEvent * e)
 625 {
 626         // Useful debug code:
 627         /*
 628         switch (e->type())
 629         {
 630         case QEvent::WindowActivate:
 631         case QEvent::ActivationChange:
 632         case QEvent::WindowDeactivate:
 633         case QEvent::Paint:
 634         case QEvent::Enter:
 635         case QEvent::Leave:
 636         case QEvent::HoverEnter:
 637         case QEvent::HoverLeave:
 638         case QEvent::HoverMove:
 639         case QEvent::StatusTip:
 640                 break;
 641         default:
 642         */
 643
 644         if (e->type() == QEvent::ShortcutOverride) {
 645                 QKeyEvent * ke = static_cast<QKeyEvent*>(e);
 646                 if (ke->key() == Qt::Key_Tab || ke->key() == Qt::Key_Backtab) {
 647                         boost::shared_ptr<QLyXKeySym> sym(new QLyXKeySym);
 648                         sym->set(ke);
 649                         BOOST_ASSERT(work_area_);
 650                         work_area_->processKeySym(sym, key_modifier::none);
 651                         e->accept();
 652                         return true;
 653                 }
 654         }
 655         //} for the debug switch above.
 656
 657         return QMainWindow::event(e);
 658 }
 659
 660
 661 bool GuiView::focusNextPrevChild(bool /*next*/)
 662 {
 663         setFocus();
 664         return true;
 665 }
 666
 667
 668 void GuiView::show()
 669 {
 670         QMainWindow::setWindowTitle(qt_("LyX"));
 671         QMainWindow::show();
 672         updateFloatingGeometry();
 673 }
 674
 675
 676 void GuiView::busy(bool yes)
 677 {
 678         BOOST_ASSERT(work_area_);
 679         static_cast<GuiWorkArea *>(work_area_)->setUpdatesEnabled(!yes);
 680
 681         if (yes) {
 682                 work_area_->stopBlinkingCursor();
 683                 QApplication::setOverrideCursor(Qt::WaitCursor);
 684         }
 685         else {
 686                 work_area_->startBlinkingCursor();
 687                 QApplication::restoreOverrideCursor();
 688         }
 689 }
 690
 691
 692 Toolbars::ToolbarPtr GuiView::makeToolbar(ToolbarBackend::Toolbar const & tbb, bool newline)
 693 {
 694         QLToolbar * Tb = new QLToolbar(tbb, *this);
 695
 696         if (tbb.flags & ToolbarBackend::TOP) {
 697                 if (newline)
 698                         addToolBarBreak(Qt::TopToolBarArea);
 699                 addToolBar(Qt::TopToolBarArea, Tb);
 700         }
 701
 702         if (tbb.flags & ToolbarBackend::BOTTOM) {
 703 // Qt < 4.2.2 cannot handle ToolBarBreak on non-TOP dock.
 704 #if (QT_VERSION >= 0x040202)
 705                 if (newline)
 706                         addToolBarBreak(Qt::BottomToolBarArea);
 707 #endif
 708                 addToolBar(Qt::BottomToolBarArea, Tb);
 709         }
 710
 711         if (tbb.flags & ToolbarBackend::LEFT) {
 712 // Qt < 4.2.2 cannot handle ToolBarBreak on non-TOP dock.
 713 #if (QT_VERSION >= 0x040202)
 714                 if (newline)
 715                         addToolBarBreak(Qt::LeftToolBarArea);
 716 #endif
 717                 addToolBar(Qt::LeftToolBarArea, Tb);
 718         }
 719
 720         if (tbb.flags & ToolbarBackend::RIGHT) {
 721 // Qt < 4.2.2 cannot handle ToolBarBreak on non-TOP dock.
 722 #if (QT_VERSION >= 0x040202)
 723                 if (newline)
 724                         addToolBarBreak(Qt::RightToolBarArea);
 725 #endif
 726                 addToolBar(Qt::RightToolBarArea, Tb);
 727         }
 728
 729         // The following does not work so I can not restore to exact toolbar location
 730         /*
 731         ToolbarSection::ToolbarInfo & info = LyX::ref().session().toolbars().load(tbb.name);
 732         Tb->move(info.posx, info.posy);
 733         */
 734
 735         return Toolbars::ToolbarPtr(Tb);
 736 }
 737
 738 } // namespace frontend
 739 } // namespace lyx
 740
 741 #include "GuiView_moc.cpp"